Mar 12, 2021, 02:04 by suji.velupil...@broadcom.com: > Thank you for the review, please see inline. > > On Thu, Mar 11, 2021 at 2:56 PM Lynne <d...@lynne.ee> wrote: > >> > + /** >> > + * Convert AVPixelFormat to VKAPI equivalent pixel format >> > + */ >> > + int (*av2vk_fmt)(enum AVPixelFormat pixel_format); >> > >> >> This function can stay, but it needs no state at all, so just put >> it out side of the structure. Name it: >> const VkFormat *av_vkil_from_pixfmt(enum AVPixelFormat p); >> The *vk* namespace is taken by Vulkan already. >> > > Make sense, can I change it to vkapi instead to be consistent? >
What about expanding "vk" shortenings to "valkyrie" instead? vkapi is kinda really close to meaning vulkan api -_- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
