> -----Original Message-----
> >> -----Original Message-----
> >> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of
> >> Andreas Rheinhardt
> >> Sent: 2021年3月11日 5:55
> >> To: ffmpeg-devel@ffmpeg.org
> >> Cc: Andreas Rheinhardt <andreas.rheinha...@gmail.com>
> >> Subject: [FFmpeg-devel] [PATCH 15/23]
> >> dnn/dnn_backend_native_layer_conv2d: Join two arrays, avoid allocation
> >>
> >> Fixes Coverity issue #1473507.
> >>
> >> Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@gmail.com>
> >> ---
> >> libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 10 +++++-----
> >> 1 file changed, 5 insertions(+), 5 deletions(-)
> >> }
> >>
> >> //release memory
> >> - av_freep(&thread_id);
> >> -
> >> for (int i = 0; i < thread_num; i++){
> >> av_freep(&thread_param[i]);
> >> }
> >
> > LGMT, and just one question: shall we reduce the allocation as less as
> possible? thanks.
> >
> If it is doable without too much effort as is here, then the answer is
> yes. Actually, one could go even further than what this patchset did:
> One could keep the thread_param array instead of constantly allocating
> and freeing it. With much more effort, one could even keep the threads.
thanks, and is the reason that: we need to check the return value for dynamic
allocation, and also need some effort to make sure to free it for all possible
paths in the code followed?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
