Re: [FFmpeg-devel] [PATCH 3/5] avfilter/scale: separate exprs parse and eval

2019-12-27 Thread Gyan
Hi Michael, On 26-12-2019 02:42 pm, Gyan wrote: On 24-12-2019 11:39 am, Gyan wrote: On 24-12-2019 04:50 am, Michael Niedermayer wrote: On Tue, Dec 17, 2019 at 02:55:06PM +0530, Gyan wrote: [...] @@ -127,6 +204,22 @@ static av_cold int init_dict(AVFilterContext *ctx, AVDictionary **opts)

[FFmpeg-devel] [PATCH] avformat/matroskadec: Add webm file extension

2019-12-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 75f72d330c..3879a54af5 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -4193,7

[FFmpeg-devel] [PATCH 2/2] avformat/matroskadec: Fix lzo decompression

2019-12-27 Thread Andreas Rheinhardt
When a Matroska Block is only stored in compressed form, the size of the uncompressed block is not explicitly coded and therefore not known before decompressing it. Therefore the demuxer uses a guess for the uncompressed size: The first guess is three times the compressed size and if this is not en

[FFmpeg-devel] [PATCH 1/2] fate/matroska: Add test for ProRes and bz2 compression

2019-12-27 Thread Andreas Rheinhardt
This test tests that demuxing ProRes that is muxed like it should be in Matroska (i.e. with the first header ("icpf") atom stripped away) works; it also tests bz2 decompression as well as the handling of unknown-length clusters. Signed-off-by: Andreas Rheinhardt --- The samples have already been

Re: [FFmpeg-devel] [PATCH, 4/7] lavu/hwcontext_vaapi: add vaapi_format_map support for 0YUV/Y210/Y410

2019-12-27 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Saturday, December 28, 2019 06:41 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH, 4/7] lavu/hwcontext_vaapi: add > vaapi_format_map support for 0YUV/Y210/Y410 > > On 04/12/2019 14:44, Linjie

Re: [FFmpeg-devel] [PATCH v1] avcodec/h264_metadata_bsf: Fix user data failed to insert in case no SPSs NAL for global headers

2019-12-27 Thread Limin Wang
On Fri, Dec 27, 2019 at 11:30:34PM +, Mark Thompson wrote: > On 26/12/2019 00:55, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > FLV, MP4... will enable global_header default and place SPSs headers in > > extradata > > instead of every keyframe. So it'll failed to insert user dat

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/h265_metadata_bsf: add option to insert a string as SEI unregistered user data

2019-12-27 Thread Limin Wang
On Fri, Dec 27, 2019 at 11:32:40PM +, Mark Thompson wrote: > On 26/12/2019 01:01, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > update to add keyframe NAL checking as H.264 patch for global header > > This case is much easier in H.265, thou

[FFmpeg-devel] [PATCH 2/2] avdevice/xcbgrab: capture the full desktop if video_size is not specified

2019-12-27 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/indevs.texi | 2 +- libavdevice/xcbgrab.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index 92bc65be41..e2a3540203 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -1532,7 +153

[FFmpeg-devel] [PATCH 1/2] avdevice/xcbgrab: fix packet timestamps

2019-12-27 Thread Marton Balint
Since 648b8cca6c56a4fa1760efc72dfe1363a5c6e31e and c991e9cd91845044e93a9c89dd25b48ae707461b timestamps were not set properly. Signed-off-by: Marton Balint --- libavdevice/xcbgrab.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavdevice/xcbgrab.c b/libavdev

Re: [FFmpeg-devel] [PATCH] configure: Change the configure check for tonemap_vaapi

2019-12-27 Thread Mark Thompson
On 24/12/2019 06:32, Xinpeng Sun wrote: > "VAProcFilterParameterBufferHDRToneMapping" was defined in libva 2.4.1, which > will lead to > build failure for the filter tonemap_vaapi for libva 2.3.0 with current > check. This patch > is to fix this build error. > > Signed-off-by: Xinpeng Sun > ---

Re: [FFmpeg-devel] [PATCH v3] avcodec/v4l2_m2m_enc: Check encoder pix_fmt matches pix_fmt on device

2019-12-27 Thread Mark Thompson
On 27/12/2019 23:38, Andriy Gelman wrote: > From: Andriy Gelman > > Fixes #8079 > > During initialization of a v4l2m2m device, the configured pix_fmt can be > different to the pix_fmt of the encoder (i.e. avctx->pix_fmt). > > For example on the Odroid XU4: > ./ffmpeg -f lavfi -i yuvtestsrc -cod

Re: [FFmpeg-devel] [PATCH 8/8] avformat/img2enc: add support for specifying protocol options

2019-12-27 Thread Marton Balint
On Fri, 27 Dec 2019, Lou Logan wrote: On Fri, Dec 27, 2019, at 12:14 PM, Marton Balint wrote: Signed-off-by: Marton Balint +ffmpeg -f x11grab -r 1 -framerate 1 -video_size hd1080 -i :0.0 -qscale 6 -update 1 -protocol_opts method=PUT http://example.com/desktop.jpg What's the reason this e

[FFmpeg-devel] [PATCH v3] avcodec/v4l2_m2m_enc: Check encoder pix_fmt matches pix_fmt on device

2019-12-27 Thread Andriy Gelman
From: Andriy Gelman Fixes #8079 During initialization of a v4l2m2m device, the configured pix_fmt can be different to the pix_fmt of the encoder (i.e. avctx->pix_fmt). For example on the Odroid XU4: ./ffmpeg -f lavfi -i yuvtestsrc -codec:v h264_v4l2m2m out.h264 will configure the v4l2 encoder

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/h265_metadata_bsf: add option to insert a string as SEI unregistered user data

2019-12-27 Thread Mark Thompson
On 26/12/2019 01:01, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > update to add keyframe NAL checking as H.264 patch for global header This case is much easier in H.265, though - the extradata can include SEI which applies globally, so just put it ther

Re: [FFmpeg-devel] [PATCH v1] avcodec/h264_metadata_bsf: Fix user data failed to insert in case no SPSs NAL for global headers

2019-12-27 Thread Mark Thompson
On 26/12/2019 00:55, lance.lmw...@gmail.com wrote: > From: Limin Wang > > FLV, MP4... will enable global_header default and place SPSs headers in > extradata > instead of every keyframe. So it'll failed to insert user data unregisted > for no SPSs NAL after first AU without the patch. > > Pleas

Re: [FFmpeg-devel] [PATCH, v3, 1/7] lavu/pixfmt: add new pixel format 0yuv/y210/y410

2019-12-27 Thread Mark Thompson
On 05/12/2019 11:55, James Darnley wrote: > On 2019-12-04 15:43, Linjie Fu wrote: >> Previously, media driver provided planar format(like 420 8 bit), >> but for HEVC Range Extension (422/444 8/10 bit), the decoded image >> is produced in packed format because Windows expects it. >> >> Add some pack

Re: [FFmpeg-devel] [PATCH, 4/7] lavu/hwcontext_vaapi: add vaapi_format_map support for 0YUV/Y210/Y410

2019-12-27 Thread Mark Thompson
On 04/12/2019 14:44, Linjie Fu wrote: > VA_RT_FORMAT describes the desired sampling format for surface. > > When creating surface, VA_RT_FORMAT will be used firstly to choose > the expected fourcc/media_format for the surface. And the fourcc > will be revised by the value of VASurfaceAttribPixelFo

[FFmpeg-devel] [PATCH 3/3] avdevice/decklink: deprecate the -list_formats option

2019-12-27 Thread Marton Balint
The user should use ffmpeg -sources decklink or ffmpeg -sinks decklink instead. Signed-off-by: Marton Balint --- doc/indevs.texi | 6 +++--- doc/outdevs.texi | 6 +++--- libavdevice/decklink_dec.cpp | 1 + libavdevice/decklink_enc.cpp | 1 + libavdevice/version.h

[FFmpeg-devel] [PATCH 2/3] avdevice/decklink_dec: remove -bm_v210 option

2019-12-27 Thread Marton Balint
Deprecated since Sep 28, 2017. Signed-off-by: Marton Balint --- doc/indevs.texi | 7 +-- libavdevice/decklink_common_c.h | 1 - libavdevice/decklink_dec.cpp| 5 - libavdevice/decklink_dec_c.c| 1 - 4 files changed, 1 insertion(+), 13 deletions(-) diff --git a/doc

[FFmpeg-devel] [PATCH 1/3] avdevice/decklink_dec: remove the @mode syntax

2019-12-27 Thread Marton Balint
Deprecated since March 28, 2017. Signed-off-by: Marton Balint --- libavdevice/decklink_common.cpp | 11 +-- libavdevice/decklink_common.h | 4 ++-- libavdevice/decklink_dec.cpp| 21 + 3 files changed, 12 insertions(+), 24 deletions(-) diff --git a/libavdevice/

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_geq: Add support for reading sample sums and means of rectangles

2019-12-27 Thread Michael Niedermayer
On Fri, Dec 06, 2019 at 05:18:18PM +0100, Michael Niedermayer wrote: > This allows integrating box blur style filters in geq. > > Without this computing the mean of an area in geq would have been excessivly > slow > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_geq.c | 107 ++

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/vf_geq: Add NB_PLANES

2019-12-27 Thread Michael Niedermayer
On Fri, Dec 06, 2019 at 05:18:17PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_geq.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Brea

Re: [FFmpeg-devel] [PATCH 1/3] avutil/eval: Add av_expr_count_func() similar to av_expr_count_vars()

2019-12-27 Thread Michael Niedermayer
On Tue, Dec 17, 2019 at 11:18:51AM +0100, Michael Niedermayer wrote: > On Tue, Dec 17, 2019 at 01:50:37AM +0100, Marton Balint wrote: > > > > > > On Tue, 17 Dec 2019, Michael Niedermayer wrote: > > > > >On Sun, Dec 15, 2019 at 01:59:23PM +0100, Marton Balint wrote: > > >> > > >> > > >>On Fri, 6

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/vc1dec: Free sprite_output_frame on error

2019-12-27 Thread Michael Niedermayer
On Tue, Dec 17, 2019 at 12:19:45AM +0100, Michael Niedermayer wrote: > Fixes: memleaks > Fixes: > 19471/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5688035714269184 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > S

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vc1dec: Fix "return -1" cases

2019-12-27 Thread Michael Niedermayer
On Tue, Dec 17, 2019 at 09:10:57AM +0800, myp...@gmail.com wrote: > On Tue, Dec 17, 2019 at 7:23 AM Michael Niedermayer > wrote: > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vc1dec.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/libav

Re: [FFmpeg-devel] [PATCH 8/8] avformat/img2enc: add support for specifying protocol options

2019-12-27 Thread Lou Logan
On Fri, Dec 27, 2019, at 12:14 PM, Marton Balint wrote: > Signed-off-by: Marton Balint > > +ffmpeg -f x11grab -r 1 -framerate 1 -video_size hd1080 -i :0.0 -qscale > 6 -update 1 -protocol_opts method=PUT http://example.com/desktop.jpg What's the reason this examples uses both -r and -framerate?

Re: [FFmpeg-devel] [PATCH 3/5] avfilter/vf_geq: Relicense to LGPL

2019-12-27 Thread Michael Niedermayer
On Mon, Dec 16, 2019 at 03:40:39PM -0900, Lou Logan wrote: > On Tue, 17 Dec 2019 01:13:15 +0100 (CET) > Marton Balint wrote: > > > > > You should also remove the gpl dependency from configure. > > ...and update LICENSE.md. will apply with these changes thx [...] -- Michael GnuPG fingerp

Re: [FFmpeg-devel] [PATCH 1/8] doc/muxers: fix order of options and examples for image2 muxer

2019-12-27 Thread Lou Logan
On Fri, Dec 27, 2019, at 12:14 PM, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/muxers.texi | 52 ++-- > 1 file changed, 26 insertions(+), 26 deletions(-) LGTM ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/atrac9dec: Clamp band_ext_data to max that can be read if skipped.

2019-12-27 Thread Michael Niedermayer
On Thu, Dec 26, 2019 at 05:24:31PM +0100, Lynne wrote: > Dec 26, 2019, 13:57 by d...@lynne.ee: > > > Dec 16, 2019, 23:19 by mich...@niedermayer.cc: > > > >> Fixes: out of array read > >> Fixes: > >> 19327/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5679823087468544 > >> > >> F

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/agm: Include block size in the MV check for flags == 3

2019-12-27 Thread Michael Niedermayer
On Tue, Dec 17, 2019 at 12:19:43AM +0100, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 19331/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5644115983466496 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/wmadec: Keep track of exponent initialization per channel

2019-12-27 Thread Michael Niedermayer
On Sat, Nov 30, 2019 at 09:26:58PM +0100, Michael Niedermayer wrote: > Fixes: division by 0 > Fixes: > 19123/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMAV2_fuzzer-5655493121146880 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] [PATCH 8/8] avformat/img2enc: add support for specifying protocol options

2019-12-27 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/muxers.texi | 11 +++ libavformat/img2enc.c | 13 - 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index fb5c9bc4c0..a1f801c28d 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1

[FFmpeg-devel] [PATCH 7/8] avformat/img2enc: fix writing multiple streams in write_muxed_file

2019-12-27 Thread Marton Balint
Maybe we should just reject multiple streams for the image2 muxer instead? Signed-off-by: Marton Balint --- libavformat/img2enc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index 718c9929f7..39398f37a3 100644 ---

[FFmpeg-devel] [PATCH 3/8] avformat/img2enc: factorize piped write_packet

2019-12-27 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/img2enc.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index 0ce8ef5bff..dfc7566dad 100644 --- a/libavformat/img2enc.c +++ b/libavformat/img2enc.c @@

[FFmpeg-devel] [PATCH 6/8] avformat/img2enc: minor simplification

2019-12-27 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/img2enc.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index 14e6d641f9..718c9929f7 100644 --- a/libavformat/img2enc.c +++ b/libavformat/img2enc.c @@ -92,18 +92,16 @@ stati

[FFmpeg-devel] [PATCH 2/8] avformat/img2enc: factorize writing fully muxed file

2019-12-27 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/img2enc.c | 65 +-- 1 file changed, 37 insertions(+), 28 deletions(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index bec4bf81dd..0ce8ef5bff 100644 --- a/libavformat/img2enc.c +++ b/liba

[FFmpeg-devel] [PATCH 4/8] avformat/img2enc: reindent after last commit

2019-12-27 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/img2enc.c | 86 --- 1 file changed, 41 insertions(+), 45 deletions(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index dfc7566dad..a976d07acc 100644 --- a/libavformat/img2enc.c +++ b/liba

[FFmpeg-devel] [PATCH 5/8] avformat/img2enc: cleanup IO contexts on error

2019-12-27 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/img2enc.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index a976d07acc..14e6d641f9 100644 --- a/libavformat/img2enc.c +++ b/libavformat/img2enc.c @@ -124,7 +124,7 @@ s

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/iff: Check that video_size is large enough for the read parameters

2019-12-27 Thread Michael Niedermayer
On Sat, Nov 30, 2019 at 09:26:56PM +0100, Michael Niedermayer wrote: > video is allocated before parameters like bpp are read. > > Fixes: out of array access > Fixes: > 19084/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5718556033679360 > > Found-by: continuous fuzzing proce

[FFmpeg-devel] [PATCH 1/8] doc/muxers: fix order of options and examples for image2 muxer

2019-12-27 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/muxers.texi | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 5d7ff1ab3b..fb5c9bc4c0 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1169,6

Re: [FFmpeg-devel] [PATCH 01/13] avutil/opt: add full support for AV_OPT_TYPE_DICT

2019-12-27 Thread Marton Balint
On Thu, 26 Dec 2019, Michael Niedermayer wrote: On Wed, Dec 25, 2019 at 10:43:02PM +0100, Marton Balint wrote: Now it is possible to set them from a string, to serialize them and to use a default value. Signed-off-by: Marton Balint --- libavutil/opt.c | 51 +

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: propagate icy to child AVIOContexts

2019-12-27 Thread James Almer
On 12/21/2019 8:11 PM, Liu Steven wrote: > > >> 在 2019年12月21日,下午7:03,Marvin Scholz 写道: >> >> On 17 Dec 2019, at 1:45, Marvin Scholz wrote: >> >>> When the user decides they do not want to to send the Icy-MetaData >>> header, this should be respected for all requests, not just the first >>> one.

Re: [FFmpeg-devel] [PATCH] avformat/hls: propagate icy to child AVIOContexts

2019-12-27 Thread James Almer
On 12/21/2019 8:11 PM, Liu Steven wrote: > > >> 在 2019年12月21日,下午7:02,Marvin Scholz 写道: >> >> On 17 Dec 2019, at 1:17, Marvin Scholz wrote: >> >>> When the user decides they do not want to to send the Icy-MetaData >>> header, this should be respected for all requests, not just the first >>> one.

Re: [FFmpeg-devel] [PATCH] avformat/hls: propagate icy to child AVIOContexts

2019-12-27 Thread James Almer
On 12/21/2019 8:11 PM, Liu Steven wrote: > > >> 在 2019年12月21日,下午7:02,Marvin Scholz 写道: >> >> On 17 Dec 2019, at 1:17, Marvin Scholz wrote: >> >>> When the user decides they do not want to to send the Icy-MetaData >>> header, this should be respected for all requests, not just the first >>> one.

Re: [FFmpeg-devel] Copying Audio

2019-12-27 Thread Lou Logan
On Fri, Dec 27, 2019, at 12:38 AM, Chris wrote: > I have a file with audio in the format pcm_s16be. When I try to copy > this audio to another file using -c:a copy, it copies the audio but > also transcodes it to AAC. > If it's literally a copy, shouldn't the copy be pcm_s16be as well? How > can

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Paul B Mahol
On 12/27/19, Reino Wijnsma wrote: > On 2019-12-27T16:48:22+0100, Paul B Mahol wrote: >> On 12/27/19, James Almer wrote: >>> On 12/27/2019 12:29 PM, Paul B Mahol wrote: On 12/27/19, Nicolas George wrote: > Paul B Mahol (12019-12-27): >> I disagree. >> >> And yet in the meant

Re: [FFmpeg-devel] [PATCH 3/3] lavf/dump: use a writer.

2019-12-27 Thread Nicolas George
Andriy Gelman (12019-12-27): > The 3/3 patch fails to apply with git: > https://unofficial.patchwork-ffmpeg.org/project/FFmpeg/list/?series=68 It is on top of a patch to disable deprecation warnings that was not yet pushed. It does not matter much right now. Regards, -- Nicolas George signa

Re: [FFmpeg-devel] [PATCH 3/3] lavf/dump: use a writer.

2019-12-27 Thread Andriy Gelman
On Fri, 27. Dec 14:24, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavformat/avformat.h | 21 +++ > libavformat/dump.c | 297 + > 2 files changed, 175 insertions(+), 143 deletions(-) > > > Note: I chose flags instead of is_output

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Reino Wijnsma
On 2019-12-27T16:48:22+0100, Paul B Mahol wrote: > On 12/27/19, James Almer wrote: >> On 12/27/2019 12:29 PM, Paul B Mahol wrote: >>> On 12/27/19, Nicolas George wrote: Paul B Mahol (12019-12-27): > I disagree. > > And yet in the meantime somebody found a bug. This is a big patc

Re: [FFmpeg-devel] -progress option per output

2019-12-27 Thread Nicolas George
vivien anglesio (12019-12-20): > I would like to work on a "per output" -progress option. I will try to > implement this myself but before putting my hands on it I wanted to discuss > about the different solutions with the community. I have three of them in > mind I would not object to this, altho

Re: [FFmpeg-devel] [PATCH v1] avcodec/mvha: fix warning: variable 'size' set but not used

2019-12-27 Thread James Almer
On 12/27/2019 1:00 PM, Paul B Mahol wrote: > lgtm Pushed. > > On 12/27/19, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavcodec/mvha.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/mvha.c b/libavcodec/mvha.c >> ind

Re: [FFmpeg-devel] [PATCH v2] avfilter/formats: optimize ff_all_formats

2019-12-27 Thread Nicolas George
zhilizhao (12019-12-24): > I get the idea. However, if lavi is built agains version A of libavutils > and use version B at runtime, it’s not guaranteed to work with or without > access to AV_PIX_FMT_NB: In principle, it is. > 1. For major version bump, AV_PIX_FMT_XXX may have different values > i

Re: [FFmpeg-devel] [PATCH v2] avutil/mem: Add av_fast_realloc_array()

2019-12-27 Thread Nicolas George
Andreas Rheinhardt (12019-12-26): > I don't understand. Do you think that callers will take this as a blank > cheque to not check at all? No, I mean that using the wrong type will impose limitations on us later, that will take work to resolve. > My intention was actually to convert the types for

Re: [FFmpeg-devel] [PATCH v1] avcodec/mvha: fix warning: variable 'size' set but not used

2019-12-27 Thread Paul B Mahol
lgtm On 12/27/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/mvha.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/mvha.c b/libavcodec/mvha.c > index c270063..afe5e51 100644 > --- a/libavcodec/mvha.c > +++ b/libavco

[FFmpeg-devel] [PATCH v1] avcodec/mvha: fix warning: variable 'size' set but not used

2019-12-27 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mvha.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/mvha.c b/libavcodec/mvha.c index c270063..afe5e51 100644 --- a/libavcodec/mvha.c +++ b/libavcodec/mvha.c @@ -161,6 +161,9 @@ static int decode_frame(AVCodecContext

Re: [FFmpeg-devel] [PATCH v1] avfilter: add colorstats, colorrgbstats, coloryuvstats video filter

2019-12-27 Thread Paul B Mahol
That is because signalstats is doing more stuff. On 12/27/19, Limin Wang wrote: > On Fri, Dec 27, 2019 at 03:20:19PM +0100, Paul B Mahol wrote: >> On 12/27/19, Limin Wang wrote: >> > On Fri, Dec 27, 2019 at 12:35:25PM +0100, Paul B Mahol wrote: >> >> You are duplicating some functionality of sig

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Paul B Mahol
On 12/27/19, James Almer wrote: > On 12/27/2019 12:29 PM, Paul B Mahol wrote: >> On 12/27/19, Nicolas George wrote: >>> Paul B Mahol (12019-12-27): I disagree. >>> >>> And yet in the meantime somebody found a bug. This is a big patch, and >>> we have a policy. >>> >> >> I will not follow suc

Re: [FFmpeg-devel] [PATCH v1] avfilter: add colorstats, colorrgbstats, coloryuvstats video filter

2019-12-27 Thread Limin Wang
On Fri, Dec 27, 2019 at 03:20:19PM +0100, Paul B Mahol wrote: > On 12/27/19, Limin Wang wrote: > > On Fri, Dec 27, 2019 at 12:35:25PM +0100, Paul B Mahol wrote: > >> You are duplicating some functionality of signalstats filter. > >> > > Yes, I have other function need to use the mean and stdev whi

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread James Almer
On 12/27/2019 12:29 PM, Paul B Mahol wrote: > On 12/27/19, Nicolas George wrote: >> Paul B Mahol (12019-12-27): >>> I disagree. >> >> And yet in the meantime somebody found a bug. This is a big patch, and >> we have a policy. >> > > I will not follow such policy. Paul, you got a positive review.

Re: [FFmpeg-devel] [PATCH] lavu/avstring: deprecate av_d2str().

2019-12-27 Thread Nicolas George
James Almer (12019-12-26): > I guess we'll bumping in the coming months (it's been a long while since > the last time, and some cleaning is in order), so might as well make > this < 58 so we don't have to postpone it later. Ok, locally changed to 58. Regards, -- Nicolas George signature.asc

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Paul B Mahol
On 12/27/19, Nicolas George wrote: > Paul B Mahol (12019-12-27): >> I disagree. > > And yet in the meantime somebody found a bug. This is a big patch, and > we have a policy. > I will not follow such policy. > -- > Nicolas George > ___ ffmpeg-devel m

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Nicolas George
Paul B Mahol (12019-12-27): > I disagree. And yet in the meantime somebody found a bug. This is a big patch, and we have a policy. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Paul B Mahol
On 12/27/19, Nicolas George wrote: > Paul B Mahol (12019-12-27): >> Will apply in 5 minutes. > > Too soon. Let other people time to spot problems and voice objections. I disagree. > > Regards, > > -- > Nicolas George > ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread James Almer
On 12/26/2019 5:25 PM, Paul B Mahol wrote: > +if (s->thistogram) > +return ff_filter_frame(outlink, av_frame_clone(out)); av_frame_clone() can fail to allocate an AVFrame struct and return NULL, which will make ff_filter_frame() crash as it doesn't expect frame to be NULL. > +else

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Nicolas George
Paul B Mahol (12019-12-27): > Will apply in 5 minutes. Too soon. Let other people time to spot problems and voice objections. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Paul B Mahol
Will apply in 5 minutes. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1] avfilter: add colorstats, colorrgbstats, coloryuvstats video filter

2019-12-27 Thread Paul B Mahol
On 12/27/19, Limin Wang wrote: > On Fri, Dec 27, 2019 at 12:35:25PM +0100, Paul B Mahol wrote: >> You are duplicating some functionality of signalstats filter. >> > Yes, I have other function need to use the mean and stdev which is > support in showinfo filter(only 8bit and don't support packed fo

Re: [FFmpeg-devel] [PATCH v1] avfilter: add colorstats, colorrgbstats, coloryuvstats video filter

2019-12-27 Thread Limin Wang
On Fri, Dec 27, 2019 at 12:35:25PM +0100, Paul B Mahol wrote: > You are duplicating some functionality of signalstats filter. > Yes, I have other function need to use the mean and stdev which is support in showinfo filter(only 8bit and don't support packed format, no multi-thread), and signalstats

[FFmpeg-devel] [PATCH 3/3] lavf/dump: use a writer.

2019-12-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/avformat.h | 21 +++ libavformat/dump.c | 297 + 2 files changed, 175 insertions(+), 143 deletions(-) Note: I chose flags instead of is_output because I intent do add new flags later, in particular AV_DUM

[FFmpeg-devel] [PATCH 2/3] lavu/writer: add test.

2019-12-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/Makefile | 1 + libavutil/tests/.gitignore | 1 + libavutil/tests/writer.c | 190 + tests/fate/libavutil.mak | 4 + tests/ref/fate/writer | 36 +++ 5 files changed, 232 insertions(+) creat

[FFmpeg-devel] [PATCH 1/3] lavu: new AVWriter API.

2019-12-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/Makefile | 3 +- libavutil/writer.c | 371 libavutil/writer.h | 418 + 3 files changed, 791 insertions(+), 1 deletion(-) create mode 100644 libavutil/writer.c creat

Re: [FFmpeg-devel] [PATCH 1/2] avformat/microdvd: Use \n instead of \0 to end file header

2019-12-27 Thread Michael Niedermayer
On Fri, Dec 27, 2019 at 10:44:53AM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 2/2] avformat/microdvdenc: Use avio_w8 to write a char

2019-12-27 Thread Michael Niedermayer
On Thu, Dec 12, 2019 at 04:53:18PM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/microdvdenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No

Re: [FFmpeg-devel] [PATCH V4 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

2019-12-27 Thread Michael Niedermayer
On Thu, Dec 19, 2019 at 11:35:51AM +0800, Ting Fu wrote: > Tested using this command: > ./ffmpeg -pix_fmt yuv420p -s 1920*1080 -i ArashRawYuv420.yuv \ > -vcodec rawvideo -s 1920*1080 -pix_fmt rgb24 -f null /dev/null > > The fps increase from 151 to 389 on my local machine. Thats nice but why is

Re: [FFmpeg-devel] [PATCH v1] avfilter: add colorstats, colorrgbstats, coloryuvstats video filter

2019-12-27 Thread Paul B Mahol
You are duplicating some functionality of signalstats filter. On 12/27/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/filters.texi| 74 ++ > libavfilter/Makefile| 1 + > libavfilter/allfilters.c| 3 + > libavfilte

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Paul B Mahol
On 12/27/19, Nicolas George wrote: > Paul B Mahol (12019-12-26): >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 46 ++ >> libavfilter/Makefile | 1 + >> libavfilter/allfilters.c | 1 + >> libavfilter/vf_histogram.c | 127 +++

[FFmpeg-devel] [PATCH v1] avfilter: add colorstats, colorrgbstats, coloryuvstats video filter

2019-12-27 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi| 74 ++ libavfilter/Makefile| 1 + libavfilter/allfilters.c| 3 + libavfilter/vf_colorstats.c | 461 4 files changed, 539 insertions(+) create mode 100644 libav

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Nicolas George
Paul B Mahol (12019-12-26): > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 46 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_histogram.c | 127 ++--- > 4 files changed, 151 insertion

Re: [FFmpeg-devel] [PATCH 1/2] lavc/decode: re-allocate surface in ff_decode_get_hw_frames_ctx

2019-12-27 Thread Hendrik Leppkes
On Fri, Dec 27, 2019 at 9:59 AM Linjie Fu wrote: > > Allow hw_frames_ctx to be recreated instead of just return if it exists. > > Move hw_frames_ctx check outside ff_decode_get_hw_frames_ctx, and check > in relevant code. > > Signed-off-by: Linjie Fu > --- > libavcodec/decode.c | 2 +- > libavco

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vp9: support hardware decode with resolution changing on inter frame

2019-12-27 Thread Hendrik Leppkes
On Fri, Dec 27, 2019 at 9:59 AM Linjie Fu wrote: > > VP9 decoder should be able to handle resolution changing on inter > frame without re-initialization. For hardware decoder, re-allocate hardware > frame surface. > > Fix #8068 for VA-API. > > Signed-off-by: Linjie Fu > --- > Request for comments

Re: [FFmpeg-devel] [PATCH 1/2] avformat/microdvd: Use \n instead of \0 to end file header

2019-12-27 Thread Paul B Mahol
lgtm On 12/27/19, Andreas Rheinhardt wrote: > Andreas Rheinhardt: >> Andreas Rheinhardt: >>> Up until now, the microdvd demuxer uses av_strdup() to allocate the >>> extradata from a string; its length is set to strlen() + 1, i.e. >>> including the \0 at the end. Upon remuxing, the muxer would sim

[FFmpeg-devel] Copying Audio

2019-12-27 Thread Chris
I have a file with audio in the format pcm_s16be. When I try to copy this audio to another file using -c:a copy, it copies the audio but also transcodes it to AAC. If it's literally a copy, shouldn't the copy be pcm_s16be as well? How can I do this and wind up with a pcm copy of the original aud

Re: [FFmpeg-devel] [PATCH V4 2/2] libswscale/x86/yuv2rgb: add ssse3 version

2019-12-27 Thread Paul B Mahol
LGTM On 12/26/19, Fu, Ting wrote: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Ting Fu >> Sent: Thursday, December 19, 2019 11:36 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH V4 2/2] libswscale/x86/yuv2rgb: add ssse3 >> version >> >> Tested using th

Re: [FFmpeg-devel] [PATCH 1/4] tests/checkasm: add overflow test for hevc_add_res

2019-12-27 Thread Fu, Linjie
Hi, > -Original Message- > From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Wednesday, December 18, 2019 09:55 > To: FFmpeg development discussions and patches de...@ffmpeg.org>; alexan...@khirnov.net; c...@passwd.hu; Paul B Mahol > ; jamr...@gmail.com; u...@pkh.me > Subject: Re: [FF

[FFmpeg-devel] [PATCH 2/2] lavc/vp9: support hardware decode with resolution changing on inter frame

2019-12-27 Thread Linjie Fu
VP9 decoder should be able to handle resolution changing on inter frame without re-initialization. For hardware decoder, re-allocate hardware frame surface. Fix #8068 for VA-API. Signed-off-by: Linjie Fu --- Request for comments. This works for VA-API, however for dxva2 it didn't cover all cases

[FFmpeg-devel] [PATCH] lavc/hevcdec: Align transform syntax with the SPEC

2019-12-27 Thread Linjie Fu
Doesn't change the logic, modify to keep it consistent with 7.3.8.8 in spec to avoid some misunderstandings. Signed-off-by: Linjie Fu --- libavcodec/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 8f1c162..fb2ee72 10

[FFmpeg-devel] [PATCH 1/2] lavc/decode: re-allocate surface in ff_decode_get_hw_frames_ctx

2019-12-27 Thread Linjie Fu
Allow hw_frames_ctx to be recreated instead of just return if it exists. Move hw_frames_ctx check outside ff_decode_get_hw_frames_ctx, and check in relevant code. Signed-off-by: Linjie Fu --- libavcodec/decode.c | 2 +- libavcodec/dxva2.c | 8 +--- libavcodec/vdpau.c | 9 + 3 file

[FFmpeg-devel] [PATCH] lavc/pthread_frame: Update user context in ff_frame_thread_free

2019-12-27 Thread Linjie Fu
Resolution/format changes lead to re-initialization of hardware accelerations(vaapi/dxva2/..) with new hwaccel_priv_data in the worker-thread. But hwaccel_priv_data in user context won't be updated until the resolution changing frame is output. A termination with "-vframes" just after the reinit w

[FFmpeg-devel] [PATCH 2/2] vf_dnn_processing: add support for more formats gray8 and grayf32

2019-12-27 Thread Guo, Yejun
The following is a python script to halve the value of the gray image. It demos how to setup and execute dnn model with python+tensorflow. It also generates .pb file which will be used by ffmpeg. import tensorflow as tf import numpy as np from skimage import color from skimage import io in_img = i

[FFmpeg-devel] [PATCH 1/2] vf_dnn_processing: remove parameter 'fmt'

2019-12-27 Thread Guo, Yejun
do not request AVFrame's format in vf_ddn_processing with 'fmt', but to add another filter for the format. command examples: ./ffmpeg -i input.jpg -vf format=bgr24,dnn_processing=model=halve_first_channel.model:input=dnn_in:output=dnn_out:dnn_backend=native -y out.native.png ./ffmpeg -i input.jp