Paul B Mahol (12019-12-26): > Signed-off-by: Paul B Mahol <one...@gmail.com> > --- > doc/filters.texi | 46 ++++++++++++++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_histogram.c | 127 ++++++++++++++++++++++++++++++------- > 4 files changed, 151 insertions(+), 24 deletions(-)
Thanks for merging them. I have no objection to this version, just a
small remark below.
I did not look at the arithmetic of the code closely, but I can do it if
you want me to.
> + if (!strcmp(ctx->filter->name, "thistogram"))
> + s->thistogram = 1;
Could you not test if s->width == 1 and have just one filter:
histogram=... -> equivalent to current histogram
histogram=width=1080:... -> equivalent to new thistogram
? It would save you the task of using a macro for common options.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
