On Thu, Dec 26, 2019 at 05:24:31PM +0100, Lynne wrote: > Dec 26, 2019, 13:57 by d...@lynne.ee: > > > Dec 16, 2019, 23:19 by mich...@niedermayer.cc: > > > >> Fixes: out of array read > >> Fixes: > >> 19327/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5679823087468544 > >> > >> Found-by: continuous fuzzing process > >> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > >> Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > >> > > Actually nevermind, patch is good as-is. I think a 0 len just means to reuse > the parameters from the previous. So clipping them should be fine. > You should replace the FFMIN(val, (len << 1) - 1) with a av_clip_uintp2(val, > len) which does exactly that.
i think both the FFMIN and av_clip_uintp2 do the same thing here, unless iam missing something. But i agree The later is a bit prettier, and as you prefer it too, ill change it and will apply with that Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
