Re: [FFmpeg-devel] [PATCH V4 2/2] libswscale/x86/yuv2rgb: add ssse3 version

2019-12-25 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: Thursday, December 19, 2019 11:36 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V4 2/2] libswscale/x86/yuv2rgb: add ssse3 > version > > Tested using this command: > /ffmpeg -pix_fmt yuv420p -s 192

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpeg12dec: Fix invalid shift in mpeg2_fast_decode_block_intra()

2019-12-25 Thread Kieran Kunhya
On Thu, 26 Dec 2019 at 00:27, Michael Niedermayer wrote: > Fixes: left shift of negative value -695 > Fixes: > 19232/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-5702856963522560 > Fixes: > 19555/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-5741218147

[FFmpeg-devel] [PATCH v2 2/2] avcodec/h265_metadata_bsf: add option to insert a string as SEI unregistered user data

2019-12-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- update to add keyframe NAL checking as H.264 patch for global header doc/bitstream_filters.texi | 8 libavcodec/h265_metadata_bsf.c | 68 +- 2 files changed, 75 insertions(+), 1 deletion(-) diff --git a/d

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_vp9: Check data_size

2019-12-25 Thread James Almer
On 12/25/2019 9:18 PM, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 19542/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5659498341728256 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-b

[FFmpeg-devel] [PATCH v1 1/2] avcodec/ass: remove the unneeded ()

2019-12-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ass.c b/libavcodec/ass.c index b4f081c..a51673f 100644 --- a/libavcodec/ass.c +++ b/libavcodec/ass.c @@ -105,7 +105,7 @@ int ff_ass_add_rect(AVSubtitle

[FFmpeg-devel] [PATCH v1 2/2] avcodec/vc1dec: remove the unneeded ()

2019-12-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/vc1dec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index ac3198e..d1ca2af 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -688,7 +688,7 @@ static int

Re: [FFmpeg-devel] [PATCH v1 3/3] avfilter/vf_yadif: remove duplicate code with macro-based function

2019-12-25 Thread Limin Wang
On Wed, Dec 25, 2019 at 05:57:58PM +0100, Michael Niedermayer wrote: > On Tue, Dec 24, 2019 at 09:13:39AM +0800, Limin Wang wrote: > > On Thu, Nov 28, 2019 at 09:34:18AM +0800, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > > --- > > > libavfilter

[FFmpeg-devel] [PATCH v1] avcodec/h264_metadata_bsf: Fix user data failed to insert in case no SPSs NAL for global headers

2019-12-25 Thread lance . lmwang
From: Limin Wang FLV, MP4... will enable global_header default and place SPSs headers in extradata instead of every keyframe. So it'll failed to insert user data unregisted for no SPSs NAL after first AU without the patch. Please test it with below command: ./ffmpeg -f lavfi -i testsrc -c:v lib

[FFmpeg-devel] [PATCH v3] avutil/frame: Use av_realloc_array()

2019-12-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavutil/frame.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index e403809..2e763ef 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -696,11 +696,8 @@ AVFrameSideData *a

[FFmpeg-devel] [PATCH 1/2] avcodec/mpeg12dec: Fix invalid shift in mpeg2_fast_decode_block_intra()

2019-12-25 Thread Michael Niedermayer
Fixes: left shift of negative value -695 Fixes: 19232/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-5702856963522560 Fixes: 19555/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-5741218147598336 Found-by: continuous fuzzing process https://github.com/go

[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_vp9: Check data_size

2019-12-25 Thread Michael Niedermayer
Fixes: out of array access Fixes: 19542/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5659498341728256 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cbs_vp9.c | 3 +++ 1 fil

Re: [FFmpeg-devel] [aarch64] improve performance of ff_yuv2planeX_8_neon

2019-12-25 Thread Sebastian Pop
On Mon, Dec 16, 2019 at 3:56 PM Jean-Baptiste Kempf wrote: > > On Tue, Dec 10, 2019, at 23:38, Sebastian Pop wrote: >> Please let me know how I can improve the patch. > > No remarks from me. > Clément, any further feedback to improve the patch? Ok to commit? Thanks, Sebastian ___

[FFmpeg-devel] [PATCH 12/13] avcodec/libxavs2: use AV_OPT_TYPE_DICT for xavs2-params

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/libxavs2.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 2f8460ab8e..76b57e731e 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -48,7 +48,7 @@

[FFmpeg-devel] [PATCH 11/13] avcodec/libx265: use AV_OPT_TYPE_DICT for x265-params

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/libx265.c | 39 +-- 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 963c28fb1d..8c380eeb0a 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c

[FFmpeg-devel] [PATCH 13/13] avcodec/rav1e: use AV_OPT_TYPE_DICT for rav1e-params

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/librav1e.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c index a5aedd512c..b8b1b4f8f1 100644 --- a/libavcodec/librav1e.c +++ b/libavcodec/librav1e.c @@ -42,7 +42,7

[FFmpeg-devel] [PATCH 10/13] avcodec/libx264: use AV_OPT_TYPE_DICT for x264-params

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/libx264.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index bfd91bb900..77bf88748f 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -95,7 +95,7 @

[FFmpeg-devel] [PATCH 05/13] avformat/fifo: use AV_OPT_TYPE_DICT for format_opts

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/fifo.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index b403ba717b..7b37fff6da 100644 --- a/libavformat/fifo.c +++ b/libavformat/fifo.c @@ -36,7 +36,6 @@ typedef struct

[FFmpeg-devel] [PATCH 09/13] avcodec/libvpxenc: use AV_OPT_TYPE_DICT for ts-parameters

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/libvpxenc.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 721a052641..3f659b4b67 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -100

[FFmpeg-devel] [PATCH 06/13] avformat/hlsenc: use AV_OPT_TYPE_DICT for hls_ts_options

2019-12-25 Thread Marton Balint
Simplifies code and avoids memory leaks. Signed-off-by: Marton Balint --- libavformat/hlsenc.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 6551e1c234..561e3ff736 100644 --- a/libavformat/hlsenc.c +++

[FFmpeg-devel] [PATCH 07/13] avformat/segment: use AV_OPT_TYPE_DICT for segment_format_options

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/segment.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index e3082063d8..bf9e706c1c 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -75,7 +75,6 @@ t

[FFmpeg-devel] [PATCH 08/13] avformat/tee: use AV_OPT_TYPE_DICT for fifo_options

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/tee.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/libavformat/tee.c b/libavformat/tee.c index d91993354b..56669d9d8e 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @@ -56,7 +56,6 @@ typedef struct TeeContext

[FFmpeg-devel] [PATCH 03/13] avutil/tests/opt: add av_opt_get/av_opt_set tests

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/tests/opt.c | 41 + tests/ref/fate/opt| 26 ++ 2 files changed, 67 insertions(+) diff --git a/libavutil/tests/opt.c b/libavutil/tests/opt.c index 1173ae8eba..3134ffd354 100644 --- a/lib

[FFmpeg-devel] [PATCH 04/13] avformat/dashenc: use AV_OPT_TYPE_DICT for format_options

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/dashenc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 8c28fb6b6e..b84736881f 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -142,7 +142,7 @@ typed

[FFmpeg-devel] [PATCH 02/13] avutil/tests/opt: add tests for AV_OPT_TYPE_DICT

2019-12-25 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/tests/opt.c | 5 + tests/ref/fate/opt| 15 +-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/libavutil/tests/opt.c b/libavutil/tests/opt.c index f4cfa590aa..1173ae8eba 100644 --- a/libavutil/tests/opt.c +++ b/libavu

[FFmpeg-devel] [PATCH 01/13] avutil/opt: add full support for AV_OPT_TYPE_DICT

2019-12-25 Thread Marton Balint
Now it is possible to set them from a string, to serialize them and to use a default value. Signed-off-by: Marton Balint --- libavutil/opt.c | 51 ++- libavutil/opt.h | 10 +++--- 2 files changed, 53 insertions(+), 8 deletions(-) diff --git a/

Re: [FFmpeg-devel] [PATCH] configure: Change the configure check for tonemap_vaapi

2019-12-25 Thread Marton Balint
On Tue, 24 Dec 2019, Xinpeng Sun wrote: "VAProcFilterParameterBufferHDRToneMapping" was defined in libva 2.4.1, which will lead to build failure for the filter tonemap_vaapi for libva 2.3.0 with current check. This patch is to fix this build error. Thanks, it fixes the issue indeed. Regar

Re: [FFmpeg-devel] [PATCH] Fix spelling in ID3v1 genres and extend the list of Winamp extensions.

2019-12-25 Thread Michael Niedermayer
On Wed, Dec 25, 2019 at 04:44:51PM +0100, Ulrich Spörlein wrote: > On Tue, 24 Dec 2019, 00:42 Michael Niedermayer, > wrote: > > > On Mon, Dec 23, 2019 at 11:43:10AM +0100, Ulrich Spörlein wrote: > > > On Sun, 2019-12-22 at 18:44:01 +0100, Michael Niedermayer wrote: > > > > a reference to a VCS sh

[FFmpeg-devel] [PATCH] lavc: remove not required includes, relocate some functions

2019-12-25 Thread vitamin-caig
Signed-off-by: vitamin-caig --- libavcodec/raw.c| 11 +++ libavcodec/raw.h| 2 -- libavcodec/rawdec.c | 2 +- libavcodec/utils.c | 12 4 files changed, 12 insertions(+), 15 deletions(-) diff --git a/libavcodec/raw.c b/libavcodec/raw.c index b6fb91c1c6..96b7442f51

Re: [FFmpeg-devel] [PATCH v1 2/3] avfilter/vf_yadif: cosmetics

2019-12-25 Thread Michael Niedermayer
On Thu, Nov 28, 2019 at 09:34:17AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_yadif.c | 47 +++--- > 1 file changed, 12 insertions(+), 35 deletions(-) will aply thx [...] -- Michael Gnu

Re: [FFmpeg-devel] [PATCH v2] avutil/frame: Use av_realloc_array()

2019-12-25 Thread Michael Niedermayer
On Tue, Dec 24, 2019 at 08:56:12AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/frame.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index e4038096c2..1a67eda

Re: [FFmpeg-devel] [PATCH v1 3/3] avfilter/vf_yadif: remove duplicate code with macro-based function

2019-12-25 Thread Michael Niedermayer
On Tue, Dec 24, 2019 at 09:13:39AM +0800, Limin Wang wrote: > On Thu, Nov 28, 2019 at 09:34:18AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_yadif.c | 147 +++-- > > 1 file changed, 54

Re: [FFmpeg-devel] [PATCH] Fix spelling in ID3v1 genres and extend the list of Winamp extensions.

2019-12-25 Thread Ulrich Spörlein
On Tue, 24 Dec 2019, 00:42 Michael Niedermayer, wrote: > On Mon, Dec 23, 2019 at 11:43:10AM +0100, Ulrich Spörlein wrote: > > On Sun, 2019-12-22 at 18:44:01 +0100, Michael Niedermayer wrote: > > > a reference to a VCS should include the version > > > similarly for wikipedia some revission of the

Re: [FFmpeg-devel] [PATCH] qsvenc: Add ROI encoding support for h264_qsv and hevc_qsv

2019-12-25 Thread Zhong Li
Guo, Yejun 于2019年12月25日周三 下午7:10写道: > > command examples: > ./ffmpeg -s 1920x1080 -i input.yuv -vf addroi=0:0:640:320:0.5 -c:v hevc_qsv > -b:v 5M -y qsv.b5m.roi.h265 > ./ffmpeg -s 1920x1080 -i input.yuv -vf addroi=0:0:640:320:-0.5 -c:v h264_qsv > -mfmode 1 -b:v 4M -y qsv.b4m.roi.h264 > > Sign

[FFmpeg-devel] [PATCH] avfilter/buffersrc: Remove unused variables

2019-12-25 Thread Andreas Rheinhardt
Unused since f09ae730. Signed-off-by: Andreas Rheinhardt --- libavfilter/buffersrc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index 72a5ea9370..2fa9e00daf 100644 --- a/libavfilter/buffersrc.c +++ b/libavfilter/buffersrc.c @@ -435,8 +4

[FFmpeg-devel] [PATCH] qsvenc: Add ROI encoding support for h264_qsv and hevc_qsv

2019-12-25 Thread Guo, Yejun
command examples: ./ffmpeg -s 1920x1080 -i input.yuv -vf addroi=0:0:640:320:0.5 -c:v hevc_qsv -b:v 5M -y qsv.b5m.roi.h265 ./ffmpeg -s 1920x1080 -i input.yuv -vf addroi=0:0:640:320:-0.5 -c:v h264_qsv -mfmode 1 -b:v 4M -y qsv.b4m.roi.h264 Signed-off-by: Guo, Yejun --- libavcodec/qsvenc.c | 11