On Wed, Dec 25, 2019 at 04:44:51PM +0100, Ulrich Spörlein wrote: > On Tue, 24 Dec 2019, 00:42 Michael Niedermayer, <mich...@niedermayer.cc> > wrote: > > > On Mon, Dec 23, 2019 at 11:43:10AM +0100, Ulrich Spörlein wrote: > > > On Sun, 2019-12-22 at 18:44:01 +0100, Michael Niedermayer wrote: > > > > a reference to a VCS should include the version > > > > similarly for wikipedia some revission of the page should be mentioned > > in > > > > the commit message > > > > > > Heh, this is already a defunct standard, I doubt it will ever change > > > again. I've updated the commit message to provide more direct links to > > > fixed versions in time, hth, please see attached. > > > > > > > > > > > id3v1.c | 58 > > +++++++++++++++++++++++++++++++++++++++++++++++++++------- > > > id3v1.h | 2 +- > > > 2 files changed, 52 insertions(+), 8 deletions(-) > > > 18bb5fc86701a138c90c9bc95737d5a18299c6ea > > 0001-libavformat-fix-spelling-in-ID3v1-genres-and-extend-.patch > > > From 55601483bdc8c002f3b8c19f830ab6ebbf4586cd Mon Sep 17 00:00:00 2001 > > > From: =?UTF-8?q?Ulrich=20Sp=C3=B6rlein?= <uspoerl...@gmail.com> > > > Date: Thu, 19 Dec 2019 16:12:46 +0100 > > > Subject: [PATCH] libavformat: fix spelling in ID3v1 genres and extend > > the list > > > of Winamp extensions. > > > > > > Sources include various lists on the Internet, as well as the current > > > Wikipedia page at > > > > > https://en.wikipedia.org/w/index.php?title=List_of_ID3v1_Genres&oldid=896774343 > > > but most importantly the list as used by taglib at > > > > > https://github.com/taglib/taglib/commit/3e60e339a4bc46e2a1a7aea782502480561a8acf#diff-f86455366624350770f41b4940925dde > > > > > > Further patches to harmonize the spelling have been sent to taglib and > > > libid3tag. See also https://github.com/taglib/taglib/pull/942/ > > > --- > > > libavformat/id3v1.c | 58 +++++++++++++++++++++++++++++++++++++++------ > > > libavformat/id3v1.h | 2 +- > > > 2 files changed, 52 insertions(+), 8 deletions(-) > > > > patch may be ok, but spelling is not my strong side ;) > > > > Heh ;) > The main thing really is the extension of the genre list. So where do we go > from here, who can commit this? Is there anything else for me to do?
i guess, ping it in a 1-2 weeks and ill apply it if noone else commented thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
