On Tue, Dec 24, 2019 at 08:56:12AM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang <lance.lmw...@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmw...@gmail.com>
> ---
> libavutil/frame.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/libavutil/frame.c b/libavutil/frame.c
> index e4038096c2..1a67eda91d 100644
> --- a/libavutil/frame.c
> +++ b/libavutil/frame.c
> @@ -693,14 +693,11 @@ AVFrameSideData
> *av_frame_new_side_data_from_buf(AVFrame *frame,
> {
> AVFrameSideData *ret, **tmp;
>
> - if (!buf)
> + if (!buf || frame->nb_side_data > INT_MAX - 1)
> return NULL;
>
> - if (frame->nb_side_data > INT_MAX / sizeof(*frame->side_data) - 1)
> - return NULL;
> -
> - tmp = av_realloc(frame->side_data,
> - (frame->nb_side_data + 1) * sizeof(*frame->side_data));
> + tmp = av_realloc_array(frame->side_data,
> + (frame->nb_side_data + 1), sizeof(*frame->side_data));the () is unneeded [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart then the original author, trying to rewrite it will not make it better.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
