Re: [FFmpeg-devel] [PATCH v4 7/9] avformat/utils: Avoid copying packets unnecessarily

James Almer: > On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: >> Up until now, read_frame_internal in avformat/utils.c uses a spare >> packet on the stack that serves no real purpose: At no point in this >> function is there a need for another packet besides the packet destined >> for output: >> 1

[FFmpeg-devel] [PATCH v5] avformat/utils: Don't create unnecessary references

When AVFMT_FLAG_GENPTS is set, av_read_frame would put a reference to a packet in the packet list (via av_packet_ref) and then immediately thereafter unreference the original packet. This has been changed to move the reference instead. Signed-off-by: Andreas Rheinhardt --- Updated the commit mess

[FFmpeg-devel] [PATCH v2 15/15] avcodec/jpeg2000dwt: Fix undefined shifts of negative numbers

Affected the vsynth*-jpeg2000 and the vsynth*-jpeg2000-97 FATE tests (where * ranges over { 1, 2, 3, _lena }) as well as ticket #7983. Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeg2000dwt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/jpeg2000dwt.c b/lib

[FFmpeg-devel] [PATCH v2 12/15] avcodec/ituh263dec: Fix undefined left shift of negative number

Fixes ticket #8160. Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ituh263dec.c b/libavcodec/ituh263dec.c index 1b57e53cad..afc786bd8b 100644 --- a/libavcodec/ituh263dec.c +++ b/libavcodec/ituh263dec.c

[FFmpeg-devel] [PATCH v2 02/15] avfilter/vf_hqx: Fix undefined left shifts of negative numbers

Affected every usage of this filter; in particular, it affected the FATE-tests filter-2xbr, filter-3xbr and filter-4xbr. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_hqx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_hqx.c b/libavfilter/vf_hqx.c inde

[FFmpeg-devel] [PATCH v2 14/15] avcodec/j2kenc: Simplify computations

1. (1 << (c - 1)) & ~((1 << c) - 1) is always zero. This together with the fact that a square is always nonnegative (there's no overflow) allows to remove a FFMAX. 2. The discriminant of the polynomial i * i - 2^(F+1) * i + 2^(F - 1) + 2^(2 * F) is negative; hence this polynomial has no real soluti

[FFmpeg-devel] [PATCH v2 07/15] swscale/utils: Fix invalid left shifts of negative numbers

Affected the FATE-tests vsynth_lena-dv-411, vsynth1-dv-411, vsynth2-dv-411 and hevc-paramchange-yuv420p.yuv420p10. Signed-off-by: Andreas Rheinhardt --- libswscale/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 1b1f779532

[FFmpeg-devel] [PATCH v2 13/15] avcodec/j2kenc: Fix undefined shifts of negative numbers

Also add parentheses to some lines to make the operator precedence clearer. This affected the FATE-tests vsynth*-jpeg2000 and vsynth*-jpeg2000-97 (where * ranges over { 1, 2, 3, _lena }) as well as ticket #7983. Signed-off-by: Andreas Rheinhardt --- libavcodec/j2kenc.c | 10 +- 1 file c

[FFmpeg-devel] [PATCH v2 09/15] avcodec/vc1_pred: Fix undefined left shifts of negative numbers

Affects the FATE-tests vc1_sa10143, vc1_ilaced_twomv. Signed-off-by: Andreas Rheinhardt --- libavcodec/vc1_pred.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vc1_pred.c b/libavcodec/vc1_pred.c index e1ad0e1d7d..08412b3435 100644 --- a/libavcodec/vc1_pred.

[FFmpeg-devel] [PATCH v2 08/15] avformat/webmdashenc: Don't pass NULL to memcmp

Affects the FATE-tests webm-dash-manifest-unaligned-video-streams, webm-dash-manifest and webm-dash-manifest-representations. Signed-off-by: Andreas Rheinhardt --- libavformat/webmdashenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/webmdashenc.c b/libavfor

[FFmpeg-devel] [PATCH v2 06/15] avcodec/ffv1enc: Fix out-of-bounds-array access

libavcodec/ffv1enc.c accessed an array of uint8_t [32] via array[0][j] in order to loop over all the uint8_t in this array of arrays. Of course this implied an out-of-bounds access for array[0] and UBSan complained about this. So replace this with nested loops; furthermore, factor this out into a f

[FFmpeg-devel] [PATCH v2 10/15] avcodec/cinepakenc: Fix invalid shifts

Fixes: left shift of 1 by 31 places cannot be represented in type 'int'. Affected the FATE-tests vsynth1-cinepak, vsynth2-cinepak and vsynth_lena-cinepak. Signed-off-by: Andreas Rheinhardt --- libavcodec/cinepakenc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a

[FFmpeg-devel] [PATCH v2 11/15] avcodec/dnxhdenc: Fix undefined left shifts of negative numbers

Affected 61 FATE-tests: 60 vsynth tests and lavf-mxf_opatom. Signed-off-by: Andreas Rheinhardt --- libavcodec/dnxhdenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index c82c5d5140..2feb8baf21 100644 --- a/libavcodec/dn

[FFmpeg-devel] [PATCH v2 05/15] avcodec/cavsdsp: Fix undefined left shifts of negative numbers

Affected the ffmpeg-filter_colorkey FATE-test (but only if the C version of idct8_add is used and not e.g. the x86 SSE2 version). Signed-off-by: Andreas Rheinhardt --- libavcodec/cavsdsp.c | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff

[FFmpeg-devel] [PATCH v2 01/15] avfilter/vf_xbr: Fix left shift of negative number

Affected every usage of vf_xbr, e.g. the FATE-tests filter-2xbr, filter-3xbr, filter-4xbr. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_xbr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_xbr.c b/libavfilter/vf_xbr.c index 2c71871d22..87810c88f1 10064

[FFmpeg-devel] [PATCH v2 04/15] avcodec/adpcm: Fix undefined left shifts of negative numbers

Affected the adpcm-afc, adpcm-dtk, adpcm-ea-1, adpcm-ea-2, adpcm-ima-oki, adpcm-ea-maxis-xa, adpcm-ea-r1, adpcm-ea-r2, adpcm-ea-r3 and adpcm-thp FATE-tests. Signed-off-by: Andreas Rheinhardt --- libavcodec/adpcm.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) dif

[FFmpeg-devel] [PATCH v2 03/15] swscale/x86/swscale: Fix undefined left shifts of negative numbers

This affected many FATE-tests: The number of failing tests went down from 663 to 344. (Both numbers exclude tests that failed because of unaligned accesses in code that is inside #if HAVE_FAST_UNALIGNED.) Signed-off-by: Andreas Rheinhardt --- libswscale/x86/swscale.c | 4 ++-- 1 file changed, 2

Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format a2r10g10b10/a2b10g10r10

Am Sa., 28. Sept. 2019 um 02:14 Uhr schrieb Song, Ruiling : > > Am Fr., 27. Sept. 2019 um 11:02 Uhr schrieb Sun, Xinpeng > > : > > > > > > > Add two 10 bit RGBA pixel format for hardware color space conversion > > > > > support in VAAPI and QSV: > > > > > > > > > > 2:10:10:10 10 bit: A2R10G10B10 >

Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format a2r10g10b10/a2b10g10r10

> -Original Message- > From: ffmpeg-devel On Behalf Of > Carl Eugen Hoyos > Sent: Friday, September 27, 2019 7:47 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel > format a2r10g10b10/a2b10g10r1

[FFmpeg-devel] [PATCH] cmdutils: trailing options may be ignored

Signed-off-by: Lou Logan --- fftools/cmdutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 6f4031fbb9..84f98b7c04 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -848,8 +848,8 @@ do {

[FFmpeg-devel] [PATCH] avformat: Add max_probe_packets option

From: Andriy Gelman This allows the user to set a maximum number of buffered packets when probing a codec. It was a hard-coded parameter before this commit. --- doc/formats.texi| 4 libavformat/avformat.h | 7 +++ libavformat/internal.h | 2 -- libavformat/options_

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: -timelimit is in user time

On Fri, Sep 27, 2019, at 12:18 AM, Michael Niedermayer wrote: > On Thu, Sep 26, 2019 at 10:27:57AM -0800, Lou Logan wrote: > > Signed-off-by: Lou Logan > > --- > > Some users were expecting real/wall-clock time. > > > > doc/ffmpeg.texi | 2 +- > > fftools/ffmpeg_opt.c | 2 +- > > 2 files changed, 2

[FFmpeg-devel] [PATCH] avfilter: add arnndn filter

Signed-off-by: Paul B Mahol --- doc/filters.texi | 11 + libavfilter/Makefile |1 + libavfilter/af_arnndn.c | 1522 ++ libavfilter/allfilters.c |1 + 4 files changed, 1535 insertions(+) create mode 100644 libavfilter/af_arnndn.c diff --

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

applied, but after some discussion on IRC, I opted to rename the current -refs option to -dpb_size, and use -refs for this one. -refs now matches what libx264 uses it for and what probably the majority of users expect. ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH v4] libavformat/rtsp: return error if rtsp_hd_out is null instead of crash

On Mon, Sep 23, 2019 at 8:23 AM Ross Nicholson wrote: > Can this be applied? > Applied to master. Thank you for your contribution. > > > On 19 Sep 2019, at 16:14, Ross Nicholson wrote: > > > > Updated to v4 of patch after learning from Aman Gupta that 'rt' did not > need to be checked in the

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

Hi Reino - good point. Though, that was an existing log message that I did not modify. Should the old typo be addressed in a separate patch, or should I update it here? On Wed, Sep 25, 2019 at 2:36 PM Reino Wijnsma wrote: > On 2019-09-25T20:57:08+0200, William Martin > wrote: > > +a

[FFmpeg-devel] [PATCH 09/11] avcodec/adpcm: Check initial predictor for ADPCM_IMA_EA_EACS

Fixes: signed integer overflow: -2147483360 - 631 cannot be represented in type 'int' Fixes: 17701/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_EA_EACS_fuzzer-5711517319692288 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sign

[FFmpeg-devel] [PATCH 08/11] avcodec/g723_1dec: Fix overflow in shift

Fixes: shift exponent 1008 is too large for 32-bit type 'int' Fixes: 17700/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G723_1_fuzzer-5707633436131328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 10/11] avcodec/aptx: Fix multiple shift anomalies

Fixes: left shift of negative value -24576 Fixes: 17719/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APTX_fuzzer-5710508002377728 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aptx.c |

[FFmpeg-devel] [PATCH 11/11] avcodec/sbcdec: Fix integer overflows in sbc_synthesize_eight()

Fixes: signed integer overflow: 518484152 + 1868182638 cannot be represented in type 'int' Fixes: 17732/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SBC_fuzzer-5663738132168704 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by

[FFmpeg-devel] [PATCH 05/11] avcodec/g729postfilter: Fix undefined shifts

Fixes: left shift of negative value -12 Fixes: 17689/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ACELP_KELVIN_fuzzer-5756275014500352 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/g729

[FFmpeg-devel] [PATCH 03/11] avcodec/utils: Check sample_rate before opening decoder

Fixes: signed integer overflow: 2 * -1306460384 cannot be represented in type 'int' Fixes: 17685/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_fuzzer-574739033664 Fixes: 17688/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INTERPLAY_ACM_fuzzer-5739287210885120 Fixes: 17699/cluste

[FFmpeg-devel] [PATCH 07/11] avcodec/apedec: Fix integer overflow in predictor_update_3930()

Fixes: signed integer overflow: -69555262 * 31 cannot be represented in type 'int' Fixes: 17698/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5728970447781888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michae

[FFmpeg-devel] [PATCH 04/11] avcodec/lsp: Fix undefined shifts in lsp2poly()

Fixes: left shift of negative value -30635 Fixes: 17689/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ACELP_KELVIN_fuzzer-5756275014500352 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/l

[FFmpeg-devel] [PATCH 01/11] avcodec/adpcm: Fix left shifts in AV_CODEC_ID_ADPCM_EA

Fixes: left shift of negative value -1 Fixes: 17683/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_EA_R2_fuzzer-5111690013704192 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/adpcm.

[FFmpeg-devel] [PATCH 06/11] avcodec/g729postfilter: Fix undefined intermediate pointers

Fixes: index -49 out of bounds for type 'int16_t [192]' Fixes: 17689/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ACELP_KELVIN_fuzzer-5756275014500352 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 02/11] avcodec/aacdec_template: Check decode_extension_payload() for failure

Signed-off-by: Michael Niedermayer --- libavcodec/aacdec_template.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index 6e086e00df..f1e03d3d77 100644 --- a/libavcodec/aacdec_template.c +++ b/libavcodec/

Re: [FFmpeg-devel] [PATCH] avfilter: add arnndn filter

On 7/27/19, Lynne wrote: > Jul 26, 2019, 4:37 PM by one...@gmail.com : >> +static void biquad(float *y, float mem[2], const float *x, >> + const float *b, const float *a, int N) >> +{ >> +for (int i = 0; i < N; i++) { >> +float xi, yi; >> +

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: parse sdtp atom and set the pkt disposable flag accordingly

On 27/09/2019 16:45, Matthieu Bouron wrote: > Fixed locally. +1 - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wi

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: parse sdtp atom and set the pkt disposable flag accordingly

On Fri, Sep 27, 2019 at 04:14:33PM +0100, Derek Buitenhuis wrote: > On 27/09/2019 15:37, Matthieu Bouron wrote: > > Allows the creation of the sdtp atom while remuxing MP4 to MP4. This > > atom is required by Apple devices (iPhone, Apple TV) in order to accept > > 2160p medias. > > Can you point t

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: parse sdtp atom and set the pkt disposable flag accordingly

On 27/09/2019 15:37, Matthieu Bouron wrote: > Allows the creation of the sdtp atom while remuxing MP4 to MP4. This > atom is required by Apple devices (iPhone, Apple TV) in order to accept > 2160p medias. Can you point to a document about this (for informational purposes)? Is this valid for both

Re: [FFmpeg-devel] [PATCH 2/2] fate: update references after mov sdtp parsing change

Am Fr., 27. Sept. 2019 um 16:45 Uhr schrieb Matthieu Bouron : > > --- > tests/ref/fate/hapqa-extract-snappy1-to-hapalphaonly | 2 +- > tests/ref/fate/hapqa-extract-snappy1-to-hapq | 2 +- > tests/ref/fate/hapqa-extract-snappy16-to-hapalphaonly | 2 +- > tests/ref/fate/hapqa-extract-snapp

[FFmpeg-devel] [PATCH 2/2] fate: update references after mov sdtp parsing change

--- tests/ref/fate/hapqa-extract-snappy1-to-hapalphaonly | 2 +- tests/ref/fate/hapqa-extract-snappy1-to-hapq | 2 +- tests/ref/fate/hapqa-extract-snappy16-to-hapalphaonly | 2 +- tests/ref/fate/hapqa-extract-snappy16-to-hapq | 2 +- 4 files changed, 4 insertions(+), 4 deletions(

[FFmpeg-devel] [PATCH 1/2] avformat/mov: parse sdtp atom and set the pkt disposable flag accordingly

Allows the creation of the sdtp atom while remuxing MP4 to MP4. This atom is required by Apple devices (iPhone, Apple TV) in order to accept 2160p medias. --- libavformat/isom.h | 2 ++ libavformat/mov.c | 41 + 2 files changed, 43 insertions(+) diff --gi

Re: [FFmpeg-devel] [PATCH v6] doc/filters: add 4x4 layout example for xstack filter

On 9/27/19, Limin Wang wrote: > On Thu, Sep 26, 2019 at 09:50:16PM +0530, Gyan wrote: >> >> >> On 26-09-2019 08:27 PM, lance.lmw...@gmail.com wrote: >> >From: Limin Wang >> > >> >Reviewed-by: Gyan >> >Signed-off-by: Limin Wang >> >--- >> > doc/filters.texi | 55 >> > +++

Re: [FFmpeg-devel] [PATCH v6] doc/filters: add 4x4 layout example for xstack filter

On Thu, Sep 26, 2019 at 09:50:16PM +0530, Gyan wrote: > > > On 26-09-2019 08:27 PM, lance.lmw...@gmail.com wrote: > >From: Limin Wang > > > >Reviewed-by: Gyan > >Signed-off-by: Limin Wang > >--- > > doc/filters.texi | 55 > > --- > > 1 file

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_framerate: limit the scene level max range

ping, please help push it or comments for further changes. On Tue, Sep 24, 2019 at 06:18:07PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Reviewed-by: Paul B Mahol > Signed-off-by: Limin Wang > --- > libavfilter/vf_framerate.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [FFmpeg-devel] [PATCH V1] lavc/mpeg4audio: add chan_config check to avoid indeterminate channels

On 9/21/2019 8:29 AM, Jun Zhao wrote: > From: Jun Zhao > > add chan_config check to avoid indeterminate channels. > > Signed-off-by: Jun Zhao > --- > libavcodec/mpeg4audio.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/libavcodec/mpeg4audio.c b/libavcodec/m

Re: [FFmpeg-devel] [PATCH 3/3] avformat: use avpriv_mpeg4audio_get_config2()

On 9/23/2019 11:24 PM, myp...@gmail.com wrote: > On Sun, Sep 22, 2019 at 7:28 AM James Almer wrote: >> >> Signed-off-by: James Almer >> --- >> libavformat/adtsenc.c | 2 +- >> libavformat/isom.c| 4 ++-- >> libavformat/latmenc.c | 2 +- >> libavformat/matroskaenc.c | 3 +-- >> 4

Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format a2r10g10b10/a2b10g10r10

On 9/27/19, Carl Eugen Hoyos wrote: > Am Fr., 27. Sept. 2019 um 11:02 Uhr schrieb Sun, Xinpeng > : > >> > > Add two 10 bit RGBA pixel format for hardware color space conversion >> > > support in VAAPI and QSV: >> > > >> > > 2:10:10:10 10 bit: A2R10G10B10 >> > > 2:10:10:10 10 bit: A2B10G10R10 >> >

Re: [FFmpeg-devel] [PATCH] lavc/dnxhddec: do not warn if CID == 1271 && CLF == 0 && CLV > 0

Am Fr., 27. Sept. 2019 um 09:59 Uhr schrieb Michael Bradshaw : > > The original code requires CID to be 1256 or 1270 if CLV or CLF are set. > This is unnecessarily restrictive. If CLF is 1, then CID must be 1256 or > 1270. But if CLF is 0, then CID may be different. If CLV is 1 or 2, then > CID mus

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

Am Fr., 27. Sept. 2019 um 14:15 Uhr schrieb Timo Rothenpieler : > > On 27/09/2019 12:28, Roman Arzumanyan wrote: > >> First, this needs SDK Version Guards > > Thanks, I've missed that. Added to patch. > > >> Second, in what way is this different from the existing global > >> option(avctx->refs), w

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

On 27/09/2019 12:28, Roman Arzumanyan wrote: First, this needs SDK Version Guards Thanks, I've missed that. Added to patch. Second, in what way is this different from the existing global option(avctx->refs), which nvenc.c already uses to set It's slightly different from existing global opti

Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format a2r10g10b10/a2b10g10r10

Am Fr., 27. Sept. 2019 um 11:02 Uhr schrieb Sun, Xinpeng : > > > Add two 10 bit RGBA pixel format for hardware color space conversion > > > support in VAAPI and QSV: > > > > > > 2:10:10:10 10 bit: A2R10G10B10 > > > 2:10:10:10 10 bit: A2B10G10R10 > > > > Without more explanation, this patch is not

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

> First, this needs SDK Version Guards Thanks, I've missed that. Added to patch. > Second, in what way is this different from the existing global > option(avctx->refs), which nvenc.c already uses to set It's slightly different from existing global option (gives more fine-grain control): "nb_ref_

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

On 27/09/2019 11:04, Roman Arzumanyan wrote: Hello, This patch adds multiple reference frames support (part of Video Codec SDK 9.1). It adds "nb_ref_frames" CLI option to set number of reference frames. Possible values: * auto - let encoder decide (default value). * [0;7] - set value

[FFmpeg-devel] [PATCH] doc/examples/muxing: fix underflow in duration of encoded streams

Now they are exactly 10 seconds long. Fixes #5684. Signed-off-by: Paul B Mahol --- doc/examples/muxing.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/examples/muxing.c b/doc/examples/muxing.c index 08da98e574..9af9aae483 100644 --- a/doc/examples/muxing.c +++ b/do

[FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

Hello, This patch adds multiple reference frames support (part of Video Codec SDK 9.1). It adds "nb_ref_frames" CLI option to set number of reference frames. Possible values: * auto - let encoder decide (default value). * [0;7] - set value by hand. 0 is equal to auto. Usage example: ffm

Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format a2r10g10b10/a2b10g10r10

> -Original Message- > From: ffmpeg-devel On Behalf Of Carl > Eugen Hoyos > Sent: Wednesday, September 25, 2019 4:53 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format > a2r10g10b10/a2b10g10r10 > > Am Mi., 2

Re: [FFmpeg-devel] [PATCH v4] swscale/swscale: cosmetics

On Thu, Sep 26, 2019 at 11:44:59PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libswscale/swscale.c | 7 --- > 1 file changed, 7 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_scale: cosmetics

On Thu, Sep 26, 2019 at 11:36:54PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_scale.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B14

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: -timelimit is in user time

On Thu, Sep 26, 2019 at 10:27:57AM -0800, Lou Logan wrote: > Signed-off-by: Lou Logan > --- > Some users were expecting real/wall-clock time. > > doc/ffmpeg.texi | 2 +- > fftools/ffmpeg_opt.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) LGTM assuming noone has better wording

[FFmpeg-devel] [PATCH] lavc/dnxhddec: do not warn if CID == 1271 && CLF == 0 && CLV > 0

The original code requires CID to be 1256 or 1270 if CLV or CLF are set. This is unnecessarily restrictive. If CLF is 1, then CID must be 1256 or 1270. But if CLF is 0, then CID may be different. If CLV is 1 or 2, then CID must be in the range 1270-1274 (inclusive). Thus, the original code would w