Am Fr., 27. Sept. 2019 um 14:15 Uhr schrieb Timo Rothenpieler <t...@rothenpieler.org>: > > On 27/09/2019 12:28, Roman Arzumanyan wrote: > >> First, this needs SDK Version Guards > > Thanks, I've missed that. Added to patch. > > >> Second, in what way is this different from the existing global > >> option(avctx->refs), which nvenc.c already uses to set > > It's slightly different from existing global option (gives more fine-grain > > control): > > "nb_ref_frames" effectively specifies maximum allowed number of reference > > frames in L0 and L1 reference lists for every P & B frame; > > "avctx->refs" effectively specifies DPB size; > > I feel like the new fields match much better with the -refs option. As > in, avctx->refs sets this, and a dedicated option sets the maximum DPB size. > But now it's too late and changing it would be an API break. So a new > option is what it's going to be.
Please break it (with some compatibility code if necessary / useful)! Having different options doing the same thing makes user's lives infinitely more difficult. Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
