[FFmpeg-devel] [PATCH] lavc/qsvdec: fix the regression on linux for init_hw_device

2019-09-02 Thread Linjie Fu
Fixed the regression mentioned in #7030 since commit: b0cd14fb1dab4b044f7fe6b53ac635409849de77 which breaks the decode pipeline with " -init_hw_device qsv:hw" on Linux. hw_device_match_by_codec(ist->dec) can't get the valid dev for QSV thus can't call ff_qsv_init_session_device. (called ff_qsv_ini

Re: [FFmpeg-devel] Blocking vs non-blocking modes in protocols

2019-09-02 Thread Andriy Gelman
Nicolas, thank you for clarifying On Mon, 02. Sep 17:21, Nicolas George wrote: > Andriy Gelman (12019-09-01): > > Below are my notes on blocking and non-blocking modes in protocols. Proposed > > changes that I'd like to make are at the end. > > > > Thanks, > > Andriy > > > > > > ---General

Re: [FFmpeg-devel] [PATCH 1/2] lavu/pixfmt: add AYUV pixel format

2019-09-02 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Sunday, September 1, 2019 01:57 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/pixfmt: add AYUV pixe

Re: [FFmpeg-devel] [PATCH v1 1/2] avcodec/videotoolboxenc: add H264 Extended profile and level

2019-09-02 Thread Limin Wang
On Mon, Sep 02, 2019 at 09:21:11PM -0400, Rick Kern wrote: > On Mon, Sep 2, 2019 at 9:53 AM Limin Wang wrote: > > > On Tue, Aug 27, 2019 at 10:56:42AM -0400, Richard Kern wrote: > > > > > I’ll look at it this weekend. > > ping > > > > > It shows error kVTParameterErr when using the software encod

[FFmpeg-devel] [PATCH] avformat/hls: mark the playlist is broken when the reload times is over

2019-09-02 Thread Steven Liu
when the playlist is master playlist, there have many playlist. the workflow should continue if one of the playlist is broken. Signed-off-by: Steven Liu --- libavformat/hls.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3

[FFmpeg-devel] [PATCH] avformat/hls: continue to play enabled playlist when have failed playlist

2019-09-02 Thread Steven Liu
fix ticket: 7811 Signed-off-by: Steven Liu --- libavformat/hls.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 61b6759ef5..3aee7a19ae 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -116,6 +116,7 @@

Re: [FFmpeg-devel] [PATCH v1 1/2] avcodec/videotoolboxenc: add H264 Extended profile and level

2019-09-02 Thread Rick Kern
On Mon, Sep 2, 2019 at 9:53 AM Limin Wang wrote: > On Tue, Aug 27, 2019 at 10:56:42AM -0400, Richard Kern wrote: > > > I’ll look at it this weekend. > ping > > It shows error kVTParameterErr when using the software encoder: Error setting profile/level property: -12902 I used the following comma

[FFmpeg-devel] [PATCH 05/25] avcodec/v4l2_buffers: teach ff_v4l2_buffer_avframe_to_buf about contiguous planar formats

2019-09-02 Thread Aman Gupta
From: Aman Gupta This fixes h264_v4l2m2m encoding on the Raspberry Pi Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 61 ++- 1 file changed, 53 insertions(+), 8 deletions(-) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index

[FFmpeg-devel] [PATCH 06/25] avcodec/v4l2_buffers: Add handling for NV21 and YUV420P

2019-09-02 Thread Aman Gupta
From: Dave Stevenson The single planar support was for NV12 only. Add NV21 and YUV420P support. Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index 17228fe36d..e7234d3ca

[FFmpeg-devel] [PATCH 10/25] avcodec/v4l2_m2m_dec: set pkt_dts on decoded frames to NOPTS

2019-09-02 Thread Aman Gupta
From: Aman Gupta Without this ffmpeg will attempt to copy the dts from the most recently enqueued packet into the most recently dequeued frame, which does not account for the buffering inside v4l2 and is not accurate. Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 1 + libavcodec/v4

[FFmpeg-devel] [PATCH 01/25] avcodec/v4l2_context: ensure v4l2_dequeue does not hang in poll() when no buffers are pending

2019-09-02 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_context.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index 6924760840..070988b4c3 100644 --- a/libavcodec/v4l2_context.c +++ b/libavcodec/v4l2_co

[FFmpeg-devel] [PATCH 03/25] avcodec/v4l2_m2m: fix av_pix_fmt changing when multiple /dev/video* devices are probed

2019-09-02 Thread Aman Gupta
From: Aman Gupta On the RPI, three different /dev/video devices exist (decoder, scaler, encoder). When probing the devices in order, the originally requested pix fmt would be mutated causing the wrong one to be chosen when a matching device was finally found. Signed-off-by: Aman Gupta --- lib

[FFmpeg-devel] [PATCH 02/25] avcodec/v4l2_m2m: disable info logging during device probe

2019-09-02 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_m2m.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c index 48104d01d2..0cf5db284a 100644 --- a/libavcodec/v4l2_m2m.c +++ b/libavcodec/v4l2_m2m.c @@ -60

[FFmpeg-devel] [PATCH 07/25] avcodec/v4l2_m2m: decouple v4l2_m2m helpers from AVCodecContext

2019-09-02 Thread Aman Gupta
From: Aman Gupta This will allow re-use of the m2m backend with AVFilterContext Signed-off-by: Aman Gupta --- libavcodec/v4l2_context.c | 9 +++ libavcodec/v4l2_m2m.c | 50 +++ libavcodec/v4l2_m2m.h | 18 +++--- libavcodec/v4l2_m2m_dec.c

[FFmpeg-devel] [PATCH 04/25] avcodec/v4l2_m2m_enc: add support for -force_key_frames

2019-09-02 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_m2m_enc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c index 27bb254fc1..a0d5bcf760 100644 --- a/libavcodec/v4l2_m2m_enc.c +++ b/libavcodec/v4l2_m2m_enc.c @@ -245,6 +24

[FFmpeg-devel] [PATCH 09/25] avcodec/v4l2_m2m_enc: fix indentation and add M2MENC_CLASS macro

2019-09-02 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_m2m_enc.c | 44 --- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c index 8014e442a8..4849bc26c5 100644 --- a/libavcodec/v4l2_

[FFmpeg-devel] [PATCH 00/25] V4L2 support for DRM_PRIME

2019-09-02 Thread Aman Gupta
From: Aman Gupta This patchset enables a zero-copy hardware accelerated decode+scale+encode pipeline on the RPI4 via V4L2. It also includes various patches submitted to ffmpeg-devel in the past and from LibreELEC's ffmpeg fork. The V4L2 decoders can either output software pixel formats, or be us

[FFmpeg-devel] [PATCH 20/25] avfilter/vf_scale_v4l2m2m: add V4L2 M2M scaler

2019-09-02 Thread Aman Gupta
From: Aman Gupta works on Raspberry Pi using /dev/video12 wrapper for OMX.broadcom.isp Signed-off-by: Aman Gupta --- configure | 1 + libavcodec/v4l2_buffers.c | 12 +- libavcodec/v4l2_m2m.h | 4 + libavfilter/Makefile | 1 + libavfilter/allf

[FFmpeg-devel] [PATCH 23/25] avcodec/v4l2_buffers: use correct timebase for encoder/decoder/filter

2019-09-02 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index 389b5dea8d..d8cec06cb3 100644 --- a/libavcodec/v4l2_buffers.c +++

[FFmpeg-devel] [PATCH 25/25] hwcontext_drm: do not require drm device

2019-09-02 Thread Aman Gupta
From: Jonas Karlman This allows the cli to create a dummy drm hwcontext that can be shared between the v4l2 decoder/scaler/encoder. This is especially useful on older RPI3 where /dev/dri devices are not available in the default configuration. Signed-off-by: Jonas Karlman Signed-off-by: Aman Gu

[FFmpeg-devel] [PATCH 22/25] avcodec/v4l2_context: set frame SAR using VIDIOC_CROPCAP

2019-09-02 Thread Aman Gupta
From: Maxime Jourdan Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 3 ++- libavcodec/v4l2_context.c | 20 libavcodec/v4l2_context.h | 1 + 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c inde

[FFmpeg-devel] [PATCH 24/25] avcodec/v4l2_buffers: extract v4l2_timebase constant

2019-09-02 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index d8cec06cb3..8424fbcd3e 100644 --- a/libavcodec/v4l2_buffers.c +++ b/libavcodec/v4l2_buffers.

[FFmpeg-devel] [PATCH 21/25] avcodec/v4l2m2m: clean up buffer options and pick sane defaults

2019-09-02 Thread Aman Gupta
From: Aman Gupta Previously the default values for output/capture buffers were quite high, causing a lot of memory usage on devices with limited resources. On a default RPI3 installation, it is easy to run out of kernel CMA memory without additional kernel boot flags. Similar patches are being u

[FFmpeg-devel] [PATCH 15/25] avcodec/v4l2_m2m: add support for AV_PIX_FMT_DRM_PRIME

2019-09-02 Thread Aman Gupta
From: Aman Gupta Based on patch originally developed by Lukas Rusak This allows for a zero-copy output by exporting the v4l2 buffer then wrapping that buffer in the AVDRMFrameDescriptor like it is done in rkmpp. This has been in use for quite some time with great success on many

[FFmpeg-devel] [PATCH 18/25] avcodec/v4l2_context: expose timeout for dequeue_frame

2019-09-02 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_context.c | 6 +++--- libavcodec/v4l2_context.h | 3 ++- libavcodec/v4l2_m2m_dec.c | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index 32246cf564..26e062

[FFmpeg-devel] [PATCH 19/25] avcodec/v4l2_m2m_dec: fix dropped packets while decoding

2019-09-02 Thread Aman Gupta
From: Maxime Jourdan * FFmpeg retrieves a packet from the bitstream * It attempts to get an input buffer (from its own list or by dequeuing one from the driver) * If no input buffer is found, the bitstream packet is dropped instead of scheduled for trying again later It's an issue that showed

[FFmpeg-devel] [PATCH 13/25] avcodec/v4l2_buffers: split out v4l2_buf_increase_ref helper

2019-09-02 Thread Aman Gupta
From: Lukas Rusak Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index 721e01420b..f90c50db80 100644 --- a/libavcodec/v4l2_bu

[FFmpeg-devel] [PATCH 14/25] avcodec/v4l2_buffers: read height/width from the proper context

2019-09-02 Thread Aman Gupta
From: Aman Gupta Frames are generally dequeued into capture buffers, so using the output properties here was incorrect. It happened to work fine for decoding, since the output/capture buffers have the same dimensions. For the v4l2 scaler, the dimensions can be different between output and captur

[FFmpeg-devel] [PATCH 16/25] avcodec/v4l2_m2m_dec: add support for AV_PIX_FMT_DRM_PRIME

2019-09-02 Thread Aman Gupta
From: Aman Gupta Based on patchset submitted to ffmpeg-devel by Lukas Rusak Signed-off-by: Aman Gupta --- libavcodec/v4l2_m2m_dec.c | 85 --- 1 file changed, 80 insertions(+), 5 deletions(-) diff --git a/libavcodec/v4l2_m2m_dec.c b/libavcodec/v4l2_m2m_dec.

[FFmpeg-devel] [PATCH 17/25] avcodec/v4l2_m2m_enc: add support for AV_PIX_FMT_DRM_PRIME

2019-09-02 Thread Aman Gupta
From: Aman Gupta --- libavcodec/v4l2_m2m_enc.c | 20 1 file changed, 20 insertions(+) diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c index 4849bc26c5..4ccfe77322 100644 --- a/libavcodec/v4l2_m2m_enc.c +++ b/libavcodec/v4l2_m2m_enc.c @@ -302,11 +302,27 @@

[FFmpeg-devel] [PATCH 11/25] avcodec/v4l2_buffers: split out AVFrame generation into helper method

2019-09-02 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 76 +++ 1 file changed, 45 insertions(+), 31 deletions(-) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index 4982fc564e..784ea94d4c 100644 --- a/libavcodec/v4l2_

[FFmpeg-devel] [PATCH 12/25] avcodec/v4l2_buffers: split out V4L2Buffer generation into helper method

2019-09-02 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index 784ea94d4c..721e01420b 100644 --- a/libavcodec/v4l2_buffers.c +++ b/l

[FFmpeg-devel] [PATCH 08/25] avcodec/v4l2_m2m_dec: fix indentation and add M2MDEC_CLASS macro

2019-09-02 Thread Aman Gupta
From: Lukas Rusak This just makes the M2MDEC_CLASS similar to how it is done in rkmpp. It looks clean and has proper indentation --- libavcodec/v4l2_m2m_dec.c | 45 --- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/libavcodec/v4l2_m2m_dec.c b

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/apedec: Check max_samples

2019-09-02 Thread James Almer
On 9/2/2019 9:14 PM, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 16627/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5638059583864832 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermay

[FFmpeg-devel] [PATCH 2/5] avcodec/apedec: Fix several integer overflows in predictor_update_filter() and do_apply_filter()

2019-09-02 Thread Michael Niedermayer
Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself Fixes: signed integer overflow: -14527961 - 2147483425 cannot be represented in type 'int' Fixes: 16380/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5645957

[FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

2019-09-02 Thread Michael Niedermayer
TODO: APIChanges, bump version Signed-off-by: Michael Niedermayer --- libavcodec/avcodec.h | 8 libavcodec/options_table.h | 1 + tests/ref/fate/api-mjpeg-codec-param | 2 ++ tests/ref/fate/api-png-codec-param | 2 ++ 4 files changed, 13 insertions(+) diff -

[FFmpeg-devel] [PATCH 1/5] avcodec/apedec: Fix 32bit int overflow in do_apply_filter()

2019-09-02 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147480546 + 4096 cannot be represented in type 'int' Fixes: 16280/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5123442566758400 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

[FFmpeg-devel] [PATCH 4/5] tools/target_dec_fuzzer: Set max_samples

2019-09-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 3a19efd031..1e26ac738f 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -90,6 +90,8 @@ cons

[FFmpeg-devel] [PATCH 5/5] avcodec/apedec: Check max_samples

2019-09-02 Thread Michael Niedermayer
Fixes: OOM Fixes: 16627/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5638059583864832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/apedec.c | 3 +++ 1 file changed, 3 insert

[FFmpeg-devel] [PATCH] avfilter/vf_delogo: add auto set the area inside of the frame

2019-09-02 Thread Steven Liu
when the area outside of the frame, then use expr should give user warning message and auto set to the area inside of the frame. Signed-off-by: Steven Liu --- libavfilter/vf_delogo.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delo

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_delogo: support expr in delogo filter

2019-09-02 Thread Steven Liu
> 在 2019年9月2日,21:43,Limin Wang 写道: > > On Wed, Aug 28, 2019 at 05:01:13PM +0200, Michael Niedermayer wrote: >> On Wed, Aug 28, 2019 at 05:39:32AM +0800, Steven Liu wrote: >>> Signed-off-by: Steven Liu >>> --- >>> libavfilter/vf_delogo.c | 83 >>> ++-

Re: [FFmpeg-devel] [PATCH v6] Add ZeroMQ as protocol option

2019-09-02 Thread Marton Balint
On Sat, 31 Aug 2019, Andriy Gelman wrote: Changes in v6: - Changed minimum required libzmq version from 4.3.1 to 4.2.1 - Removed ff_ prefix from static functions - Use zmq_ctx_term function instead of zmq_ctx_destroy (since zmq_ctx_destroy is deprecated) Thanks, applied. Rega

Re: [FFmpeg-devel] [PATCH 1/2] avformat/avformat: Introduced `AVInputFormat.read_timestamp2` to fix keyframe seeking for formats that rely on `read_timestamp` for seeking

2019-09-02 Thread Darren Mo
Yup! I just wanted to do the migration in phases rather than all at once so that I can do one demuxer at a time while gathering feedback. At the end of the migration, I’ll rename `read_timestamp2` to `read_timestamp`. > On Sep 2, 2019, at 1:07 PM, James Almer wrote: > > AVInputFormat.read_time

Re: [FFmpeg-devel] [PATCH 1/2] avformat/avformat: Introduced `AVInputFormat.read_timestamp2` to fix keyframe seeking for formats that rely on `read_timestamp` for seeking

2019-09-02 Thread James Almer
On 8/31/2019 7:10 AM, fumoboy...@me.com wrote: > From: fumoboy007 > > If the user omits `AVSEEK_FLAG_ANY`, then the result of the seek should be a > keyframe. `ff_gen_search` did not respect that contract because it had no > good way to determine whether a timestamp returned by `read_timestamp`

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: fix flushing of audio packets

2019-09-02 Thread Marton Balint
On Wed, 28 Aug 2019, Marton Balint wrote: On Wed, 28 Aug 2019, Andreas Håkon wrote: Hi Marton, ‐‐‐ Original Message ‐‐‐ On Tuesday, 27 de August de 2019 23:33, Marton Balint wrote: > Please, note that the main problem at time with the mpegts muxer is that all PES packets a

Re: [FFmpeg-devel] [PATCH 1/2] avformat/avformat: Introduced `AVInputFormat.read_timestamp2` to fix keyframe seeking for formats that rely on `read_timestamp` for seeking

2019-09-02 Thread Darren Mo
That’s true. However, I think your approach would produce incorrect results when `AVSEEK_FLAG_BACKWARD` is used. The bisection would find the frame just before the target time and then we would search for the next keyframe, which would be after the target time. Instead, we want to return the ke

Re: [FFmpeg-devel] [PATCH 1/2] docs/formats: fix max_interleave_delta default

2019-09-02 Thread Marton Balint
On Sat, 31 Aug 2019, Gyan wrote: On 31-08-2019 09:55 PM, Marton Balint wrote: On Tue, 27 Aug 2019, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/formats.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/formats.texi b/doc/formats.texi index 729c77b

Re: [FFmpeg-devel] Blocking vs non-blocking modes in protocols

2019-09-02 Thread Nicolas George
So, let us survey the state of blocking and non-blocking mode at this date in FFmpeg. First, why and how. This is a question of how the program is designed. There are two big classes of design: output-driven and input-driven. An output-driven design decides it wants to produce some output and rea

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/ralf: fix undefined shift in extend_code()

2019-09-02 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 01:28:37AM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -3 > Fixes: > 16147/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5658392722407424 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/ralf: fix undefined shift

2019-09-02 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 01:28:36AM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -2 > Fixes: > 16145/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5146671058518016 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2019-09-02 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 11:04:20AM +0200, Paul B Mahol wrote: > On Sun, Aug 18, 2019 at 10:25 AM Michael Niedermayer > wrote: > > > On Sun, Aug 18, 2019 at 09:21:25AM +0200, Paul B Mahol wrote: > > > NAK > > > > What problem do you see in this patch ? > > > > What change do you suggest ? > > or w

Re: [FFmpeg-devel] [PATCH] lavc/v4l2_m2m: don't close the file descriptor we don't own

2019-09-02 Thread Pavel Koshevoy
On Mon, Sep 2, 2019 at 10:40 AM Aman Gupta wrote: > > > > On Mon, Sep 2, 2019 at 12:27 AM Pavel Koshevoy wrote: >> >> ff_v4l2_m2m_create_context initialized V4L2m2mContext.fd to 0 >> which is a valid file descriptor value. Next ff_v4l2_m2m_codec_init >> failed and v4l2_m2m_destroy_context closed

Re: [FFmpeg-devel] [PATCH v2] configure: Update libmysofa check with a new symbol.

2019-09-02 Thread Paul B Mahol
On 9/2/19, Andrey Semashev wrote: > Ping? I would like this to make it into 4.2 as well. > Applied to master. > On Wed, Aug 28, 2019 at 11:16 PM Andrey Semashev > wrote: >> >> The current code in libavfilter/af_sofalizer.c requires >> mysofa_neighborhood_init_withstepdefine function, which only

Re: [FFmpeg-devel] [PATCH v2] configure: Update libmysofa check with a new symbol.

2019-09-02 Thread Andrey Semashev
Ping? I would like this to make it into 4.2 as well. On Wed, Aug 28, 2019 at 11:16 PM Andrey Semashev wrote: > > The current code in libavfilter/af_sofalizer.c requires > mysofa_neighborhood_init_withstepdefine function, which only appeared > in libmysofa 0.7. Use this function in configure scrip

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: Optimize has_trns code

2019-09-02 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 10:29:02AM +0200, Michael Niedermayer wrote: > add inner loop specialisations for 2 bpp and 4 bpp > These are all cases for which i found testsamples. > > 30M cycles -> 5M cycles > > Testcase: fate-rgbapng-4816 > Testcase: > 16097/clusterfuzz-testcase-minimized-ffmpeg_AV_

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/apedec: Fix integer overflow in filter_fast_3320()

2019-09-02 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 01:28:40AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1094994793 * 2 cannot be represented in type > 'int' > Fixes: > 16139/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5663911036059648 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 6/6] vcodec/apedec: Fix integer overflow in filter_3800()

2019-09-02 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 01:28:41AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2021654528 + 2032575680 cannot be represented > in type 'int' > Fixes: > 16270/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5732438816325632 > > Found-by: continuous fuzzing pro

Re: [FFmpeg-devel] [PATCH] lavc/v4l2_m2m: don't close the file descriptor we don't own

2019-09-02 Thread Aman Gupta
On Mon, Sep 2, 2019 at 12:27 AM Pavel Koshevoy wrote: > ff_v4l2_m2m_create_context initialized V4L2m2mContext.fd to 0 > which is a valid file descriptor value. Next ff_v4l2_m2m_codec_init > failed and v4l2_m2m_destroy_context closed file descriptor 0 even > though it didn't belong to V4L2m2mConte

[FFmpeg-devel] [REFUND-REQUEST] Packaging and Shipping cost AMD GPU

2019-09-02 Thread Timo Rothenpieler
I have sent one of my spare AMD GPUs to Rodger Combs for work on AMF and AMF/Vulkan integration. Since there is personal information on the receipts, I won't post them here, but can send them to the responsible person on request easily. Packaging: PackSet M: 1.99€ Bubble-Wrap "Protection Kit"

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/h264: Fix poc_lsb in open gop context

2019-09-02 Thread Kieran Kunhya
On Mon, 2 Sep 2019 at 09:01, Gaullier Nicolas wrote: > >Envoyé : mardi 23 juillet 2019 14:09 > >When no IDR nor mmco_reset is found, prev_poc_lsb is undefined and shall > not be assumed to be zero > >--- > > libavcodec/h264_parse.c | 2 ++ > > libavcodec/h264dec.c| 2 +- > > 2 files changed, 3

[FFmpeg-devel] FFmpeg 4.2.1

2019-09-02 Thread Michael Niedermayer
Hi all Its almost a month since 4.2, so its time to make 4.2.1, and i intend to do that in the next days. If you want some bugfix in it, dont forget to backport it. Thanks -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failure, be that a per

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/bgmc: Check input space in ff_bgmc_decode_init()

2019-09-02 Thread Michael Niedermayer
On Mon, Sep 02, 2019 at 09:47:04AM +0200, Thilo Borgmann wrote: > Am 01.09.19 um 23:10 schrieb Michael Niedermayer: > > Fixes: Infinite loop > > Fixes: > > 16608/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5636229827133440 > > > > Found-by: continuous fuzzing process > > https:/

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vp3: Check for end of input in 2 places of vp4_unpack_macroblocks()

2019-09-02 Thread Michael Niedermayer
On Mon, Sep 02, 2019 at 06:33:43PM +1000, Peter Ross wrote: > On Sun, Sep 01, 2019 at 11:10:25PM +0200, Michael Niedermayer wrote: > > Fixes: Timeout (82sec -> 1sec) > > Fixes: > > 16411/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP3_fuzzer-5166958151991296 > > > > Found-by: continuous fuz

Re: [FFmpeg-devel] [PATCH] ffmpeg: switch to avformat_seek_file for stream_loop

2019-09-02 Thread Michael Niedermayer
On Sat, Aug 31, 2019 at 08:28:51PM +0530, Gyan wrote: > A user observed that stream_loop didn't work with very short FLV files. > seek_to_start in ffmpeg.c calls av_seek_frame with no flags; FLV seek only > works with RTMP protocol so lavf falls back on seek_frame_generic which > searches forward,

Re: [FFmpeg-devel] Blocking vs non-blocking modes in protocols

2019-09-02 Thread Nicolas George
Andriy Gelman (12019-09-01): > Below are my notes on blocking and non-blocking modes in protocols. Proposed > changes that I'd like to make are at the end. > > Thanks, > Andriy > > > ---General notes-- > -blocking mode- > - transfer_function deals with polling and timeout > - block ins

Re: [FFmpeg-devel] [PATCH v3] Allow 'concat' filter to support inputs with different frame rates

2019-09-02 Thread Nicolas George
Calvin Walton (12019-08-30): > Right now, the concat filter does not set the frame_rate value on any of > the out links. As a result, the default ffmpeg behaviour kicks in - to > copy the framerate from the first input to the outputs. > > If a later input is higher framerate, this results in dropp

[FFmpeg-devel] [PATCH 2/2] avcodec/h264: fix draw_horiz_band with slice threads

2019-09-02 Thread James Darnley
From: Kieran Kunhya --- libavcodec/h264_slice.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index 5ceee107a0..fe2aa01ceb 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@

Re: [FFmpeg-devel] [PATCH] lavc/v4l2_m2m: don't close the file descriptor we don't own

2019-09-02 Thread Nicolas George
Pavel Koshevoy (12019-09-02): > ff_v4l2_m2m_create_context initialized V4L2m2mContext.fd to 0 > which is a valid file descriptor value. Next ff_v4l2_m2m_codec_init > failed and v4l2_m2m_destroy_context closed file descriptor 0 even > though it didn't belong to V4L2m2mContext. > --- > libavcodec/v4

[FFmpeg-devel] [PATCH 1/2] avcodec/h264: enable draw_horiz_band

2019-09-02 Thread James Darnley
--- libavcodec/h264dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 8d1bd16a8e..b9f304936c 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -1056,7 +1056,7 @@ AVCodec ff_h264_decoder = { .init

[FFmpeg-devel] [PATCH 0/2] WIP: h264, slice threads, draw_horiz_band

2019-09-02 Thread James Darnley
Trying a combination of sliced threads, chunk decoding, and draw_horiz_band we found that it didn't work with the current master code. Modifying the api-h264-slice fate test showed obvious errors with grey and green blocks and more subtle ones that looked like misplaced macroblocks. Kieran identi

Re: [FFmpeg-devel] [PATCH 1/2] avformat/avformat: Introduced `AVInputFormat.read_timestamp2` to fix keyframe seeking for formats that rely on `read_timestamp` for seeking

2019-09-02 Thread Michael Niedermayer
On Sat, Aug 31, 2019 at 03:10:38AM -0700, fumoboy...@me.com wrote: > From: fumoboy007 > > If the user omits `AVSEEK_FLAG_ANY`, then the result of the seek should be a > keyframe. `ff_gen_search` did not respect that contract because it had no > good way to determine whether a timestamp returned

Re: [FFmpeg-devel] [PATCH v1 1/2] avcodec/videotoolboxenc: add H264 Extended profile and level

2019-09-02 Thread Limin Wang
On Tue, Aug 27, 2019 at 10:56:42AM -0400, Richard Kern wrote: > I’ll look at it this weekend. ping > > > On Aug 27, 2019, at 10:40 AM, Limin Wang wrote: > > > > > > ping the patchset. > > > >> On Tue, Aug 20, 2019 at 07:04:29PM +0800, lance.lmw...@gmail.com wrote: > >> From: Limin Wang > >

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_scale: split the scale_frame function from filter_frame for activate function support

2019-09-02 Thread Limin Wang
ping, although my frame thread code can't pass fate testing and can't submit for review. The change is independent for that. Thanks, Limin On Sat, Jul 27, 2019 at 08:18:16PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_scale.c |

Re: [FFmpeg-devel] [PATCH v2] libavformat/avio: Fix for the unexpected file close which will cause fd 0 is closed

2019-09-02 Thread Limin Wang
ping, have test with the example code. On Sat, Jul 13, 2019 at 10:22:57PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > By the code, is_connected is used to check file open or not, so after open_dir > is done, we should not set is_connected to 1, it'll cause the function > ffurl_

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_delogo: support expr in delogo filter

2019-09-02 Thread Limin Wang
On Wed, Aug 28, 2019 at 05:01:13PM +0200, Michael Niedermayer wrote: > On Wed, Aug 28, 2019 at 05:39:32AM +0800, Steven Liu wrote: > > Signed-off-by: Steven Liu > > --- > > libavfilter/vf_delogo.c | 83 > > ++--- > > 1 file changed, 79 insertions(+), 4

[FFmpeg-devel] Paid for, short term contract work.

2019-09-02 Thread Warwick New
Hey, I'm really sorry if this work isn't relevant to any of you guys. But we're looking for a paid for, short term contractor to help us make our web streaming stack more stable. We currently use Janus as a conferencing technology and are trying to leverage Wowza's one to many streaming potential

Re: [FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-09-02 Thread Andrey Semashev
Ping? On 2019-08-28 18:32, Andrey Semashev wrote: Because lavf_container is sometimes called with only 2 arguments, fate tests produce bash errors like this: tests/fate-run.sh: 299: test: =: unexpected operator This commit fixes this. --- tests/fate-run.sh | 2 +- 1 file changed, 1 inser

Re: [FFmpeg-devel] Add Timing Info to Log Lines

2019-09-02 Thread Thomas Volkert
On 02.09.19 12:26, Bodecs Bela wrote: 2019.09.02. 1:03 keltezéssel, Soft Works írta: Hi, I’m not sure whether this has been discussed, considered or disregarded before. I have some code ready for adding timestamps to the log output, similar to this: $ ffmpegd -loglevel +timing ffmpeg version

Re: [FFmpeg-devel] Add Timing Info to Log Lines

2019-09-02 Thread Bodecs Bela
2019.09.02. 1:03 keltezéssel, Soft Works írta: Hi, I’m not sure whether this has been discussed, considered or disregarded before. I have some code ready for adding timestamps to the log output, similar to this: $ ffmpegd -loglevel +timing ffmpeg version 4.2.git Copyright (c) 2000-2019 the FFm

[FFmpeg-devel] [PATCH] hlsenc: flush segments to guarantuee atomic single file hls

2019-09-02 Thread Daniel Oberhoff
Hi all, This makes sure segments published in the playlist of a single file hls recording are actually visible in the filesystem before the playlist entry. Otherwise there is a tiny race condition where a read to a piblished segment may fail. from c309a535a865be70682885aa3b3bffcede41d85c Mon

Re: [FFmpeg-devel] [PATCH/RFC] libavcodec/cinepak: Separate decoding from parsing

2019-09-02 Thread Tomas Härdin
sön 2019-09-01 klockan 23:07 +0200 skrev Carl Eugen Hoyos: > Am So., 1. Sept. 2019 um 22:58 Uhr schrieb Tomas Härdin < > tjop...@acc.umu.se>: > > > Attached patch separates parsing from decoding in the Cinepak decoder. > > It puts in some rather strict checks which are in line with how I've > > fi

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vp3: Check for end of input in 2 places of vp4_unpack_macroblocks()

2019-09-02 Thread Peter Ross
On Sun, Sep 01, 2019 at 11:10:25PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (82sec -> 1sec) > Fixes: > 16411/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP3_fuzzer-5166958151991296 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/h264: Fix poc_lsb in open gop context

2019-09-02 Thread Gaullier Nicolas
>Envoyé : mardi 23 juillet 2019 14:09 >When no IDR nor mmco_reset is found, prev_poc_lsb is undefined and shall not >be assumed to be zero >--- > libavcodec/h264_parse.c | 2 ++ > libavcodec/h264dec.c| 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) I have not received any feeback, do yo

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/bgmc: Check input space in ff_bgmc_decode_init()

2019-09-02 Thread Thilo Borgmann
Am 01.09.19 um 23:10 schrieb Michael Niedermayer: > Fixes: Infinite loop > Fixes: > 16608/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5636229827133440 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Micha

[FFmpeg-devel] [PATCH] nv-codec-headers: add functions and tidy up loader

2019-09-02 Thread Daniel Oberhoff
Hi all, We use nv-codec-headers to talk to cuda since we use ffmpeg already and nv-codec-headers makes for a nice way to talk to the cuda libs. But we need a few more functions, so we added them and would like to push those changes back upstream. They may be very useful to other users of ffmpeg

[FFmpeg-devel] [PATCH] lavc/v4l2_m2m: don't close the file descriptor we don't own

2019-09-02 Thread Pavel Koshevoy
ff_v4l2_m2m_create_context initialized V4L2m2mContext.fd to 0 which is a valid file descriptor value. Next ff_v4l2_m2m_codec_init failed and v4l2_m2m_destroy_context closed file descriptor 0 even though it didn't belong to V4L2m2mContext. --- libavcodec/v4l2_m2m.c | 1 + 1 file changed, 1 insertio