Trying a combination of sliced threads, chunk decoding, and draw_horiz_band we found that it didn't work with the current master code. Modifying the api-h264-slice fate test showed obvious errors with grey and green blocks and more subtle ones that looked like misplaced macroblocks.
Kieran identified the cause and coded this quick fix. He said that essentially the code would give a region to draw_horiz_band which could include the previous slice even if it hadn't been finished yet. This corrects that problem and lets us decode exactly. However it does cause errors decoding B-frames in chunked mode. Needs more work. James Darnley (1): avcodec/h264: enable draw_horiz_band Kieran Kunhya (1): avcodec/h264: fix draw_horiz_band with slice threads libavcodec/h264_slice.c | 29 +++++++++++++++++++++++------ libavcodec/h264dec.c | 2 +- 2 files changed, 24 insertions(+), 7 deletions(-) -- 2.22.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
