Calvin Walton (12019-08-30): > Right now, the concat filter does not set the frame_rate value on any of > the out links. As a result, the default ffmpeg behaviour kicks in - to > copy the framerate from the first input to the outputs. > > If a later input is higher framerate, this results in dropped frames; if > a later input is lower framerate it might cause judder. > > This patch checks if all of the video inputs have the same framerate, and > if not it sets the out link to use '1/0' as the frame rate, the value > meaning "unknown/vfr". > > A test is added to verify the VFR behaviour. The existing test for CFR > behaviour passes unchanged. > --- > Updated version of > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2017-March/208251.html > > Fixes the missing concat-vfr filtergraph for tests, and adds a newline > to the end of the log message. > > libavfilter/avf_concat.c | 15 ++- > tests/fate/filter-video.mak | 4 +- > tests/filtergraphs/concat-vfr | 8 ++ > tests/ref/fate/filter-concat-vfr | 224 +++++++++++++++++++++++++++++++ > 4 files changed, 249 insertions(+), 2 deletions(-) > create mode 100644 tests/filtergraphs/concat-vfr > create mode 100644 tests/ref/fate/filter-concat-vfr
Thanks for the patch, it looks ok to me and I intend to push it in a few days to let somebody comment. Please do not hesitate to remind me if I forget. Regards, -- Nicolas George
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
