Re: [FFmpeg-devel] [PATCH 2/3] avformat/avienc: add reserve_index_space option

2017-01-30 Thread Michael Niedermayer
On Mon, Jan 30, 2017 at 04:40:17PM +0100, Tobias Rapp wrote: > On 25.01.2017 22:49, Michael Niedermayer wrote: > >On Mon, Jan 23, 2017 at 11:12:13AM +0100, Tobias Rapp wrote: > >[...] > >> libavformat/avi.h |1 > >> libavformat/avienc.c| 77 > >> +

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-30 Thread Andreas Cadhalpun
On 30.01.2017 17:17, Ronald S. Bultje wrote: > On Sun, Jan 29, 2017 at 7:37 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 29.01.2017 04:46, Ronald S. Bultje wrote: >>> Hm ... So I guess I wasn't clear about this, but the reason I didn't >> reply >>> to other patches wi

[FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-01-30 Thread Chris Cunningham
Blocks are marked as key frames whenever the "reference" field is zero. This is incorrect for non-keyframe Blocks that take a refernce on a keyframe at time zero. Now using -1 to denote "no reference". Reported to chromium at http://crbug.com/497889 (contains sample) --- libavformat/matroskadec.

Re: [FFmpeg-devel] [PATCH] Allow borderless playback windows

2017-01-30 Thread Lucas Sandery
On 2017-01-31 11:28, Marton Balint wrote: On Tue, 31 Jan 2017, Lucas Sandery wrote: For a pure video tile effect, and enabling better integration of playback windows into other programs. It would improve the looks in many situations and avoid ugly hacks like this: http://stackoverflow.com/q/31

Re: [FFmpeg-devel] [PATCH 4/9] ircamdec: prevent overflow during block alignment calculation

2017-01-30 Thread Andreas Cadhalpun
On 30.01.2017 09:52, Paul B Mahol wrote: > On 1/30/17, Andreas Cadhalpun wrote: >> On 29.01.2017 02:34, Michael Niedermayer wrote: >>> On Thu, Jan 26, 2017 at 02:12:19AM +0100, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun --- libavformat/ircamdec.c | 6 ++ 1

[FFmpeg-devel] [PATCH] pgssubdec: reset rle_data_len/rle_remaining_len on allocation error

2017-01-30 Thread Andreas Cadhalpun
The code relies on their validity and otherwise can try to access a NULL object->rle pointer, causing segmentation faults. Signed-off-by: Andreas Cadhalpun --- libavcodec/pgssubdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/pgssubdec.c b/libavcodec/pgssu

Re: [FFmpeg-devel] [PATCH] Allow borderless playback windows

2017-01-30 Thread Marton Balint
On Tue, 31 Jan 2017, Lucas Sandery wrote: For a pure video tile effect, and enabling better integration of playback windows into other programs. It would improve the looks in many situations and avoid ugly hacks like this: http://stackoverflow.com/q/31465630/315024 Could you please add som

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-30 Thread Andreas Cadhalpun
On 31.01.2017 00:59, Steinar H. Gunderson wrote: > On Tue, Jan 31, 2017 at 12:49:56AM +0100, Andreas Cadhalpun wrote: >>> How can you get a negative run, which would be required for this to happen? >> Some values in ff_dc_alpha_run_vlc_le.table are negative, e.g.: >> ff_dc_alpha_run_vlc_le.table[3

[FFmpeg-devel] [PATCH] Allow borderless playback windows

2017-01-30 Thread Lucas Sandery
For a pure video tile effect, and enabling better integration of playback windows into other programs. It would improve the looks in many situations and avoid ugly hacks like this: http://stackoverflow.com/q/31465630/315024 From f1519f82373366596e4f2fee80a3e6be043daad6 Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-30 Thread Steinar H. Gunderson
On Tue, Jan 31, 2017 at 12:49:56AM +0100, Andreas Cadhalpun wrote: >> How can you get a negative run, which would be required for this to happen? > Some values in ff_dc_alpha_run_vlc_le.table are negative, e.g.: > ff_dc_alpha_run_vlc_le.table[32] = {-1, 0} This sounds like a strangeness in constr

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-30 Thread Andreas Cadhalpun
On 30.01.2017 09:23, Steinar H. Gunderson wrote: > How can you get a negative run, which would be required for this to happen? Some values in ff_dc_alpha_run_vlc_le.table are negative, e.g.: ff_dc_alpha_run_vlc_le.table[32] = {-1, 0} Best regards, Andreas ___

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/ebur128: fix relative threshold calculation for multiple contexts

2017-01-30 Thread Marton Balint
On Wed, 25 Jan 2017, Marton Balint wrote: Also disallow NULL contexts. Fixes Coverity CID 1396273, 1396279. Signed-off-by: Marton Balint --- libavfilter/ebur128.c | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/libavfilter/ebur128

Re: [FFmpeg-devel] [PATCH] avutil/frame: fix av_frame_copy for unknown layouts

2017-01-30 Thread Marton Balint
On Mon, 30 Jan 2017, Paul B Mahol wrote: On 1/30/17, wm4 wrote: On Mon, 30 Jan 2017 08:47:49 +0100 Hendrik Leppkes wrote: On Mon, Jan 30, 2017 at 8:40 AM, wm4 wrote: > On Mon, 30 Jan 2017 01:37:02 +0100 > Marton Balint wrote: > >> I wonder how unknown layouts ever worked without this? >>

[FFmpeg-devel] [PATCH] lavf/xwma: fix incorrect format specifier

2017-01-30 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- libavformat/xwma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/xwma.c b/libavformat/xwma.c index df84d25..9235157 100644 --- a/libavformat/xwma.c +++ b/libavformat/xwma.c @@ -87,7 +87,7 @@ static int xwma_read_header(AVFormatC

Re: [FFmpeg-devel] [PATCH] avformat/segment: remove last_cut check when detecting a new segment

2017-01-30 Thread Marton Balint
On Thu, 26 Jan 2017, Marton Balint wrote: Not starting a new segment if the elapsed microsecs since the start of the day equals the the elapsed microsecs since the start of the day at the time of the last cut seems plain wrong to me, Deti do you remember the original reason behind this check?

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: change ff_inlink_make_frame_writable() to take AVFrame* argument

2017-01-30 Thread Marton Balint
On Mon, 30 Jan 2017, Rostislav Pehlivanov wrote: On 30 January 2017 at 00:09, Marton Balint wrote: On Sat, 28 Jan 2017, Nicolas George wrote: Le nonidi 9 pluviôse, an CCXXV, Muhammad Faiz a écrit : so the behavior will be similar to av_frame_make_writable(). The point was to move aw

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-30 Thread Sasi Inguva
patch looks good to me. Thanks. On Mon, Jan 30, 2017 at 6:48 AM, Michael Niedermayer wrote: > On Mon, Jan 30, 2017 at 03:39:19PM +0100, Michael Niedermayer wrote: > > On Mon, Jan 30, 2017 at 10:51:02AM +, Eran Kornblau wrote: > > > > -Original Message- > > > > From: ffmpeg-devel [ma

Re: [FFmpeg-devel] GSoC 2017

2017-01-30 Thread Thilo Borgmann
Am 30.01.17 um 18:41 schrieb Umair Khan: > On Wed, Jan 25, 2017 at 5:45 PM, Thilo Borgmann > wrote: >> Am 25.01.17 um 06:14 schrieb Umair Khan: >>> On Wed, Jan 25, 2017 at 7:45 AM, Michael Niedermayer >>> wrote: On Mon, Jan 23, 2017 at 03:39:09PM +0100, Michael Niedermayer wrote:

Re: [FFmpeg-devel] GSoC 2017

2017-01-30 Thread Umair Khan
On Wed, Jan 25, 2017 at 5:45 PM, Thilo Borgmann wrote: > Am 25.01.17 um 06:14 schrieb Umair Khan: >> On Wed, Jan 25, 2017 at 7:45 AM, Michael Niedermayer >> wrote: >>> >>> On Mon, Jan 23, 2017 at 03:39:09PM +0100, Michael Niedermayer wrote: Hi all GSoC 2017 mentor org registration

Re: [FFmpeg-devel] [PATCH] avformat/msf: fix codec 4 (joint stereo ATRAC3) and align

2017-01-30 Thread Paul B Mahol
On 1/30/17, Banana M. wrote: > It should work with all proper MSF. > Here is my test suite, which includes most MSF variations (including some > not yet supported by FFmpeg) > https://www.sendspace.com/file/omvv8s > For example, there is no 1ch ATRAC3-codec4 test MSF because the encoder > only out

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-30 Thread Ronald S. Bultje
Hi, On Sun, Jan 29, 2017 at 7:37 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 29.01.2017 04:46, Ronald S. Bultje wrote: > > Hm ... So I guess I wasn't clear about this, but the reason I didn't > reply > > to other patches with log messages was not because I'm OK with, but

Re: [FFmpeg-devel] [PATCH] avformat/msf: fix codec 4 (joint stereo ATRAC3) and align

2017-01-30 Thread Banana M.
It should work with all proper MSF. Here is my test suite, which includes most MSF variations (including some not yet supported by FFmpeg) https://www.sendspace.com/file/omvv8s For example, there is no 1ch ATRAC3-codec4 test MSF because the encoder only outputs joint stereo I'm afraid I don't know

Re: [FFmpeg-devel] [PATCH] doc: add a lexicon

2017-01-30 Thread Clément Bœsch
On Mon, Jan 30, 2017 at 04:59:28PM +0100, Michael Niedermayer wrote: > On Mon, Jan 30, 2017 at 03:58:12PM +0100, Clément Bœsch wrote: > > --- > > doc/lexicon | 23 +++ > > 1 file changed, 23 insertions(+) > > create mode 100644 doc/lexicon > > > > diff --git a/doc/lexicon b/d

[FFmpeg-devel] [PATCH] HTTP: improve performance by reducing forward seeks

2017-01-30 Thread Joel Cunningham
This commit optimizes HTTP performance by reducing forward seeks, instead favoring a read-ahead and discard on the current connection (referred to as a short seek) for seeks that are within a TCP window's worth of data. This improves performance because with TCP flow control, a window's worth of da

Re: [FFmpeg-devel] [PATCH] doc: add a lexicon

2017-01-30 Thread Michael Niedermayer
On Mon, Jan 30, 2017 at 03:58:12PM +0100, Clément Bœsch wrote: > --- > doc/lexicon | 23 +++ > 1 file changed, 23 insertions(+) > create mode 100644 doc/lexicon > > diff --git a/doc/lexicon b/doc/lexicon > new file mode 100644 > index 00..36ff803fb5 > --- /dev/null >

Re: [FFmpeg-devel] [PATCH 2/3] avformat/avienc: add reserve_index_space option

2017-01-30 Thread Tobias Rapp
On 25.01.2017 22:49, Michael Niedermayer wrote: On Mon, Jan 23, 2017 at 11:12:13AM +0100, Tobias Rapp wrote: [...] libavformat/avi.h |1 libavformat/avienc.c| 77 +--- libavformat/version.h |2 tes

Re: [FFmpeg-devel] [PATCH] avfilter: add threshold filter

2017-01-30 Thread Paul B Mahol
On 2/6/16, Paul B Mahol wrote: > Hi, > > patch attached. > gonna apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter/overlay: add gbrp output format

2017-01-30 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 5 +++- libavfilter/vf_overlay.c | 71 +--- 2 files changed, 65 insertions(+), 11 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 21a5bf5..14cd026 100644 --- a/doc/filters.

[FFmpeg-devel] [PATCH] avcodec/atrac3: Add multichannel joint stereo ATRAC3

2017-01-30 Thread bananaman255
From: bnnm Multichannel joint stereo simply interleaves stereo pairs (6ch: 2ch + 2ch + 2ch), so each pair is decoded separatedly. *** To test my changes, I converted examples to wav with ffmpeg.exe (old and new), and compared them to see they are byte-exact. Regular 2ch files (JS and normal)

[FFmpeg-devel] [PATCH] doc: add a lexicon

2017-01-30 Thread Clément Bœsch
--- doc/lexicon | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 doc/lexicon diff --git a/doc/lexicon b/doc/lexicon new file mode 100644 index 00..36ff803fb5 --- /dev/null +++ b/doc/lexicon @@ -0,0 +1,23 @@ +Common abbreviations/shorthands we use that don

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-30 Thread Michael Niedermayer
On Mon, Jan 30, 2017 at 03:39:19PM +0100, Michael Niedermayer wrote: > On Mon, Jan 30, 2017 at 10:51:02AM +, Eran Kornblau wrote: > > > -Original Message- > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > > > Sasi Inguva > > > Sent: Wednesday, January 18,

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-30 Thread Michael Niedermayer
On Mon, Jan 30, 2017 at 10:51:02AM +, Eran Kornblau wrote: > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > > Sasi Inguva > > Sent: Wednesday, January 18, 2017 3:30 AM > > To: FFmpeg development discussions and patches > > Subject:

Re: [FFmpeg-devel] [PATCH] Implement optimal huffman encoding for (M)JPEG.

2017-01-30 Thread Michael Niedermayer
On Sun, Jan 29, 2017 at 07:54:19PM -0800, Jerry Jiang wrote: > Hey everyone, > > Sorry for the long wait, here's a new patch addressing the feedback. In > addition, we discovered that this current implementation of optimal huffman > encoding is not compatible with QP RD, so we chose to disable QP

Re: [FFmpeg-devel] [PATCH] avformat/msf: fix codec 4 (joint stereo ATRAC3) and align

2017-01-30 Thread Paul B Mahol
On 1/30/17, bananaman...@gmail.com wrote: > From: bnnm > > Codec 4 (frame size 98) uses joint stereo per spec and examples. > Also removed an incorrect "align" var which wasn't used anyway (it was > overwrittern). > > Probably all/only .AT3 of frame size 98 are JS, too. > > Signed-off-by: bnnm >

[FFmpeg-devel] [PATCH] avformat/msf: fix codec 4 (joint stereo ATRAC3) and align

2017-01-30 Thread bananaman255
From: bnnm Codec 4 (frame size 98) uses joint stereo per spec and examples. Also removed an incorrect "align" var which wasn't used anyway (it was overwrittern). Probably all/only .AT3 of frame size 98 are JS, too. Signed-off-by: bnnm --- libavformat/msf.c | 13 ++--- 1 file changed,

Re: [FFmpeg-devel] [PATCH] avformat/Makefile: fix compilation of testprogs when networking is disabled

2017-01-30 Thread Tobias Rapp
On 26.01.2017 20:16, Michael Niedermayer wrote: On Wed, Jan 25, 2017 at 03:05:55PM +0100, Tobias Rapp wrote: Signed-off-by: Tobias Rapp --- libavformat/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) probably ok Pushed. Regards, Tobias __

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-30 Thread Eran Kornblau
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Sasi > Inguva > Sent: Wednesday, January 18, 2017 3:30 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] mov: support for multiple edits and cenc > decryption >

Re: [FFmpeg-devel] [PATCH]lavc/alac: Export samplerate

2017-01-30 Thread Paul B Mahol
On 1/30/17, Carl Eugen Hoyos wrote: > Hi! > > I suspect attached patch makes using the alac decoder easier with > non-FFmpeg demuxers. > > Please comment, Carl Eugen > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/

[FFmpeg-devel] [PATCH]lavc/alac: Export samplerate

2017-01-30 Thread Carl Eugen Hoyos
Hi! I suspect attached patch makes using the alac decoder easier with non-FFmpeg demuxers. Please comment, Carl Eugen From c3a4a0ca8a5ce07cabb339f0288e6b1223dda1b0 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 30 Jan 2017 11:03:21 +0100 Subject: [PATCH] lavc/alac: Export samplerate

Re: [FFmpeg-devel] [PATCH] avutil/frame: fix av_frame_copy for unknown layouts

2017-01-30 Thread Paul B Mahol
On 1/30/17, wm4 wrote: > On Mon, 30 Jan 2017 08:47:49 +0100 > Hendrik Leppkes wrote: > >> On Mon, Jan 30, 2017 at 8:40 AM, wm4 wrote: >> > On Mon, 30 Jan 2017 01:37:02 +0100 >> > Marton Balint wrote: >> > >> >> I wonder how unknown layouts ever worked without this? >> >> >> >> Signed-off-by: Ma

Re: [FFmpeg-devel] [PATCH] avutil/frame: fix av_frame_copy for unknown layouts

2017-01-30 Thread wm4
On Mon, 30 Jan 2017 08:47:49 +0100 Hendrik Leppkes wrote: > On Mon, Jan 30, 2017 at 8:40 AM, wm4 wrote: > > On Mon, 30 Jan 2017 01:37:02 +0100 > > Marton Balint wrote: > > > >> I wonder how unknown layouts ever worked without this? > >> > >> Signed-off-by: Marton Balint > >> --- > >> libavu

Re: [FFmpeg-devel] [PATCH 4/9] ircamdec: prevent overflow during block alignment calculation

2017-01-30 Thread Paul B Mahol
On 1/30/17, Andreas Cadhalpun wrote: > On 29.01.2017 02:34, Michael Niedermayer wrote: >> On Thu, Jan 26, 2017 at 02:12:19AM +0100, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavformat/ircamdec.c | 6 ++ >>> 1 file changed, 6 insertions(+) >> >> LGTM assuming

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-30 Thread Steinar H. Gunderson
On Mon, Jan 30, 2017 at 02:31:08AM +0100, Andreas Cadhalpun wrote: > Fixes out-of-bounds writes. Hi, How can you get a negative run, which would be required for this to happen? /* Steinar */ -- Homepage: https://www.sesse.net/ ___ ffmpeg-devel mailing