Re: [FFmpeg-devel] [PATCH] Respect payload offset in av_packet_ref

2016-05-12 Thread Michael Niedermayer
On Thu, May 12, 2016 at 05:47:09PM +0300, Andriy Lysnevych wrote: > You are right > --- > libavcodec/avpacket.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failu

Re: [FFmpeg-devel] [PATCH] avformat/dump.c: fix mixed log levels

2016-05-12 Thread Michael Niedermayer
On Thu, May 12, 2016 at 04:38:41PM +0200, Tobias Rapp wrote: > On 12.05.2016 16:00, Michael Niedermayer wrote: > >On Thu, May 12, 2016 at 10:26:03AM +0200, Tobias Rapp wrote: > >>Previously a partial log message without newline was printed in case of > >>loglevel=warning. > >> > >>Signed-off-by: To

Re: [FFmpeg-devel] [PATCH] Const src in av_packet_clone declaration

2016-05-12 Thread Andriy Lysnevych
> That's a change that could break source-compatibility with C++, I don't think it can be made so easily. I do not agree. It extends function so it can take as argument both const and non-const packets. Actually I discovered this defect when I was not able to clone const packet in C++ project. __

Re: [FFmpeg-devel] [PATCH] Updated (v3) -- Add input mode autodetect to the decklink module.

2016-05-12 Thread Felt, Patrick
I hang my head in shame. I neglected to notice that time wasn’t already included and so I had to modify the patch. Apologies for the noise. -- Add input mode autodetect to the decklink module. Previously users had to supply the input format like this 'DeckLink Device@modenum'. This patch allo

Re: [FFmpeg-devel] [PATCH] Updated -- Add input mode autodetect to the decklink module.

2016-05-12 Thread Felt, Patrick
-- Add input mode autodetect to the decklink module. Previously users had to supply the input format like this 'DeckLink Device@modenum'. This patch allows users to either leave it off completely, or supply 0 or negative number to indicate autodetect is requested. Autodetect only works the firs

Re: [FFmpeg-devel] [PATCH] -- Add input mode autodetect to the decklink module.

2016-05-12 Thread Felt, Patrick
Ah… I see a bug. I should either be setting ctx->video in the if block or I should be breaking instead of continuing. Good catch! On 5/12/16, 1:32 PM, "ffmpeg-devel on behalf of Matthias Hunstock" wrote: >Am 12.05.2016 um 19:16 schrieb Felt, Patrick: >> +while (!ctx->video) { >> +

Re: [FFmpeg-devel] [PATCH] -- Add input mode autodetect to the decklink module.

2016-05-12 Thread Felt, Patrick
Ah. Didn’t realize we had that. Will do. On 5/12/16, 1:37 PM, "ffmpeg-devel on behalf of Marton Balint" wrote: > > >On Thu, 12 May 2016, Matthias Hunstock wrote: > >> Am 12.05.2016 um 19:16 schrieb Felt, Patrick: >>> +while (!ctx->video) { >>> +if (autodetect_delay--) { >>

[FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-12 Thread Andrey Turkin
Few functions didn't handle hw_frames_ctx references causing resources leaks and even crashes. --- libavcodec/options.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/options.c b/libavcodec/options.c index ea2563b..8682262 100644 --- a/libavcodec/options.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH] -- Add input mode autodetect to the decklink module.

2016-05-12 Thread Matthias Hunstock
Am 12.05.2016 um 19:16 schrieb Felt, Patrick: > +while (!ctx->video) { > +if (autodetect_delay--) { > +/* this could indicate we are in the right mode. let's > assume so */ > +continue; > +} > +sleep(1); > +} I d

Re: [FFmpeg-devel] [PATCH] -- Add input mode autodetect to the decklink module.

2016-05-12 Thread Marton Balint
On Thu, 12 May 2016, Matthias Hunstock wrote: Am 12.05.2016 um 19:16 schrieb Felt, Patrick: +while (!ctx->video) { +if (autodetect_delay--) { +/* this could indicate we are in the right mode. let's assume so */ +continue; +} +

[FFmpeg-devel] [PATCH] -- Add input mode autodetect to the decklink module.

2016-05-12 Thread Felt, Patrick
Previously users had to supply the input format like this 'DeckLink Device@modenum'. This patch allows users to either leave it off completely, or supply 0 or negative number to indicate autodetect is requested. Autodetect only works the first time so if the mode changes mid stream you'll die.

Re: [FFmpeg-devel] [PATCH] Const src in av_packet_clone declaration

2016-05-12 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > > -AVPacket *av_packet_clone(AVPacket *src) > > +AVPacket *av_packet_clone(const AVPacket *src) > > That's a change that could break source-compatibility with C++ How can this breakage be reproduced? Carl Eugen ___ ffmp

Re: [FFmpeg-devel] [PATCH]lavc/libx265: Support gray encoding

2016-05-12 Thread Derek Buitenhuis
On 5/12/2016 4:18 PM, Carl Eugen Hoyos wrote: > The feature is not new (and the necessary define in the header > was always there) but it did not work (at least for some > revisions). > How should I proceed? Hmm. I'm not really a fan of bumping up the required x265 version, since it has been st

Re: [FFmpeg-devel] [PATCH] Const src in av_packet_clone declaration

2016-05-12 Thread wm4
On Thu, 12 May 2016 16:02:48 +0300 Andriy Lysnevych wrote: > --- > libavcodec/avcodec.h | 2 +- > libavcodec/avpacket.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 97b2128..1ad0412 100644 > --- a/libavcodec/avc

Re: [FFmpeg-devel] [PATCH]lavc/libx265: Support gray encoding

2016-05-12 Thread Carl Eugen Hoyos
Derek Buitenhuis gmail.com> writes: > On 5/12/2016 10:43 AM, Carl Eugen Hoyos wrote: > > I am also attaching the patch I just sent to x265-devel > > that allows to test the feature. > > Would this not need a version requirement bump in configure, > if the feature is new? The feature is not ne

Re: [FFmpeg-devel] [PATCH] Respect payload offset in av_packet_ref

2016-05-12 Thread Andriy Lysnevych
You are right --- libavcodec/avpacket.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index dd8b71e..19597f2 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -568,16 +568,18 @@ int av_packet_ref(AVPacket *dst,

Re: [FFmpeg-devel] [PATCH] avformat/dump.c: fix mixed log levels

2016-05-12 Thread Tobias Rapp
On 12.05.2016 16:00, Michael Niedermayer wrote: On Thu, May 12, 2016 at 10:26:03AM +0200, Tobias Rapp wrote: Previously a partial log message without newline was printed in case of loglevel=warning. Signed-off-by: Tobias Rapp --- libavformat/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [FFmpeg-devel] [PATCH] avformat/dump.c: fix mixed log levels

2016-05-12 Thread Michael Niedermayer
On Thu, May 12, 2016 at 10:26:03AM +0200, Tobias Rapp wrote: > Previously a partial log message without newline was printed in case of > loglevel=warning. > > Signed-off-by: Tobias Rapp > --- > libavformat/dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavform

Re: [FFmpeg-devel] [PATCH] Respect payload offset in av_packet_ref

2016-05-12 Thread Hendrik Leppkes
On Thu, May 12, 2016 at 3:44 PM, Andriy Lysnevych wrote: > Details are in the ticket https://trac.ffmpeg.org/ticket/5543 > > --- > libavcodec/avpacket.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > index dd8b71e..842d8

Re: [FFmpeg-devel] [PATCH] swresample/arm: add ff_resample_common_apply_filter_{x4, x8}_{float, s16}_neon

2016-05-12 Thread Benoit Fouet
Hi, On 12/05/2016 15:22, Matthieu Bouron wrote: On Thu, May 12, 2016 at 10:01 AM, Benoit Fouet wrote: Hi, I mostly have nits remarks. On 11/05/2016 18:39, Matthieu Bouron wrote: From: Matthieu Bouron [...] diff --git a/libswresample/arm/resample.S b/libswresample/arm/resample.S new

[FFmpeg-devel] [PATCH] Respect payload offset in av_packet_ref

2016-05-12 Thread Andriy Lysnevych
Details are in the ticket https://trac.ffmpeg.org/ticket/5543 --- libavcodec/avpacket.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index dd8b71e..842d8ba 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -56

Re: [FFmpeg-devel] [PATCH] swresample/arm: add ff_resample_common_apply_filter_{x4, x8}_{float, s16}_neon

2016-05-12 Thread Matthieu Bouron
On Thu, May 12, 2016 at 10:01 AM, Benoit Fouet wrote: > Hi, > > I mostly have nits remarks. > > On 11/05/2016 18:39, Matthieu Bouron wrote: > >> From: Matthieu Bouron >> >> > [...] > > diff --git a/libswresample/arm/resample.S b/libswresample/arm/resample.S >> new file mode 100644 >> index 0

[FFmpeg-devel] [PATCH] Const src in av_packet_clone declaration

2016-05-12 Thread Andriy Lysnevych
--- libavcodec/avcodec.h | 2 +- libavcodec/avpacket.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 97b2128..1ad0412 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4300,7 +4300,7 @@ AVPacket *av_packet_a

Re: [FFmpeg-devel] [PATCH]lavc/libx265: Support gray encoding

2016-05-12 Thread Derek Buitenhuis
On 5/12/2016 10:43 AM, Carl Eugen Hoyos wrote: > I am also attaching the patch I just sent to x265-devel that allows to > test the feature. Would this not need a version requirement bump in configure, if the feature is new? - Derek ___ ffmpeg-devel ma

Re: [FFmpeg-devel] [PATCHv3] h2645_parse: support badly muxed mp4 streams

2016-05-12 Thread Michael Niedermayer
On Thu, May 12, 2016 at 12:07:40PM +0200, Hendrik Leppkes wrote: > Some streams contain an additional AnnexB NAL inside the mp4/nalff NALU. > This commonly occurs in interlaced streams where both fields are packed > into the same MP4 NAL with an AnnexB startcode in between. > > Port handling of th

[FFmpeg-devel] [PATCHv3] h2645_parse: support badly muxed mp4 streams

2016-05-12 Thread Hendrik Leppkes
Some streams contain an additional AnnexB NAL inside the mp4/nalff NALU. This commonly occurs in interlaced streams where both fields are packed into the same MP4 NAL with an AnnexB startcode in between. Port handling of this format from the previous h264 nal handling. Fixes trac #5529 --- Third

Re: [FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-05-12 Thread Nicolas George
Le quartidi 24 floréal, an CCXXIV, wm4 a écrit : > Conceptually, passing the packets just along is equivalent to copying. > It's how refcounting works; without a real copy, the first write access > to the packet will do the real copy. And copying the packet is doing no filtering at all on it. You

Re: [FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-05-12 Thread wm4
On Thu, 12 May 2016 11:20:28 +0200 Nicolas George wrote: > Le quartidi 24 floréal, an CCXXIV, Paul B Mahol a écrit : > > Yes. I object its name. Null name is misleading. Its name should be copy. > > I can live with that if other people agree, but for now we have null and > anull in libavfilter

[FFmpeg-devel] [PATCH]lavc/libx265: Support gray encoding

2016-05-12 Thread Carl Eugen Hoyos
Hi! Attached patch implements gray encoding with libx265, does not fix or workaround ticket #5536. I am also attaching the patch I just sent to x265-devel that allows to test the feature. Please comment, Carl Eugen # HG changeset patch # User Carl Eugen Hoyos # Date 1463045462 -7200 # Node ID

Re: [FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-05-12 Thread Nicolas George
Le quartidi 24 floréal, an CCXXIV, Paul B Mahol a écrit : > Yes. I object its name. Null name is misleading. Its name should be copy. I can live with that if other people agree, but for now we have null and anull in libavfilter, that would be inconsistent. Plus, the filter does not copy the packet

Re: [FFmpeg-devel] [PATCH] avformat/tee: Move to new BSF API

2016-05-12 Thread Nicolas George
Le quartidi 24 floréal, an CCXXIV, Nicolas George a écrit : > Le quartidi 24 floréal, an CCXXIV, Jan Sebechlebsky a écrit : > > I can change it to array, the advantage of using linked list was that number > > of bitstream > > filters used is not known before arguments are parsed, this way the filte

Re: [FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-05-12 Thread Paul B Mahol
On 5/12/16, Nicolas George wrote: > Le decadi 10 floreal, an CCXXIV, Nicolas George a ecrit : >> From 9507a24a4774dc7542e6cd9739104bb7d9528185 Mon Sep 17 00:00:00 2001 >> From: Nicolas George >> Date: Thu, 28 Apr 2016 10:25:37 +0200 >> Subject: [PATCH 1/3] lavc/bsf: add a null bitstream filter. >

Re: [FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-05-12 Thread Nicolas George
Le decadi 10 floréal, an CCXXIV, Nicolas George a écrit : > From 9507a24a4774dc7542e6cd9739104bb7d9528185 Mon Sep 17 00:00:00 2001 > From: Nicolas George > Date: Thu, 28 Apr 2016 10:25:37 +0200 > Subject: [PATCH 1/3] lavc/bsf: add a null bitstream filter. > > It passes packets unchanged with a ve

[FFmpeg-devel] [PATCH] h2645_parse: support badly muxed mp4 streams

2016-05-12 Thread Hendrik Leppkes
Some streams contain an additional AnnexB NAL inside the mp4/nalff NALU. This commonly occurs in interlaced streams where both fields are packed into the same MP4 NAL with an AnnexB startcode in between. Port handling of this format from the previous h264 nal handling. Fixes trac #5529 --- libav

Re: [FFmpeg-devel] [PATCH] h2645_parse: support badly muxed mp4 streams

2016-05-12 Thread Hendrik Leppkes
On Thu, May 12, 2016 at 10:52 AM, Hendrik Leppkes wrote: > Some streams contain an additional AnnexB NAL inside the mp4/nalff NALU. > This commonly occurs in interlaced streams where both fields are packed > into the same MP4 NAL with an AnnexB startcode in between. > > Port handling of this forma

[FFmpeg-devel] [PATCH] h2645_parse: support badly muxed mp4 streams

2016-05-12 Thread Hendrik Leppkes
Some streams contain an additional AnnexB NAL inside the mp4/nalff NALU. This commonly occurs in interlaced streams where both fields are packed into the same MP4 NAL with an AnnexB startcode in between. Port handling of this format from the previous h264 nal handling. Fixes trac #5529 --- libav

[FFmpeg-devel] [PATCH] avformat/dump.c: fix mixed log levels

2016-05-12 Thread Tobias Rapp
Previously a partial log message without newline was printed in case of loglevel=warning. Signed-off-by: Tobias Rapp --- libavformat/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index d6a3249..9eb6146 100644 --- a/libavformat/

Re: [FFmpeg-devel] [PATCH] swresample/arm: add ff_resample_common_apply_filter_{x4, x8}_{float, s16}_neon

2016-05-12 Thread Benoit Fouet
Hi, I mostly have nits remarks. On 11/05/2016 18:39, Matthieu Bouron wrote: From: Matthieu Bouron [...] diff --git a/libswresample/arm/resample.S b/libswresample/arm/resample.S new file mode 100644 index 000..13462e3 --- /dev/null +++ b/libswresample/arm/resample.S @@ -0,0 +1,77 @@ [