Re: [FFmpeg-devel] [PATCH 3/3] lavu/internal: tighten errors for avpriv_exp10

2015-12-25 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 9:11 AM, Ganesh Ajjanagadde wrote: > This tightens the errors by doing a first order Taylor approximation of > one obvious source of error. This results in negligible runtime > slowdown, but improves worst case relative error by ~ 30%, worst case > ulp count from 673 to 39

Re: [FFmpeg-devel] [PATCH 1/5] lavfi/vf_hue: replace rint by lrint

2015-12-25 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 5:41 PM, Michael Niedermayer wrote: > On Fri, Dec 25, 2015 at 04:00:16PM -0800, Ganesh Ajjanagadde wrote: >> avoids float to int cast, and is slightly superior in terms of rounding >> ("Dutch/Gauss rounding"). >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavfilter/

Re: [FFmpeg-devel] [PATCH 5/5] lavc/snowenc: replace rint by lrint

2015-12-25 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 5:38 PM, Michael Niedermayer wrote: > On Fri, Dec 25, 2015 at 04:00:20PM -0800, Ganesh Ajjanagadde wrote: >> avoids float to int cast, and is > > >> slightly superior in terms of rounding >> ("Dutch/Gauss rounding"). > > isnt the rounding the same ? oops, confused with rou

Re: [FFmpeg-devel] [PATCH 1/5] lavfi/vf_hue: replace rint by lrint

2015-12-25 Thread Michael Niedermayer
On Fri, Dec 25, 2015 at 04:00:16PM -0800, Ganesh Ajjanagadde wrote: > avoids float to int cast, and is slightly superior in terms of rounding > ("Dutch/Gauss rounding"). > > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/vf_hue.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH 5/5] lavc/snowenc: replace rint by lrint

2015-12-25 Thread Michael Niedermayer
On Fri, Dec 25, 2015 at 04:00:20PM -0800, Ganesh Ajjanagadde wrote: > avoids float to int cast, and is > slightly superior in terms of rounding > ("Dutch/Gauss rounding"). isnt the rounding the same ? the change itself LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

2015-12-25 Thread Roger Pack
On 12/11/15, Lou Logan wrote: > On Wed, 9 Dec 2015 21:24:06 +0100, Hendrik Leppkes wrote: > >> libvo-aacenc doesn't see any development anymore. >> Its an encoder taken from the android sdk a long time ago, but AOSP >> replaced it with fdk-aac, so libvo-aacenc is EOL. >> >> And its quality is horr

[FFmpeg-devel] [PATCH 5/5] lavc/snowenc: replace rint by lrint

2015-12-25 Thread Ganesh Ajjanagadde
avoids float to int cast, and is slightly superior in terms of rounding ("Dutch/Gauss rounding"). Signed-off-by: Ganesh Ajjanagadde --- libavcodec/snowenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index 90b6439..26a8383 10

[FFmpeg-devel] [PATCH 4/5] lavc/dds: replace rint by lrint

2015-12-25 Thread Ganesh Ajjanagadde
avoids float to int cast, and is slightly superior in terms of rounding ("Dutch/Gauss rounding"). Signed-off-by: Ganesh Ajjanagadde --- libavcodec/dds.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/dds.c b/libavcodec/dds.c index d473fd1..9577b67 100644 --- a/l

[FFmpeg-devel] [PATCH 3/5] lavc/texturedsp: replace rint by lrint

2015-12-25 Thread Ganesh Ajjanagadde
avoids float to int cast, and is slightly superior in terms of rounding ("Dutch/Gauss rounding). Signed-off-by: Ganesh Ajjanagadde --- libavcodec/texturedsp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/texturedsp.c b/libavcodec/texturedsp.c index f32d1b3..c5

[FFmpeg-devel] [PATCH 2/5] lavfi/avf_showspectrum: replace rint by lrint

2015-12-25 Thread Ganesh Ajjanagadde
avoids float to int cast, and is slightly superior in terms of rounding ("Dutch/Gauss rounding"). Signed-off-by: Ganesh Ajjanagadde --- libavfilter/avf_showspectrum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum

[FFmpeg-devel] [PATCH 1/5] lavfi/vf_hue: replace rint by lrint

2015-12-25 Thread Ganesh Ajjanagadde
avoids float to int cast, and is slightly superior in terms of rounding ("Dutch/Gauss rounding"). Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_hue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_hue.c b/libavfilter/vf_hue.c index 2c1b34e..92607f1

Re: [FFmpeg-devel] [PATCH] ffplay: replace rint by lrint

2015-12-25 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 12:51 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Dec 25, 2015 at 2:29 PM, Ganesh Ajjanagadde > wrote: >> >> avoids the float to integer cast, and is slightly superior in terms of >> rounding ("Dutch/Gauss rounding"). >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> f

Re: [FFmpeg-devel] [PATCH] ffplay: replace rint by lrint

2015-12-25 Thread Ronald S. Bultje
Hi, On Fri, Dec 25, 2015 at 2:29 PM, Ganesh Ajjanagadde wrote: > avoids the float to integer cast, and is slightly superior in terms of > rounding ("Dutch/Gauss rounding"). > > Signed-off-by: Ganesh Ajjanagadde > --- > ffplay.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > di

Re: [FFmpeg-devel] new to FOSS, Need guidance

2015-12-25 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 11:52 AM, Love Mehta wrote: > Hello eveyone, > > I am a second year student of Indian Institute of Technology, Ropar. I am > quite comfortable with c, c++, HTML, CSS, javaScript and java programming. > > I am new in the open source software community and wish to contribute

[FFmpeg-devel] new to FOSS, Need guidance

2015-12-25 Thread Love Mehta
Hello eveyone, I am a second year student of Indian Institute of Technology, Ropar. I am quite comfortable with c, c++, HTML, CSS, javaScript and java programming. I am new in the open source software community and wish to contribute in free software. I have found out about the FFmpeg community f

[FFmpeg-devel] [PATCH] ffplay: replace rint by lrint

2015-12-25 Thread Ganesh Ajjanagadde
avoids the float to integer cast, and is slightly superior in terms of rounding ("Dutch/Gauss rounding"). Signed-off-by: Ganesh Ajjanagadde --- ffplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ffplay.c b/ffplay.c index 2f8a0bf..9256392 100644 --- a/ffplay.c +++ b/

[FFmpeg-devel] [PATCH] Fix buffer allocation in pad filter

2015-12-25 Thread Andrey Turkin
One extra line must be allocated when adding left padding to make sure that last line in every plane fits in the allocated buffer fully --- libavfilter/vf_pad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_pad.c b/libavfilter/vf_pad.c index d94ced1..555b318 10

Re: [FFmpeg-devel] [PATCH 1/3] lavu/libm, configure: remove exp10, exp10f detection

2015-12-25 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 9:11 AM, Ganesh Ajjanagadde wrote: > Subsequent commit introduces avpriv_exp10 instead. > > Signed-off-by: Ganesh Ajjanagadde > --- > configure| 2 -- > libavutil/libm.h | 18 -- > 2 files changed, 20 deletions(-) > > diff --git a/configure b/conf

Re: [FFmpeg-devel] [PATCH 2/3] lavu/internal: add avpriv_exp10

2015-12-25 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 9:55 AM, Ganesh Ajjanagadde wrote: > On Fri, Dec 25, 2015 at 9:47 AM, Hendrik Leppkes wrote: >> On Fri, Dec 25, 2015 at 6:27 PM, Ganesh Ajjanagadde wrote: >>> On Fri, Dec 25, 2015 at 9:26 AM, James Almer wrote: On 12/25/2015 2:11 PM, Ganesh Ajjanagadde wrote: >

Re: [FFmpeg-devel] [PATCH] lavc/acelp_pitch_delay: replace exp2f(M_LOG2_10 *x) by exp10f(x)

2015-12-25 Thread Ganesh Ajjanagadde
On Wed, Dec 23, 2015 at 12:26 PM, Ganesh Ajjanagadde wrote: > Suggested-by: Ronald S. Bultje > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/acelp_pitch_delay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/acelp_pitch_delay.c b/libavcodec/acelp_pitc

Re: [FFmpeg-devel] [PATCH 15/15] lavc/wmaprodec: replace pow(10, x) by exp10(x)

2015-12-25 Thread Ganesh Ajjanagadde
On Wed, Dec 23, 2015 at 10:47 AM, Ganesh Ajjanagadde wrote: > exp10, introduced recently, is superior for the purpose. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/wmaprodec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/wmaprodec.c b/libavcod

Re: [FFmpeg-devel] [PATCH 2/3] lavu/internal: add avpriv_exp10

2015-12-25 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 9:47 AM, Hendrik Leppkes wrote: > On Fri, Dec 25, 2015 at 6:27 PM, Ganesh Ajjanagadde wrote: >> On Fri, Dec 25, 2015 at 9:26 AM, James Almer wrote: >>> On 12/25/2015 2:11 PM, Ganesh Ajjanagadde wrote: Fast, reasonably accurate 10^x. Alternative of detection of libm e

Re: [FFmpeg-devel] [PATCH 2/3] lavu/internal: add avpriv_exp10

2015-12-25 Thread Hendrik Leppkes
On Fri, Dec 25, 2015 at 6:27 PM, Ganesh Ajjanagadde wrote: > On Fri, Dec 25, 2015 at 9:26 AM, James Almer wrote: >> On 12/25/2015 2:11 PM, Ganesh Ajjanagadde wrote: >>> Fast, reasonably accurate 10^x. Alternative of detection of libm exp10 at >>> configure >>> time is not worth the trouble, sinc

Re: [FFmpeg-devel] [PATCH 2/3] lavu/internal: add avpriv_exp10

2015-12-25 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 9:26 AM, James Almer wrote: > On 12/25/2015 2:11 PM, Ganesh Ajjanagadde wrote: >> Fast, reasonably accurate 10^x. Alternative of detection of libm exp10 at >> configure >> time is not worth the trouble, since it is anyway not POSIX or ISO C, >> and currently only the GNU l

Re: [FFmpeg-devel] [PATCH 2/3] lavu/internal: add avpriv_exp10

2015-12-25 Thread James Almer
On 12/25/2015 2:11 PM, Ganesh Ajjanagadde wrote: > Fast, reasonably accurate 10^x. Alternative of detection of libm exp10 at > configure > time is not worth the trouble, since it is anyway not POSIX or ISO C, > and currently only the GNU libm has it. Furthermore, GNU libm's variant > is ~ 2x slowe

[FFmpeg-devel] [PATCH 1/3] lavu/libm, configure: remove exp10, exp10f detection

2015-12-25 Thread Ganesh Ajjanagadde
Subsequent commit introduces avpriv_exp10 instead. Signed-off-by: Ganesh Ajjanagadde --- configure| 2 -- libavutil/libm.h | 18 -- 2 files changed, 20 deletions(-) diff --git a/configure b/configure index 73abf28..a510e8f 100755 --- a/configure +++ b/configure @@ -1817

[FFmpeg-devel] [PATCH 3/3] lavu/internal: tighten errors for avpriv_exp10

2015-12-25 Thread Ganesh Ajjanagadde
This tightens the errors by doing a first order Taylor approximation of one obvious source of error. This results in negligible runtime slowdown, but improves worst case relative error by ~ 30%, worst case ulp count from 673 to 391. Another illustration is: arg : -303.13720760010643270798027

[FFmpeg-devel] [PATCH 2/3] lavu/internal: add avpriv_exp10

2015-12-25 Thread Ganesh Ajjanagadde
Fast, reasonably accurate 10^x. Alternative of detection of libm exp10 at configure time is not worth the trouble, since it is anyway not POSIX or ISO C, and currently only the GNU libm has it. Furthermore, GNU libm's variant is ~ 2x slower, and is ironically not correctly rounded (2 ulp off) to j

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-25 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 12:42 AM, Michael Niedermayer wrote: > On Thu, Dec 24, 2015 at 06:29:09PM -0800, Ganesh Ajjanagadde wrote: >> On Thu, Dec 24, 2015 at 6:18 PM, Michael Niedermayer >> wrote: >> > On Thu, Dec 24, 2015 at 06:07:17PM -0800, Ganesh Ajjanagadde wrote: >> >> On Thu, Dec 24, 2015

Re: [FFmpeg-devel] [PATCH] doc/muxers/mpegts: update doc after adding flag to embed an AC-3/E-AC-3 ES the DVB way

2015-12-25 Thread Michael Niedermayer
On Fri, Dec 25, 2015 at 10:33:35AM +0100, "Stefan Pöschel" wrote: > > Gesendet: Donnerstag, 24. Dezember 2015 um 02:50 Uhr > > Von: "Michael Niedermayer" > > An: "FFmpeg development discussions and patches" > > Betreff: Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add flag to embed > > an AC-3

Re: [FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

2015-12-25 Thread Michael Niedermayer
On Thu, Dec 24, 2015 at 05:27:49PM -0500, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 24, 2015 at 5:09 PM, Michael Bradshaw wrote: > > > On Thu, Nov 19, 2015 at 6:31 PM, Michael Niedermayer > > wrote: > > > > > On Wed, Nov 18, 2015 at 09:22:57PM -0800, Michael Bradshaw wrote: > > > > On Wed,

[FFmpeg-devel] [PATCH] doc/muxers/mpegts: update doc after adding flag to embed an AC-3/E-AC-3 ES the DVB way

2015-12-25 Thread Stefan Pöschel
> Gesendet: Donnerstag, 24. Dezember 2015 um 02:50 Uhr > Von: "Michael Niedermayer" > An: "FFmpeg development discussions and patches" > Betreff: Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add flag to embed an > AC-3/E-AC-3 ES the DVB way > > On Sun, Dec 13, 2015 at 11:54:32AM +0100, Stefan

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-25 Thread Michael Niedermayer
On Thu, Dec 24, 2015 at 06:29:09PM -0800, Ganesh Ajjanagadde wrote: > On Thu, Dec 24, 2015 at 6:18 PM, Michael Niedermayer > wrote: > > On Thu, Dec 24, 2015 at 06:07:17PM -0800, Ganesh Ajjanagadde wrote: > >> On Thu, Dec 24, 2015 at 3:55 PM, Ganesh Ajjanagadde > >> wrote: > >> [...] > >> > 2. ac