Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/j2kenc: YUV should not use the ICT

On Fri, Jun 19, 2015 at 05:33:32AM +0200, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Fri Jun 19 > 04:51:59 2015 +0200| [bb3703a4c30659d7ae7b41a94455ce810bbc102b] | committer: > Michael Niedermayer > > avcodec/j2kenc: YUV should not use the ICT > > Signed-off-b

Re: [FFmpeg-devel] [PATCH] library.mak: Workaround SDL redefining main and breaking fate tests on mingw

On 18/06/15 8:06 PM, Michael Niedermayer wrote: > -Umain does not work as SDL adds its defines afterwards You could add -Umain to CFLAGS then, something like diff --git a/library.mak b/library.mak index 7c26024..29460b8 100644 --- a/library.mak +++ b/library.mak @@ -34,6 +34,7 @@ $(SUBDIR)x86/%.o

[FFmpeg-devel] [PATCH 1/2] avcodec/j2kenc: Support writing JP2 encapsulation

The added option matches openjpeg Signed-off-by: Michael Niedermayer --- libavcodec/j2kenc.c | 88 ++- 1 file changed, 87 insertions(+), 1 deletion(-) diff --git a/libavcodec/j2kenc.c b/libavcodec/j2kenc.c index 6a5fd36..ebf8cc7 100644 --- a/lib

[FFmpeg-devel] [PATCH 2/2] avcodec/j2kenc: Use JP2 format by default

Without the JP2 fields its not possible to identify the colorspace Fixes Ticket538 Signed-off-by: Michael Niedermayer --- libavcodec/j2kenc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/j2kenc.c b/libavcodec/j2kenc.c index ebf8cc7..293515c 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH] postproc: fix unaligned access

On 19.06.2015 01:34, Michael Niedermayer wrote: > On Fri, Jun 19, 2015 at 12:05:50AM +0200, Andreas Cadhalpun wrote: >> On 18.06.2015 22:26, Michael Niedermayer wrote: >>> On Thu, Jun 18, 2015 at 08:29:06PM +0200, Andreas Cadhalpun wrote: QP_store is only 8-bit-aligned, so accessing it as uint

Re: [FFmpeg-devel] using afl for fuzzing (was: [PATCH] vp9: don't retain NULL as segmentation_map)

On 19.06.2015 00:59, Kieran Kunhya wrote: >> Thanks for this analysis. I've pushed the patch now. >> >> By the way, afl [1] is really a great tool for finding such problems. >> I can only recommend everyone to try it out yourself. > > Not to push this off-topic but can you let me know how you use

Re: [FFmpeg-devel] [PATCH] postproc: fix unaligned access

On Fri, Jun 19, 2015 at 12:05:50AM +0200, Andreas Cadhalpun wrote: > On 18.06.2015 22:26, Michael Niedermayer wrote: > > On Thu, Jun 18, 2015 at 08:29:06PM +0200, Andreas Cadhalpun wrote: > >> QP_store is only 8-bit-aligned, so accessing it as uint32_t causes > >> SIGILL crashes on sparc. > >> > >>

[FFmpeg-devel] [PATCH] library.mak: Workaround SDL redefining main and breaking fate tests on mingw

-Umain does not work as SDL adds its defines afterwards Fixes Ticket3368 Signed-off-by: Michael Niedermayer --- library.mak |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library.mak b/library.mak index 7c26024..1967a0a 100644 --- a/library.mak +++ b/library.mak @@ -33,7

Re: [FFmpeg-devel] [PATCH] vp9: don't retain NULL as segmentation_map

> Thanks for this analysis. I've pushed the patch now. > > By the way, afl [1] is really a great tool for finding such problems. > I can only recommend everyone to try it out yourself. Not to push this off-topic but can you let me know how you use afl with ffmpeg - I could never get it to work whe

Re: [FFmpeg-devel] [PATCH] vp9: don't retain NULL as segmentation_map

On 18.06.2015 23:43, Ronald S. Bultje wrote: > OK, looked further, it's actually quite complicated and I don't think > it's easy to do "the correct thing". The reason is that on frame header > error, we don't move the reference frame state forward (that's the code > in vp9_decode_frame right after

Re: [FFmpeg-devel] [PATCH] postproc: fix unaligned access

On 18.06.2015 22:26, Michael Niedermayer wrote: > On Thu, Jun 18, 2015 at 08:29:06PM +0200, Andreas Cadhalpun wrote: >> QP_store is only 8-bit-aligned, so accessing it as uint32_t causes >> SIGILL crashes on sparc. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libpostproc/postprocess.c | 5 +--

Re: [FFmpeg-devel] [PATCH] avformat: clarify what package needs to be compiled with SSL support

On Thu, Jun 18, 2015 at 08:36:19PM +0200, wm4 wrote: > Try to reduce user confusion. > --- > Why is TLS not enabled by default anyway. > --- > libavformat/avio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF

Re: [FFmpeg-devel] [PATCH] postproc: fix unaligned access

On Thu, Jun 18, 2015 at 08:29:06PM +0200, Andreas Cadhalpun wrote: > QP_store is only 8-bit-aligned, so accessing it as uint32_t causes > SIGILL crashes on sparc. > > Signed-off-by: Andreas Cadhalpun > --- > libpostproc/postprocess.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) >

Re: [FFmpeg-devel] [PATCH 01/13] lavc/adpcm: THP: handle packets with sample counts not divisible by 14

Dana 18. 6. 2015. 21:35 osoba "James Almer" napisala je: > > On 18/06/15 6:02 AM, Rodger Combs wrote: > > --- > > libavcodec/adpcm.c | 18 +- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > > index 22b5468..1b3502

Re: [FFmpeg-devel] [PATCH] vp9: don't retain NULL as segmentation_map

Hi Andreas, On Wed, Jun 17, 2015 at 11:56 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Hi Ronald, > > On 17.06.2015 20:26, Ronald S. Bultje wrote: > > On Jun 17, 2015 10:07 AM, "Andreas Cadhalpun" < > > andreas.cadhal...@googlemail.com> wrote: > >> > >> This fixes segmentati

Re: [FFmpeg-devel] [PATCH 01/13] lavc/adpcm: THP: handle packets with sample counts not divisible by 14

On 18/06/15 6:02 AM, Rodger Combs wrote: > --- > libavcodec/adpcm.c | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > index 22b5468..1b35029 100644 > --- a/libavcodec/adpcm.c > +++ b/libavcodec/adpcm.c > @@ -642,

Re: [FFmpeg-devel] [PATCH 02/13] lavc: add little-endian ADPCM_THP decoder

Dana 18. 6. 2015. 20:33 osoba "James Almer" napisala je: > > On 18/06/15 6:03 AM, Rodger Combs wrote: > > @@ -1601,6 +1611,7 @@ ADPCM_DECODER(AV_CODEC_ID_ADPCM_SBPRO_2, sample_fmts_s16, adpcm_sbpro_2, > > ADPCM_DECODER(AV_CODEC_ID_ADPCM_SBPRO_3, sample_fmts_s16, adpcm_sbpro_3, "ADPCM So

[FFmpeg-devel] [PATCH] avformat: clarify what package needs to be compiled with SSL support

Try to reduce user confusion. --- Why is TLS not enabled by default anyway. --- libavformat/avio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index deeb87f..261ff2a 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -263,7 +

Re: [FFmpeg-devel] [PATCH 02/13] lavc: add little-endian ADPCM_THP decoder

On 18/06/15 6:03 AM, Rodger Combs wrote: > @@ -1601,6 +1611,7 @@ ADPCM_DECODER(AV_CODEC_ID_ADPCM_SBPRO_2, > sample_fmts_s16, adpcm_sbpro_2, > ADPCM_DECODER(AV_CODEC_ID_ADPCM_SBPRO_3, sample_fmts_s16, > adpcm_sbpro_3, "ADPCM Sound Blaster Pro 2.6-bit"); > ADPCM_DECODER(AV_CODEC_ID_

[FFmpeg-devel] [PATCH] postproc: fix unaligned access

QP_store is only 8-bit-aligned, so accessing it as uint32_t causes SIGILL crashes on sparc. Signed-off-by: Andreas Cadhalpun --- libpostproc/postprocess.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libpostproc/postprocess.c b/libpostproc/postprocess.c index 92cc436..

Re: [FFmpeg-devel] [PATCH 10/13] lavf: add support for loop points

On Thu, 18 Jun 2015 04:03:08 -0500 Rodger Combs wrote: > --- > Changelog | 1 + > libavformat/avformat.h | 12 > libavformat/options_table.h | 2 ++ > libavformat/utils.c | 2 +- > libavformat/version.h | 2 +- > 5 files changed, 17 insertion

Re: [FFmpeg-devel] [PATCH 1/2] movtextdec.c: Improve upon dynarrays and text_to_ass

Updated patch attached. On 18-Jun-2015 2:52 PM, "Clément Bœsch" wrote: av_dynarray_add(&style_flags, &index, flag); > > +s_temp->style_flag = AV_RB8(tsmb); > > +count = i; > > > +av_dynarray_add(&s, &count, s_temp); > > missing check > >

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

Updated patch. Thanks, Niklesh movtextenc.c-Support-for-Bold-Italic-and-Underlined-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

Thanks Clement, I'll make the necessary changes. I guess there shouldn't be any alignment problem here. I have tried to take care of that. The AVBPrint buffer is initialized with max size inside mov_text_encode_init(). So, the length shouldn't be a problem. Niklesh On 18-Jun-2015 2:35 PM, "Cléme

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for qpel functions

On Sun, Jun 14, 2015 at 11:26:23PM +0530, shivraj.pa...@imgtec.com wrote: > From: Shivraj Patil > > This patch adds MSA (MIPS-SIMD-Arch) optimizations for qpel functions in new > file qpeldsp_msa.c > Adds new generic macros (needed for this patch) in > libavutil/mips/generic_macros_msa.h > > S

Re: [FFmpeg-devel] [PATCH] avcodec/fic: Add skip_cursor AVOption

On 6/18/15, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/fic.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/fic.c b/libavcodec/fic.c > index 48e7a6e..13f15d3 100644 > --- a/libavcodec/fic.c > +++ b/

Re: [FFmpeg-devel] Ability to skip cursor draw in FIC decoding

On Wed, Jun 17, 2015 at 09:38:45PM +0100, Cal Leeming wrote: > It would appear that the FIC codec will skip any errors relating to > cursor draw, but results in a lot of warnings being printed. In some > situations, the user may not even want the cursor to be drawn, and as > such it would be good t

[FFmpeg-devel] [PATCH] avcodec/fic: Add skip_cursor AVOption

Signed-off-by: Michael Niedermayer --- libavcodec/fic.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libavcodec/fic.c b/libavcodec/fic.c index 48e7a6e..13f15d3 100644 --- a/libavcodec/fic.c +++ b/libavcodec/fic.c @@ -22,6 +22,7 @@ */ #include "liba

[FFmpeg-devel] [PATCH] lavf/brstm: cleanup; fix short-block demuxing

--- libavformat/brstm.c | 77 ++--- 1 file changed, 43 insertions(+), 34 deletions(-) diff --git a/libavformat/brstm.c b/libavformat/brstm.c index e314de7..c42e9a6 100644 --- a/libavformat/brstm.c +++ b/libavformat/brstm.c @@ -30,6 +30,8 @@ typedef

[FFmpeg-devel] [PATCH] lavf/brstm: allow larger block sizes

--- libavformat/brstm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/brstm.c b/libavformat/brstm.c index 15e63b8..564be16 100644 --- a/libavformat/brstm.c +++ b/libavformat/brstm.c @@ -223,7 +223,7 @@ static int read_header(AVFormatContext *s) } b->bl

Re: [FFmpeg-devel] [PATCH 05/13] lavc/adpcm: THP: allow channel counts up to 10

Dana 18. 6. 2015. 11:04 osoba "Rodger Combs" napisala je: > > --- > libavcodec/adpcm.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > index 0228ce1..69ece18 100644 > --- a/libavcodec/adpcm.c > +++ b/libavcodec/adpcm.c > @

Re: [FFmpeg-devel] [PATCH 04/13] lavf/brstm: allow larger block sizes

Dana 18. 6. 2015. 11:04 osoba "Rodger Combs" napisala je: > > --- > libavformat/brstm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavformat/brstm.c b/libavformat/brstm.c > index 15e63b8..5dc1e2b 100644 > --- a/libavformat/brstm.c > +++ b/libavformat/brstm.c > @@ -223,8 +223,6 @@

Re: [FFmpeg-devel] [PATCH 1/2] movtextdec.c: Improve upon dynarrays and text_to_ass

On Wed, Jun 17, 2015 at 08:37:04PM +0530, Niklesh Lalwani wrote: > From: Niklesh > > This Patch uses a single dynarray instead of 3 dynarrays used before. Changes > are also done in text_to_ass() which previously failed to produce correct > results for a few specific cases. > Signed-off-by: Nik

[FFmpeg-devel] [PATCH 13/13] lavf/brstm: add FATE tests for BFSTM and BCSTM files

--- tests/fate/demux.mak | 4 tests/ref/fate/bfstm | 1 + 2 files changed, 5 insertions(+) create mode 100644 tests/ref/fate/bfstm diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak index 0eccc9b..05ce4bf 100644 --- a/tests/fate/demux.mak +++ b/tests/fate/demux.mak @@ -13,6 +13,10 @@

[FFmpeg-devel] [PATCH 12/13] lavf/brstm: expose the loop point when present

--- libavformat/brstm.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/brstm.c b/libavformat/brstm.c index b83d8d0..49f71fc 100644 --- a/libavformat/brstm.c +++ b/libavformat/brstm.c @@ -89,10 +89,11 @@ static int read_header(AVFormatContext *s) {

[FFmpeg-devel] [PATCH 08/13] lavf/brstm: cleanup; fix short-block demuxing

--- libavformat/brstm.c | 75 - 1 file changed, 39 insertions(+), 36 deletions(-) diff --git a/libavformat/brstm.c b/libavformat/brstm.c index 84c41a4..5743a07 100644 --- a/libavformat/brstm.c +++ b/libavformat/brstm.c @@ -30,6 +30,8 @@ typedef

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

On Wed, Jun 17, 2015 at 08:43:26PM +0530, Niklesh Lalwani wrote: > From: Niklesh > > Support for Bold, Italic and Underlined styles. The style information is > appended into the buffer after the text. Dynarray is used to account for > multiple style records. Tested on QuickTime OSX and iPhone.

[FFmpeg-devel] [PATCH 11/13] ffprobe: display loop points when applicable

--- ffprobe.c | 4 1 file changed, 4 insertions(+) diff --git a/ffprobe.c b/ffprobe.c index 3e5324e..d54eb87 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2436,6 +2436,10 @@ static int show_format(WriterContext *w, AVFormatContext *fmt_ctx) } print_time("start_time", fmt_ctx->st

[FFmpeg-devel] [PATCH 09/13] lavf/brstm: add support for seeking

--- libavformat/brstm.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/libavformat/brstm.c b/libavformat/brstm.c index 5743a07..b83d8d0 100644 --- a/libavformat/brstm.c +++ b/libavformat/brstm.c @@ -32,6 +32,7 @@ typedef struct BRSTMDemuxContext { uint32_tlas

[FFmpeg-devel] [PATCH 07/13] lavf/brstm: move bfstm var to a local

--- libavformat/brstm.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/libavformat/brstm.c b/libavformat/brstm.c index 5dc1e2b..84c41a4 100644 --- a/libavformat/brstm.c +++ b/libavformat/brstm.c @@ -32,7 +32,6 @@ typedef struct BRSTMDemuxContext {

[FFmpeg-devel] [PATCH 10/13] lavf: add support for loop points

--- Changelog | 1 + libavformat/avformat.h | 12 libavformat/options_table.h | 2 ++ libavformat/utils.c | 2 +- libavformat/version.h | 2 +- 5 files changed, 17 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index a5c6b82.

[FFmpeg-devel] [PATCH 05/13] lavc/adpcm: THP: allow channel counts up to 10

--- libavcodec/adpcm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 0228ce1..69ece18 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -84,7 +84,7 @@ static const int swf_index_tables[4][16] = { /* end of table

[FFmpeg-devel] [PATCH 06/13] lavc/adpcm: THP: fix indentation

--- libavcodec/adpcm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 69ece18..94b4de1 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1451,15 +1451,15 @@ static int adpcm_decode_frame(AVCodecContext *

[FFmpeg-devel] [PATCH 04/13] lavf/brstm: allow larger block sizes

--- libavformat/brstm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/brstm.c b/libavformat/brstm.c index 15e63b8..5dc1e2b 100644 --- a/libavformat/brstm.c +++ b/libavformat/brstm.c @@ -223,8 +223,6 @@ static int read_header(AVFormatContext *s) } b->block_size = read

[FFmpeg-devel] [PATCH 03/13] lavf/brstm: support little-endian files (BCSTM; 3DS)

--- Changelog | 2 +- libavformat/brstm.c | 100 2 files changed, 63 insertions(+), 39 deletions(-) diff --git a/Changelog b/Changelog index cfe3e93..a5c6b82 100644 --- a/Changelog +++ b/Changelog @@ -3,7 +3,7 @@ releases are sorted

[FFmpeg-devel] [PATCH 02/13] lavc: add little-endian ADPCM_THP decoder

--- Changelog | 1 + libavcodec/adpcm.c | 21 - libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/utils.c | 1 + libavcodec/version.h| 2 +- 7 files changed, 28 insertions(+), 6 deleti

[FFmpeg-devel] [PATCH 01/13] lavc/adpcm: THP: handle packets with sample counts not divisible by 14

--- libavcodec/adpcm.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 22b5468..1b35029 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -642,9 +642,17 @@ static int get_nb_samples(AVCodecContext *avct