[FFmpeg-devel] [PATCH] avcodec/hevc: reduce memory used by the SAO

2015-02-01 Thread Christophe Gisquet
Hi, the attached patch is somewhat of a hack job, as the commit I used may already have been edited from its original version, and I have added some stuff on top of it (eg the commit message). Thus I have signed it off. I haven't tried testing it in the edge filter case because it was a messier t

Re: [FFmpeg-devel] Post-processing filter Documentation

2015-02-01 Thread Michael Niedermayer
On Sat, Jan 31, 2015 at 02:30:29PM +0530, arwa arif wrote: > On Thu, Jan 29, 2015 at 5:18 PM, Stefano Sabatini > wrote: > > > On date Thursday 2015-01-29 03:46:42 +0530, Arwa Arif encoded: > > > I have updated the page with new images. > > > http://trac.ffmpeg.org/wiki/Postprocessing > > > > Note

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: allow to set service_type in sdt

2015-02-01 Thread Michael Niedermayer
On Sun, Feb 01, 2015 at 07:12:17PM +0200, dhead666 wrote: > --- > > patch updated with documentation. > also added what seems to me the most useful service types from en-300-468 ( > http://www.etsi.org/deliver/etsi_en/300400_300499/300468/01.11.01_60/en_300468v011101p.pdf > ). > I can drop them

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-02-01 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 12:25:13AM +0100, Andreas Cadhalpun wrote: > Hi, > > On 01.02.2015 21:50, Timothy Gu wrote: > >>If you care about that, one could also leave the 'HTML_TIMESTAMP = YES' > >>in the Doxyfile and just add 'HTML_TIMESTAMP = NO' to the doxy-wrapper. > >> > >>That way, everyone us

Re: [FFmpeg-devel] [PATCH] vorbis: parse out setup headers as well

2015-02-01 Thread Michael Niedermayer
On Sun, Feb 01, 2015 at 08:00:02PM -0500, Ben Boeckel wrote: > Prevents an 'Invalid packet' message. Currently mid-stream setup packets > are ignored. Theoretically, they could, based on the specification, be used to > reinitialize the stream if parameters change, but I don't expect that to be > co

Re: [FFmpeg-devel] [PATCH] flac: ignore IDv3 tags if vorbis tags exist

2015-02-01 Thread Ben Boeckel
On Mon, 02 Feb, 2015 at 01:10:47 GMT, James Almer wrote: >> +if (has_idv3) { >> +av_log(s, AV_LOG_WARNING, "FLAC does not support IDv3 tags.\n"); >> +} > > You could check for s->error_recognition & AV_EF_COMPLIANT and abort if true > instead of just warning. > And the message coul

Re: [FFmpeg-devel] [PATCH] flac: ignore IDv3 tags if vorbis tags exist

2015-02-01 Thread James Almer
On 01/02/15 10:00 PM, Ben Boeckel wrote: > FLAC doesn't really support IDv3 tags, so warn if they are found at all. > If vorbis tags are found, toss out the IDv3 tags. They are kept if > vorbis tags aren't found to at least have something there. > > Fixes #3799. > > Signed-off-by: Ben Boeckel >

[FFmpeg-devel] [PATCH] vorbis: parse out setup headers as well

2015-02-01 Thread Ben Boeckel
Prevents an 'Invalid packet' message. Currently mid-stream setup packets are ignored. Theoretically, they could, based on the specification, be used to reinitialize the stream if parameters change, but I don't expect that to be common (and no one seems to have asked for it). Signed-off-by: Ben Boe

[FFmpeg-devel] [PATCH] flac: ignore IDv3 tags if vorbis tags exist

2015-02-01 Thread Ben Boeckel
FLAC doesn't really support IDv3 tags, so warn if they are found at all. If vorbis tags are found, toss out the IDv3 tags. They are kept if vorbis tags aren't found to at least have something there. Fixes #3799. Signed-off-by: Ben Boeckel --- libavformat/flacdec.c | 17 + 1 file

Re: [FFmpeg-devel] [PATCH] ffplay: Fallback to dts if pts is unavailable in pkt_in_play_range calculation

2015-02-01 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 12:23:42AM +0100, Marton Balint wrote: > > On Sun, 1 Feb 2015, Michael Niedermayer wrote: > > >Signed-off-by: Michael Niedermayer > >--- > >ffplay.c |4 +++- > >1 file changed, 3 insertions(+), 1 deletion(-) > > > >diff --git a/ffplay.c b/ffplay.c > >index 72ec35d..c11

Re: [FFmpeg-devel] [PATCH 4/6] lavu/x86/x86inc: deprecate INIT_AVX

2015-02-01 Thread Michael Niedermayer
On Fri, Sep 05, 2014 at 12:13:36AM +0200, James Darnley wrote: > The same can be done with INIT_XMM avx > --- > libavutil/x86/x86inc.asm |8 > 1 files changed, 0 insertions(+), 8 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC78704

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-02-01 Thread Andreas Cadhalpun
Hi, On 01.02.2015 21:50, Timothy Gu wrote: If you care about that, one could also leave the 'HTML_TIMESTAMP = YES' in the Doxyfile and just add 'HTML_TIMESTAMP = NO' to the doxy-wrapper. That way, everyone using the doxy-wrapper gets a reproducible output (with the git revision) and nothing cha

Re: [FFmpeg-devel] [PATCH] ffplay: Fallback to dts if pts is unavailable in pkt_in_play_range calculation

2015-02-01 Thread Marton Balint
On Sun, 1 Feb 2015, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- ffplay.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ffplay.c b/ffplay.c index 72ec35d..c112ead 100644 --- a/ffplay.c +++ b/ffplay.c @@ -2881,6 +2881,7 @@ static int read_thread(v

Re: [FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2015-02-01 Thread Michael Niedermayer
On Sun, Feb 01, 2015 at 05:24:56PM -0500, Ronald S. Bultje wrote: > Hi, > > On Sun, Feb 1, 2015 at 4:26 PM, Christophe Gisquet < > christophe.gisq...@gmail.com> wrote: > > > 2014-09-05 9:59 GMT+02:00 Christophe Gisquet > >: > > > I haven't yet had time to investigate where the problem is. Probab

Re: [FFmpeg-devel] [PATCH 3/3] hevc/sao: use aligned copies

2015-02-01 Thread Michael Niedermayer
On Sun, Feb 01, 2015 at 07:44:49PM -0300, James Almer wrote: > On 01/02/15 7:27 PM, Michael Niedermayer wrote: > > On Sun, Feb 01, 2015 at 08:54:44PM +0100, Mickaël Raulet wrote: > >> something like this. > >> > >> https://github.com/OpenHEVC/openHEVC/commit/5d9f79edef2c11b915bdac3a025b59a32082f409

Re: [FFmpeg-devel] [PATCH 3/3] hevc/sao: use aligned copies

2015-02-01 Thread James Almer
On 01/02/15 7:27 PM, Michael Niedermayer wrote: > On Sun, Feb 01, 2015 at 08:54:44PM +0100, Mickaël Raulet wrote: >> something like this. >> >> https://github.com/OpenHEVC/openHEVC/commit/5d9f79edef2c11b915bdac3a025b59a32082f409 > > should we try to apply this one ? > > also we should reduce the

Re: [FFmpeg-devel] [PATCH 3/3] hevc/sao: use aligned copies

2015-02-01 Thread Christophe Gisquet
Hi, 2015-02-01 23:27 GMT+01:00 Michael Niedermayer : > On Sun, Feb 01, 2015 at 08:54:44PM +0100, Mickaël Raulet wrote: >> something like this. >> >> https://github.com/OpenHEVC/openHEVC/commit/5d9f79edef2c11b915bdac3a025b59a32082f409 > > should we try to apply this one ? I'm in the process of doi

Re: [FFmpeg-devel] [PATCH 3/3] hevc/sao: use aligned copies

2015-02-01 Thread Michael Niedermayer
On Sun, Feb 01, 2015 at 08:54:44PM +0100, Mickaël Raulet wrote: > something like this. > > https://github.com/OpenHEVC/openHEVC/commit/5d9f79edef2c11b915bdac3a025b59a32082f409 should we try to apply this one ? also we should reduce the differences to openhevc, are there any other changes which w

Re: [FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2015-02-01 Thread Ronald S. Bultje
Hi, On Sun, Feb 1, 2015 at 4:26 PM, Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > 2014-09-05 9:59 GMT+02:00 Christophe Gisquet >: > > I haven't yet had time to investigate where the problem is. Probably > PEBKAC > > It was PEBKAC. > > The patch was commited to x264 in August 2014:

Re: [FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2015-02-01 Thread Christophe Gisquet
2014-09-05 9:59 GMT+02:00 Christophe Gisquet : > I haven't yet had time to investigate where the problem is. Probably PEBKAC It was PEBKAC. The patch was commited to x264 in August 2014: https://github.com/MasterNobody/x264/commit/73b8686fc22c9247d90963983d406cd7b9131068 Could we merge it? --

Re: [FFmpeg-devel] [PATCH 3/3] hevc/sao: use aligned copies

2015-02-01 Thread Christophe Gisquet
Hi, 2015-02-01 20:54 GMT+01:00 Mickaël Raulet : > something like this. > > https://github.com/OpenHEVC/openHEVC/commit/5d9f79edef2c11b915bdac3a025b59a32082f409 If I understand correctly, SAO EO needs data from before SAO on top and left. I had hoped something simpler than this. Nice that the abov

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-02-01 Thread Timothy Gu
On Sun Feb 01 2015 at 9:47:12 AM Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Hi, > > On 01.02.2015 18:30, Timothy Gu wrote: > > On Sun Feb 01 2015 at 9:01:04 AM Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > >> On 01.02.2015 16:44, Michael Niedermayer wrote:

Re: [FFmpeg-devel] [PATCH 3/3] hevc/sao: use aligned copies

2015-02-01 Thread Mickaël Raulet
something like this. https://github.com/OpenHEVC/openHEVC/commit/5d9f79edef2c11b915bdac3a025b59a32082f409 Mickaël 2015-02-01 20:37 GMT+01:00 Christophe Gisquet : > Hi, > > 2015-02-01 20:00 GMT+01:00 James Almer : > > From: Christophe Gisquet > > > > For band filter, source and destination are

Re: [FFmpeg-devel] [PATCH 3/3] hevc/sao: use aligned copies

2015-02-01 Thread Christophe Gisquet
Hi, 2015-02-01 20:00 GMT+01:00 James Almer : > From: Christophe Gisquet > > For band filter, source and destination are aligned (except for 16x16 ctbs), > and otherwise, they are most often aligned. Overall, the total width is also > too small for amortizing memcpy. There's probably much better

Re: [FFmpeg-devel] [PATCH 1/3] x86/hevc: add ff_hevc_sao_band_filter_{8, 10, 12}_{sse2, avx, avx2}

2015-02-01 Thread Christophe Gisquet
Hi, 2015-02-01 20:00 GMT+01:00 James Almer : > Original x86 intrinsics code and initial 8bit yasm port by Pierre-Edouard > Lepere. > 10/12bit yasm ports, refactoring and optimizations by James Almer Good for me, the biggest change being unrolling, which helps the x86_32 port. Best regards, Chri

Re: [FFmpeg-devel] [PATCH 3/3] x86/hevc: add ff_hevc_sao_band_filter_{8, 10, 12}_{sse2, avx2}

2015-02-01 Thread James Almer
Posted an unrolled version in a new thread, alongside a few patches by Christophe. On 30/01/15 3:50 PM, James Almer wrote: > Original x86 intrinsics code and initial 8bit yasm port by Pierre-Edouard > Lepere. > 10/12bit yasm ports, refactoring and optimizations by James Almer > > Benchmarks of

[FFmpeg-devel] [PATCH 2/3] x86: hevc/sao: aligned source buffers

2015-02-01 Thread James Almer
From: Christophe Gisquet Usefull for at least band filter, for which: - Band filter call only: 32 64 Before: 1655654015 After: 1649752355 - Whole case: 32 64 Before: 37031 103008 After: 3204593952 --- libavcodec/hevc.c | 6 +++--- li

[FFmpeg-devel] [PATCH 3/3] hevc/sao: use aligned copies

2015-02-01 Thread James Almer
From: Christophe Gisquet For band filter, source and destination are aligned (except for 16x16 ctbs), and otherwise, they are most often aligned. Overall, the total width is also too small for amortizing memcpy. Timings (using an intrinsic version of edge filters): B/32 B/64 E/

[FFmpeg-devel] [PATCH 1/3] x86/hevc: add ff_hevc_sao_band_filter_{8, 10, 12}_{sse2, avx, avx2}

2015-02-01 Thread James Almer
Original x86 intrinsics code and initial 8bit yasm port by Pierre-Edouard Lepere. 10/12bit yasm ports, refactoring and optimizations by James Almer Benchmarks of BQTerrace_1920x1080_60_qp22.bin with an Intel Core i5-4200U width 32 40338 decicycles in sao_band_filter_0_8, 2048 runs, 0 skips 8056

[FFmpeg-devel] [PATCH] avcodec/wavpackenc: remove unneeded L suffixes

2015-02-01 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/wavpackenc.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/wavpackenc.c b/libavcodec/wavpackenc.c index 63971c6..c174950 100644 --- a/libavcodec/wavpackenc.c +++ b/libavcodec/wavpackenc.c @@ -640,9 +640,

Re: [FFmpeg-devel] [PATCH 2/3] hevcdsp: replace the SAOParams struct parameter from sao_band_filter

2015-02-01 Thread James Almer
On 30/01/15 4:46 PM, Michael Niedermayer wrote: > On Fri, Jan 30, 2015 at 03:50:13PM -0300, James Almer wrote: >> Pass instead the two variables from the struct needed in the function. >> This simplifies writing asm optimized versions of the function >> >> Signed-off-by: James Almer >> --- >> lib

Re: [FFmpeg-devel] [PATCH 1/3] hevcdsp: remove unused parameter from sao_band_filter

2015-02-01 Thread James Almer
On 30/01/15 4:34 PM, Michael Niedermayer wrote: > On Fri, Jan 30, 2015 at 03:50:12PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/hevc_filter.c | 7 ++- >> libavcodec/hevcdsp.h | 3 +-- >> libavcodec/hevcdsp_template.c | 3 +-- >> 3 files changed,

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-02-01 Thread Andreas Cadhalpun
Hi, On 01.02.2015 18:30, Timothy Gu wrote: On Sun Feb 01 2015 at 9:01:04 AM Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: On 01.02.2015 16:44, Michael Niedermayer wrote: doxygen doc/Doxyfile would lack the revission Yes, one has to use the doxy-wrapper to get the revision: do

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-02-01 Thread Timothy Gu
On Sun Feb 01 2015 at 9:01:04 AM Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Hi, > > On 01.02.2015 16:44, Michael Niedermayer wrote: > > On Sat, Jan 31, 2015 at 11:18:26PM +0100, Andreas Cadhalpun wrote: > >> One can include the git revision in the PROJECT_NUMBER, e.g. with > >>

[FFmpeg-devel] [PATCH] libavformat/mpegtsenc: allow to set service_type in sdt

2015-02-01 Thread dhead666
--- patch updated with documentation. also added what seems to me the most useful service types from en-300-468 ( http://www.etsi.org/deliver/etsi_en/300400_300499/300468/01.11.01_60/en_300468v011101p.pdf ). I can drop them and leave only digital_tv and digital_radio but if we follow the standa

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-02-01 Thread Andreas Cadhalpun
Hi, On 01.02.2015 16:44, Michael Niedermayer wrote: On Sat, Jan 31, 2015 at 11:18:26PM +0100, Andreas Cadhalpun wrote: One can include the git revision in the PROJECT_NUMBER, e.g. with attached patch. this works for generating the doxy for the headers only (make doc/doxy/html) doxygen doc/D

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-02-01 Thread Michael Niedermayer
On Sat, Jan 31, 2015 at 11:18:26PM +0100, Andreas Cadhalpun wrote: > Hi, > > On 31.01.2015 22:36, Michael Niedermayer wrote: > >On Sun, Jan 25, 2015 at 09:25:07PM +0100, Andreas Cadhalpun wrote: > >>diff --git a/doc/Doxyfile b/doc/Doxyfile > >>index 8697e6c..5d18b10 100644 > >>--- a/doc/Doxyfile >

[FFmpeg-devel] [PATCH] libavformat/mpegtsenc: allow to set service_type in sdt

2015-02-01 Thread dhead666
--- Clément, how about this? I only added these few as they seems the most usefull, though maybe I'll just drop teletext? doc/muxers.texi | 3 +++ libavformat/mpegtsenc.c | 19 ++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/doc/muxers.texi b/doc/muxer

[FFmpeg-devel] [PATCH] avutil/mem: replace remaining void **/*** casts by memcpy()

2015-02-01 Thread Michael Niedermayer
This is similar to 60392480181f24ebf3ab48d8ac3614705de90152 Signed-off-by: Michael Niedermayer --- libavutil/mem.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/libavutil/mem.c b/libavutil/mem.c index 155569e..5fd2395 100644 --- a/libavutil/mem.c +++

Re: [FFmpeg-devel] [PATCH 5/6] avfilter: add paletteuse filter

2015-02-01 Thread Clément Bœsch
On Fri, Jan 30, 2015 at 11:42:54AM -0500, Calvin Walton wrote: > On Tue, 2015-01-27 at 14:20 +0100, Clément Bœsch wrote: > > On Sun, Jan 25, 2015 at 07:55:22PM +0100, Clément Bœsch wrote: > > > --- > > > doc/filters.texi| 31 + > > > libavfilter/Makefile| 1 + > > > liba

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: allow to set service_type in sdt

2015-02-01 Thread Clément Bœsch
On Sun, Feb 01, 2015 at 04:19:22AM +0200, dhead666 wrote: > --- > > @TimothyGu thanks for all your help, I hope this is now fine. > > doc/muxers.texi | 3 +++ > libavformat/mpegtsenc.c | 6 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/doc/muxers.texi b/doc/m