[PATCH] Prevent displayed images from being re-scaled

atch attached. All the best, Timothy >From 9c34dd6aba62d734f6ae9aecaffa76a0250bf495 Mon Sep 17 00:00:00 2001 From: TEC Date: Wed, 29 Sep 2021 21:29:27 +0800 Subject: [PATCH] org: Don't change image size based on font size * lisp/org.el (org--create-inline-image): When `create-image' is calle

Re: [PATCH] Treat :tangle-mode as an octal value not integer

nt to #o544) I think as long as it’s clear what’s intended, and it’s not some home-baked non-standard format, or terribly annoying to support — why not? All the best, Timothy

Re: [PATCH] Treat :tangle-mode as an octal value not integer

",g=" (substring mode 3 6) ",a=" (substring mode 6 9)) org-tangle-default-mode)) (t (user-error "File mode %S not recognised as a valid format." mode #+end_src -- Timothy

Re: Grabbing the link to a message on the archive

d_src I expect this could be adapted to other clients (notmuch, gnus, etc.) without much trouble :) #+begin_signature All the best,\\ @@html:@@Timothy@@html:@@ #+end_signature

[PATCH] Don't fill displayed equations

n for this change is fairly clear, and so without feedback I intend to push this in a few days, however I if anybody has comments on the way I’m currently implementing this, I’d like to hear your thoughts. All the best, Timothy >From d008ff3c2218e19bb501137715b05e06a0c511e3 Mon Sep 17 00:00:

Re: [PATCH] Don't fill displayed equations

The initial patch was just slightly off. Here's a correct version. Timothy writes: > As such, I have attached a patch which adds fill “cuts” around `\[' and > `\]', when `\[' occurs at the start of a line. This leaves the display > equation > deli

Re: [PATCH] Treat :tangle-mode as an octal value not integer

Hi Jeremy, > I love it! Much better than my proposed patch. I’m about to send a patch based on my snippet, so I’m marking this patch as cancelled. All the best, Timothy

[PATCH] Accept more :tangle-mode specification forms

introducing ambiguity in parsing or interpretation (and I think we can), can’t we make everyone happy? All the best, Timothy [prior thread] <https://list.orgmode.org/20210928145448.245883-1-jer...@cowgar.com/> >From 5087de0d70151c33d66eb13dda84d78a361d7053 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] Don't fill displayed equations

{equation*}...\end{equation*}, which will not be filled. Given that \[ ... \] is an alias for \begin{equation*} ... \end{equation*} I don't see why it should be treated any differently when filling. -- Timothy

Re: [PATCH] Don't fill displayed equations

constructs in Org to be consistent with LaTeX? -- Timothy

Re: [PATCH] Don't fill displayed equations

org-latex-preview, wrapped `\[ ... \]' blocks join lines, resulting in lines that are displayed going off edge of the page after filling. Basically, this leads to a worse experience when using Org in what I would think to be a perfectly reasonably way. All the best, Timothy

Re: [PATCH] Accept more :tangle-mode specification forms

orter (or #o0600). Perhaps, but I personally find it easier to interpret “rwxr-xr–” for example than “(or #o754)”, and I feel quite confident in guessing that a. I’m not alone b. Nobody that understands “#o754” will have difficult understanding “rwxr-xr–” All the best, Timothy

Re: [PATCH] Don't fill displayed equations

Nicolas Goaziou writes: > Timothy writes: > >> I think there are also some relevant points which I haven’t mentioned so far, >> separate from my thoughts that since we’re using the LaTeX syntax we should >> be >> consistent with how LaTeX treats this. >

Re: [orgweb] Making the git repo URL more visible

it on the homepage, but I’m also wary of clutter, and I’m hoping that the use of the common Git branch icon may clue devs into thinking that the repository is linked/given on that page. Do you have any thoughts on that? All the best, Timothy

Re: Visibility cycling with inline tasks 2

Just marking this as a patch for :)

Re: [PATCH] Accept more :tangle-mode specification forms

7; and `file-modes-symbolic-to-number' Maybe with (if anybody says they would like this) • #o755 (elisp octal) • 0755 (C octal) • “rwx” = user perm, bit-or’d with `org-babel-tangle-default-mode' for the rest (i.e. `org-babel-tangle-default-mode', but not exceeding the user perm) All the best, Timothy

Re: [orgweb] Making the git repo URL more visible

Hi Bastien, > Done, let me know if it’s good enough. Just 2c from me, I’d be tempted to have put that on the contribute page ¯\_(ツ)_/¯. All the best, Timothy

Re: [orgweb] Making the git repo URL more visible

nfamiliar. Perhaps we could like to the org-contrib and website repos as well there? All the best, Timothy

Re: [Worg] Proposing a few CSS changes

Hi Adam, >From the last few messages in this thread, I think we’ve reached agreement on the changes. Would you like to go ahead? All the best, Timothy

Re: [orgweb] Making the git repo URL more visible

Hi Adam, > Sounds good to me. Thanks :) it’s nice to get a second opinion. All the best, Timothy

Re: [PATCH] Don't fill displayed equations

\]' specially in if we want ’sensible’ behaviour — as I mention in my reply to Nicolas, we’re already parsing it differently to other inline markup… All the best, Timothy * However, I am not advocating for this: There’s both the obvious comparability issue, but I also rather like using `\[ ... \]' myself.

Re: [PATCH] Don't fill displayed equations

er fully LaTeX-y or fully Org-y. I still think it would be good to improve this, but I no longer have such a firm idea that “modifying fill is the way”. All the best, Timothy

Re: [Worg] Proposing a few CSS changes

to stand out enough as the page heading when it was also green. The contrast looks good to me 👍. All the best, Timothy

Re: [PATCH] Don't fill displayed equations

that would be appreciated. > I guess one thing I’m missing/not understanding is when/why people > want to use instead of full #+begin_export latex block? org-latex-preview :) All the best, Timothy

Re: org-latex-preview and latex export blocks

on, or something one would want to preview. This separation is also useful for packages like org-fragtog, which auto-toggles equations[1] previews on cursor entry/exit. Basically, LaTeX export blocks and maths are (in my view) two different things, even if both use LaTeX syntax. All the best, T

Re: [PATCH] Prevent displayed images from being re-scaled

Hi All, I intend to push this in the next few days, assuming I don’t get any feedback. All the best, Timothy

Re: [PATCH] Prevent displayed images from being re-scaled

Bastien writes: > Nitpick: I suggest shortening the ChangeLog part like this: > *snip* > The ChangeLog part should not be too verbose, you can add explanations > after it. Thanks Bastien, I’ll use that message when I push the commit 👍. All the best, Timothy

Re: [PATCH] Fontification for inline src blocks

an that, this all works fantastically as far as I can tell from a few months of usage of my branch of Org 🙂. -- Timothy

Re: [PATCH] Don't fill displayed equations

or different > elements. Thanks for that idea. Perhaps something along those lines may be the best solution here. If we don’t want to make the whole function modular, perhaps we could make a setting for this? All the best, Timothy

Re: [PATCH] Don't fill displayed equations

ce for users. Mmmm, I’m with you on this in general. I also think the code base has far too many monolithic “200 line” functions which are crying out to be split up. Now if I could just clone myself once or twice… 😛 All the best, Timothy

Re: [PATCH] Fontification for inline src blocks

ss if `point' is before or after a markup character). All the best, Timothy

Re: [PATCH] Don't fill displayed equations

Hi Ihor, > Then would you mind proposing a patch for org-fill-element in > particular? At least, you seem to have a motivation for this particular > function ;) Perhaps in a few weeks, for now I’m a bit to busy for anything other than “accidental” 😛 patches. All the best, Timothy

Re: Cannot clone org-mode's git repository

Hi Colin, > I get a strange error when I try to clone org-mode: Interesting, I just tried `git clone git://git.sv.gnu.org/emacs/org-mode.git' and that seemed fine. All the best, Timothy

Re: Inequalities in math blocks

rt. Perhaps, it is possible to define a filter. You’re going to be much better off if you just use LaTeX math delimiters, i.e. `\( ... \)'. All the best, Timothy

Re: ox-slimhtml

rop-in replacement for > “ox-html”. Otherwise, users will miss out many features. Of course, we > could ship two competing HTML export back-ends, but I don’t think that’s > a good idea either. > > So, it is meant for inclusion in Org proper, or as a GNU ELPA package? > I don’t know. May

Re: Org mode web site

Hi Thomas, > I’m seeing what looks like a spurious headline: Elaboration + demo image > ignore Thanks, that is indeed spurious. “ignore” is the tag :ignore: but it seems like the ox-extra that makes :ignore: work isn’t being loaded any more. All the best, Timothy

Re: [PATCH] Don't fill displayed equations

pi} \log \cos \left( > │ \frac{\pi}{4} \right) = - \frac{2D}{\pi} \log 2^{-\frac{1}{2}} = > \frac{D}{\pi} \log 2. > │ \] The complete solution for \(\tilde{y}\) is hence, \[ \tilde{y} = > \frac{2D}{\pi} \log \cos > │ \left( \pi \frac{D-2x}{4D} \right) + \frac{D}{\pi} \log 2. \] > └ -- Timothy

Re: New HTML exporter (was a feature request)

ke a look. All the best, Timothy

Re: [PATCH] Don't fill displayed equations

g like a list of cons cells where the car is a regexp matching the start of the “don’t touch” region and the cdr a regexp matching the end. All the best, Timothy

Re: Org lint and named source blocks

rhaps a dialog with them could be productive? All the best, Timothy

Bare oc-csl author variants?

" "bf") '(:mode author-only :suppress-affixes t :ignore-et-al t)) │((or "caps-full" "cf") '(:mode author-only :capitalize-first t :ignore-et-al t)) │((or "bare-caps-full" "bcf") '(:mode author-only :suppress-affixes t :capitalize-first t :ignore-et-al t)) │(_ '(:mode author-only └ All the best, Timothy

Re: Inequalities in math blocks

X and Org 🙂. You might be able to use `org-element-map' to robustly convert from $ … $= to `\( ... \)'. All the best, Timothy

Re: Bare oc-csl author variants?

basically just using this as a way to insert the author’s name without any chance of typos. Some thing was introduced in Doe (2019), and some comments about it. To demonstrate X, Doe considers … which allows Doe to …. All the best, Timothy

Re: Bare oc-csl author variants?

Hi All, Sounds like the general attitude is “why not?”. So I’ve turned my snippet into a patch and unless any concerns are raised in the next few days I’ll push it to main. All the best, Timothy >From 88f8bb7bc8726c20f3cdd4e8d47d1b487b1c2cd7 Mon Sep 17 00:00:00 2001 From: TEC Date: Tue, 5

Re: [PATCH] Accept more :tangle-mode specification forms

is) > • #o755 (elisp octal) > • 0755 (C octal) > • “rwx” = user perm, bit-or’d with `org-babel-tangle-default-mode’ for the > rest > (i.e. `org-babel-tangle-default-mode’, but not exceeding the user perm) All the best, Timothy

Re: [PATCH] Accept more :tangle-mode specification forms

ommit. All the best, Timothy

Re: Inequalities in math blocks

Hi Greg, > oof. ... is the way to go. I’m thinking we should perhaps update the docs to more strongly recommend `\( ... \)' over `$ ... $'. So that someone coming from say, Markdown + $-math or (not-La)TeX doesn’t just go “cool, $ works, I’ll keep on using that”. All the best, Timothy

Re: Inequalities in math blocks

t; and &rt;. As the maintainer for ox-html, I’ll take a look at this. I am exceptionally busy over the next few weeks though, so there may be a brief delay. All the best, Timothy

Useful package? Compat.el

pports Emacs 24.3 and newer with compat.el. Just tossing this out as an idea :) All the best, Timothy

Re: Useful package? Compat.el

ion of Emacs. Not sure how this would best be done, but if this were to be useful, this is how I’d imagine it working. All the best, Timothy

Re: [PATCH] Rename headline to heading

t attempt towards the goal. All the best, Timothy

Re: [BUG] Inline images cannot be displayed [9.5 (release_9.5-108-g93132c @ /tmp/org-mode/lisp/)]

Hi Bhavin, > Confirmed > > I was able to reproduce this with the latest main branch. It works fine with > attributes like this: > > #+attr_org: :width 500px > > And the 9.5 tag does not have this bug, so I think this might be related to > recent changes to image widt

Re: citeproc-style-parse: Symbol’s function definition is void: libxml-parse-xml-region

Hi Joseph, The function libxml-parse-xml-region has been around for a while, what version of Emacs are you running? All the best, Timothy

Re: Shower thought: submit an IETF RFC to register Org as a MIME type

Hi Carlos, Just a minor point from me, this really should be a new thread IMO. While not much may have happened with the IETF RFC, it’s still something on my mind that I hope to get back to eventually. All the best, Timothy

Re: Bare oc-csl author variants?

Pushed as 7111ee7c.

Re: [PATCH] Prevent displayed images from being re-scaled

It’s been quite a few days, so I’ve just pushed this as 9dc08c9.

Re: Introducing Org-transclusion

an issue. All the best, Timothy

Re: Introducing Org-transclusion

ded alongside less-essential features like `#+plot'. All the best, Timothy

Re: Subject: [PATCH] Fix DISPLAY error on exporting org with plantuml to html

change and merge the patch. All the best, Timothy

Re: [BUG] org-mode binds C-c C-TAB, which seems illegal [9.5 (9.5-g0a86ad @ /home/il/.config/emacs/elpa/org-9.5/)]

I think that the two actions we may want to take here are: 1. Replace "C-TAB" with "C-" in the keybinding 2. Change the keybinding to something else that doesn't use control+tab for instance, "C-c M-TAB" seems to be available. Which option seems preferable? -- Timothy

Re: [PATCH] org-manual.org: org-cite additions

Hi Bruce, Thanks for this patch. I've had a read through and it all looks good to me. I've just applied this with minor tweaks as 30dbfc6. > This is a minor patch to address the most obvious missing pieces that > have confused people. -- Timothy

Re: [BUG] require org-macs at compile time [9.5 (9.5-g0a86ad @ /home/phil/.emacs.d/elpa/org-9.5/)]

Hi Phil, > The macro `org-dlet' is not expanded in file org-agenda.el at compile > time when installing Org 9.5 from ELPA. How does this issue manifest? I tried byte-compiling org-agenda.el and didn't see any errors/warnings. -- Timothy

Re: [PATCH] Accept more :tangle-mode specification forms

u+x :tangle t3.txt this works #+end_src #+begin_src text :tangle-mode rw-r--r-- :tangle t4.txt this works #+end_src #+begin_src text :tangle-mode hey :tangle t5.txt invalid, error message given #+end_src -- Timothy

Re: [PATCH] ob-R async evaluation

plication/pdf; 0001-ob-R.el-Patch-4-async-evaluation.patch]... -- Timothy

Re: [PATCH] Treat :tangle-mode as an octal value not integer

Just removing this from updates.orgmode.org.

Re: [PATCH] org.el (org-display-inline-image--width): Small fix

Just marking this patch as applied for updates.orgmode.org. Nicolas Goaziou writes: > Hello, > > Sébastien Miquel writes: > >> Subject: [PATCH] org.el (org-display-inline-image--width): Small fix > > I expounded the commit message and applied your patch. Thank you. > > Regards,

Re: [PATCH] Accept more :tangle-mode specification forms

the implementation to handle :tangle-mode o755, which will make org-babel-parse-header-arguments parse the argument as a string. I’m be keen to hear other people’s thoughts on this. All the best, Timothy

Re: [PATCH] Accept more :tangle-mode specification forms

but am open to other suggestions. All the best, Timothy

Re: [PATCH] Accept more :tangle-mode specification forms

e entering “just a number” expecting > for it to be read as octal is too high. Is it worth the risk? I’ve just pushed three commits that 1. Add “o555” as an octal shorthand 2. Perform a simple check that integer modes are valid* 3. Make the ls-style regex stricter > Timothy, I really admire you

[Aside] Generating commit messages for Org

mit is <https://github.com/tecosaur/emacs-config/commit/d1e3042a>). Another thought I’ve had is a commit lint function for flycheck to check some extra things (two spaces after sentences, commit subject starting with a capital letter, etc.), but I haven’t looked into that at all. All the best, Timothy

Re: [PATCH] Accept more :tangle-mode specification forms

eading 'o' as a '0', missing the point > it is an octal value not a decimal one. However, this seems like a low > risk, so I'm happy either way. Well, I've got "o" for now but that's not set in stone. With a lower case "o" I feel the risk for confusion with "0" is quite low (besides which a "0" prefix seems to be the C-style for octal anyway). All the best, Timothy

Re: [PATCH] Accept more :tangle-mode specification forms

actually affected by my recent changes) and my concerns are with the viability of the necessary changes rather than whether this would be good (we are of the same mind I think). All the best, Timothy

Re: [PATCH] org-src: Reset buffer-modified-p after fontifying

tch; > 0001-org-src-Reset-buffer-modified-p-after-fontifying.patch]... -- Timothy

Dodgy Worg publishing? (was: [patch] Fix link to Library of Babel)

ing link used on Worg. All the best, Timothy

Re: [PATCH] Fontification for inline src blocks

ilaos’ comments on making some new faces deserve consideration, but could easily be done subsequently, as I’m quite keen to get this merged for now. All the best, Timothy >From 53d2851e248c4f4e4076878a999cbf647b401578 Mon Sep 17 00:00:00 2001 From: TEC Date: Tue, 13 Jul 2021 02:43:29 +0800 Subject: [PA

Re: [PATCH] Accept more :tangle-mode specification forms

ee if the ls -l format is fit for purpose or not. I think it will be, but correctness is of course more important than niceness. >> [sticky bits and the ls -l format] > > This is very difficult Timothy. I really do appreciate all the work you > have done here and your patience, wh

Re: [PATCH] Fix window width when line numbers present

nt. As such, I’ve just applied your patch as cd3e138, tweaking the commit message to no longer go over the maximum length :) Looking at the docstring for `line-number-display-width', it seems that the pixelwise mode may be more useful for our purposes, but that improvement can be in a subsequent patch. All the best, Timothy

Re: [PATCH] Fix window width when line numbers present

Oops, I forgot to mark this patch as applied for updates.orgmode.org. Done in this message.

Re: [PATCH] Fix regex for determining image width from attribute

ow if there are any good examples of unintended / counter-intuitive behaviour you’re aware of. All the best, Timothy * Well, it’s worked this way for a while, and I made a deliberate choice to keep this behaviour when expanding the width to recognise proportional values.

Re: [PATCH] Fix window width when line numbers present

er-display-width 'line-number-display-width) │ (defun org-line-number-display-width (&rest _) 0)) └ in org-compat.el, but I think that fallback definition could be improved — even just `(or display-line-numbers-width 0)' would be better. All the best, Timothy

Re: [PATCH] Fix window width when line numbers present

<https://orgmode.org/worg/org-maintenance.html#emacs-compatibility>. All the best, Timothy

Re: Dodgy Worg publishing?

zg/job/627192#task-install-784> > > “Reference `fibs’ not found in this buffer” > > Can someone have a look at this and fix the ref? I’ve just pushed b837a85 which just defines fibs using the content of the example block. This may not be the best fix long-term, but should make it work. All the best, Timothy

Supported Emacs version (was: [PATCH] Fix window width when line numbers present)

ompat.el and notice that we still have code for Emacs < 24.4 compatibility. I’m tempted to make some patches to remove all the Emacs < 26 compatibility code if we no longer need it. What do you think? All the best, Timothy

Re: Supported Emacs version

really have is whether it’s better to provide /partial/ support for older versions of Emacs? Personally I’m more inclined towards an all-or-nothing approach. All the best, Timothy

Re: Supported Emacs version

or leaving those bit in. Thanks for discussing this a bit :) All the best, Timothy

Re: [PATCH] Fix regex for determining image width from attribute

; unless a specific setting is made for that backend. Hmmm, I’m not sure this is called for. All the best, Timothy

Re: [PATCH] Fontification for inline src blocks

just adds this face. I feel like this might be the final version of this patch so I’d appreciate thoughts on this. All the best, Timothy >From 133b7a90853f7f9062bae40af2efc8fd22781125 Mon Sep 17 00:00:00 2001 From: TEC Date: Tue, 13 Jul 2021 02:43:29 +0800 Subject: [PATCH] org-src: Implement

Re: [PATCH] Fontification for inline src blocks

face nil)) >> +(font-lock-append-text-property pt (1+ pt) ’face ’(org-block >> shadow)) > > Do you really intend to use ’org-block and ’shadow faces here? Not > ’org-inline-src-block? Ah, that was an oversight. Thanks for catching that, changed to `(org-inline-s

Re: [PATCH] Fontification for inline src blocks

> need to re-implement the parser. Perhaps. However frankly I don’t think it would do that much to reduce the complexity, and what’s in this patch seems to work fairly nicely. All the best, Timothy

Re: [PATCH] Fix regex for determining image width from attribute

Hi Matt, I’ve just pushed the change I described in 4514a32. This improves the interpretation of :width attributes and makes a value of “t” work as discussed. I have not prioritised #+attr_org for now, but that sounds like a change we could make in the future. All the best, Timothy

Worg's library-of-babel.org (was: Dodgy Worg publishing?)

"Thomas S. Dye" writes: > I checked this morning and I still get a 404 error when I follow the Worg link > in section 16.12 of the Org mode manual at orgmode.org. (sigh) I already fixed a 2nd issue, it looks like there's at least a 3rd... -- Timothy

Re: [QUESTION] How to specific image size attributes under headline scope?

Hi Christopher, > I want to specify image size under headline properties. Is it possible to do > this? As I understand org.el, this is solely governed by `org-display-inline-image--width', which only looks at `#+attr_*' keywords when setting an image width. All the best, Timothy

Re: [PATCH] ob-shell-test, test-ob-shell and introduction

It wasn’t clear to me how to send > along > a message with git send-email, so I formatted these patches and included them > as > an attachment. Is that fine? Patches attached to an email are perfectly fine here. Thanks for getting in touch, and I hope to see you around 🙂. All t

Re: Invalid read syntax errors compiling orgmode from git repository

Hi Kyle, > Timothy, please look over my change to confirm that it matches the > change you intended to make in 4514a324c. I’ve just become aware that a paren slipped out of that commit. I’m currently writing the commit message on a correction. Expect to see it pushed in a minute or two :

Re: Invalid read syntax errors compiling orgmode from git repository

Hi Kyle, >> Timothy, please look over my change to confirm that it matches the >> change you intended to make in 4514a324c. > > I’ve just become aware that a paren slipped out of that commit. I’m currently > writing the commit message on a correction. Expect to see it pushe

Re: [PATCH] Fix regex for determining image width from attribute

Hi Matt, This issue and Kyle’s change were resolved in another thread, just FYI this is fixed now. Thanks for mentioning it. All the best, Timothy

Re: [PATCH] Fix regex for determining image width from attribute

Hi Matt, (sigh) well that’s silly. Thanks, I’ve just pushed that. All the best, Timothy

Re: Why is an image width restricted to being between 0 and 200% of the text area

ust prevents them from being previewed at 5x the buffer text width as that seems a bit ridiculous. Happy to reconsider the [0,2] preview restriction, but I don’t think ridiculously large in-buffer images make much sense. All the best, Timothy

Re: Why is an image width restricted to being between 0 and 200% of the text area

area width! I suppose the exception would be say something like ┌ │ #+attr_org: :width 300% └ Though I can’t imagine why you’d want that… I think you don’t raise an unreasonable point, however I’m tempted to let this sit till we hear from someone who actually runs into this as an issue. All the best, Timothy

Re: [Aside] Generating commit messages for Org

. All the best, Timothy

  1   2   3   4   5   6   7   >