Re: Multiline list entries / Is auto-fill-mode in org(roam) usual?

2022-04-04 Thread Ihor Radchenko
c.bu...@posteo.jp writes: > Am 04.04.2022 06:06 schrieb Ihor Radchenko: >> A list item continues until >> there are _2_ blank lines or until the subsequent line is not indented >> >= >> current list item indentation: > > Intereseting. What 2 lines not 1 l

Re: Ethical problems with MathJax as default - Was: Faulty SVG width

2022-04-04 Thread Ihor Radchenko
Yuchen Guo writes: >> The license is declared in the script. You can see it by following the >> script url. It is right on top. > > True. My fault. The problem is that the declaration is not > machine-readable by LibreJS. I understand the problem, however I do not see why LibreJS could not whit

Re: [PATCH] ol.el: add description format parameter to org-link-parameters

2022-04-04 Thread Ihor Radchenko
Hugo Heagren writes: > * ol.el (org-link-parameters): add parameter `:default-description', a > string or a function. LGTM in general. Note that I proposed (and never followed up on) a similar patch in the past: https://orgmode.org/list/87pnauvxht.fsf@localhost I like that you introduced an opt

Re: ox-latex table tabbing support.

2022-04-04 Thread Ihor Radchenko
emacs--- via "General discussions about Org-mode." writes: > I have implemented tabbing > (http://www.ctex.org/documents/latex/latex2e-html/ltx-58.html) support for > ox-latex. By setting #+ATTR_LATEX: :mode tabbingthe exporter will use the > tabbing environment.  > > The benefits of using tab

Re: org-agenda todos list sorted by earliest deadline first

2022-04-04 Thread Ihor Radchenko
Sébastien Gendre writes: > My Emacs version is 27.2 and Org is 9.4.4. > > The value of "org-agenda-sorting-strategy" is: > > ((agenda habit-down time-up priority-down category-keep) > (todo priority-down category-keep deadline-up) > (tags priority-down category-keep deadline-up) > (search cate

Re: Removing obsolete function `org-truely-invisible-p'.

2022-04-04 Thread Ihor Radchenko
renaming it. 2. Rename it without obsoletion. Then, there is not much point moving the function definition to org-compat. > From: Ihor Radchenko > Subject: Re: Removing obsolete function `org-truely-invisible-p'. > To: Karl Fogel > Cc: Org Mode > Date: Sun, 19 Dec

Remove old WORG page with Org Syntax (draft) in favour of new syntax page by Timothy (was: Multiline list entries / Is auto-fill-mode in org(roam) usual?)

2022-04-04 Thread Ihor Radchenko
even though is can still be further improved. WDYT? Best, Ihor c.bu...@posteo.jp writes: > Am 04.04.2022 09:44 schrieb Ihor Radchenko: >> WORG is also official, though serves more like a wiki and not as >> official as the manual. In your particular case, we are currently in

Re: org-agenda todos list sorted by earliest deadline first

2022-04-04 Thread Ihor Radchenko
Sébastien Gendre writes: > I've tested it, but the tasks with no deadlines are still on top of the list. I am unable to reproduce on my side using latest stable Org. I used the following example org file: * TODO test1 * TODO test2 * TODO test3 DEADLINE: <2022-04-04 Mon> * TODO test4 DEADLI

Re: Removing obsolete function `org-truely-invisible-p'.

2022-04-04 Thread Ihor Radchenko
s.el is meant to store general-purpose functions that can be useful for development of the whole Org mode ecosystem. If we decide that org-truely-invisible-p stays in org-macs, we should fix the issue with its name. Renaming requires creating obsolete function name alias in org-compat.el to make sure

Re: Remove old WORG page with Org Syntax (draft) in favour of new syntax page by Timothy

2022-04-04 Thread Ihor Radchenko
Timothy writes: > Should we rename org-syntax to org-syntax-old? Or would you advocate for > something else? Would keeping the old org-syntax version benefit anyone? I think it only creates confusion and there is no extra information in the old version that is not available in the new syntax doc

Re: org-agenda todos list sorted by earliest deadline first

2022-04-05 Thread Ihor Radchenko
Sébastien Gendre writes: > If I evaluate the same setq and define the same tasks, my result withe > org-agenda tasks list are: > > Global list of TODO items of type: ALL > Press ‘N r’ (e.g. ‘0 r’) to search again: (0)[A$ > (1)TODO (2)DONE > test: TODO test1 > test

Re: Remove old WORG page with Org Syntax (draft) in favour of new syntax page by Timothy

2022-04-05 Thread Ihor Radchenko
Timothy writes: >> I am in favour of removing the old version completely and putting the >> new document at the old address >> >> >> The old version will remain accessible via git logs if absolutely >> necessary. > > That sounds good to me. Note tha

Re: problem with diary sexps

2022-04-05 Thread Ihor Radchenko
Christian Stuermer writes: > And the problem is gone, after reverting > >(result (if calendar-debug-sexp (eval sexp t) > (condition-case nil > (eval sexp t) > > back to > >(result (if calendar-debug-sexp (eval sexp) > (conditi

Inline src org block element with containing inside item does not get exported when it contains a newline (was: Inline src block element not parsed correctly for export when in a list item)

2022-04-05 Thread Ihor Radchenko
Confirmed. Interestingly, I cannot reproduce the bug using my personal branch at https://github.com/yantar92/org. The fix should be lurking somewhere close... Kaushal Modi writes: > I believe I have come across a corner case issue where the inline src > block element doesn't get parsed as one,

Re: Drop defadvice from Org

2022-04-06 Thread Ihor Radchenko
Bastien Guerry writes: > Stefan Monnier writes: > >> The patch below gets rid of the old `defadvice`, replacing it with >> `advice-add`. > > Applied in the main branch as 6d73cd34a, thanks a lot! The change in (eval ...) call inside org-diary-sexp-entry broke sexp timestamps. See orgmode.org/li

Re: org-cite styles don't allow * in them

2022-04-06 Thread Ihor Radchenko
"Bruce D'Arcus" writes: > On Sun, Apr 3, 2022 at 5:07 PM John Kitchin wrote: >> >> I was looking into using latex commands as styles in org-cite, e.g. >> >> [cite/citet:@key]. That example works fine, but [cite/citet*:@key] is not >> allowed. Could that be allowed? > > I have no insight into th

Re: Removing obsolete function `org-truely-invisible-p'.

2022-04-06 Thread Ihor Radchenko
Karl Fogel writes: > Unfortunately, the 'CONTRIBUTE' file at the top level of the Org > Mode source tree gives incomplete guidance on commit messages (it > just says to follow what Emacs does, so I did that). I didn't > realize that > https://orgmode.org/worg/org-contribute.html#commit-messa

Re: [PATCH v2] ol.el: add description format parameter to org-link-parameters

2022-04-06 Thread Ihor Radchenko
Hugo Heagren writes: > I've added the condition-case back to the check on > `org-link-make-description', and added a new one to the check for the > `:default-description' parameter, as Ihor suggested. I've also > modified the handling of that parameter, to reflect > `org-link-make-description', a

Re: problem with diary sexps

2022-04-07 Thread Ihor Radchenko
Eric S Fraga writes: > On Tuesday, 5 Apr 2022 at 19:22, Ihor Radchenko wrote: >> More accurate error can be found after setting calendar-debug-sexp to t. >> I got the following backtrace clearly indicating lexical scope issue: > > Which makes sense. The diary code does

Re: ob-ledger stopped working

2022-04-08 Thread Ihor Radchenko
Michael Englehorn writes: > I was running my ledger reports today, and discovered that ob-ledger seems to > be gone. Was there a reason it was removed, and is there a way for me to get > it back? I use it frequently. Contributed packages have been moved to separate repository at https://git.sr

Re: [BUG] Incorrect timestamp face in a heading if previous body contains link to such a heading [9.5.2 (release_9.5.2-25-gaf6f12 @ /usr/share/emacs/28.1/lisp/org/)]

2022-04-12 Thread Ihor Radchenko
Hanspeter Gisler writes: > OBSERVED BEHAVIOR > = > > The following 2 files 'correct_face_rendering.org' and > 'incorrect_face_rendering.org' render the 3rd headings timestamp face > differently, once correctly and once incorrectly. > > incorrect_face_rendering.org > --

Re: Bug: Changed behaviour of org-at-timestamp-p after recent change

2022-04-15 Thread Ihor Radchenko
em are only using group 0 and org-follow-timestamp-link is using group 1 as currently set by org-at-timestamp-p against the docstring. Best, Ihor >From d9a5cb8b7d7b12aca389331f4817130420d2d744 Mon Sep 17 00:00:00 2001 Message-Id: From: Ihor Radchenko Date: Fri, 15 Apr 2022 15:05:39 +0800 Subject: [PATCH] org-at-timestamp-p: F

Re: Patch: Fix typo in org-manual

2022-04-15 Thread Ihor Radchenko
"Cody Harris" writes: > I was reading the docs and saw some what looks like some errant > keystrokes in the manual, so here's a patch =] Thanks! Applied to main as a0755ebcc. Best, Ihor Applied.

[PATCH] CONTRIBUTE: Link WORG page when explaining commit message format

2022-04-15 Thread Ihor Radchenko
t, Ihor >From cd5e965d079aa7a3ac842e8ea3ea5762e2d80985 Mon Sep 17 00:00:00 2001 Message-Id: From: Ihor Radchenko Date: Fri, 15 Apr 2022 17:29:47 +0800 Subject: [PATCH] CONTRIBUTE: Link WORG page when explaining commit message format * CONTRIBUTE (Main contribution rules): Link relevant WORG contribute page section with

[PATCH] org-element-export-snippet-parser: Fix snippets without ending @@

2022-04-15 Thread Ihor Radchenko
u have any objections, I will install the attached patch to bugfix. Best, Ihor >From c866dcc8e593da2fca2611b100b4ab3ea9641e03 Mon Sep 17 00:00:00 2001 Message-Id: From: Ihor Radchenko Date: Sat, 16 Apr 2022 13:08:57 +0800 Subject: [PATCH] org-element-export-snippet-parser: Fix snippets without endi

Re: [PATCH] CONTRIBUTE: Link WORG page when explaining commit message format

2022-04-16 Thread Ihor Radchenko
Robert Pluim writes: > It might be good to mention `magit-generate-changelog' there as an > easy way to produce the ChangeLog format entry (it doesnʼt require you > to iterate over the diff hunks, and you can call it from the magit > commit buffer). Note that we already mention `magit-commit-add

Re: [PATCH] Re: [BUG] org-cite: 10 second hang opening a ~4k org file with 10MB bibtex library

2022-04-16 Thread Ihor Radchenko
Ihor Radchenko writes: > Jamie Matthews writes: > >> I can confirm that the key turns red on insert when I altered the key >> outside of emacs (with that second version of >> `org-cite-basic--parse-bibliography`). > > Great. Then, I am attaching the pat

Re: link error when file missing

2022-04-16 Thread Ihor Radchenko
Alan Wehmann writes: > I have a link in a text file that looks as follows, in fundamental mode: > > 5. Contracts: [[docview:~/Documents/Wheaton_condo/landscaping/from > Mark/2019/ALM_landscape_contract_Fall_2018.pdf::1][Landscape]], > [[docview:~/Documents/Wheaton_condo/landscaping/from > Mark

Re: [BUG] (Doom) Consistently seeing "org-element--cache" problems [9.6 (9.6-??-0c9b30e @ /home/dc/.emacs.doom/.local/straight/build-28.0.90/org/)]

2022-04-16 Thread Ihor Radchenko
David Conner writes: > I'm running a newer version of guix emacs-pgtk-native-comp and i'm not > longer seeing these org-mode cache messages. Great! > Thanks for your help Ihor. Can you close this issue? There is nothing to close. We only open issues from Org ML when the initial bug report is e

Re: diary-countdown

2022-04-17 Thread Ihor Radchenko
Sharon Kimble writes: > In the past this worked > > %%(diary-countdown 4 18 2022 7) Easter Monday Bank Holiday > > But now it doesn't. > > Can somebody help me get it working again please? Could you please elaborate what exactly is not working for you. What did you do? What did

Re: org-cite styles don't allow * in them

2022-04-17 Thread Ihor Radchenko
"Bruce D'Arcus" writes: >> A less awkward solution (IMO) would be to use an entity like ⋆. It is >> straightforward to add that to the org-element-citation-prefix-re. Then I >> see something like this. > > So Ihor, is there any problem with John's proposed change here? I am not a big fan of usi

Re: Cascading Org-Capture templates

2022-04-17 Thread Ihor Radchenko
Christophe Schockaert writes: > ... > So, "gM" is related to the second case (2), and I end up with the > following error : "Capture abort: Buffer is read-only: # As you see, I am using Doom Emacs, but I think it’s related with what I > am trying to do anyway. > ... > To me, this goes to the in

Re: org-cite styles don't allow * in them

2022-04-17 Thread Ihor Radchenko
John Kitchin writes: > I am also not a fan of using Unicode here and prefer a simple ascii > asterisk. That works fine for me so far, but I am not a heavy user of bold > markup and citations. What about something like [cite/citet*/:@key]? "*/" is not recognised as bold ending. > As I mentioned

Re: [O] Bug with Habits and Active Dates

2022-04-18 Thread Ihor Radchenko
cra...@gmx.net writes: > I have run into problems with a TODO entry that has a body which > contains an active date. Finishing it results in > > Entry repeats: SCHEDULED: <2016-12-13 Tue +1w> > > being printed to *Messages*, but no actual new SCHEDULED line is added > to the entry. For record, th

Re: org-cite styles don't allow * in them

2022-04-18 Thread Ihor Radchenko
John Kitchin writes: >> In contrast, [cite/citet*:@key] is likely to be used fairly frequently >> and has much higher chance to break things. > > > We have had a citet*:key link (and all the other * variants) for a long > time in org-ref, with no reported issues I can recall. I respect your expe

Re: Bug: Order of drawers is important [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.3/lisp/org/)]

2022-04-18 Thread Ihor Radchenko
Olaf Dietsche writes: > I would expect, that the order of drawers doesn't matter. The order of drawers does matter since Org 8.3. See https://orgmode.org/worg/org-release-notes.html#org7a85d9d Best, Ihor

Re: [BUG] Off-by-one error in width of Agenda window? [9.5.2 (release_9.5.2-25-gaf6f12 @ /data/installs/snapshots/emacs-28.1/lisp/org/)]

2022-04-18 Thread Ihor Radchenko
"N. Jackson" writes: > Recently it seems as if Org Agenda thinks its window is one > character wider than it actually is. The incorrect behaviour I > observe is: I do not see any issues on both stable bugfix and main branches. Are you able to reproduce starting from emacs -Q? (see https://orgm

Re: gnus links not followed, also avl-tree error (org-capture issues)

2022-04-18 Thread Ihor Radchenko
web...@toryanderson.com (Tory S. Anderson) writes: > Second, most of my plain (just me typing entries) captures fail to complete > at all. > > =org-capture: Capture abort: Wrong type argument: avl-tree-, nil > This is sending me back years to before I developed a nicely tuned org > workflow, and

Re: Bug: Order of drawers is important [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.3/lisp/org/)]

2022-04-18 Thread Ihor Radchenko
Olaf Dietsche writes: > This seems much more useful than the non-working "repair" of > org-set-property. FYI, even repair is no longer there in the latest Org release. In future, I recommend running org-lint. It is usually able to catch this and similar problems in Org files regardless of Org ve

Re: Local visibility makes header always visible

2022-04-18 Thread Ihor Radchenko
Eduardo Suarez-Santana writes: > Would you consider this as a bug? Yep. Confirmed. Best, Ihor

Re: org-cite styles don't allow * in them

2022-04-18 Thread Ihor Radchenko
"Bruce D'Arcus" writes: > Just to clarify, I don't believe the discussion is to add such styles to > the included org-cite processors (which already support such > functionality), but rather to allow it, for example for third party ones; > say a hypothetical org-ref one. Sure. However, the discu

Re: gnus links not followed, also avl-tree error (org-capture issues)

2022-04-18 Thread Ihor Radchenko
"Tory S. Anderson" writes: >> Thanks for reporting! Are you able to reproduce with emacs -Q? > > Thanks! I am not sure what an emacs -Q would mean in cases like this, since > they are custom written capture templates in the first place, so -Q would > lose them. Please refer to https://orgmode

Re: [BUG] Off-by-one error in width of Agenda window? [9.5.2 (release_9.5.2-25-gaf6f12 @ /data/installs/snapshots/emacs-28.1/lisp/org/)]

2022-04-18 Thread Ihor Radchenko
"N. Jackson" writes: > No, it doesn't happen just with emacs -Q. > > I have bisected my init file and narrowed it down to this setting in > my custom-set-variables: > > '(fringe-mode '(nil . 0) nil (fringe)) > > > Here is a recipe to reproduce the problem from emacs -Q: Thanks! I was able to r

Re: Fixing the automatic generation of Tex info node names

2022-04-19 Thread Ihor Radchenko
Philip Kaludercic writes: > For some reason ox-texinfo removes periods from node names. It seems > this is not necessary as info can render these files without any issues, > and in certain cases not intended (e.g. I had a node named "Emacs 28.1" > and it was abbreviated to "Emacs 281"). Accordi

Re: [BUG] Off-by-one error in width of Agenda window?

2022-04-19 Thread Ihor Radchenko
"N. Jackson" writes: > It turns out there is already an Emacs bug for this (Bug 19395: > Setting left fringe to 0 messes up window-width > (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19395)). > > My understanding of the discussion is that the bug is caused by > window-width including in its re

Re: Fixing the automatic generation of Tex info node names

2022-04-19 Thread Ihor Radchenko
Philip Kaludercic writes: > Would you happen to know what the issue is? As I said, the documents > appear to render just as expected in my case, but it might just be due > to the version or because I didn't hit some specific edge-case. The link I shared is all I know. Apparently, using some sym

Re: [BUG] (org-agenda-files) after restrict agenda to a file [9.5.2 (9.5.2-gfbff08 @ /home/ignacio/.emacs.d/elpa/org-9.5.2/)]

2022-04-20 Thread Ihor Radchenko
Ignacio Casso writes: > After restricting the agenda to a file for a single agenda command, with > 'C-c a < a', and exiting the agenda with 'x', (org-agenda-files) still > returns that file instead of the original list of agenda files. This can > be easily solved using the UNRESTRICTED optional a

[PATCH] oc-basic: Detect malformed bibtex bibliographies

2022-04-20 Thread Ihor Radchenko
es) results)) + (setf (buffer-file-name) nil)) + (error (setq org-cite-basic--file-id-cache nil))) (when info (plist-put info :cite-basic/bibliography results)) results))) -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Mat

Re: [PATCH] oc-basic: Detect malformed bibtex bibliographies

2022-04-20 Thread Ihor Radchenko
John Kitchin writes: > I would see if you can cache the result and not do it more than needed; it > can add a performance issue on large files. The results of parsing are already cached. See 7ddc5b57c. With this patch, I'd expect 2x performance degradation on (1) first time Org opens the biblio

[PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

2022-04-20 Thread Ihor Radchenko
. Best, Ihor Anders Johansson (3): Fix typo: delete-duplicates → delete-dups Fix bug in org-get-heading Rename remaining org-force-cycle-archived → org-cycle-force-archived Ihor Radchenko (35): Add org-fold-core: new folding engine Separate folding functions from org.el into new library

[PATCH v2 03/38] Separate cycling functions from org.el into new library: org-cycle

2022-04-20 Thread Ihor Radchenko
+1,818 @@ +;;; org-cycle.el --- Visibility cycling of Org entries -*- lexical-binding: t; -*- +;; +;; Copyright (C) 2020-2020 Free Software Foundation, Inc. +;; +;; Maintainer: Ihor Radchenko +;; Keywords: folding, visibility cycling, invisible text +;; Homepage: https://orgmode.org +;; +;; This file

[PATCH v2 01/38] Add org-fold-core: new folding engine---

2022-04-20 Thread Ihor Radchenko
-core.el @@ -0,0 +1,1490 @@ +;;; org-fold-core.el --- Folding buffer text -*- lexical-binding: t; -*- +;; +;; Copyright (C) 2020-2020 Free Software Foundation, Inc. +;; +;; Author: Ihor Radchenko +;; Keywords: folding, invisible text +;; Homepage: https://orgmode.org +;; +;; This file is part of GNU

[PATCH v2 04/38] Remove functions from org.el that are now moved elsewhere

2022-04-20 Thread Ihor Radchenko
--- lisp/org.el | 1272 ++- 1 file changed, 40 insertions(+), 1232 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 2353c6594..855f0813d 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -1179,90 +1179,6 @@ (defgroup org-structure nil :tag "

[PATCH v2 05/38] Disable native-comp in agendaIt caused cryptic bugs in the past.

2022-04-20 Thread Ihor Radchenko
task and appointment lists for Org -*- lexical-binding: t; -*- +;;; org-agenda.el --- Dynamic task and appointment lists for Org -*- lexical-binding: t; no-native-compile: t; -*- ;; Copyright (C) 2004-2022 Free Software Foundation, Inc. -- 2.35.1 -- Ihor Radchenko, PhD, Center for

[PATCH v2 02/38] Separate folding functions from org.el into new library: org-fold

2022-04-20 Thread Ihor Radchenko
+1,1135 @@ +;;; org-fold.el --- Folding of Org entries -*- lexical-binding: t; -*- +;; +;; Copyright (C) 2020-2020 Free Software Foundation, Inc. +;; +;; Author: Ihor Radchenko +;; Keywords: folding, invisible text +;; Homepage: https://orgmode.org +;; +;; This file is part of GNU Emacs. +;; +;; GNU

[PATCH v2 15/38] Alias new org-fold functions to their old shorter names

2022-04-20 Thread Ihor Radchenko
overview) +(defalias 'org-content #'org-cycle-content) +(defalias 'org-reveal #'org-fold-reveal) +(defalias 'org-force-cycle-archived #'org-cycle-force-archived) ;; `org-outline-regexp' ought to be a defconst but is let-bound in ;; some places -- e.g. see the ma

[PATCH v2 08/38] org-string-width: Reimplement to work with new folding

2022-04-20 Thread Ihor Radchenko
nil (line-beginning-position) (point-max))) +(set-window-buffer nil (current-buffer)) +(car (window-text-pixel-size + nil (line-beginning-position) (point-max))) +(if pixels + pixel-width + (/ pixe

[PATCH v2 07/38] org-at-heading-p: Accept optional argument* lisp/org.el (org-at-heading-p): Use second argument to allow

2022-04-20 Thread Ihor Radchenko
(save-excursion +(beginning-of-line) +(and (bolp) (or (not invisible-not-ok) (not (org-fold-folded-p))) +(looking-at outline-regexp (defun org-in-commented-heading-p (&optional no-inheritance element) "Non-nil if point is under a commented heading. -- 2.35.1 -- Ihor Radchen

[PATCH v2 06/38] org-macs: New function org-find-text-property-region---

2022-04-20 Thread Ihor Radchenko
table-p 2 0) org-script-display))) +(put-text-property (match-beginning 2) (match-end 3) + 'org-emphasis t) (add-text-properties (match-beginning 2) (match-end 2) (list 'invisible t)) (when (and (eq (char-after (match-beginning 3)) ?{) -- 2.

[PATCH v2 21/38] org-manual: Update to new org-fold function names---

2022-04-20 Thread Ihor Radchenko
archived subtrees. - #+vindex: org-sparse-tree-open-archived-trees -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China Em

[PATCH v2 12/38] org-fold: Handle indirect buffer visibility---

2022-04-20 Thread Ihor Radchenko
ore-decouple-indirect-buffer-folds) + ;; Return the buffer. + indirect-buffer) (error (make-indirect-buffer buffer bname) (defun org-set-frame-title (title) -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Lab

[PATCH v2 09/38] Rename old function call to use org-fold---

2022-04-20 Thread Ihor Radchenko
--- lisp/ob-core.el | 14 ++-- lisp/ob-lilypond.el | 4 +- lisp/ob-ref.el| 4 +- lisp/ol.el| 13 ++-- lisp/org-agenda.el| 43 +-- lisp/org-archive.el | 12 +-- lisp/org-capture.el | 2 +-

[PATCH v2 10/38] Implement link folding* lisp/ol.el (org-link--link-folding-spec):

2022-04-20 Thread Ihor Radchenko
link-folding-spec) :visible nil) +(org-fold-core-set-folding-spec-property (car org-link--link-folding-spec) :visible t)) (setq-local outline-regexp org-outline-regexp) (setq-local outline-level 'org-outline-level) (setq bidi-paragraph-direction 'left-to-right) -- 2.35.1

[PATCH v2 14/38] Support extra org-fold optimisations for huge buffers

2022-04-20 Thread Ihor Radchenko
heading t) -(buffer-substring (point-at-bol 2) (org-end-of-subtree t +(filter-buffer-substring (point-at-bol 2) (org-end-of-subtree t (defun org-edit-headline (&optional heading) "Edit the current headline. -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advanc

[PATCH v2 11/38] Implement overlay- and text-property-based versions of some functions

2022-04-20 Thread Ihor Radchenko
((= contents-end (point)) + (forward-char -1) + (org--backward-paragraph-once)) + (t + (goto-char contents-end +;; Move between empty lines in some blocks. +((and (memq type '(comment-block example-block export-block src-block +

[PATCH v2 29/38] org-string-width: Work around `window-pixel-width' bug in old Emacs

2022-04-20 Thread Ihor Radchenko
current-buffer)) + (car (window-text-pixel-size +nil (line-beginning-position) (point-max))))))) + (if pixels + pixel-width +(/ pixel-width symbol-width))) (defun org-not-nil (v) "If V not nil, and

[PATCH v2 13/38] Fix subtle differences between overlays and invisible text properties

2022-04-20 Thread Ihor Radchenko
ion) + (progn (forward-line) (current-indentation)) (should (equal '(2 2) @@ -1566,8 +1566,8 @@ (ert-deftest test-ob/preserve-results-indentation () " #+name: block\n #+begin_src emacs-lisp\n(+ 1 1)\n #+end_src" (org-babel-execute-src-bloc

[PATCH v2 17/38] org-compat: Work around some third-party packages using outline-* functions

2022-04-20 Thread Ihor Radchenko
fold-show-children) +(org-fold-show-entry +ad-do-it)) + +;; TODO: outline-headers-as-kill + Speed commands (make-obsolete-variable 'org-speed-commands-user "configure `org-speed-commands' instead." "9.5") - (provide 'org-compat

[PATCH v2 16/38] Obsolete old function names that are now in org-fold---

2022-04-20 Thread Ihor Radchenko
6") + (define-obsolete-variable-alias 'org-attach-directory 'org-attach-id-dir "9.3") (make-obsolete 'org-attach-store-link "No longer used" "9.4") @@ -383,6 +462,15 @@ (make-obsolete 'org-attach-expand-link "No longer used"

[PATCH v2 36/38] org-macs.el: Fix fontification checks take 2---

2022-04-20 Thread Ihor Radchenko
'org-fold-core-fontified t) +(text-property-not-all + (match-beginning 0) (match-end 0) + 'fontified t)) (save-match-data (font-lock-fontify-region (match-beginning 0) (ma

[PATCH v2 20/38] Add org-fold-related tests---

2022-04-20 Thread Ihor Radchenko
le-p))) +(org-test-with-temp-text + "* Heading 1 +#+begin_src emacs-lisp +(+ 1 2) +#+end_src +Text here" + (org-cycle) + (org-fold-hide-drawer-all) + (re-search-forward "end") + (should (org-invisible-p)) + (delete-char -1) + (re-search-backward "

[PATCH v2 22/38] ORG-NEWS: Add list of changes---

2022-04-20 Thread Ihor Radchenko
. +Passing optional argument will produce the old behaviour. + ** Miscellaneous *** Styles are customizable in ~biblatex~ citation processor -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Beha

[PATCH v2 18/38] Move `org-buffer-list' to org-macs.el---

2022-04-20 Thread Ihor Radchenko
(if (and (funcall filter b) - (or (not exclude-tmp) - (not (string-match "tmp" (buffer-name b) -b - nil)) - (buffer-list) - (defun org-agenda-files (&optional unrestricted archives) "Get the list o

[PATCH v2 27/38] Fix org-fold--hide-drawers--overlays---

2022-04-20 Thread Ihor Radchenko
ning-position) 'invisible)) (o (cdr-safe pair))) -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong Univers

[PATCH v2 23/38] Backport contributed commits---

2022-04-20 Thread Ihor Radchenko
nil 'cached))) (cached-tags (org-element-property :tags cached))) (if cached - ;; If we do explicitly copy the result, reference would +;; If we do not explicitly copy the result, reference would ;; be returned and cache element might be modified directly.

[PATCH v2 19/38] Restore old visibility behaviour of org-refile---

2022-04-20 Thread Ihor Radchenko
file'. ;; Do not prompt for a note when refiling multiple -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China Email:

[PATCH v2 28/38] org-string-width: Handle undefined behaviour in older Emacs

2022-04-20 Thread Ihor Radchenko
ocal char-property-alias-alist current-char-property-alias-alist) (let (pixel-width symbol-width) -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, X

[PATCH v2 31/38] org-fold-core: Fix fontification inside folded regions

2022-04-20 Thread Ihor Radchenko
d t) + (save-match-data + (font-lock-fontify-region (match-beginning 0) +(match-end 0 + (defsubst org-no-properties (s &optional restricted) "Remove all text properties from string S. When RESTRICTED is non-nil, only remove the properties listed -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China Email: yanta...@gmail.com, ihor_radche...@alumni.sutd.edu.sg

[PATCH v2 33/38] org--string-from-props: Fix handling folds in Emacs <28

2022-04-20 Thread Ihor Radchenko
and (or (eq t buffer-invisibility-spec) (assoc-string spec buffer-invisibility-spec)) 0)) -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Mater

[PATCH v2 30/38] org-fold-show-set-visibility: Fix edge case when folded region is at BOB

2022-04-20 Thread Ihor Radchenko
)) (when region (org-fold-region (car region) (cdr region) nil (unless (org-before-first-heading-p) -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials

[PATCH v2 34/38] org-link-make-string: Throw error when both LINK and DESCRIPTION are empty

2022-04-20 Thread Ihor Radchenko
on +(if (not (org-string-nw-p link)) +(or description +(error "Empty link")) (format "[[%s]%s]" (org-link-escape link) (if description (format "[%s]" description) "") -- 2.35.1 -- Ihor Radch

[PATCH v2 35/38] test-ol/org-toggle-link-display: Fix compatibility with old Emacs

2022-04-20 Thread Ihor Radchenko
visible-p))) +(should-not (org-xor org-link-descriptive (org-invisible-p))) (org-toggle-link-display) -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials,

[PATCH v2 32/38] test-org/string-width: Add tests for strings with prefix properties

2022-04-20 Thread Ihor Radchenko
(should (= 2 (org-string-width #(" " 0 1 (display (space :width 2)) + ;; Test `wrap-prefix' property. + (should (= 2 (org-string-width #("ab" 0 2 (wrap-prefix " ") + ;; Test `line-prefix' property. + (should (= 2 (org-string-width #("ab"

[PATCH v2 37/38] org-fold-core-fontify-region: Fix cases when fontification is not registered

2022-04-20 Thread Ihor Radchenko
xt 'org-fold-core-fontified t) +(put-text-property pos next 'fontified t) (setq pos next) (defun org-fold-core-update-optimisation (beg end) -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Labor

[PATCH v2 38/38] org-agenda.el: Re-enable native compilation* lisp/org-agenda.el: Re-enable native compilation as it does not

2022-04-20 Thread Ihor Radchenko
-binding: t; -*- ;; Copyright (C) 2004-2022 Free Software Foundation, Inc. -- 2.35.1 -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China Em

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

2022-04-20 Thread Ihor Radchenko
Bastien writes: > One glitch: in an agenda view with an agenda item that has a link, > changing the todo state will make all parts of the link visible. > > Let me know if you need a more detail recipe to reproduce the bug. Recipe would be helpftul. I was unable to reproduce using * TODO this is

[PATCH] org-agenda: Use `window-max-chars-per-line' instead of `window-width'

2022-04-20 Thread Ihor Radchenko
in org-agenda trying to account for the face width. w-m-c-p-l should do better than that. Attaching the patch. Best, Ihor >From 5de3de87872ddae994f5b68eba74d915d5f73201 Mon Sep 17 00:00:00 2001 Message-Id: <5de3de87872ddae994f5b68eba74d915d5f73201.1650518543.git.yanta...@gmail.com> Fro

Re: [PATCH] ol: Fix org-link-search

2022-04-20 Thread Ihor Radchenko
tony aldon writes: > If I'm not wrong, name defined after #+NAME: should be match first > before trying a fuzzy search in the function `org-link-search`. > ... > - (name (org-element-property :name element))) > + (name (org-element-property :value element))

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

2022-04-20 Thread Ihor Radchenko
Bastien writes: > I'm on commit e0abbbacf9427b69482c6c47c3ea0975b0e6fa6d from the > feature/org-fold-universal-core branch of your org repo. > > Using Emacs 29.0.50 and this as the content for ~/test.org: > > * TODO [[https://orgmode.org][test]] > SCHEDULED: <2022-04-20 mer.> > > Then run: > > -

Re: [PATCH] Re: No mathematics in Texinfo exports

2022-04-20 Thread Ihor Radchenko
Rudolf Adamkovič writes: > My patch (from almost a month ago) has yet to appear at > > https://updates.orgmode.org This is strange. Marking the patch manually. In any case, thanks for your contribution and patience. > Any ideas what to do? Could someone review it? The idea sounds good and hav

#3 Org mode profiling meetup on Sat, Apr 23 (was: #2 Org mode profiling meetup on Sat, Mar 26)

2022-04-21 Thread Ihor Radchenko
Dear all, I am continuing my experiment with Org mode meetups and online debugging. This time, I plan to 1. Talk about contributing patches to Org - Applying patches sent by others - Testing changes (make test) - Creating patches - Sending patches to the mailing list 2. Talk about and

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

2022-04-21 Thread Ihor Radchenko
Bastien writes: >> Since the actual patch does not have the problem, I'd prefer to ignore >> this problem unless it appears again after merging. > > Sure - can you point the exact branch/commit I should test for the > version that will be merged? https://github.com/yantar92/org/tree/feature/org

Re: [PATCH] Re: No mathematics in Texinfo exports

2022-04-21 Thread Ihor Radchenko
Nicolas Goaziou writes: >> Rudolf Adamkovič writes: >> >> The idea sounds good and having tests is very good. Though I am not >> expert in texinfo. CC-ing Nicolas. He is the maintainer. > > My Texinfo 6.7 manual does not contain any reference to displaymath > environment, which is used throughou

Re: org-cite styles don't allow * in them

2022-04-21 Thread Ihor Radchenko
Nicolas Goaziou writes: >> Note that inserting zero-width space will not only be awkward here, but >> also breaks parser: e.g. [cite/citet:@key] is not currently >> recognised as a citation. > > I think the zero-width space can be inserted on the other side. Could you elaborate? In the following

Re: [PATCH] Re: New source block results option for attaching file to node

2022-04-21 Thread Ihor Radchenko
Ryan Scott writes: > Here's my latest patch. > Uses special :dir value 'attach to use attachment directory as working dir. > Now prompts to create IDs for nodes that are missing. > Solved a handful of issues with my previous versions of this and I've been > using it regularly for a bit now. > > I

Re: [PATCH] ol: Fix org-link-search

2022-04-21 Thread Ihor Radchenko
Patch marked as cancelled.

Re: [PATCH] Re: No mathematics in Texinfo exports

2022-04-21 Thread Ihor Radchenko
Nicolas Goaziou writes: >>> My Texinfo 6.7 manual does not contain any reference to displaymath >>> environment, which is used throughout the patch. Where is it coming >>> from? >> >> I do see @displaymath in my TeXinfo 6.8. Also, >> https://www.gnu.org/software/texinfo/manual/texinfo/html_node/I

Re: org-cite styles don't allow * in them

2022-04-21 Thread Ihor Radchenko
Nicolas Goaziou writes: > I had your > > *bold [cite:citet*:@key] > > example in mind. Sure, if bold jumps across the citation this is > different. I'm not sure this is something that is frequent enough to > worry. According to Prof. Kitchin, it is not frequent. However, if it does happen it w

Re: Small patch for org-refile

2022-04-21 Thread Ihor Radchenko
Kambiz Darabi writes: > I recently switched to Emacs 28 and stumpled upon a call in org-refile to > define-obsolete-function-alias which doesn't have the 'when' parameter. > As Emacs 28 has made the 'when' parameter mandatory, this is a problem > for me. > > Attached is a tiny patch against the g

Re: Fix M-j with default fill-prefix value

2022-04-21 Thread Ihor Radchenko
Javier Olaechea writes: > org-comment-line-break-function does not handle fill-prefix being set to > nil, which is the default value for fill-prefix. This means that pressing > M-j inside an org-mode buffer in a vanilla installation of Emacs results in > an error. From looking at other callers of

<    3   4   5   6   7   8   9   10   11   12   >