Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-28 Thread York Zhao
> It could have (depending on what other files you might have had there, > not from the Git repo). May happen in theory, but never in real life, at least never happen on me. > It certainly muddied the waters w.r.t. your bug report. I had provided a reproducer proved to be straightforward and eff

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-27 Thread Achim Gratz
York Zhao writes: > As explained above, yes, my `org-mode' is in some other path outside of Emacs, > e.g., "foo/org-mode", which I had already explained, I'm going to delete the > first line. But it doesn't hurt to have the first line anyways right? It could have (depending on what other files you

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-27 Thread York Zhao
> The only path that needs to be in load-path is the lisp directory for > org-mode, which is the second line (that you say is "key"). You are right on this which I didn't realize before you pointed out, thanks. Anyways, in my configuration I always have both lines, and I'm going to delete the firs

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-27 Thread Achim Gratz
Nick Dokos writes: > However, with your patch there is the opposite side of the coin: if you > have a buffer in a mode derived from org (as in York's case), then doing > C-c C-c on the options line will reset the mode to org, not to the > derived one, right? It would have done exactly that before

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-27 Thread Nick Dokos
Achim Gratz writes: > Nick Dokos writes: >> I pushed the fix to master. Thanks to York and Tom for all the help. > > I'm not sure this fix is complete. It seems that when someone would > manually enter org-mode (say, in a scratch buffer) Emacs could return to > an entirely different mode upon ex

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-27 Thread Achim Gratz
Nick Dokos writes: > I pushed the fix to master. Thanks to York and Tom for all the help. I'm not sure this fix is complete. It seems that when someone would manually enter org-mode (say, in a scratch buffer) Emacs could return to an entirely different mode upon executing org-reset. > | 2 unexpe

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-27 Thread Nick Dokos
I pushed the fix to master. Thanks to York and Tom for all the help. I ran ``make test before pushing''. There were two failures, I believe unrelated to this patch: , | Ran 481 tests, 479 results as expected, 2 unexpected (2013-11-27 09:20:58-0500) | 4 expected failures | | 2 unexpected res

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-26 Thread Achim Gratz
York Zhao writes: >> York Zhao writes: >>> (add-to-list 'load-path "path/to/org-mode") >> >> This line is not needed. > > My org-mode is "installed" in separate directory outside of Emacs system and > therefor this line is needed in my setup, otherwise the org-mode shipped with > Emacs would be use

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-26 Thread Thomas S. Dye
Nick Dokos writes: > Nick Dokos writes: > >> The best solution I can think of so far: revert commit 5ea0228, >> and change org-mode-restart to call normal-mode, instead of org-mode. >> normal-mode splits the setting of the mode from the setting of local >> variables, so it would avoid the recurs

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-26 Thread York Zhao
> Can both interested parties (York Zhao and Tom Dye) please test it and let me > know of any problems? Thank you for the fix, your patch worked for me. York

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-26 Thread York Zhao
> York Zhao writes: >> (add-to-list 'load-path "path/to/org-mode") > > This line is not needed. My org-mode is "installed" in separate directory outside of Emacs system and therefor this line is needed in my setup, otherwise the org-mode shipped with Emacs would be used. >> (add-to-list 'load-pat

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-26 Thread Achim Gratz
York Zhao writes: > (add-to-list 'load-path "path/to/org-mode") This line is not needed. > (add-to-list 'load-path "path/to/org-mode/lisp") ; this line is the > key Key for what? Did you create autoload files for this installation? > Third, file "yhj-mode.el" has to be byte-compiled. You'll

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-25 Thread Nick Dokos
Nick Dokos writes: > The best solution I can think of so far: revert commit 5ea0228, > and change org-mode-restart to call normal-mode, instead of org-mode. > normal-mode splits the setting of the mode from the setting of local > variables, so it would avoid the recursion. > > I think (but I have

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-25 Thread Nick Dokos
York Zhao writes: > First goes .emacs file: > > (add-to-list 'load-path "path/to/org-mode") > (add-to-list 'load-path "path/to/org-mode/lisp") ; this line is the key > (add-to-list 'load-path "path/to/yhj-mode") > (require 'yhj-mode) > > Second goes yhj-mode.el: > > (require 'org) > (define-der

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-25 Thread York Zhao
OK, finally I was able to reproduce the problem with a minimal setup. First goes .emacs file: --8<---cut here---start->8--- (add-to-list 'load-path "path/to/org-mode") (add-to-list 'load-path "path/to/org-mode/lisp") ; this line is the key (add-to-list 'load-p

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-25 Thread York Zhao
Oop, I didn't know that I replied to Nicolas instead of to the list because I hitted "reply" instead of "reply all". So I'm reposting my previous post to the list. Here we go: In my previous post I actually meant to say that I set `debug-on-quit', have no idea why I did `debug-on-error'. But anywa

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-25 Thread Thomas S. Dye
Nick Dokos writes: > It may be that hack-local-variables takes a long time to process a large > file, although I don't think so: iirc, it limits itself to a tail of the > file of a given size, or the last "page" of the file (demarcated by ^L), > whichever is smaller. Hi Nick, I haven't noticed

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-25 Thread Nick Dokos
Nick Dokos writes: > York Zhao writes: > >> Hi List, >> >> I have an org-mode file that is 3230004 bytes in size. With commit "92f30ae" >> it >> can be opened without any problem. However, with commit "5ea0228" the same >> file >> could not be opened properly. >> >> What I did was: I opened Di

Re: [O] commit 5ea0228 has problem opening big org-mode file

2013-11-24 Thread Nick Dokos
York Zhao writes: > Hi List, > > I have an org-mode file that is 3230004 bytes in size. With commit "92f30ae" > it > can be opened without any problem. However, with commit "5ea0228" the same > file > could not be opened properly. > > What I did was: I opened Dired buffer, select the file, pres