Hi Nicolas
On Sun, Nov 17, 2013 at 12:46 PM, Nicolas Goaziou wrote:
> It looks good to me.
Thank you, I just pushed.
Michael
Hello,
Michael Brand writes:
> No, the point about documentation is now covered in org-open-at-point
> like all other previous changes to the ERT. Please see the attached
> changed local commit.
It looks good to me.
Thank you for the patch.
Regards,
--
Nicolas Goaziou
Hi Nicolas
Thank you for reviewing.
On Sat, Nov 16, 2013 at 9:43 PM, Nicolas Goaziou wrote:
> You are testing `url-encode-url' here, not an Org function. Is it really
> required?
No, the point about documentation is now covered in org-open-at-point
like all other previous changes to the ERT. Pl
Hello,
Michael Brand writes:
> I would like to ask you to review the attached patch so I can change
> it when necessary before I git push it.
Sure.
> - (browse-url (concat type ":" (org-link-escape-browser path
> + ;; see `ert-deftest'
> + ;; `test-org/org-link-esca
Hi Nicolas
I would like to ask you to review the attached patch so I can change
it when necessary before I git push it.
> it probably means that `org-link-escape' is a bit too zealous (BTW
> why don't this function rely on `url-encode-url'?)
url-encode-url is a very good hint to solve a differen
Nicolas, David
I just interjected.
Nicolas Goaziou writes:
> ...if that part cannot happen for some reason, links will be unusable
> outside Org.
Correctness should overrule compatibility. In practice, we may have to
strike a balance, with more weight thrown in favor of correctness.
I am
If Org links are escaped by Org will the URLs be functional outside of
Org?
i.e., If I am on some machine, that has no Emacs or Org or if I am using
a version of Org that uses "new unescape" algorithm but the original
link was encoded with the "old escape" algorithm, will Copy-pasting the
link to
I sense a design flaw. Fix it rather than "escape" it.
Jambunathan K writes:
> If Org links are escaped by Org will the URLs be functional outside of
> Org?
>
> i.e., If I am on some machine, that has no Emacs or Org or if I am using
> a version of Org that uses "new unescape" algorithm but t
Hello,
Jambunathan K writes:
> If Org links are escaped by Org will the URLs be functional outside of
> Org?
If there is an "unencoding" part, and if that part cannot happen for
some reason, links will be unusable outside Org.
That's already the case with the current encoding, which will break
At Sun, 28 Jul 2013 14:06:54 +0530,
Jambunathan K wrote:
>
>
> If Org links are escaped by Org will the URLs be functional outside of
> Org?
>
> i.e., If I am on some machine, that has no Emacs or Org or if I am using
> a version of Org that uses "new unescape" algorithm but the original
> link
David Maus writes:
> The more I think about it the more I grow certain that it is NOT about
> URI encoding but protecting a string.
This is what I mean.
> `[' and `]' are not forbidden per se, they belong to the set of
> reserved characters (see RFC 3986, 2.2.).
>
> "characters in the reserved
At Fri, 26 Jul 2013 12:20:37 +0200,
Nicolas Goaziou wrote:
>
> David Maus writes:
>
> Thanks for your answer. It seems I got confused with the current state
> of URI-encoding. Please scratch my previous suggestion and let's start
> over.
The more I think about it the more I grow certain that it
David Maus writes:
Thanks for your answer. It seems I got confused with the current state
of URI-encoding. Please scratch my previous suggestion and let's start
over.
> The assumption underlying the current implementation is
> to delegate dealing with forbidden characters to the consuming
> appl
At Thu, 25 Jul 2013 23:46:34 +0200,
Nicolas Goaziou wrote:
>
> Hello,
>
> David Maus writes:
>
> >
> > The bottom-line: Org creates link programmatically (org-store-link)
> > and needs a mechanism to protected conflicting characters. It chose
> > percent-escaping and in order to preserve the id
Hello,
David Maus writes:
> IIRC org-link-escape is not used to create URLs but to escape
> characters in a link that would otherwise conflict with Orgmode syntax
> (e.g. square brackets).
> Org applies percent escaping to a link before
> it is stored in the buffer and applies unescaping when i
Hi Nicolas,
Hi Nick,
At Wed, 24 Jul 2013 13:09:05 +0200,
Nicolas Goaziou wrote:
>
> Hello,
>
> Nick Dokos writes:
>
> > Maybe the thing to do is to delete '=' from org-link-escape-chars and
> > see what problems arise.
>
> AFAICT, `url-encode-url' is subtler than that. It encodes characters
>
Hello,
Nick Dokos writes:
> Maybe the thing to do is to delete '=' from org-link-escape-chars and
> see what problems arise.
AFAICT, `url-encode-url' is subtler than that. It encodes characters
whenever they are really forbidden, which is not the case of
`org-link-escape'. Hence my initial ques
Am 24.07.2013 11:16, schrieb Nicolas Goaziou:
Robert Eckl writes:
Ok, using visible-mode i see the link with %3D, i can replace it,
then all works fine. If iinsert a new link from clipboard, i get %3D.
Then, as I said, `org-link-escape' (called from `org-insert-link', aka
C-c C-l) is buggy.
Nicolas Goaziou writes:
> My guess is that your URL is encoded in the original buffer already. Try
> to use M-x visible-mode to see what is the real URL. If you see
> "http://example.de/?idprop%3D222";, it probably means that
> `org-link-escape' is a bit too zealous (BTW why don't this function r
Robert Eckl writes:
> Ok, using visible-mode i see the link with %3D, i can replace it,
> then all works fine. If iinsert a new link from clipboard, i get %3D.
Then, as I said, `org-link-escape' (called from `org-insert-link', aka
C-c C-l) is buggy.
I think we should replace every occurence of
Am 24.07.2013 09:34, schrieb Nicolas Goaziou:
Hello,
Robert Eckl writes:
The issue seems to be introduced with
Org-mode version 8.0.6 (release_8.0.6-4-g21dd83
org-element: Do not url-decode parsed links
The description sounds like the issue, no?
IIUC, this is different from your issue.
Hello,
Robert Eckl writes:
> The issue seems to be introduced with
> Org-mode version 8.0.6 (release_8.0.6-4-g21dd83
> org-element: Do not url-decode parsed links
> The description sounds like the issue, no?
IIUC, this is different from your issue. You write a URL that is not
encoded, and,
Hello,
Am 24.07.2013 01:35, schrieb Nicolas Goaziou:
Hello,
Robert Eckl writes:
At least since release_8.0.6-478-g9ee8e2
This release number is suspicious. Latest is release_8.0.6-353-g2b5670.
You're 125 commits ahead of us.
(encoding utf-8)
If i'm using a link which contains the charact
Hello,
Robert Eckl writes:
> At least since release_8.0.6-478-g9ee8e2
This release number is suspicious. Latest is release_8.0.6-353-g2b5670.
You're 125 commits ahead of us.
> (encoding utf-8)
>
> If i'm using a link which contains the character "=" the character in the
> target is replaced
At least since release_8.0.6-478-g9ee8e2
(encoding utf-8)
If i'm using a link which contains the character "=" the character in the
target is replaced with "%3D", at least for export to html and latex.
[[http://example.de/?idprop=222][http://example.de/picture.jpg]]
->
http://example.de/?idpr
Eric S Fraga writes:
> I used to have this problem and it was incredibly annoying. I also
> started adding the line Bernt suggests but I kept forgetting for new
> files. I finally solved this problem by adding the following lines to
> my emacs initialisation:
>
> #+begin_src emacs-lisp
> (pref
Bernt Hansen wrote:
> Nick Dokos writes:
>
> > Isn't the setting of LANG used during initialization to set these things?
> > I have LANG set to en_US.UTF-8 and new buffers are in utf-8-unix
> > (except for mail composition buffers: they are in undecided-unix).
> > I'm pretty sure I'm not mucki
Nick Dokos writes:
> Bernt Hansen wrote:
>
>> Eric S Fraga writes:
>>
>> > Bernt Hansen writes:
>> >
>> >> Julien Cubizolles writes:
>> >>
>> >>> I'm having a very strange problem with character encoding. I write all
>> >>> my text files with emacs, with non-ascii characters (I'm french). I
Bernt Hansen wrote:
> Eric S Fraga writes:
>
> > Bernt Hansen writes:
> >
> >> Julien Cubizolles writes:
> >>
> >>> I'm having a very strange problem with character encoding. I write all
> >>> my text files with emacs, with non-ascii characters (I'm french). I keep
> >>> a copy of many files
Eric S Fraga writes:
> Bernt Hansen writes:
>
>> Julien Cubizolles writes:
>>
>>> I'm having a very strange problem with character encoding. I write all
>>> my text files with emacs, with non-ascii characters (I'm french). I keep
>>> a copy of many files (latex/org/...) on separate machines usi
Bernt Hansen writes:
> Julien Cubizolles writes:
>
>> I'm having a very strange problem with character encoding. I write all
>> my text files with emacs, with non-ascii characters (I'm french). I keep
>> a copy of many files (latex/org/...) on separate machines using
>> unison. Very often after
Julien Cubizolles writes:
> I'm having a very strange problem with character encoding. I write all
> my text files with emacs, with non-ascii characters (I'm french). I keep
> a copy of many files (latex/org/...) on separate machines using
> unison. Very often after a synchronization, the non-asc
I'm having a very strange problem with character encoding. I write all
my text files with emacs, with non-ascii characters (I'm french). I keep
a copy of many files (latex/org/...) on separate machines using
unison. Very often after a synchronization, the non-ascii charaters are
completely displaye
33 matches
Mail list logo
