Re: [PATCH 3/20] staging: rtl8192u: Prefer using the BIT macro

Ok, I will send this patch again with the proper label. But do I have to send all the patches again of this patch series? Thanks, Simran Singhal ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman

[PATCH 01/15] staging: rtl8192u: fixing white space issue

Fix the following checkpatch.pl error and warnings: WARNING: please, no space before tabs Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b

[PATCH 02/15] staging: rtl8192u: Adding space after struct definition

Fixes checkpatch.pl warning: WARNING: missing space after struct definition Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers

[PATCH 03/15] staging: rtl8192u: Adding space after enum and struct definition

Fixes checkpatch.pl warning: WARNING: missing space after struct definition WARNING: missing space after enum definition Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff

[PATCH 04/15] staging: rtl8192u: blank lines aren't necessary before a close brace '}'

Fix checkpatch issues: "CHECK: Blank lines aren't necessary before a close brace '}'". Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee8021

[PATCH 05/15] staging: rtl8192u: Use min_t instead of min

Use min_t instead of min function in ieee80211/ieee80211_wx.c fixed warning: WARNING: min() should probably be min_t(u8, network->ssid_len, 32) Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 06/15] staging: rtl8192u: Fixing coding style issues

t;<' ERROR: space required after that ',' ERROR: spaces required around that '+=' WARNING: Missing a blank line after declarations CHECK: spaces required around that '?' CHECK: spaces required around that ':' Signed-off-by: simran singhal --- drive

[PATCH 07/15] staging: rtl8192u: Fixing style issues in r8180_93cx6.c

round that '-' CHECK: Alignment should match open parenthesis Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8180_93cx6.c | 71 -- 1 file changed, 33 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/stagi

[PATCH 08/15] staging: rtl8192u: Fixing style issues in r8180_93cx6.h

Fixing the following checkpatch.pl errors and warning: WARNING: Block comments use * on subsequent lines CHECK: Please don't use multiple blank lines Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8180_93cx6.h | 27 +-- 1 file changed, 13 insertions(+

[PATCH 09/15] staging: rtl8192u: fixing block comments use * on subsequent lines

Fixed checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8190_rtl8256.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.h b/drivers

Re: [PATCH 01/15] staging: rtl8192u: fixing white space issue

While resending them ...do I have to mention v2. On Tue, Feb 14, 2017 at 10:54 PM, Greg KH wrote: > On Tue, Feb 14, 2017 at 02:33:34AM +0530, simran singhal wrote: >> Fix the following checkpatch.pl error and warnings: >> WARNING: please, no space before tabs >> >> Si

[PATCH v2 1/9] staging: rtl8192u: fixing white space issue

Fix the following checkpatch.pl error and warnings: WARNING: please, no space before tabs Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b

[PATCH v2 2/9] staging: rtl8192u: Adding space after struct definition

Fixes checkpatch.pl warning: WARNING: missing space after struct definition Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers

[PATCH v2 3/9] staging: rtl8192u: Adding space after enum and struct definition

Fixes checkpatch.pl warning: WARNING: missing space after struct definition WARNING: missing space after enum definition Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff

[PATCH v2 4/9] staging: rtl8192u: blank lines aren't necessary before a close brace '}'

Fix checkpatch issues: "CHECK: Blank lines aren't necessary before a close brace '}'". Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee8021

[PATCH v2 5/9] staging: rtl8192u: Use min_t instead of min

Use min_t instead of min function in ieee80211/ieee80211_wx.c fixed warning: WARNING: min() should probably be min_t(u8, network->ssid_len, 32) Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

t;<' ERROR: space required after that ',' ERROR: spaces required around that '+=' WARNING: Missing a blank line after declarations CHECK: spaces required around that '?' CHECK: spaces required around that ':' Signed-off-by: simran singhal --- drive

[PATCH v2 7/9] staging: rtl8192u: Fixing style issues in r8180_93cx6.c

round that '-' CHECK: Alignment should match open parenthesis Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8180_93cx6.c | 71 -- 1 file changed, 33 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/stagi

[PATCH v2 9/9] staging: rtl8192u: fixing block comments use * on subsequent lines

Fixed checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8190_rtl8256.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.h b/drivers

[PATCH v2 8/9] staging: rtl8192u: Fixing style issues in r8180_93cx6.h

Fixing the following checkpatch.pl errors and warning: WARNING: Block comments use * on subsequent lines CHECK: Please don't use multiple blank lines Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8180_93cx6.h | 27 +-- 1 file changed, 13 insertions(+

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

Yes, I totally agree with joe. But as there is no coding style issue in this patch. So, do I have to resend the complete patch series again? On Wed, Feb 15, 2017 at 1:53 AM, Joe Perches wrote: > On Wed, 2017-02-15 at 01:44 +0530, simran singhal wrote: > [] >> diff --git a/dri

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

On Wed, Feb 15, 2017 at 9:01 AM, Joe Perches wrote: > On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote: >> Yes, I totally agree with joe. >> >> But as there is no coding style issue in this patch. > > Style is more than just checkpatch conformity. > >>

Re: [PATCH v2 9/9] staging: rtl8192u: fixing block comments use * on subsequent lines

Then which tree it applies to. Thanks, Simran On Fri, Feb 17, 2017 at 12:05 AM, Greg KH wrote: > On Wed, Feb 15, 2017 at 01:46:27AM +0530, simran singhal wrote: >> Fixed checkpatch.pl warning: >> WARNING: Block comments use * on subsequent lines >> >> Si

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

f you guide me so that I can improve. On Fri, Feb 17, 2017 at 12:02 AM, Greg KH wrote: > On Wed, Feb 15, 2017 at 01:48:13PM +0530, SIMRAN SINGHAL wrote: >> On Wed, Feb 15, 2017 at 9:01 AM, Joe Perches wrote: >> > On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote: >>

Re: [PATCH v2 9/9] staging: rtl8192u: fixing block comments use * on subsequent lines

I am attaching the screenshot of what I am getting from the script get_maintainer.pl. Thanks, Simran On Fri, Feb 17, 2017 at 12:23 AM, Greg KH wrote: > On Fri, Feb 17, 2017 at 12:20:22AM +0530, SIMRAN SINGHAL wrote: >> Then which tree it applies to. > > I have no idea, you w

[no subject]

ted by checkpatch.pl Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index a9a92d8..

[PATCH 1/3] staging: rtl8192u: Replace symbolic permissions with octal permissions

WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. This warning is detected by checkpatch.pl Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 inse

[PATCH v2 1/3] staging: rtl8192u: Replace symbolic permissions with octal permissions

Octal permissions should be used instead of symbolic ones for easier reading. WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. This warning is detected by checkpatch.pl Signed-off-by: simran singhal ---

Re: [PATCH v2 9/9] staging: rtl8192u: fixing block comments use * on subsequent lines

Sorry for replying properly. On Fri, Feb 17, 2017 at 1:16 AM, Greg KH wrote: > On Fri, Feb 17, 2017 at 12:49:54AM +0530, SIMRAN SINGHAL wrote: >> I am attaching the screenshot of what I am getting from the >> script get_maintainer.pl. > > I can't read images from a te

[PATCH 2/3] staging: rtl8192u: Fixed 'tabstop' coding style warnings

Replace a mix of tabs and spaces indentation by tabs only. Fixed checkpatch warning "Statements should start on a tabstop" in rtl8192u module. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH 3/3] staging: rtl8192u: Prefer using the BIT macro

avoid the warning. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140 - 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h ind

[PATCH v2 2/3] staging: rtl8192u: Fixed 'tabstop' coding style warning

Replace a mix of tabs and spaces indentation by tabs only. Fixed checkpatch warning "Statements should start on a tabstop" in rtl8192u module. Signed-off-by: simran singhal --- v2: -Modified "warnings" to "warning" in the patch Subject. drivers/staging/rtl

[PATCH v2 3/3] staging: rtl8192u: Prefer using the BIT macro

Replaces left shift operation (1 << d) by BIT(x) macro. Fix the checkpatch.pl issue: CHECK: Prefer using the BIT macro replacing Signed-off-by: simran singhal --- V2: -modified patch message. drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140 - 1 file c

[PATCH 1/6] staging: rtl8192e: Replaced comparison to NULL statements

This patch corrects check generated by checkpatch.pl by replacing comparison to null statements with equivalent statements in the form of "!x". Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di

[PATCH 2/6] staging: rtl8192e: Remove CamelCase

This patch renames pBA to pba to avoid camelcase. Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 100 +++--- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging

[PATCH v2 1/6] staging: rtl8192e: Replaced comparison to NULL statements

This patch removes the explicit NULL comparison. This issue was found by checkpatch. Signed-off-by: simran singhal --- v2: -Modified commit message drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e

[PATCH 3/6] staging: rtl8192e: Fix block comments warning

Align * on a line, to conform to the kernal coding style for block comments. Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h

[PATCH 4/6] staging: rtl8192e: Remove blank line after '{'

Remove blank line after opening brace to fix the checkpatch issue blank lines aren't necessary after a open brace '{'. Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_

[PATCH 5/6] staging: rtl8192e: Fixes multiple blank lines issue

This patch fixes the checkpatch.pl issue: Please don't use multiple blank lines Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_HT.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h

[PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

Extra parentheses were causing checkpatch issues and were removed. Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e

[PATCH v2 3/6] staging: rtl8192e: Fix block comments warning

Align * on last line, to conform to the kernal coding style for block comments. Signed-off-by: simran singhal --- v2: -Modified commit message drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b

[PATCH 1/6] staging: vt6655: Compress return logic

Simplify function returns by merging assignment and return into one command line. Found with Coccinelle @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: simran singhal --- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 1/6] staging: vt6655: Compress return logic

Coccinelle @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: simran singhal --- v2: -Removed assignment drivers/staging/vt6655/card.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers

[PATCH v3 1/6] staging: vt6655: Compress return logic

Simplify function returns by merging assignment and return into one command line. Found with Coccinelle @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: simran singhal --- v2: -Removed assignment v3: -Removed declaration of qwTSFOffset

[PATCH 2/6] staging: rtl8192e: Change form of NULL comparisons

Change null comparisons of the form x == NULL to !x. This was done using Coccinelle. @@ expression e; @@ - e == NULL + !e Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_TSProc.c| 2 +- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +- drivers/staging/rtl8192e

[PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses

Extra parentheses were causing checkpatch issues and were removed. Signed-off-by: simran singhal --- v2: -Removed parentheses around argument of cast -Removed cast drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 3/6] staging: greybus: Remove unnecessary braces

This patch removes braces for single statement blocks. The warning was detected using checkpatch.pl. Coccinelle was used to make the change. @@ expression e,e1; @@ - if (e) { + if (e) e1; - } Signed-off-by: simran singhal --- drivers/staging/greybus/audio_manager_sysfs.c | 3 +-- drivers

[PATCH v2 3/6] staging: greybus: Remove unnecessary braces

This patch removes braces for single statement blocks. The warning was detected using checkpatch.pl. Coccinelle was used to make the change. @@ expression e,e1; @@ - if (e) { + if (e) e1; - } Signed-off-by: simran singhal --- v2: -I forgot to cc outreachy mailing list drivers/staging

[PATCH 4/6] staging: Drop useless initialisation

Removed initialisation of a varible if it is immediately reassigned. Changes were made using Coccinelle. @@ type T; constant C; expression e; identifier i; @@ T i - = C ; i = e; Signed-off-by: simran singhal --- drivers/staging/android/ion/ion_heap.c | 2 +- drivers/staging

[PATCH 5/6] staging: lustre: Using macro DIV_ROUND_UP

(e1,e2) ) Signed-off-by: simran singhal --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +- drivers/staging/lustre/lnet/selftest/conrpc.c | 11 --- drivers/staging/lustre/lustre/ptlrpc/client.c | 3 +-- drivers/staging/lustre/lustre/ptlrpc/niobuf.c | 2

[PATCH 6/6] staging: comedi: Using macro DIV_ROUND_UP

(e1,e2) ) Signed-off-by: simran singhal --- drivers/staging/comedi/drivers/addi_apci_3xxx.c | 2 +- drivers/staging/comedi/drivers/cb_pcidas64.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi_apci_3xxx.c b/drivers/staging/comedi

[PATCH 1/7] staging: vc04_services: Using macro DIV_ROUND_UP

(e1,e2) ) Signed-off-by: simran singhal --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface

[PATCH 2/7] staging: most: Using macro DIV_ROUND_UP

(e1,e2) ) Signed-off-by: simran singhal --- drivers/staging/most/hdm-dim2/dim2_hal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.c b/drivers/staging/most/hdm-dim2/dim2_hal.c index 0b9816c..6824826 100644 --- a/drivers/staging

[PATCH 3/7] staging: gdm724x: Drop useless initialisation

Removed initialisation of a varible if it is immediately reassigned. Changes were made using Coccinelle. @@ type T; constant C; expression e; identifier i; @@ T i - = C ; i = e; Signed-off-by: simran singhal --- drivers/staging/gdm724x/gdm_lte.c | 2 +- drivers/staging/gdm724x/gdm_mux.c | 4

[PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP

(e1,e2) ) Signed-off-by: simran singhal --- v2: -Included kernel.h as DIV_ROUND_UP is defined in it, before it was giving compilation error. drivers/staging/most/hdm-dim2/dim2_hal.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/hdm-dim2

[PATCH v2 5/6] staging: lustre: Using macro DIV_ROUND_UP

(e1,e2) ) Signed-off-by: simran singhal --- v2: -Removed unnecessary parantheses from the right side of assignment. drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +- drivers/staging/lustre/lnet/selftest/conrpc.c | 11 --- drivers/staging/lustre/lustre/ptlrpc

Re: [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses

On Fri, Feb 24, 2017 at 10:47 PM, Greg KH wrote: > On Mon, Feb 20, 2017 at 10:41:47PM +0530, simran singhal wrote: >> Extra parentheses were causing checkpatch issues >> and were removed. >> >> Signed-off-by: simran singhal >> --- >> >> v2: >&

[PATCH 1/5] staging: lustre: Remove unnecessary else after return

This patch fixes the checkpatch warning that else is not generally useful after a break or return. @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: simran singhal --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 3 +-- drivers/staging

[PATCH 3/5] staging: rtl8712: Remove unnecessary else after return

This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: simran singhal --- drivers/staging/rtl8712/os_intfs.c | 3 +-- 1

[PATCH 2/5] staging: rtl8192u: Remove unnecessary else after return

This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211

[PATCH 4/5] staging: sm750fb: Remove unnecessary else after return

This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: simran singhal --- drivers/staging/sm750fb/ddk750_sii164.c | 6

[PATCH 5/5] staging: gdm724x: Remove unnecessary else after return

This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: simran singhal --- drivers/staging/gdm724x/gdm_endian.c | 12

[PATCH] staging: iio: accel: Move header file content to source file

The contents of the header file are used only by this single source file. Move content into .c and remove .h. Signed-off-by: simran singhal --- drivers/staging/iio/accel/adis16201.h | 144 drivers/staging/iio/accel/adis16201_core.c | 145

Re: [PATCH 5/5] staging: gdm724x: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 1:11 AM, Joe Perches wrote: > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: >> This patch fixes the checkpatch warning that else is not generally >> useful after a break or return. > >> This was done using Coccinelle: >> @@ >

Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 12:55 AM, Joe Perches wrote: > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: >> This patch fixes the checkpatch warning that else is not generally >> useful after a break or return. > > checkpatch doesn't actually warn for this

Re: [PATCH 4/5] staging: sm750fb: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 1:01 AM, Joe Perches wrote: > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: >> This patch fixes the checkpatch warning that else is not generally >> useful after a break or return. > [] >> diff --git a/drivers/staging/sm750fb/ddk750_swi2c

[PATCH v2] staging: iio: accel: Move header file content to source file

The contents of the header file are used only by this single source file. Move content into .c and remove .h. Signed-off-by: simran singhal --- v2: -Removing ifndef and define drivers/staging/iio/accel/adis16201.h | 144 - drivers/staging/iio/accel

Re: [Outreachy kernel] [PATCH 4/5] staging: sm750fb: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 2:45 AM, Julia Lawall wrote: > > > On Mon, 27 Feb 2017, simran singhal wrote: > >> This patch fixes the checkpatch warning that else is not generally >> useful after a break or return. >> >> This was done using Coccinelle: >

Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 2:13 AM, Joe Perches wrote: > On Tue, 2017-02-28 at 01:51 +0530, SIMRAN SINGHAL wrote: >> On Tue, Feb 28, 2017 at 12:55 AM, Joe Perches wrote: >> > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: >> > > This patch fixes the check

Re: [Outreachy kernel] [PATCH 4/5] staging: sm750fb: Remove unnecessary else after return

On Wed, Mar 1, 2017 at 12:30 AM, Julia Lawall wrote: > > > On Wed, 1 Mar 2017, SIMRAN SINGHAL wrote: > >> On Tue, Feb 28, 2017 at 2:45 AM, Julia Lawall wrote: >> > >> > >> > On Mon, 27 Feb 2017, simran singhal wrote: >> > >> >>

Re: [PATCH 5/5] staging: gdm724x: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 1:49 AM, SIMRAN SINGHAL wrote: > On Tue, Feb 28, 2017 at 1:11 AM, Joe Perches wrote: >> On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: >>> This patch fixes the checkpatch warning that else is not generally >>> useful after a break or r

Re: [Outreachy kernel] [PATCH 3/5] staging: rtl8712: Remove unnecessary else after return

On Tue, Feb 28, 2017 at 2:49 AM, Julia Lawall wrote: > > > On Mon, 27 Feb 2017, simran singhal wrote: > >> This patch fixes the checkpatch warning that else is not generally >> useful after a break or return. >> >> This was done using Coccinelle: >

Re: [PATCH v2] staging: iio: accel: Move header file content to source file

On Wed, Mar 1, 2017 at 12:53 AM, Jonathan Cameron wrote: > On 28/02/17 19:17, Jonathan Cameron wrote: >> On 28/02/17 18:51, simran singhal wrote: >>> The contents of the header file are used only by this single >>> source file. Move content into .c and remove .h. &g

Re: [PATCH v2] staging: iio: accel: Move header file content to source file

On Wed, Mar 1, 2017 at 1:04 AM, Lars-Peter Clausen wrote: > On 02/28/2017 08:32 PM, SIMRAN SINGHAL wrote: >> On Wed, Mar 1, 2017 at 12:53 AM, Jonathan Cameron wrote: >>> On 28/02/17 19:17, Jonathan Cameron wrote: >>>> On 28/02/17 18:51, simran singhal wrote: >>

[PATCH v3] staging: iio: adis16201: Move header file content to source file

The contents of the header file are used only by this single source file. Move content into .c and remove .h. Signed-off-by: simran singhal --- v3: -Removing endif as it is not needed -Changing subject drivers/staging/iio/accel/adis16201.h | 144

[PATCH 5/6] staging: rtl8192u: Fix Sparse warning of cast from restricted __le16

__le16 And added space before '|' Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8192U_dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index 9209aad..e1c83a3 100644 ---

[PATCH 3/6] staging: wlan-ng: Fix sparse warnings in hfa384x_usb.c

__be32 [usertype] Signed-off-by: simran singhal --- drivers/staging/wlan-ng/hfa384x_usb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index a7ff572..cdf987b 100644 --- a

[PATCH 1/6] staging: wlan-ng: Fix sparse warning of restricted __le16

This patch fixes the following sparse warning: warning: cast to restricted __le16 Signed-off-by: simran singhal --- drivers/staging/wlan-ng/prism2sta.c | 51 ++--- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2sta.c

[PATCH 4/6] staging: fbtft: Fix sparse warnings of incorrect type in assignment

: simran singhal --- drivers/staging/fbtft/fbtft-bus.c | 2 +- drivers/staging/fbtft/fbtft-io.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c index ec45043..df2223e 100644 --- a/drivers/staging/fbtft/fbtft

[PATCH 2/6] staging: wlan-ng: Fix sparse warnings

:got restricted __le16 [usertype] Signed-off-by: simran singhal --- drivers/staging/wlan-ng/hfa384x_usb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 6134eba..a7ff572 100644

[PATCH 6/6] staging: rtl8192u: Fix Sparse warning of cast to restricted __le16

This patch fixes the following Sparse warnings:- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:177:16: warning: cast to restricted __le16 Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Outreachy kernel] [PATCH 1/6] staging: wlan-ng: Fix sparse warning of restricted __le16

On Thu, Mar 2, 2017 at 3:20 PM, Julia Lawall wrote: > > > On Thu, 2 Mar 2017, Julia Lawall wrote: > >> >> >> On Thu, 2 Mar 2017, simran singhal wrote: >> >> > This patch fixes the following sparse warning: >> > warning: cast to restricted __l

[PATCH v2 3/6] staging: wlan-ng: Fix sparse warnings in hfa384x_usb.c

/wlan-ng/hfa384x_usb.c:3527:34:got restricted __be32 [usertype] Signed-off-by: simran singhal --- v2: -changed commit message drivers/staging/wlan-ng/hfa384x_usb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng

[PATCH v2 4/6] staging: fbtft: Fix sparse warnings of incorrect type in assignment

restricted __be64 [usertype] Signed-off-by: simran singhal --- v2: -changed commit message drivers/staging/fbtft/fbtft-bus.c | 2 +- drivers/staging/fbtft/fbtft-io.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers

[PATCH] staging: nvec: cleanup USLEEP_RANGE checkpatch checks

Resolve strict checkpatch USLEEP_RANGE checks by converting delays and sleeps as described in ./Documentation/timers/timers-howto.txt. CHECK: usleep_range is preferred over udelay; see Documentation/ timers/timers-howto.txt Signed-off-by: simran singhal --- drivers/staging/nvec/nvec.c | 4

[PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

This patch removes unnecessary typecast of c90 int constant. WARNING: Unnecessary typecast of c90 int constant Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp

[PATCH 3/7] staging: media: Replace NULL with "!"

Use ! in comparison tests using "==NULL" rather than moving the "==NULL" to the right side of the test. Addesses multiple instances of the checkpatch.pl warning: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: simran singhal --- d

[PATCH 4/7] staging: media: Remove blank line before '}' and after '{' braces

Remove unneeded blank lines preceding/following '}' and '{' braces, as pointed out by checkpatch. This patch addresses the following checkpatch checks: CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Blank lines aren't necessary after

[PATCH 6/7] staging: media: Use x instead of x != NULL

Use x instead of x != NULL . This patch removes the explicit NULL comparisons.This issue is found by checkpatch.pl script. Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media

[PATCH 2/7] staging: media: Add blank line after a declaration

Add blank line after a declaration. Problem found using checkpatch. This patch fixes these warning messages found by checkpatch.pl: WARNING : Missing a blank line after declarations. Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 7 +++ 1 file changed, 7

[PATCH 7/7] staging: media: Do not use multiple blank lines

Remove multiple blank lines. Problem found using checkpatch.pl "CHECK: Please don't use multiple blank lines". Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/gc22

[PATCH 5/7] staging: media: Remove multiple assignments

Remove multiple assignments by factorizing them. Problem found using checkpatch.pl CHECK: multiple assignments should be avoided Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] staging: nvec: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/nvec/nvec_kbd.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 1/5] staging: nvec: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/nvec/nvec_kbd.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/lustre/lustre/llite/range_lock.c | 2 +- drivers/staging/lustre/lustre/

[PATCH 4/5] staging: rts5208: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rts5208/rtsx_transport.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rtl8712/rtl8712_recv.c | 10 +- 1 file changed, 5 insertions(+)

[PATCH 2/5] staging: lustre: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++-- 1 file changed, 2 insertions(+)

Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

On Fri, Mar 3, 2017 at 3:13 AM, Joe Perches wrote: > On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote: >> The following Coccinelle script was used to detect this: >> @r@ >> expression x; >> void* e; >> type T; >> identifier f; >>

Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

On Fri, Mar 3, 2017 at 3:26 AM, Julia Lawall wrote: >> @@ -635,7 +635,7 @@ void r8712_reordering_ctrl_timeout_handler(void >> *pcontext) >> { >> unsigned long irql; >> struct recv_reorder_ctrl *preorder_ctrl = >> - (struct recv_reorder_ctrl *)pcontext; >>

  1   2   3   4   >