From: David Binder
Since a procfs or sysfs entry is allocated 1 page of memory (4096 bytes)
by default, there is no need to enforce this limit in the driver. This
patch corrects visorbus/visorchipset.c.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset.c
index 275653a..b6f1ccf 10064
iable addr
staging: unisys: visorbus: Convert references to /proc to /sys
staging: unisys: visorbus: visorchipset.c: Don't check for more than
PAGE_SIZE length
staging: unisys: visorbus: Don't check for more than PAGE_SIZE length in
visorbus
David Kershner (4):
staging: u
The function my_device_changestate was not returning errors up the stack.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff
The function save_crash_message returns an error, don't ignore it,
respond appropriately and send it up.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 7 +--
1 file changed, 5 insertions(
Add proper error handling to the function my_device_create and
propagate the error message up the stack.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 44 ++-
1 file changed, 24
Add the proper error handling to my_device_destroy so it can be send
back up the stack for further error reporting.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 17 +
1 file changed
From: David Binder
Since a procfs or sysfs entry is allocated 1 page of memory (4096 bytes)
by default, there is no need to enforce this limit in the driver. This
patch corrects visorbus/visorbus_main.c.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Binder
Signed-off-by: David Kershner
From: Sameer Wadgaonkar
This patch shortens a few error message defines by removing ERROR
from the define.
Reported-by: Greg Kroah-Hartman
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 65
-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 27 +--
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset.c
index
From: Bryan Thompson
Remove the MAX_BUF define and associated comments.
Signed-off-by: Bryan Thompson
Reviewed-by: Tim Sell
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorhba/visorhba_main.c | 4
1 file changed, 4 deletions(-)
diff --git a
From: Erik Arfvidson
This patch removes unused pound defines in controlvmchannel.h.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 22 +---
1 file changed, 22 deletions(-)
diff --git
From: David Binder
Since a sysfs entry is allocated 1 page of memory (4096 bytes) by default,
there is no need to enforce this limit in the driver. This patch corrects
visorbus/visorchipset.c.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
This series is just a resubmission of the last 2 patches from our previous
series. It just removes extraneous PAGE_SIZE checks.
Changes since v1:
-- Remove references to procfs since we are only dealing with sysfs
David Binder (2):
staging: unisys: visorbus: visorchipset.c: Don't check
From: David Binder
Since a sysfs entry is allocated 1 page of memory (4096 bytes) by default,
there is no need to enforce this limit in the driver. This patch corrects
visorbus/visorbus_main.c.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Binder
Signed-off-by: David Kershner
()
staging: unisys: visornic: Reorder logic in visornic_enable_with_timeout()
staging: unisys: visornic: Remove errant -EIO returns
David Kershner (2):
staging: unisys: visorbus: Remove unused enum members
staging: unisys: visorbus: Replace parser_param_start with parser_name_get
Tim Sell
From: Tim Sell
It just makes more sense to do the NULL-pointer check when the function is
called to enable interrupts, rather than on *every* interrupt.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 10 --
1 file changed
Replace the general CONTROLVM string parser setup which only handled the
name string with a specific name string retrieval function.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 53 +--
1 file changed, 15
From: David Binder
Removes the invocation to init_rcv_bufs() in visornic_resume() because that
function is already called in visornic_enable_with_timeout().
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 2 --
1 file changed, 2
From: David Binder
Moves the call to napi_enable() before the call to init_rcv_bufs(),
ensuring that messages are not put into the receive queue until the guest
is ready to receive interrupts.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic
From: David Binder
Remove errant -EIOs that prevent us from calling either
netif_start_queue() or napi_disable().
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
becoming corrupted.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic/visornic_main.c
index 3a638ca
Visorchipset used to parse CONTROLVM messages with a variety of string
information. All but the name string have been removed, but the code
to handle this information remained. This patch removes the other values
and handlers.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset.c
index 188e224..07f8d05 100644
--- a/drivers/staging/unisys/visorbus
From: David Binder
Removes struct safe_uis_queue, which is within struct visorchannel. The
struct is not used anywhere in the s-Par drivers.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchannel.c | 6 --
1 file changed, 6 deletions
Binder
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset.c
index c90ea6a..2d1b226 100644
From: David Binder
Checks the controlvm message's payload size before copying it into a
parser_context struct's name region.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 4
1 fi
n an operational network.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic/visornic_
, and so using the standard version creates an
unnecessary dependency between the kernel and s-Par.
Signed-off-by: Steven Matthews
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/iochannel.h | 11 +++--
drivers/staging/unisys/visorhba/visorhba_main.c | 22
-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 1 +
drivers/staging/unisys/visorbus/visorchipset.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/visorbus
We no longer send payloads back to the s-Par firmware, we can get rid of
the initialize and destroy functions since they weren't actually being
used just created and destroyed.
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c
From: David Binder
Simplifies kobject usage in visorchipset.c by combining pairs of functions
that are better expressed combined.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 76
pointer checks
staging: unisys: visorbus: Clarify reason for device pointer checks
David Kershner (2):
staging: unisys: visorbus: remove putfile data structures
staging: unisys: visorbus: get rid of unused payload info
Steven Matthews (1):
staging: unisys: include: fix improper use of
There were several unused data structures dealing with putfile that are no
longer being used. So get rid of them.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 54 +---
1 file changed, 54 deletions(-)
diff --git a
convention
David Kershner (4):
staging: unisys: Move vbushelper.h to visorbus directory
include: linux: visorbus: Add visorbus to include/linux directory
Documentation: Move visorbus documentation from staging to
Documentation/
drivers: Add visorbus to the drivers directory
Erik
From: Erik Arfvidson
This patch removes the vague -1 return values from the
write_vbus channel functions. Nobody was checking the
return values and the value stored into the vbus info
is not critical to the functioning of the device.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
From: Erik Arfvidson
This patch changes the vague -1 return value to -EINVAL
It also modifies the caller of parahotplug_request_complete
to check the return value and return appropriate result.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers
From: David Binder
Modifies the format string of snprintf to expect an unsigned int
instead of a signed one, per the supplied argument.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed
From: David Binder
Removes unused module parameters from visorbus_main.c, in response to
findings by SonarQube.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 9 +
1 file changed, 1 insertion
, because none of them ever perform any
operations that would be invalid in atomic context.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 10 +++--
drivers/staging/unisys/visorbus/visorbus_main.c | 54 +++--
2 files
From: Bryan Thompson
The STANDALONE_CLIENT define is no longer used by Unisys driver code.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging
From: Bryan Thompson
Remove visorbus_clear_channel, visorchannel_signalqueue_slots_avail,
visorchannel_signalqueue_max_slots, visorchannel_clear, and
visorchannel_debug which are no longer called by any driver.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
From: David Binder
Fixes a comment spelling mistake in visornic.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys
red state in devdata->interrupts_enabled.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorinput/visorinput.c | 57 +-
1 file changed, 47 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/unisys/visorinput/visorinput.c
b/d
From: Tim Sell
These files were made no-longer-necessary by recent commits.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/periodic_work.h | 40 -
drivers/staging/unisys/visorbus/Makefile| 1 -
drivers/staging/unisys/visorbus
From: Tim Sell
periodic_test_workqueue was an unused relic from the past, and was removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/unisys
From: David Binder
Removes unused struct definition, channel_size_info, in response to
findings by SonarQube.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6 --
1 file changed, 6 deletions(-)
diff
From: Erik Arfvidson
This patch changes the vague -1 return values to -EPERM.
This operation is not supported is a good alternative
to -1 because the return is basically telling the caller
that the processor doesn't support vmcall operations.
Signed-off-by: Erik Arfvidson
Signed-off-by:
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 1 -
drivers/staging/unisys/visorbus/visorchannel.c | 17 -
drivers/staging/unisys/visorbus/visorchipset.c | 2 --
3 files changed, 20 deletions(-)
diff --git a/drivers
From: David Binder
Moves function prototypes that are unique to visorbus from
include/visorbus.h to visorbus/visorbus_private.h.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 25
From: Tim Sell
The off parameter to visorchannel_create_guts() was never used, so it was
removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchannel.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers
From: David Binder
Code relating to ktheads was previously removed from s-Par driver code.
This patch cleans up lingering remnants of kthreads by removing thread-
related enum types.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys
From: David Binder
Fixes the kerneldoc comment for struct visor_device - the struct members
were not listed with the appropriate @ prefix.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 34 +++
1 file
From: Bryan Thompson
visordriver_callback_lock is just a binary semaphore that logically
makes more sense as a mutex.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 +-
drivers/staging/unisys
folders.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/MAINTAINERS| 2 +-
drivers/staging/unisys/visorbus/Makefile | 2 --
drivers/staging/unisys/visorbus/controlvmchannel.h| 2 +-
drivers
This patch simple does a git mv of the
drivers/staging/unisys/Documentation directory to Documentation. Renames
overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to
the correct name sysfs-bus-visorbus.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
.../ABI/stable
From: Tim Sell
This patch ONLY touches comment lines, i.e., NO executable code is
affected.
Comments were fixed in visorbus_private.h:
* Minor typos were corrected.
* Useless comments were removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus
: David Binder
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 65
1 file changed, 43 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/vbusdeviceinfo.h
b/drivers/staging/unisys
visorbus is currently located at drivers/staging/visorbus,
this patch moves it to drivers/virt.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/Kconfig| 3 +--
drivers/staging/unisys/Makefile
Only visorbus needs this header file so move it to visorbus
directory.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/{include => visorbus}/vbushelper.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename drivers/staging/unisys/{include => vi
typos were corrected.
* Useless comments were removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
Signed-off-by: David Binder
---
drivers/staging/unisys/visorbus/visorchannel.c | 83 ++
1 file changed, 71 insertions(+), 12 deletions(-)
diff --git a/drivers
From: David Binder
Adds kerneldoc formatting to appropriate functions. Other multi-line
comments now use proper formatting.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 292 -
1
tweaked so as to use appropriate conventions.
Signed-off-by: David Binder
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 420
1 file changed, 289 insertions(+), 131 deletions(-)
diff --git a/drivers/staging
From: David Binder
Renames visorchipset_device_pause_response to device_pause_response,
thereby following the convention that other responder functions follow.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c| 4 ++--
drivers
files
within the same driver, known as 'visorbus'. This eliminated the need
for a registration mechanism, but it has remained nevertheless until now.
For the sake of simplification, this registration mechanism is now being
removed.
Signed-off-by: David Binder
Signed-off-by: Davi
From: Erik Arfvidson
This patch modifies the caller of parahotplug_request_complete()
to check the return value and return appropriate result.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 5 -
1
staging: unisys: visorbus: Move visorbus-unique functions to private
header
staging: unisys: visorbus: rectify kerneldoc comment for struct
staging: unisys: visorbus: Remove notifier-related code from visorbus
staging: unisys: visorbus: Rename function to follow existing
convention
David
From: David Binder
Removes unused module parameters from visorbus_main.c, in response to
findings by SonarQube.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 9 +
1 file changed, 1 insertion
From: David Binder
Fixes a comment spelling mistake in visornic.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys
From: David Binder
Removes unused struct definition, channel_size_info, in response to
findings by SonarQube.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6 --
1 file changed, 6 deletions(-)
diff
From: Erik Arfvidson
This patch removes the return values from the write_vbus_* channel
functions. Nobody was checking the return values and the value stored
into the vbus info is not critical to the functioning of the device.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
From: David Binder
Modifies the format string of snprintf to expect an unsigned int
instead of a signed one, per the supplied argument.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed
From: David Binder
Code relating to ktheads was previously removed from s-Par driver code.
This patch cleans up lingering remnants of kthreads by removing thread-
related enum types.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys
, because none of them ever perform any
operations that would be invalid in atomic context.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 10 +++--
drivers/staging/unisys/visorbus/visorbus_main.c | 54 +++--
2 files
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 1 -
drivers/staging/unisys/visorbus/visorchannel.c | 17 -
drivers/staging/unisys/visorbus/visorchipset.c | 2 --
3 files changed, 20 deletions(-)
diff --git a/drivers
red state in devdata->interrupts_enabled.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorinput/visorinput.c | 57 +-
1 file changed, 47 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/unisys/visorinput/visorinput.c
b/d
From: Tim Sell
periodic_test_workqueue was an unused relic from the past, and was removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/unisys
From: David Binder
Renames visorchipset_device_pause_response to device_pause_response,
thereby following the convention that other responder functions follow.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c| 4 ++--
drivers
From: Bryan Thompson
Remove visorbus_clear_channel, visorchannel_signalqueue_slots_avail,
visorchannel_signalqueue_max_slots, visorchannel_clear, and
visorchannel_debug which are no longer called by any driver.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
From: Tim Sell
These files were made no-longer-necessary by recent commits.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/periodic_work.h | 40 -
drivers/staging/unisys/visorbus/Makefile| 1 -
drivers/staging/unisys/visorbus
: David Binder
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 65
1 file changed, 43 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/vbusdeviceinfo.h
b/drivers/staging/unisys
From: Tim Sell
This patch ONLY touches comment lines, i.e., NO executable code is
affected.
Comments were fixed in visorbus_private.h:
* Minor typos were corrected.
* Useless comments were removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus
tweaked so as to use appropriate conventions.
Signed-off-by: David Binder
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 420
1 file changed, 289 insertions(+), 131 deletions(-)
diff --git a/drivers/staging
files
within the same driver, known as 'visorbus'. This eliminated the need
for a registration mechanism, but it has remained nevertheless until now.
For the sake of simplification, this registration mechanism is now being
removed.
Signed-off-by: David Binder
Signed-off-by: Davi
From: David Binder
Adds kerneldoc formatting to appropriate functions. Other multi-line
comments now use proper formatting.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 292 -
1
From: David Binder
Moves function prototypes that are unique to visorbus from
include/visorbus.h to visorbus/visorbus_private.h.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 25
From: David Binder
Fixes the kerneldoc comment for struct visor_device - the struct members
were not listed with the appropriate @ prefix.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 34 +++
1 file
Only visorbus needs this header file so move it to visorbus
directory.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/{include => visorbus}/vbushelper.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename drivers/staging/unisys/{include => vi
From: Tim Sell
The off parameter to visorchannel_create_guts() was never used, so it was
removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchannel.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers
typos were corrected.
* Useless comments were removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
Signed-off-by: David Binder
---
drivers/staging/unisys/visorbus/visorchannel.c | 83 ++
1 file changed, 71 insertions(+), 12 deletions(-)
diff --git a/drivers
From: Bryan Thompson
visordriver_callback_lock is just a binary semaphore that logically
makes more sense as a mutex.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 +-
drivers/staging/unisys
From: Bryan Thompson
The STANDALONE_CLIENT define is no longer used by Unisys driver code.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging
visorbus is currently located at drivers/staging/visorbus,
this patch moves it to drivers/virt.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/Kconfig| 3 +--
drivers/staging/unisys/Makefile
This patch simple does a git mv of the
drivers/staging/unisys/Documentation directory to Documentation. Renames
overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to
the correct name sysfs-bus-visorbus.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
.../ABI/stable
folders.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/MAINTAINERS| 2 +-
drivers/staging/unisys/visorbus/Makefile | 2 --
drivers/staging/unisys/visorbus/controlvmchannel.h| 2 +-
drivers
From: Erik Arfvidson
This patch modifies the caller of parahotplug_request_complete()
to check the return value and return appropriate result.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 5 -
1
From: David Binder
Removes unused module parameters from visorbus_main.c, in response to
findings by SonarQube.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 9 +
1 file changed, 1 insertion
function to follow existing
convention
David Kershner (1):
staging: unisys: Move vbushelper.h to visorbus directory
Erik Arfvidson (2):
staging: unisys: visorbus: remove return values for write_vbus
functions
staging: unisys: visorbus: check parahotplug_request_complete_result
Tim Sell
red state in devdata->interrupts_enabled.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorinput/visorinput.c | 57 +-
1 file changed, 47 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/unisys/visorinput/visorinput.c
b/d
From: David Binder
Fixes a comment spelling mistake in visornic.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys
401 - 500 of 943 matches
Mail list logo
