[PATCH v3 02/30] staging: unisys: visorchipset change -1 return value

[David Kershner]

From: Erik Arfvidson <erik.arfvid...@unisys.com>

This patch changes the vague -1 return value to -EINVAL
It also modifies the caller of parahotplug_request_complete
to check the return value and return appropriate result.

Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com>
Signed-off-by: David Kershner <david.kersh...@unisys.com>
Reviewed-by: Tim Sell <timothy.s...@unisys.com>
---
 drivers/staging/unisys/visorbus/visorchipset.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c 
b/drivers/staging/unisys/visorbus/visorchipset.c
index 5ba5936..7f44913 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1613,7 +1613,7 @@ parahotplug_request_complete(int id, u16 active)
        }
 
        spin_unlock(&parahotplug_request_list_lock);
-       return -1;
+       return -EINVAL;
 }
 
 /*
@@ -2036,11 +2036,14 @@ static ssize_t devicedisabled_store(struct device *dev,
                                    const char *buf, size_t count)
 {
        unsigned int id;
+       int err;
 
        if (kstrtouint(buf, 10, &id))
                return -EINVAL;
 
-       parahotplug_request_complete(id, 0);
+       err = parahotplug_request_complete(id, 0);
+       if (err < 0)
+               return err;
        return count;
 }
 
-- 
1.9.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel