This patch fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations
in file ipu3-css-fw.h
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
drivers/staging/media/ipu3/ipu3-css-fw.h | 1 +
This patch fixes the following checkpatch.pl warning:
WARNING: Avoid multiple line dereference
in file ipu3-css.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
drivers/staging/media/ipu3/ipu3-css.c | 14 ++
On Sun, Feb 21, 2021 at 11:12:36AM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: Missing a blank line after declarations
>
> in file ipu3-css-fw.h
>
> Signed-off-by: Nikolay Kyx
> ---
>
> Additionally some style warnings remain valid here and co
I can't find any change in struct imgu_fw_info layout after this patch.
But warning is strange, because declarations don't actually end here.
So I think this warning should be suppressed to reduce noise
in checkpatch.pl output.
___
devel mailing list
de..
On Sat, Feb 20, 2021 at 06:22:31PM +0530, karthik alapati wrote:
> fix sparse type warning by converting le32 types to
> host byte-order types before comparison
>
> Signed-off-by: karthik alapati
> ---
> drivers/staging/wimax/i2400m/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
This mail is been writing to you because we have come to understand that
you have lost a lot of money all because you want to receive your fund
well note that all that have been put to a stop as the federal government of
Nigeria has promised to assist you with the sum of five million American funds
This patch fixes the following checkpatch.pl warning:
WARNING: Avoid multiple line dereference
in file ipu3-css.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Removed second part of patch which fixes non-existent pr
On Fri, Feb 19, 2021 at 02:38:51PM +, Lee Gibson wrote:
> This patch fixes the checkpatch warnings such as:
>
> hi6421-spmi-pmic.c:51: WARNING: please, no space before tabs
>
> Signed-off-by: Lee Gibson
> ---
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 8
> 1 file changed, 4 in
On Fri, Feb 19, 2021 at 07:34:11PM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> in files kpc2000_i2c.c kpc2000_spi.c
>
> Signed-off-by: Nikolay Kyx
> ---
>
> Additionally some style warnings remain valid
On Sat, Feb 20, 2021 at 01:55:25AM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "Block comments
> use * on subsequent lines".
>
> Signed-off-by: Amrit Khera
> ---
> drivers/staging/wimax/stack.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> di
On Sat, Feb 20, 2021 at 05:46:52AM -0800, Rajesh Kumbhakar wrote:
> netdev.c
>
> fixing style ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Rajesh Kumbhakar
> ---
> Changes in v2:
> - Removed filename from commit message.
filename is still in commit message :(
On Sat, Feb 20, 2021 at 12:22:43PM -0500, Julian Braha wrote:
> >From fd949b204eeb6b685bbf5dc9a329c931fcf8b0da Mon Sep 17 00:00:00 2001
> From: Julian Braha
> Date: Sat, 20 Feb 2021 12:07:30 -0500
> Subject: [PATCH] staging: rtl8192e: fix kconfig dependency on CRYPTO
Why is this all in the body o
On Sat, Feb 20, 2021 at 11:51:55PM +0530, Atul Gopinathan wrote:
> The "CcxRmState" field in struct "rtllib_network" is defined
> as a u16 array of size 2 (so, 4 bytes in total).
>
> But the operations performed on this array throughout the code
> base (in rtl8192e/) are all in byte size 2 indicat
On 21-02-2021 18:36, Greg KH wrote:
On Sat, Feb 20, 2021 at 05:46:52AM -0800, Rajesh Kumbhakar wrote:
netdev.c
fixing style ERROR: space required before the open parenthesis '('
Signed-off-by: Rajesh Kumbhakar
---
Changes in v2:
- Removed filename from commit message.
filename is s
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in files kpc2000_i2c.c kpc2000_spi.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by
This patch fixes the following checkpatch.pl warning:
WARNING: line length of 124 exceeds 100 columns
in file kpc2000_i2c.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH
v3:
fixing ERROR: space required before the open parenthesis '('
Signed-off-by: Rajesh Kumbhakar
---
Changes in v3:
- Fixed commit message (removed filename).
Changes in v2:
- Removed filename from commit message.
drivers/staging/wimax/i2400m/netdev.c | 2 +-
1 file changed, 1 inser
the following patches fixes two byte-order issues and a Makefile
issue and fixes these sparse warnings
drivers/staging//wimax/i2400m/op-rfkill.c:89:25: warning: incorrect type in
assignment (different base types)
drivers/staging//wimax/i2400m/op-rfkill.c:89:25:expected restricted __le16
[
fix sparse byte-order warnings by converting host byte-order
type to __le16 byte-order types before assigning to hdr.length
Signed-off-by: karthik alapati
---
drivers/staging/wimax/i2400m/op-rfkill.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m
fix sparse type warning by converting __le32 types
to host byte-order types before comparison
Signed-off-by: karthik alapati
---
drivers/staging/wimax/i2400m/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c
b/drivers/staging/wimax/i2400m
currently the functions defined in ibuf_ctrl_rmgr.c file are only
used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected
so dont't compile it when not needed, also fixes some sparse warnings
Signed-off-by: karthik alapati
---
drivers/staging/media/atomisp/Makefile | 5 +++--
1 file ch
The check for interface is duplicated in 3 places and has been refactored
into a function. Also the if condition was wrapping the whole body in all
three places, so it has been changed to return if the condition is false
to reduce the indentation levels.
Signed-off-by: Shreesh Adiga <16567adigashr
On Sun, Feb 21, 2021 at 07:34:57PM +0530, karthik alapati wrote:
> currently the functions defined in ibuf_ctrl_rmgr.c file are only
> used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected
> so dont't compile it when not needed, also fixes some sparse warnings
>
> Signed-off-by: karthi
On Sun, Feb 21, 2021 at 08:25:05PM +0530, Shreesh Adiga wrote:
> The check for interface is duplicated in 3 places and has been refactored
> into a function. Also the if condition was wrapping the whole body in all
> three places, so it has been changed to return if the condition is false
> to redu
the following patches fixes two byte-order issues
and fixes these sparse warnings
drivers/staging//wimax/i2400m/op-rfkill.c:89:25: warning: incorrect type in
assignment (different base types)
drivers/staging//wimax/i2400m/op-rfkill.c:89:25:expected restricted __le16
[usertype] length
drive
fix sparse byte-order warnings by converting host byte-order
type to __le16 byte-order types before assigning to hdr.length
Signed-off-by: karthik alapati
---
drivers/staging/wimax/i2400m/op-rfkill.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m
fix sparse type warning by converting __le32 types
to host byte-order types before comparison
Signed-off-by: karthik alapati
---
drivers/staging/wimax/i2400m/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c
b/drivers/staging/wimax/i2400m
currently the functions defined in ibuf_ctrl_rmgr.c file are only
used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected
so dont't compile it when not needed, also fixes some sparse warnings
Signed-off-by: karthik alapati
---
drivers/staging/media/atomisp/Makefile | 5 +++--
1 file ch
Instead, depend on the size of the destination buffer for easier
refactoring.
Signed-off-by: Kumar Kartikeya Dwivedi
---
Hopefully, this is more thorough. The only cases left now are where the
destination string is represented by a pointer, otherwise all call sites with a
fixed sized buffer have
The check for interface is duplicated in 3 places and has been refactored
into a function.
Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com>
---
drivers/staging/octeon/ethernet.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/octeon
The if condition was wrapping the whole body in three functions, it has
been changed to return if the condition is false to reduce the
indentation levels.
Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com>
---
drivers/staging/octeon/ethernet.c | 194 +++---
1 file
This change fixes a checkpatch warning for "Block comments
use * on subsequent lines".
Signed-off-by: Amrit Khera
---
Changes in v2:
- Removed the comment entirely, as suggested by Greg KH
drivers/staging/wimax/stack.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/s
On Sun, Feb 21, 2021 at 02:08:26PM +0100, Greg KH wrote:
> On Sat, Feb 20, 2021 at 11:51:55PM +0530, Atul Gopinathan wrote:
> > The "CcxRmState" field in struct "rtllib_network" is defined
> > as a u16 array of size 2 (so, 4 bytes in total).
> >
> > But the operations performed on this array throu
This commit fixes a checkpatch warning that references the filename in
the the file comments.
Signed-off-by: George Xanthakis
---
drivers/staging/android/uapi/ashmem.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/android/uapi/ashmem.h
b/drivers/staging/android/uapi/ashme
On Sun, Feb 21, 2021 at 10:07:59PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "Block comments
> use * on subsequent lines".
That's not all this patch does, please be descriptive of what you really
do and why you are doing it.
thanks,
greg k-h
_
This patch fixes the following checkpatch.pl check:
CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues
in file iss_regs.h
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
drivers/staging/media/omap
Hi Nikolay,
Thank you for the patch.
On Sun, Feb 21, 2021 at 10:53:08PM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues
>
> in file iss_regs.h
>
> Signed-off-by: Nikolay Kyx
> ---
>
Fixes a checkpatch CHECK issue.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +-
drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/dr
This patchset fixes the checkpatch issues related to the `ba_record`
struct defined in `rtl8192e/rtl819x_BA.h` (avoid camelcase). The last
patch reformats the struct a bit to be more consistent with the other
types defined in the same file.
William Durand (7):
staging: rtl8192e: rename Timer to
This change uses a space instead of tabs between the type and name of
each member of the struct.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/st
Fixes a checkpatch CHECK issue.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 28 +++
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/d
Fixes a checkpatch CHECK issue.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 18 +-
drivers/staging/rtl8192e/rtllib_tx.c | 2 +-
3 files changed, 11 insertions(+), 11 deletions(-)
diff --gi
Fixes a checkpatch CHECK issue.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 14 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/stag
Fixes a checkpatch CHECK issue.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 22 +++---
drivers/staging/rtl8192e/rtllib_tx.c | 2 +-
3 files changed, 13 insertions(+), 13 deletions(-)
diff
Fixes a checkpatch CHECK issue.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/stagin
This commit fix errors found in checkpath.pl.
Error message is:
It is a good idea to keep complex macros in do while loop.
Otherwise result may have side effect.
Signed-off-by: chakravarthikulkarni
---
drivers/staging/ks7010/ks_hostif.h | 24
1 file changed, 12 insertio
Removed unused variables.
Signed-off-by: Fatih Yildirim
---
drivers/staging/comedi/drivers/dt2814.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2814.c
b/drivers/staging/comedi/drivers/dt2814.c
index bcf4d5444faf..bd329d7b489
Fixes "Alignment should match open parenthesis" issues reported by
checkpatch.pl in the `rtllib_wx.c` file.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtllib_wx.c | 42
1 file changed, 18 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/rt
Hi Laurent,
Thank you for the review.
I think that if we drop the unneeded parentheses here, we need to drop
them everywhere in the file for consistency, even in places checkpatch.pl
doesn't warn about. It'll increase patch size without actual usefullness
gain, as for me. I am very (very) novice
Hi Nikolay,
On Mon, Feb 22, 2021 at 12:21:36AM +0300, Nikolay K. wrote:
> Hi Laurent,
>
> Thank you for the review.
> I think that if we drop the unneeded parentheses here, we need to drop
> them everywhere in the file for consistency, even in places checkpatch.pl
That's a good point.
> doesn't
Hi Nikolay,
Thank you for the patch.
On Sun, Feb 21, 2021 at 10:53:08PM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues
>
> in file iss_regs.h
>
> Signed-off-by: Nikolay Kyx
Review
Good day
You have been selected to receive my grant donation. Please, contact me
for further detail.I shall be expecting your quick response
veraaell...@gmail.com
Best Regards,
Mrs. Vera Aellen
--
This email has been checked for viruses by AVG.
https://www.avg.com
__
This patches fixes the checks- 'Alignment should match open parenthesis'
of 'checkpatch.pl'.
Signed-off-by: Mahak Gupta
---
drivers/staging/octeon-usb/octeon-hcd.c | 32 +
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hc
Good day
You have been selected to receive my grant donation. Please, contact me
for further detail.I shall be expecting your quick response
veraaell...@gmail.com
Best Regards,
Mrs. Vera Aellen
--
This email has been checked for viruses by AVG.
https://www.avg.com
__
On Fri, Feb 19, 2021 at 06:23:54PM +, Kurt Manucredo wrote:
>
>
> checkpatch gives the following WARNING:
> WARNING: Comparisons should place the constant on the right side of the test
> this patch fixes the coding style warning.
>
> Signed-off-by: Kurt Manucredo
> ---
Looks okay to me. T
On Sat, Feb 20, 2021 at 05:04:00PM +0530, karthik alapati wrote:
> fix sparse warning by casting to explicit user address-space
> pointer type
>
> Signed-off-by: karthik alapati
> ---
> drivers/staging/wlan-ng/p80211netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Sat, Feb 20, 2021 at 05:56:47PM +0530, karthik alapati wrote:
> fix sparse byte-order warnings by converting host byte-order
> types to le32 types
>
> Signed-off-by: karthik alapati
This is a v2 patch...
regards,
dan carpenter
___
devel mailing li
On Mon, Feb 22, 2021 at 11:10 AM Dan Carpenter wrote:
>
> On Sat, Feb 20, 2021 at 05:04:00PM +0530, karthik alapati wrote:
> > fix sparse warning by casting to explicit user address-space
> > pointer type
> >
> > Signed-off-by: karthik alapati
> > ---
> > drivers/staging/wlan-ng/p80211netdev.c |
On Sun, Feb 21, 2021 at 10:07:59PM +0530, Amrit Khera wrote:
> diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
> index ace24a6dfd2d..345a022810ef 100644
> --- a/drivers/staging/wimax/stack.c
> +++ b/drivers/staging/wimax/stack.c
> @@ -57,17 +57,7 @@ MODULE_PARM_DESC(debug
On Mon, Feb 22, 2021 at 01:43:24AM +0530, chakravarthikulkarni wrote:
> This commit fix errors found in checkpath.pl.
> Error message is:
>
> It is a good idea to keep complex macros in do while loop.
> Otherwise result may have side effect.
>
> Signed-off-by: chakravarthikulkarni
This breaks t
60 matches
Mail list logo
