[PATCH 1/2] staging: octeon: refactor interface check logic in ethernet.c

[Shreesh Adiga]

The check for interface is duplicated in 3 places and has been refactored
into a function.

Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com>
---
 drivers/staging/octeon/ethernet.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/octeon/ethernet.c 
b/drivers/staging/octeon/ethernet.c
index 5dea6e96ec90..af546ef41843 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -228,6 +228,12 @@ static struct net_device_stats 
*cvm_oct_common_get_stats(struct net_device *dev)
        return &dev->stats;
 }
 
+static int cvm_oct_validate_interface(int interface)
+{
+       return interface < 2 && (cvmx_helper_interface_get_mode(interface) !=
+                                CVMX_HELPER_INTERFACE_MODE_SPI);
+}
+
 /**
  * cvm_oct_common_change_mtu - change the link MTU
  * @dev:     Device to change
@@ -248,9 +254,7 @@ static int cvm_oct_common_change_mtu(struct net_device 
*dev, int new_mtu)
 
        dev->mtu = new_mtu;
 
-       if ((interface < 2) &&
-           (cvmx_helper_interface_get_mode(interface) !=
-               CVMX_HELPER_INTERFACE_MODE_SPI)) {
+       if (cvm_oct_validate_interface(interface)) {
                int index = INDEX(priv->port);
                /* Add ethernet header and FCS, and VLAN if configured. */
                int max_packet = new_mtu + mtu_overhead;
@@ -294,9 +298,7 @@ static void cvm_oct_common_set_multicast_list(struct 
net_device *dev)
        struct octeon_ethernet *priv = netdev_priv(dev);
        int interface = INTERFACE(priv->port);
 
-       if ((interface < 2) &&
-           (cvmx_helper_interface_get_mode(interface) !=
-               CVMX_HELPER_INTERFACE_MODE_SPI)) {
+       if (cvm_oct_validate_interface(interface)) {
                union cvmx_gmxx_rxx_adr_ctl control;
                int index = INDEX(priv->port);
 
@@ -346,9 +348,7 @@ static int cvm_oct_set_mac_filter(struct net_device *dev)
        union cvmx_gmxx_prtx_cfg gmx_cfg;
        int interface = INTERFACE(priv->port);
 
-       if ((interface < 2) &&
-           (cvmx_helper_interface_get_mode(interface) !=
-               CVMX_HELPER_INTERFACE_MODE_SPI)) {
+       if (cvm_oct_validate_interface(interface)) {
                int i;
                u8 *ptr = dev->dev_addr;
                u64 mac = 0;
-- 
2.30.0

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel