On Mon, Mar 19, 2018 at 03:16:51PM -0700, Joel Fernandes (Google) wrote:
> On Tue, Feb 27, 2018 at 10:59 PM, Yisheng Xie wrote:
> > ashmem_mutex may create a chain of dependencies like:
> >
> > CPU0CPU1
> > mmap syscall ioctl syscall
>
On 03/20/2018 02:41 AM, Nicolas Dufresne wrote:
> Le mardi 20 mars 2018 à 00:46 +, Rohit Athavale a écrit :
>> Hi Hans,
>>
>> Thanks for taking the time to take a look at this.
>>
>>> This should definitely use the V4L2 API. I guess it could be added
>>> to staging/media with a big fat TODO tha
From: HariPrasath Elango
Remove the reduntant owner initialization from this platform driver as
the platform_driver_register() takes care of it.
Signed-off-by: HariPrasath Elango
---
drivers/staging/mt7621-gpio/gpio-mt7621.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt
Refactored the function `XGIfb_search_refresh_rate` by removing a level
of `if...else` block nesting. Removed unnecessary parantheses.
Signed-off-by: Pratik Jain
---
drivers/staging/xgifb/XGI_main_26.c | 63 +++--
1 file changed, 33 insertions(+), 30 deletions(-)
Hi Wolfram,
On Fri, Mar 16, 2018 at 10:23 PM, Wolfram Sang wrote:
>> To avoid allmodconfig/allyesconfig regressions on NO_DMA=y platforms,
>> this (drivers) series should be applied after the previous (core)
>> series (but not many people may notice/care ;-)
>
> I still don't get if there is a de
Hi Alan,
On Mon, Mar 19, 2018 at 5:06 PM, Alan Tull wrote:
> On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven
> wrote:
> This essentially removes this commit
>
> commit 1c8cb409491403036919dd1c6b45013dc8835a44
> Author: Sudip Mukherjee
> Date: Wed Aug 3 13:45:46 2016 -0700
>
> drivers/
Hi Boris,
On Sun, Mar 18, 2018 at 11:04 PM, Boris Brezillon
wrote:
> On Fri, 16 Mar 2018 14:51:47 +0100
> Geert Uytterhoeven wrote:
>
>> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
>> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
>> In most case
Hi Madalin-cristian,
On Mon, Mar 19, 2018 at 6:27 AM, Madalin-cristian Bucur
wrote:
>> -Original Message-
>> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
>> On Behalf Of Geert Uytterhoeven
>> Remove dependencies on HAS_DMA where a Kconfig symbol depends on
>> a
> To play it safe, you want to postpone the subsystem patches until the core
> part has landed upstream. I will rebase and resubmit after v4.17-rc1.
Thanks for the heads up. I'll wait for the rebased patch then and apply
it after rc1 for 4.17.
signature.asc
Description: PGP signature
_
I'm trying to review this, but I feel like this makes it slightly more
complicated for no reason. Why break it up into two loops?
> - i++;
> + ++i;
These are equivalent, so you should default to accepting the original
author's style. Otherwise the next person to touch th
On Tue, Mar 20, 2018 at 11:42:27AM +0530, wrote:
> On Mon, Mar 19, 2018 at 07:45:46PM +0100, Greg KH wrote:
> > On Wed, Mar 14, 2018 at 06:15:03PM +0530, hariprasath.ela...@gmail.com
> > wrote:
> > > From: HariPrasath Elango
> > >
> > > In this case,there is only a single switch case statement.
You got a valid point about `++i` and `i++`. But I still feel
that it is less complicated than previous one. I am explicitly
saying(in first loop) that we are skipping some values to get
to a specific index. Apart from that, we can avoid unncessary
wrapping and indentation. Logic becomes much more
On Tue, Mar 20, 2018 at 02:29:51PM +0300, Dan Carpenter wrote:
> On Tue, Mar 20, 2018 at 11:42:27AM +0530, wrote:
> > On Mon, Mar 19, 2018 at 07:45:46PM +0100, Greg KH wrote:
> > > On Wed, Mar 14, 2018 at 06:15:03PM +0530, hariprasath.ela...@gmail.com
> > > wrote:
> > > > From: HariPrasath Elango
From: HariPrasath Elango
In this case,there is only a single switch case statement.So replacing
by a simple if condition
Signed-off-by: HariPrasath Elango
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/st
On Tue, Mar 20, 2018 at 05:13:31PM +0530, hariprasath.ela...@gmail.com wrote:
> From: HariPrasath Elango
>
> In this case,there is only a single switch case statement.So replacing
> by a simple if condition
>
> Signed-off-by: HariPrasath Elango
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoper
Refactored the function `XGIfb_search_refresh_rate` by removing a level
of `if...else` block nesting. Removed unnecessary parantheses.
Signed-off-by: Pratik Jain
---
drivers/staging/xgifb/XGI_main_26.c | 61 +++--
1 file changed, 32 insertions(+), 29 deletions(-)
On Tue, Mar 20, 2018 at 02:05:49PM +0530, Pratik Jain wrote:
> Refactored the function `XGIfb_search_refresh_rate` by removing a level
> of `if...else` block nesting. Removed unnecessary parantheses.
>
> Signed-off-by: Pratik Jain
> ---
> drivers/staging/xgifb/XGI_main_26.c | 63
> +
MC portals may not be available at the initial probing attempt
due to dependencies on other modules.
Check the return value of the MC portal allocation function and
defer probing in case it's not available yet. For all other error
cases the behaviour stays the same.
Signed-off-by: Ioana Radulescu
On Tue, Mar 20, 2018 at 12:47:21PM +0100, Greg KH wrote:
> On Tue, Mar 20, 2018 at 05:13:31PM +0530, hariprasath.ela...@gmail.com wrote:
> > From: HariPrasath Elango
> >
> > In this case,there is only a single switch case statement.So replacing
> > by a simple if condition
> >
> > Signed-off-by:
From: HariPrasath Elango
In this case,there is only a single switch case statement.So replacing
by a simple if condition
Signed-off-by: HariPrasath Elango
---
changes since v3:
*rebase on latest code
*missed revision history in v2
drivers/staging/wilc1000/wilc_wfi_cfgoperatio
This commit replaces custom KS_WLAN_DEBUG which is not being used anymore
in favour of DEBUG which is the one included when debugging is enabled.
Signed-off-by: Sergio Paracuellos
---
This patch was in a previous patch series and only this one wasn't applied.
So include here v3 only for this rema
Refactored the function `XGIfb_search_refresh_rate` by removing a level
of `if...else` block nesting. Removed unnecessary parantheses.
Signed-off-by: Pratik Jain
---
drivers/staging/xgifb/XGI_main_26.c | 59 +++--
1 file changed, 30 insertions(+), 29 deletions(-)
On Tue, Mar 20, 2018 at 02:48:50PM +0100, Sergio Paracuellos wrote:
> This commit replaces custom KS_WLAN_DEBUG which is not being used anymore
> in favour of DEBUG which is the one included when debugging is enabled.
>
> Signed-off-by: Sergio Paracuellos
> ---
> This patch was in a previous patc
This patch removes max_event_count field of sme_info structure which is a
write only variable just being used for debug purposes.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 7 ---
drivers/staging/ks7010/ks_wlan.h | 4
2 files changed, 11 deletions(-)
d
This commit replaces custom KS_WLAN_DEBUG which is not being used anymore
in favour of DEBUG which is the one included when debugging is enabled.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/Makefile | 1 -
drivers/staging/ks7010/ks7010_sdio.c | 9 -
drivers/staging/
This patch was in a previous patch series and only this one
wasn't applied. So include here v4 which reviews and clean up
some write only fields used in debug mode.
First patch of v3 wasn't be modified. Just another extra patch
has been added removing write only fields only used in debug.
v3:
On 20 March 2018 at 01:06, NeilBrown wrote:
> On Sat, Mar 17 2018, Justin Skists wrote:
>
>> Fix sparse warning:
>>
>> CHECK drivers/staging//lustre/lnet/lnet/acceptor.c
>> drivers/staging//lustre/lnet/lnet/acceptor.c:243:30: warning: cast to
>> restricted __le32
>>
>> LNET_PROTO_TCP_MAGIC, as
This patch series contains fixes to avoid checkpatch issues and removed
unused code. Few patch contains changes related to NULL check and freeing of
dynamically allocated memory.
Ajay Singh (11):
staging: wilc1000: refactor scan() to free kmalloc memory on failure
cases
staging: wilc1000:
Removed the unnecessary global variables used to store gtk and ptk
information. Key data stored in the params was never access using these
global variables.
Global variables given below are removed
g_add_gtk_key_params;
g_key_gtk_params;
g_add_ptk_key_params;
g_key_ptk_params;
g_key_wep_params;
g
Added changes to free the allocated memory in scan() for error condition.
Also added 'NULL' check validation before accessing allocated memory.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 62 +--
1 file changed, 46 insertions(+), 16 delet
Fix 'line over 80 characters' issue found by checkpatch.pl script.
Refactor and split the function to avoid the checkpatch reported issues.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 145 --
1 file changed, 82 insertions(+), 63 deletions
Fix 'Avoid camelCase' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 18 +-
drivers/staging/wilc1000/wilc_wlan.h | 2 +-
3 files change
Refactor mgmt_tx() to fix line over 80 characters issue. Split the
function to avoid the checkpatch.pl warning. Returning the same error
code in case of memory allocation failure.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 187 +-
1 file
Fix 'Avoid camelCase' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/
Remove 'line over 80 char' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers
Fix 'line over 80 character' issue reported by checkpatch.pl script in
set_wiphy_params(). Directly used the 'wiphy' pointer received as
function argument instead of using 'priv->dev->ieee80211_ptr->wiphy'.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 -
Fix 'line over 80 characters' issues reported by checkpatch.pl script in
cfg_connect_result().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 34 +++
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/wilc1000/wi
Cleanup patch to remove unused struct data structure.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
in
Remove 'line over 80 characters' issues found by checkpatch.pl script
for following functions.
disconnect()
del_pmksa()
wilc_create_wiphy()
del_pmksa()
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12
1 file changed, 8 insertions(+), 4 deletions
This patch series removes some custom definitions included in the driver
replacing them with the ones used in the linux kernel global headers. Not
used function signature is removed also.
Sergio Paracuellos (3):
staging: ks7010: remove not used function signature
ks_wlan_read_config_file
s
This commit removes definition of function ks_wlan_read_config_file
which is not being used at all.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/staging/ks7010/ks_
This commit reviews custom definitions using custom bit macros changing
them for the ones defined in the bitops header file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/eap_packet.h | 33 -
1 file changed, 16 insertions(+), 17 deletions(-)
diff -
This commit reviews some custom defines changing them for the
globals defined in if_ether header file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/eap_packet.h | 8 +---
drivers/staging/ks7010/ks_hostif.c | 8
2 files changed, 5 insertions(+), 11 deletions(-)
diff
Hi Lorenzo,
Are we good with the explanation? Can I send the patch with the updated commit
comments?
Thanks
Sridhar
On 3/15/18, 11:24 AM, "Sridhar Pitchai" wrote:
Apologies for not aligning my reply, I just realized after looking into
the mail archive in LKML. I have aligned the repl
On Tue, Mar 20, 2018 at 5:04 AM, Geert Uytterhoeven
wrote:
Hi Geert,
> Hi Alan,
>
> On Mon, Mar 19, 2018 at 5:06 PM, Alan Tull wrote:
>> On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven
>> wrote:
>> This essentially removes this commit
>>
>> commit 1c8cb409491403036919dd1c6b45013dc8835a44
>
On Tue, Mar 20, 2018 at 05:56:15PM +, Sridhar Pitchai wrote:
> Hi Lorenzo,
> Are we good with the explanation? Can I send the patch with the
> updated commit comments?
Almost.
[...]
> Since we have the transparent SRIOV mode now, the short VF device name
> is no longer needed.
Can
On Tue, Mar 20, 2018 at 10:25:34PM +0530, Ajay Singh wrote:
> Added changes to free the allocated memory in scan() for error condition.
> Also added 'NULL' check validation before accessing allocated memory.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
The TODO list missed some issues before we can move the driver out of staging.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchi/TODO | 27 +++
1 file changed, 27 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/vchi/TODO
b/driv
The bcm2835-camera driver has already been imported. So remove it from the TODO.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchi/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/TODO
b/drivers/staging/vc04_se
Used checkpatch.pl to clean up spaces around if and for statements
to make it easier to read
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
b
C standard guarantees that:
global and static variables will be implicitly initialized to 0 or NULL
if no explicit initializer is given.
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Used checkpatch.pl to clean up spaces around
for statements to make it easier to read
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
b/dr
Remove unnecessary parentheses highlighted by checkpatch.pl
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
b/drivers/staging/rtl8723bs/os_dep/re
missing a blank line after declaration checkpatch warnings.
Issue found by checkpatch.pl
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
b/drivers/staging/rtl8723bs/os
Rename temporary local variable and add required blank line.
Fixes checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/pi433_if.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/stagin
Fixes checkpatch error: SPACING
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c
b/drivers/staging/mt7621-dma/mtk-hsdma.c
index 507cb68e7808..3ac120e42f3
This patchset fiexes errors, warnings and checks found by checkpatch.
Christian Lütke-Stetzkamp (7):
staging: mt7621-dma: Fix Pointer Location
staging: mt7621-dma: Fix Spacing
staging: mt7621-dma: Fix open brace position
staging: mt7621-dma: Remove assignment in if
staging: mt7621-dma: F
Fixes checkpatch error: POINTER_LOCATION
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
drivers/staging/mt7621-dma/ralink-gdma.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c
b/drivers
Fixes checkpatch error: OPEN_BRACE
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-dma/ralink-gdma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c
b/drivers/staging/mt7621-dma/ralink-gdma.c
index b550385a4519..
Fixes checkpatch error: ASSIGN_IN_IF by defining a new variable before if
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-dma/ralink-gdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c
b/drivers/staging/mt7621
Fixes checkpatch warning: BRACES
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 4 ++--
drivers/staging/mt7621-dma/ralink-gdma.c | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c
b/drivers/st
Fixes checkpatch check: PARENTHESIS_ALIGNMENT
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 29 +
drivers/staging/mt7621-dma/ralink-gdma.c | 55
2 files changed, 43 insertions(+), 41 deletions(-)
diff --g
Fixes checkpatch error: CODE_IDENT
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-dma/ralink-gdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c
b/drivers/staging/mt7621-dma/ralink-gdma.c
index 60d557fb6553..27
The receive processing may continue to happen while the
internal network device state is in RCU grace period.
The internal RNDIS structure is associated with the
internal netvsc_device structure; both have the same
RCU lifetime.
Defer freeing all associated parts until after grace
period.
Fixes:
On older versions of Windows, the host ignores messages after
vmbus channel is closed.
Workaround this by doing what Windows does and send the teardown
before close on older versions of NVSP protocol.
Reported-by: Mohammed Gamal
Fixes: 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split")
Si
This set of patches fixes issues identified by Vitaly Kuznetsov and
Mohammed Gamal related to state changes in Hyper-v network driver.
A lot of the issues are because setting up the netvsc device requires
a second step (in work queue) to get all the sub-channels running.
Stephen Hemminger (4):
Make common function for detaching internals of device
during changes to MTU and RSS. Make sure no more packets
are transmitted and all packets have been received before
doing device teardown.
Change the wait logic to be common and use usleep_range().
Changes transmit enabling logic so that trans
This makes sure that no CPU is still process packets when
the channel is closed.
Fixes: 76bb5db5c749 ("netvsc: fix use after free on module removal")
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/netvsc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drive
On Tue, Mar 20 2018, Christian Lütke-Stetzkamp wrote:
> Fixes checkpatch error: ASSIGN_IN_IF by defining a new variable before if
>
> Signed-off-by: Christian Lütke-Stetzkamp
> ---
> drivers/staging/mt7621-dma/ralink-gdma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
On Tue, Mar 20 2018, Christian Lütke-Stetzkamp wrote:
> This patchset fiexes errors, warnings and checks found by checkpatch.
>
> Christian Lütke-Stetzkamp (7):
> staging: mt7621-dma: Fix Pointer Location
> staging: mt7621-dma: Fix Spacing
> staging: mt7621-dma: Fix open brace position
> s
On Tue, Mar 20 2018, hariprasath.ela...@gmail.com wrote:
> From: HariPrasath Elango
>
> Remove the reduntant owner initialization from this platform driver as
> the platform_driver_register() takes care of it.
>
> Signed-off-by: HariPrasath Elango
> ---
> drivers/staging/mt7621-gpio/gpio-mt7621
Hi Lorenzo,
Transparent SRIOV is exposing the NIC directly to the kernel via
para-virtual device, unlike creating a netdev and associating it with the bond
driver. Further descriptions here,
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0c195567a8f6e82ea5535
Stefan Wahren writes:
> The TODO list missed some issues before we can move the driver out of staging.
>
> Signed-off-by: Stefan Wahren
> ---
> drivers/staging/vc04_services/interface/vchi/TODO | 27
> +++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/staging/
On Tue, 2018-03-20 at 20:26 +, Paul McQuade wrote:
> Used checkpatch.pl to clean up spaces around if and for statements
> to make it easier to read
Perhaps the commit message can be made clearer.
I think this is technically correct, but it would
be nicer to describe these changes as moving br
It needs to free of allocated params value in the goto error statement.
Signed-off-by: Ji-Hun Kim
---
Changes since v2:
- add kfree(params) on the error case of the function
- rename unclear goto statement name
- declare the params value at start of the function, so it can be free
end o
There is no failure checking on the param value which will be allocated
memory by kmalloc. Add a null pointer checking statement. Then goto error:
and return -ENOMEM error code when kmalloc is failed.
Signed-off-by: Ji-Hun Kim
---
Changes since v1:
- Return with -ENOMEM directly, instead of got
Hi Dan,
Thanks for your detailed review comments.
On Tue, 20 Mar 2018 22:46:32 +0300
Dan Carpenter wrote:
> On Tue, Mar 20, 2018 at 10:25:34PM +0530, Ajay Singh wrote:
> > Added changes to free the allocated memory in scan() for error condition.
> > Also added 'NULL' check validation before acc
Looks good. Thanks!
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
78 matches
Mail list logo
