On Tue, Mar 20, 2018 at 5:04 AM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote:
Hi Geert, > Hi Alan, > > On Mon, Mar 19, 2018 at 5:06 PM, Alan Tull <at...@kernel.org> wrote: >> On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven >> <ge...@linux-m68k.org> wrote: >> This essentially removes this commit >> >> commit 1c8cb409491403036919dd1c6b45013dc8835a44 >> Author: Sudip Mukherjee <sudipm.mukher...@gmail.com> >> Date: Wed Aug 3 13:45:46 2016 -0700 >> >> drivers/fpga/Kconfig: fix build failure >> >> While building m32r allmodconfig the build is failing with the error: >> >> ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined! >> >> Xilinx Zynq FPGA is using DMA but there was no dependency while >> building. >> >> Link: >> http://lkml.kernel.org/r/1464346526-13913-1-git-send-email-sudipm.mukher...@gmail.com >> Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> >> Acked-by: Moritz Fischer <moritz.fisc...@ettus.com> >> Cc: Alan Tull <at...@opensource.altera.com> >> Signed-off-by: Andrew Morton <a...@linux-foundation.org> >> Signed-off-by: Linus Torvalds <torva...@linux-foundation.org> > > Yes it does. The major change is that the first (core) series introduces > all needed dummies to do successful compile-testing on NO_DMA=y platforms. OK yes, I looked at the first patch that does the fix. Looks good. Thanks for doing this. > >>> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another >>> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". >>> In most cases this other symbol is an architecture or platform specific >>> symbol, or PCI. >>> >>> Generic symbols and drivers without platform dependencies keep their >>> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that >>> cannot work anyway. >>> >>> This simplifies the dependencies, and allows to improve compile-testing. >>> >>> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> >>> Reviewed-by: Mark Brown <broo...@kernel.org> >>> Acked-by: Robin Murphy <robin.mur...@arm.com> Acked-by: Alan Tull <at...@kernel.org> Regards, Alan > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > ge...@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
