On Mon, Jun 01, 2015 at 03:18:11PM +0900, Greg Kroah-Hartman wrote:
> On Mon, Jun 01, 2015 at 11:16:51AM +0530, Sudip Mukherjee wrote:
> > On Mon, Jun 01, 2015 at 07:05:30AM +0900, Greg Kroah-Hartman wrote:
> > > On Wed, May 20, 2015 at 08:56:56PM +0530, Sudip Mukherjee wrote:
>
> > And then ther
On 01/06/15 07:06, Sharma, Abhishek (A.) wrote:
From: Abhishek Sharma
Replace unnecessary conditional checks for variable 'ret' and replace
by single return statement.
Signed-off-by: Abhishek Sharma
diff --git a/drivers/staging/comedi/drivers/adv_pci1724.c
b/drivers/staging/comedi/drivers/a
On Sun, May 31, 2015 at 02:43:16PM -0500, Petros Koutoupis wrote:
> Attached is a patch for two modules: RapidDisk & RapidCache. RapidDisk is a
> Linux
> RAM drive module which allows the user to dynamically create, remove, and
> resize
> RAM-based block devices. RapidDisk is designed to work wit
On Sun, May 31, 2015 at 11:36:09AM +0900, gre...@linuxfoundation.org wrote:
> On Thu, May 28, 2015 at 08:51:06AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > The sm750fb driver has few Framebuffer configuration dependencies that
> > need to be selected in order to get compiled successfull
On 01/06/15 05:14, Joglekar Tejas wrote:
This patch fix warning given by checkpatch.pl abouts spaces given
before tab
Signed-off-by: Joglekar Tejas
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/driv
From: Hari Prasath Gujulan Elango
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully
Signed-off-by: Hari Prasath Gujulan Elango
---
v4: Final version with From name & signed off by matching
v3: Fix al
On Sun, May 31, 2015 at 11:34:23AM +0900, gre...@linuxfoundation.org wrote:
> On Fri, May 15, 2015 at 11:33:53AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > This trivial patch removes temporary variable to check return value of
> > a function and checks return value directly.
> >
> > Si
From: Hari Prasath Gujulan Elango
This trivial patch removes temporary variable to check return value of
a function and checks return value directly.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:signed off by and From names were not matching in previous
version as pointed out by Gr
On Sun, May 31, 2015 at 11:33:32AM +0900, gre...@linuxfoundation.org wrote:
> On Thu, May 14, 2015 at 09:04:00AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > remove an unwanted assignment to a variable which is overwritten in the
> > very next line.The first value assigned is not used.
>
From: Hari Prasath Gujulan Elango
remove an unwanted assignment to a variable which is overwritten in the
very next line.The first value assigned is not used.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2: From name & signed off by were not matching.Added the From
field in commit me
On Sun, May 31, 2015 at 09:56:54AM +0900, gre...@linuxfoundation.org wrote:
> On Tue, May 12, 2015 at 12:25:22PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > Fixed indentation issue in few lines.
> >
> > Signed-off-by: Hari Prasath Gujulan Elango
>
> Same name problem :(
v2 on the way
From: Hari Prasath Gujulan Elango
Fixed indentation issue in few lines
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:From name & signed off by were not matching.Added the From
field in commit message
---
drivers/staging/rtl8712/recv_linux.c | 4 ++--
1 file changed, 2 insertions(+)
From: Hari Prasath Gujulan Elango
Remove the ununsed Macro.This patch needs to be applied after my
previous patch is applied whose title is given below because this macro
becomes ununsed after that.This was suggested by Sudip.
staging: dgnc: delete all references to 'flipbuf'
Signed-off-by: Har
On Sat, May 30, 2015 at 11:18:00AM +0530, Sudip Mukherjee wrote:
> On Fri, May 29, 2015 at 07:17:37AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > This patch deletes all references to 'flipbuf'.Memory is allocated and
> > freed but never used anywhere in the driver.Also deleted an ununsed
On Mon, Jun 01, 2015 at 09:41:52AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> This trivial patch removes temporary variable to check return value of
> a function and checks return value directly.
>
This isn't an improvement. We want to adopt normal
On Sat, May 30, 2015 at 11:12:01AM +0530, Sudip Mukherjee wrote:
> On Thu, May 28, 2015 at 12:35:22PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > Check the return value of kcalloc first and then use the pointer.
> >
> > Signed-off-by: Gujulan Elango Hari Prasath
> > ---
>
> > -
> > -
From: Hari Prasath Gujulan Elango
Check the return value of kcalloc first and then use the pointer
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Deleted multiple empty lines as checkpatch.pl with strict
option warned about it as per review comments from sudip
---
drivers/st
On Mon, Jun 01, 2015 at 01:12:18PM +0300, Dan Carpenter wrote:
> On Mon, Jun 01, 2015 at 09:41:52AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > This trivial patch removes temporary variable to check return value of
> > a function and checks ret
On Sat, May 30, 2015 at 11:35:01AM +0530, Sudip Mukherjee wrote:
> On Fri, May 29, 2015 at 08:16:21AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > Remove the unwanted else block
> something is wrong. This patch is also not applying.
> I am on staging-testing.
>
> regards
> sudip
>
Sudi
From: Gujulan Elango Hari Prasath
Remove the unwanted else block
Signed-off-by: Gujulan Elango Hari Prasath
---
v2:From name & signed off by were not matching.Added the From
field in commit message.
---
drivers/staging/dgnc/dgnc_tty.c | 4
1 file changed, 4 deletions(-)
diff --g
On Fri, May 29, 2015 at 01:29:16PM -0700, K. Y. Srinivasan wrote:
> - if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO ||
> - vstor_packet->status != 0)
> + if (vstor_packet->status != 0) {
> + ret = -EINVAL;
> goto cleanup;
> + }
There is no
On Fri, May 29, 2015 at 01:29:14PM -0700, K. Y. Srinivasan wrote:
> From: keith.ma...@microsoft.com
Keith's name is wrong.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listi
On Mon, Jun 01, 2015 at 10:27:35AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Mon, Jun 01, 2015 at 01:12:18PM +0300, Dan Carpenter wrote:
> > On Mon, Jun 01, 2015 at 09:41:52AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > From: Hari Prasath Gujulan Elango
> > >
> > > This
On Mon, Jun 01, 2015 at 02:02:06PM +0300, Dan Carpenter wrote:
> On Mon, Jun 01, 2015 at 10:27:35AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Mon, Jun 01, 2015 at 01:12:18PM +0300, Dan Carpenter wrote:
> > > On Mon, Jun 01, 2015 at 09:41:52AM +, Gujulan Elango, Hari Prasath
> >
On Mon, Jun 01, 2015 at 10:08:46AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> Remove the ununsed Macro.This patch needs to be applied after my
> previous patch is applied whose title is given below because this macro
> becomes ununsed after that.This
On Mon, Jun 01, 2015 at 01:03:16PM +0900, Greg KH wrote:
> On Sun, May 31, 2015 at 11:24:42PM -0300, Gaston Gonzalez wrote:
> > On Mon, Jun 01, 2015 at 10:53:20AM +0900, Greg KH wrote:
> > > On Sun, May 31, 2015 at 10:41:52PM -0300, Gaston Gonzalez wrote:
> > > > On Mon, Jun 01, 2015 at 08:24:17AM
On Mon, Jun 01, 2015 at 09:05:54PM +0900, gre...@linuxfoundation.org wrote:
> On Mon, Jun 01, 2015 at 10:08:46AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > Remove the ununsed Macro.This patch needs to be applied after my
> > previous patch is
cleanup checkpatch.pl warnings about not needed else
clauses after a break or return
Signed-off-by: Antonio Murdaca
---
drivers/staging/lustre/lustre/fid/fid_request.c| 5 ++-
.../staging/lustre/lustre/include/lprocfs_status.h | 3 +-
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 36
From: Madhusudhanan Ravindran
This patch attempts to simplify the debugging using standard
dev_dbg call so that individual debug prints can be enabled or
disbled by dynamic debugging rather than using module params.
Signed-off-by: Madhusudhanan Ravindran
---
v2: added From: line in the changelo
From: Madhusudhanan Ravindran
removed the commented INFO lines.
Signed-off-by: Madhusudhanan Ravindran
---
v2: added From: line in the changelog.
---
drivers/staging/emxx_udc/emxx_udc.c | 26 --
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/emxx_udc/em
From: Chaitanya Dhere
In this patch, the if, else conditions are modified to remove the
unnecessary equality checks. This change was detected with help of
coccinelle tool.
Signed-off-by: Chaitanya Dhere
---
.../staging/rtl8192u/ieee80211/ieee80211_softmac.c |6 ++
1 file changed, 2 ins
From: Chaitanya Dhere
This change was detected with help of coccinelle tool.
Signed-off-by: Chaitanya Dhere
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
From: Hari Prasath Gujulan Elango
Use a table to get a channel plan from a given country code.This was a
TODO mentioned as a comment in the driver.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 19 ---
drivers/staging/rtl8188e
On Mon, Jun 01, 2015 at 12:39:31PM +, Dhere, Chaitanya (C.) wrote:
> From: Chaitanya Dhere
>
> This change was detected with help of coccinelle tool.
Hi,
can you please let me know how to use coccinelle to detect indention
issues. I never knew coccinelle can be used to check these also.
rega
Fixed coding style issues detected by checkpatch.pl in r819xU_firmware.h and
removed commented macro that was no longer needed.
Changes since v1: Removed commented macro instead of fixing C99 comment style
suggested by
Buţiu Alexandru Octavian (2):
staging: drivers: rtl8192u: r819xU_firmware.h
Removed commented macro that was no longer needed
Signed-off-by: Buţiu Alexandru Octavian
---
drivers/staging/rtl8192u/r819xU_firmware.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.h
b/drivers/staging/rtl8192u/r819xU_firmware.h
index cfa22
Fixed coding style issue line "over 80 characters" detected by
checkpatch.pl in r819xU_firmware.h
Signed-off-by: Buţiu Alexandru Octavian
---
drivers/staging/rtl8192u/r819xU_firmware.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.
From: Hari Prasath Gujulan Elango
This patch deletes all references to 'flipbuf'.Memory is allocated and
freed but never used anywhere in the driver.Also deleted an ununsed
Macro defined in the header file.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/dgnc/dgnc_driver.c | 9 -
From: Hari Prasath Gujulan Elango
Remove the ununsed Macro
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/dgnc/dgnc_driver.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index de9e71c..0ec4073 100644
Really both patches should have been folded together.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Jun 01, 2015 at 04:18:17PM +0300, Dan Carpenter wrote:
> Really both patches should have been folded together.
>
> regards,
> dan carpenter
>
Yes Dan they can very well be a single patch.I have already sent
multiple versions of this patch and its confusing.I will leave it as it
is for n
On Mon, Jun 01, 2015 at 01:26:39PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Mon, Jun 01, 2015 at 04:18:17PM +0300, Dan Carpenter wrote:
> > Really both patches should have been folded together.
> >
> > regards,
> > dan carpenter
> >
>
> Yes Dan they can very well be a single patch.I
Hi all,
With four security critical bug patches having finally been put in
Greg's for-linus branch [1][2][3][4], I'd like to turn attention back
at the bigger issue. Where is the maintainer of this driver during
these discussions? The MAINTAINERS file lists Shigekatsu Tateno, and
in a commit [5] f
Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c
Signed-off-by: Douglas Barbonaglia Sathler Figueiredo
---
drivers/staging/wlan-ng/prism2fw.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c
b/drivers/staging/wlan-ng
On Mon, 2015-06-01 at 13:04 +0900, Greg KH wrote:
> On Sun, May 31, 2015 at 09:43:57PM -0500, Petros Koutoupis wrote:
> 1969-12-31 18:00:00.0 -0600
> > +++ linux-next/drivers/staging/rapiddisk/TODO 2015-05-31
> > 21:35:26.683515775 -0500
> > @@ -0,0 +1,5 @@
> > +TODO:
> > +- ch
Dan,
You have indeed given me a good amount of homework. Anyway, I will address
everything
according to your comments and suggestions and resubmit to the "real" part of
the kernel
and not staging. Thank you very much.
Regards,
Petros
On Mon, 2015-06-01 at 12:18 +0300, Dan Carpenter wrote:
> O
On Sun, May 31, 2015 at 10:16:37AM +0900, Greg KH wrote:
> On Tue, May 26, 2015 at 02:40:57PM -0400, Don Zickus wrote:
> > From: David Kershner
> >
> > Diagchannel.h is used primarily for the diagnostics channel. The
> > diagnostics channel is not being used by linux guests currently, so
> > the
On Sun, May 31, 2015 at 10:17:30AM +0900, Greg KH wrote:
> On Tue, May 26, 2015 at 02:40:45PM -0400, Don Zickus wrote:
> > Hi,
> >
> > GregKH ran into an issue where the last 13 patches didn't apply.
> >
> > It looks like Ben cleaned up the patches to address checkpatch.pl
> > warnings and forgot
From: Hari Prasath Gujulan Elango
Remove braces around else clause with single line
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/xgifb/vb_init.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xg
On 06/01, Gujulan Elango, Hari Prasath (H.) wrote:
> From: Hari Prasath Gujulan Elango
>
> Remove braces around else clause with single line
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/xgifb/vb_init.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
This patch set contains the remaining changes from our driver cleanup
efforts, that did not apply to staging-next. No functional changes have
been made, these have simply been rebased so they will apply cleanly,
and have proper sign-offs.
David Kershner (4):
staging: unisys: Update diag serverit
From: Don Zickus
In order for bus/dev_info structs to become public structs, one
element, pending_msg_hdr, needs to become opaque. This is to keep
all the internals of the controlvm struct private to the bus layer.
So a simple conversion of embedding the pending_msg_hdr struct into
a pointer is
From: Don Zickus
The bus driver doesn't work in server mode, just remove the left over
pieces.
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c| 66 +++---
drivers/staging/unisys/visorbus/visorbus_private.h | 5 --
From: Don Zickus
This patch removes the legacy bus_info struct and instead creates
and passes around a traditional struct device.
This allows us to remove a lot of the various look up code and
removes the doubt if the struct exists or not.
Half of the churn is just the conversion of visorchipse
From: Don Zickus
When unloading a module, we need to cleanup the platform registration.
However, unregistering the platform uncovered a couple of quirks, namely
a missing device_release function. Fix things up so module unload works
and allows us to reload the module.
Signed-off-by: Don Zickus
From: Jes Sorensen
min_size/max_size aren't used anywhere, and they were just causing
headaches in the drivers being ported over to the new interfaces.
Signed-off-by: Jes Sorensen
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-
As the actually intended timeout is not documented and msecs_to_jiffies
timeouts can be a factor 10 different from the current effective timeout
this needs to be checked by someone who knows the details of this driver
in any case it should be passed in a HZ independent manner.
I need an ack from
From: Don Zickus
Instead of creating a channel struct to temporarily hold the channel
info and passing it through multiple functions until the device is
created, just create the channel from the start.
This allows us to remove the channel_info struct.
I noticed 'chan_info.addr_type' was not bei
From: David Kershner
Diagchannel.h is used primarily for the diagnostics channel. The
diagnostics channel is not being used by linux guests currently, so
the majority of the file is not needed. What is left is what is
needed to perform postcode vmcalls. Those postcodes will eventually
end up in t
From: Don Zickus
When we combined visorchipset and visorbus into one driver we negelected
to strip out some of the MODULE_ stuff from one of the files. When
building the drivers in, it causes a WARN that we try to create
/proc/modules/visorbus/version when it is already created.
visorchipset.c
From: David Kershner
Give the enum the correct values instead of based on other values.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/diagchannel.h | 34
1 file changed, 10 insertions(+), 24 deletions(-)
diff --git
From: Don Zickus
The bus device and regular device were using two different
structs. Let's combine them as they are not entirely different
from one another.
This allows us to move this creation up the stack later and
actually remove bus/dev_info easily.
Most of the churn is just renaming devda
From: Don Zickus
Removing stuff that isn't being used. Another prepartion patch to
allow us to use visor_device everywhere without the baggage of
bus/dev_info.
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c| 72
From: Don Zickus
I used 0 as the device id for the bus root, neglecting the fact that
device 0 is a valid id in Unisys's configuration. Modify this to
use UINT_MAX instead as a unique number.
As fallout from this change it was noticed the bus_no and dev_no was not
defined the same way consisten
From: Don Zickus
In order to remove bus_info, we need to migrate vbus_hdr_info into
the public namespace of visor_device. Because the struct is private,
we use a void * to hide the contents.
As a result, we need to allocate vbus_hdr_info and manage it.
Also work around vbus_valid, as that vari
From: David Kershner
Get rid of unused values in the enum.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/diagchannel.h | 32 +++-
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/unisys/inc
From: David Kershner
When the bus device was created the list_all variables were not
being initialized. When the CONTROLVM_BUS_CONFIGURE message
was being sent, it was failing to find the bus and produced a
panic. Initialize the bus_info->list_all variable by doing a
INIT_LIST_HEAD.
Signed-off-b
From: Don Zickus
This patch removes the legacy dev_info struct and instead creates
and passes around a traditional struct device.
This allows us to remove a lot of the various look up code and
removes the doubt if the struct exists or not.
Half of the churn is just the conversion of visorchipse
On 05/31/2015 08:04 AM, Jakub Sitnicki wrote:
There is no interface to register PIDs of processes the driver should
send a signal to. Remove it.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/include/drv_types.h | 1 -
drivers/staging/rtl8188eu/include/osdep_service.h | 2
On 05/28/2015 10:04 PM, Drew Fustini wrote:
Add static declarations to statisfy sparse warnings in:
drivers/staging/unisys/visorbus/visorbus_main.c
Hi,
I'd really like to take this patch, but it doesn't apply at the end of
the current set of patches I'm working with, and if I put it ahead
Signed-off-by: Stanislav Kholmanskikh
---
Changes since V1:
Split the V1 series into more logically unrelated patches
and updated patch descriptions accordingly.
drivers/staging/wilc1000/wilc_spi.c | 6 +++---
drivers/staging/wilc1000/wilc_wlan.c | 6 ++
2 files changed, 5 insertions(+), 7
WILC_WFI_init_mon_interface() should be declared with 'const char *name',
not simply 'char *name', because this 'name' argument is only passed
as is to alloc_netdev(), and alloc_netdev(), in turn,
expects 'const char *'.
Signed-off-by: Stanislav Kholmanskikh
---
drivers/staging/wilc1000/linux_mo
Fixed several syntax/style issues found with checkpatch.pl.
Signed-off-by: Stanislav Kholmanskikh
---
drivers/staging/wilc1000/coreconfigurator.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/
Aligned enum members to follow a common style per enum.
Signed-off-by: Stanislav Kholmanskikh
---
drivers/staging/wilc1000/coreconfigurator.c | 29 +++---
drivers/staging/wilc1000/coreconfigurator.h | 62 ++---
2 files changed, 46 insertions(+), 45 deletions(-)
d
Hello.
On Sun, May 31, 2015 at 08:59:41AM +0900, Greg KH wrote:
> On Sat, May 30, 2015 at 11:44:18PM +0300, Stanislav Kholmanskikh wrote:
> > This patch reduces (a little bit) the amount of compile time
> > warnings.
> >
> > The change of WILC_WFI_init_mon_interface() prototype seems to be ok,
>
Hi Greg,
Next try, I've rebased on top of your staging-testing branch
and fixed the two build errors.
While I had done my normal build testing on the driver (a few
hundred randconfig builds), I don't normally do 'make clean',
so the stale Makefile entry ended up picking the old object
files and s
The EXPORT_SYMTAB symbol has not been used in Linux for a very
long time, the driver does not need to set it.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/Makefile
b/drivers/stagin
The driver contains an abstraction for message queues, with
optional unused features, while the driver requires the main
feature.
This makes the msgqueue code unconditional as it's required
but removes the unused parts.
A later cleanup should remove the entire msgqueue code
and replace it with so
The driver has a simple wrapper around timer_list, and an
optional but unused feature to make the timer periodic.
This removes support for the periodic timer and simplifies
the code around timers.
A follow-up should replace the remaining wrapper with
open-coded timers.
Signed-off-by: Arnd Bergma
The abstraction for time in this driver is completely
unused, so remove it.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 2 +-
drivers/staging/wilc1000/wilc_osconfig.h | 1 -
drivers/staging/wilc1000/wilc_oswrapper.h | 5 -
drivers/staging/wilc1000/wilc_pla
The wilc1000 driver produces a lot of warnings about invalid
casts between const and non-const variables. This reworks
the code to avoid all those warnings, by marking variables
and function arguments const.
A lot of the types use WILC_Uint8, I change them to const u8
for style reasons, as I'm tou
The driver has a simple wrapper around msleep, as well as
a more advanced sleep function that is unused. This removes
the unused code and the options to turn the feature on or
off.
A follow-up should rework the code to use msleep directly.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc10
All the remaining features from the OS abstraction layer
are not used at all in the driver, so we can just remove
the remaining references to them.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wilc_errorsupport.h | 17
drivers/staging/wilc1000/wilc_event.h| 123 ---
This avoids the remaining warnings that one gets on a normal
build: unused variables, unused labels, and invalid printk
format strings.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 8 ++--
drivers/staging/wilc1000/linux_wlan_spi.c | 3 ---
drivers/staging/wilc
The driver contains its own abstraction for memory allocation,
most of it unused. This removes the unused parts, but the
rest should also be removed later.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wilc_memory.c| 5 --
drivers/staging/wilc1000/wilc_memory.h| 93 -
The driver provides wrappers for a lot of string operations.
Some of them are unused, while others should be replaced
with normal kernel functions.
This replaces the unused ones for now, and leaves the other
ones for a later cleanup.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wil
The driver has its own API for semaphores. This should
be replaced with mutexes and completions, but for the moment
we can start by removing the obviously unused parts.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/wilc_osconfig.h | 1 -
drivers/staging/wilc1000/wilc_oswrapper.h |
On Sunday 31 May 2015 08:58:13 Greg KH wrote:
> On Sat, May 30, 2015 at 12:09:23PM +0530, Sudip Mukherjee wrote:
> > On Fri, May 29, 2015 at 10:52:16PM +0200, Arnd Bergmann wrote:
> > > The abstraction for time in this driver is completely
> > > unused, so remove it.
> > >
> > > Signed-off-by: Arn
The various semaphore functions all directly translate into
sema_init(), down() and up(), so we can just remove the API.
This is a mostly automated conversion using simple sed scripts,
plus some manual changes to account for down() returning no
error.
As a positive side-effect, down() no longer h
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, June 1, 2015 3:57 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parallels.com; h...@infradea
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, June 1, 2015 3:43 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parallels.com; h...@infradea
I have crossed off one item on the list, but found a few others that should
not get lost, so here is an update of the wilc1000 list
Signed-off-by: Arnd Bergmann
diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO
index 5dfeb3eda599..95199d80a3e4 100644
--- a/drivers/stagin
Thanks for reviewing.
The 2 struct members were not marked as __user, which this patch does
here. This was causing warnings with copy from/to user (see commit
description). This patch also propagates the annotation to the couple
of functions that are using those members.
On Sat, May 30, 2015 at 7
On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote:
> On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote:
> > Remove two lines at ieee80211_wep_null which checkpatch.pl reported as
> > errors.
> > The first one because it has a C99 comment style and the second one because
> > it is a
fix checkpatch.pl warning about unnecessary parentheses
Signed-off-by: Antonio Murdaca
---
drivers/staging/lustre/lustre/lov/lov_obd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c
b/drivers/staging/lustre/lustre/lov/lov_obd.c
in
On 30/05/15 09:20, Vladimirs Ambrosovs wrote:
> This patch fixes the init function for the iio_simple_dummy driver.
> The main issues were absence of kfree for the allocated array, and no
> devices being removed in case the probe function fails, running in a loop.
>
> Signed-off-by: Vladimirs Ambr
On 30/05/15 09:20, Vladimirs Ambrosovs wrote:
> Fix the module_param "instances" type to uint, since the variable type
> holding the value is unsigned.
>
> Signed-off-by: Vladimirs Ambrosovs
Applied to the togreg branch of iio.git - which will get pushed
out as testing in a few days. Or just poss
On 30/05/15 09:20, Vladimirs Ambrosovs wrote:
> The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and
> iio_dummy_evgen_release_irq() were changed to return void instead of int.
>
> Signed-off-by: Vladimirs Ambrosovs
applied as per previous patch.
> ---
> drivers/staging/iio
Fix the following sparse warnings:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning:
incorrect type in assignment (different base types)
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:expected
restricted __le16 [usertype] frame_ctl
drivers/staging/rtl8192
On 06/01, Gujulan Elango, Hari Prasath (H.) wrote:
> From: Hari Prasath Gujulan Elango
The above line should not be here and it will appear as long as the
email client is not configured correctly. Just take a step back and
fix it as this is something that you do once and then it remains
*correct*
1 - 100 of 127 matches
Mail list logo
