From: Hari Prasath Gujulan Elango <hguju...@visteon.com>

Check the return value of kcalloc first and then use the pointer

Signed-off-by: Hari Prasath Gujulan Elango <hguju...@visteon.com>
---
        v2:Deleted multiple empty lines as checkpatch.pl with strict
        option warned about it as per review comments from sudip
---
 drivers/staging/dgnc/dgnc_driver.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_driver.c 
b/drivers/staging/dgnc/dgnc_driver.c
index 7546aff..0ed16db 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -384,13 +384,13 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
 
        /* make a temporary message buffer for the boot messages */
        brd->msgbuf_head = kcalloc(8192, sizeof(u8), GFP_KERNEL);
-       brd->msgbuf = brd->msgbuf_head;
-
-       if (!brd->msgbuf) {
+       if (!brd->msgbuf_head) {
                kfree(brd);
                return -ENOMEM;
        }
 
+       brd->msgbuf = brd->msgbuf_head;
+
        /* store the info for the board we've found */
        brd->magic = DGNC_BOARD_MAGIC;
        brd->boardnum = dgnc_NumBoards;
-- 
1.9.1
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to