Re: [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements

On Thu, Feb 12, 2015 at 10:49:46PM -0800, Tolga Ceylan wrote: > Code reformatting based on checkpatch.pl with --strict: > 1) Lines over 80 characters were fixed > 2) Alignment should match open paranthesis cases corrected > 3) Comparison to NULL rewritten as !indio_dev you are doing three differen

[PATCH 1/1] Staging: gdm724x: code style improvements

Corrections based on checkpatch.pl with --strict. 1) Lines over 80 were corrected 2) Alignment should match open paranthesis cases corrected 3) Comparisons such as if (x == NULL) rewritten as if (!x) 4) CamelCase variables renamed 5) Missing spaces between operators added 6) Unnecessary blank lines

[PATCH] [media] staging: dt3155v4l: Switch to using managed resource with devm_

This patch uses managed resource APIs to allocate memory in order to simplify the driver unload or failure cases Signed-off-by: Kiran Padwal --- drivers/staging/media/dt3155v4l/dt3155v4l.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/d

Re: [PATCH 1/1] Staging: gdm724x: code style improvements

On Fri, Feb 13, 2015 at 12:56:03AM -0800, Tolga Ceylan wrote: > Corrections based on checkpatch.pl with --strict. > 1) Lines over 80 were corrected > 2) Alignment should match open paranthesis cases corrected > 3) Comparisons such as if (x == NULL) rewritten as if (!x) > 4) CamelCase variables rena

Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

On Tue, 10 Feb 2015 14:57:53 +0530, Parth Sane wrote: > A few months earlier I had requested addition of the MT7601 WiFi > dongle module into the kernel. I was told that the needful would be > done in the rt2x00 driver. Could you guys update me with the status? There is a new mac80211-based driver

[PATCH] dgnc: Use ccflags -y instead of EXTRA_CFLAGS

checkpatch fix Signed-off-by: Cass May --- drivers/staging/dgnc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile index b69f7b6..d70323e 100644 --- a/drivers/staging/dgnc/Makefile +++ b/drivers/staging/dgnc/

[PATCH v2] dgnc: Use ccflags -y instead of EXTRA_CFLAGS

Correction to syntax error in previous patch version. Apologies. Signed-off-by: Cass May --- drivers/staging/dgnc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile index b69f7b6..a278900 100644 --- a/drivers

[PATCH] staging: rtl8188eu: Fix possible leak in rtl88eu_download_fw()

Function rtl88eu_download_fw() may leak the memory of the already requested firmware data due to direct returns in the error paths. Ensure cleanup by using a centralized exit path. Detected by Coverity CID 1269127. Signed-off-by: Christian Engelmayer --- Compile tested only. Applies against branc

Re: [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements

On Fri, Feb 13, 2015 at 12:27 AM, Sudip Mukherjee wrote: > > you are doing three different types of changes here. one patch should have > only one type of change. > > regards > sudip Thank you, I'll split this up and resubmit. Regards, Tolga ___ devel

Re: [PATCH 1/1] Staging: gdm724x: code style improvements

On Fri, Feb 13, 2015 at 1:05 AM, Dan Carpenter wrote: > > You're doing too many things at one. This should probably be split into > 7 patches. I will split this up and resubmit. > > >> u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x) >> @@ -39,7 +38,7 @@ u16 gdm_cpu_to_dev16(struct gdm_endia

Re: [PATCH v2] dgnc: Use ccflags -y instead of EXTRA_CFLAGS

On Fri, Feb 13, 2015 at 08:01:36PM +, Cass May wrote: > Correction to syntax error in previous patch version. Apologies. > Put that stuff under the --- cut off line and not in the permanent kernel git log. Changelog is missing. checkpatch.pl by itself is not sufficient justification. Why d

[PATCH] ion: improve ion_phys error message

Clients often get confused when ion_phys errors out due to some heap being used that they didn't expect. Add the heap name and heap type to the error message to make it more obvious. Signed-off-by: Mitchel Humpherys --- drivers/staging/android/ion/ion.c | 4 ++-- 1 file changed, 2 insertions(+)

[PATCH 1/5] Staging: gdm724x: code style improvements

Corrections based on checkpatch.pl with --strict. Added missing spaces between operators. Signed-off-by: Tolga Ceylan --- drivers/staging/gdm724x/gdm_lte.c | 6 +++--- drivers/staging/gdm724x/gdm_mux.c | 4 ++-- drivers/staging/gdm724x/gdm_mux.h | 4 ++-- drivers/staging/gdm724x/gdm_tty

[PATCH 5/5] Staging: gdm724x: code style improvements

Unnecessary blank lines removed Signed-off-by: Tolga Ceylan --- drivers/staging/gdm724x/gdm_endian.c | 1 - drivers/staging/gdm724x/gdm_mux.c| 5 - drivers/staging/gdm724x/gdm_tty.c| 1 - drivers/staging/gdm724x/gdm_tty.h| 1 - drivers/staging/gdm724x/hci_packet.h | 1 - 5 files

[PATCH 4/5] Staging: gdm724x: code style improvements

In memory allocation (kzalloc, kmalloc) arguments sizeof(struct foo) rewritten as sizeof(*foo_obj). Signed-off-by: Tolga Ceylan --- drivers/staging/gdm724x/gdm_mux.c | 8 drivers/staging/gdm724x/gdm_tty.c | 2 +- drivers/staging/gdm724x/gdm_usb.c | 10 +- 3 files changed, 10 i

[PATCH 3/5] Staging: gdm724x: code style improvements

Comparisons such as if (x == NULL) rewritten as if (!x) Signed-off-by: Tolga Ceylan --- drivers/staging/gdm724x/gdm_lte.c | 6 +++--- drivers/staging/gdm724x/gdm_mux.c | 4 ++-- drivers/staging/gdm724x/gdm_tty.c | 2 +- drivers/staging/gdm724x/gdm_usb.c | 14 +++--- 4 files changed, 1

[PATCH 2/5] Staging: gdm724x: code style improvements

Alignment should match open paranthesis cases corrected Signed-off-by: Tolga Ceylan --- drivers/staging/gdm724x/gdm_lte.c | 32 drivers/staging/gdm724x/gdm_lte.h | 14 +++--- drivers/staging/gdm724x/gdm_mux.c | 5 +++-- drivers/staging/gdm724x/gdm_