On Fri, Feb 13, 2015 at 12:56:03AM -0800, Tolga Ceylan wrote: > Corrections based on checkpatch.pl with --strict. > 1) Lines over 80 were corrected > 2) Alignment should match open paranthesis cases corrected > 3) Comparisons such as if (x == NULL) rewritten as if (!x) > 4) CamelCase variables renamed > 5) Missing spaces between operators added > 6) Unnecessary blank lines removed > 7) in mem alloc arguments sizeof(struct foo) rewritten as sizeof(*foo_obj) >
You're doing too many things at one. This should probably be split into 7 patches. > u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x) > @@ -39,7 +38,7 @@ u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x) > if (ed->dev_ed == ed->host_ed) > return x; > > - return Endian16_Swap(x); > + return ENDIAN16_SWAP(x); > } All the changes are good except these. We have standard macros cpu_to_be16()/le16() and back for these. regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
