On Fri, Feb 13, 2015 at 08:01:36PM +0000, Cass May wrote: > Correction to syntax error in previous patch version. Apologies. >
Put that stuff under the --- cut off line and not in the permanent kernel git log. Changelog is missing. checkpatch.pl by itself is not sufficient justification. Why did the authors of checkpatch think this way is better? > Signed-off-by: Cass May <c...@cassm.net> > --- > drivers/staging/dgnc/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile > index b69f7b6..a278900 100644 > --- a/drivers/staging/dgnc/Makefile > +++ b/drivers/staging/dgnc/Makefile > @@ -1,4 +1,4 @@ > -EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\" > +ccflags-y := -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\" This isn't the right fix. Is this stuff even needed? Hopefully, not but please check and resend a different fix. regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
