Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin
---
drivers/staging/wlan-ng/hfa384x_usb.c | 52 -
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
Removed unnecessary typedefs from hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin
---
drivers/staging/wlan-ng/hfa384x_usb.c | 38 -
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/
changed printk(KERN_WARNING .. to pr_warn
Signed-off-by: Sherif Shehab Aldin
---
drivers/staging/wlan-ng/hfa384x_usb.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 2a44c79..a389c
changed declaration of ctlx_str to:
static const char * const ctlx_str[]
Signed-off-by: Sherif Shehab Aldin
---
drivers/staging/wlan-ng/hfa384x_usb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_us
In hfa384x_usb.c:
Fixed allignment issues after open braces
Moved Logical continuations to the correct lines
Removed unnecessary blank lines
Signed-off-by: Sherif Shehab Aldin
---
drivers/staging/wlan-ng/hfa384x_usb.c | 32 ++--
1 file changed, 14 insertions(+), 18
Removed lines that were ignored by #if 0
Signed-off-by: Sherif Shehab Aldin
---
drivers/staging/wlan-ng/hfa384x_usb.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 777b1e7..4e9df48 100644
--- a/driv
Fixed Alignment to match open parenthesis in hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin
---
drivers/staging/wlan-ng/hfa384x_usb.c | 113 +
1 file changed, 59 insertions(+), 54 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/stagi
Removed multiple assignments from hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin
---
drivers/staging/wlan-ng/hfa384x_usb.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 64b51b7..777b
Removed Unnecessary space after function pointer name
Signed-off-by: Sherif Shehab Aldin
---
drivers/staging/wlan-ng/hfa384x_usb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 65e59a3..
On Thu, Apr 03, 2014 at 02:25:54AM +0200, Sherif Shehab Aldin wrote:
> Removed unnecessary typedefs from hfa384x_usb.c
>
> Signed-off-by: Sherif Shehab Aldin
You've broken this patch set up in a wrong way. It should have just
been one patch. Don't introduce a warning and fix it later. The two
On Thu, Apr 03, 2014 at 09:13:29AM +0200, Sherif Shehab Aldin wrote:
> static void hfa384x_usbctlx_resptimerfn(unsigned long data)
> {
> - hfa384x_t *hw = (hfa384x_t *) data;
> + hfa384x_t *hw = (hfa384x_t *)
> unsigned long flags;
>
> spin_lock_irqsave(&hw->ctlxq.lock, flag
On Thu, Apr 03, 2014 at 09:11:59AM +0200, Sherif Shehab Aldin wrote:
> Removed unnecessary typedefs from hfa384x_usb.c
>
> Signed-off-by: Sherif Shehab Aldin
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 38
> -
> 1 file changed, 18 insertions(+), 20 deletion
Yes I see the error. I have tried to build the wlan-ng driver using make
M=drivers/staging/wlan-ng/ but it built nothing, so I went one step up
and built make M=drivers/staging/ as a whole and it built fine, I think
I am missing something here, how do I specify this module for the build
to test
This Makefile tries to set the DEBUG macro but it uses an unknown
Kconfig macro to do so. Since no code appears to even care about the
DEBUG macro this line can safely be removed.
Signed-off-by: Paul Bolle
---
Completely untested.
By the way, do de...@driverdev.osuosl.org and
de...@linuxdriverpr
Sorry for the delay, I'm just catching up with some old emails.
On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote:
> Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by
> the TODO list.
>
> Signed-off-by: Kristina Martšenko
Have you tested this change?
regard
On Tue, Mar 25, 2014 at 10:43:58PM -0500, Chase Southwood wrote:
> There were just a handful of more while loops in this file that needed
> timeouts, and this patch takes care of them. One new callback is
> introduced, and all of the proper comedi_timeout() calls are then used.
>
> Signed-off-by:
On Tue, Mar 25, 2014 at 04:38:15PM -0400, Mark Hounschell wrote:
> This patch fixes a checkpatch warning
> "Macros with complex values should be enclosed in parenthesis"
>
Really this is a bug in checkpatch.pl. We have the source for that, so
we should fix it instead of working around it.
regar
On Tue, Mar 25, 2014 at 04:38:18PM -0400, Mark Hounschell wrote:
> This patch fixes a checkpatch warning about adding typedefs
> in dgap.h
>
> Signed-off-by: Mark Hounschell
> Cc: Greg Kroah-Hartman
> ---
> drivers/staging/dgap/dgap.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On Thu, Mar 27, 2014 at 08:28:44PM -0700, Jimmy Li wrote:
> You are right, I found that variable buf also don't make sense here,
> maybe this could be more clear.
>
> param = kzalloc(sizeof(struct viawget_wpa_param), GFP_KERNEL);
> if (param == NULL)
> return -ENOMEM;
>
> removing
On Thu, Apr 03, 2014 at 10:21:21AM +0200, Sherif wrote:
> Yes I see the error. I have tried to build the wlan-ng driver using
> make M=drivers/staging/wlan-ng/ but it built nothing, so I went one
> step up and built make M=drivers/staging/ as a whole and it built
> fine, I think I am missing someth
Yes I enabled it:
$ grep PRISM2_USB .config
CONFIG_PRISM2_USB=m
But still getting the same output:
$ make M=drivers/staging/wlan-ng/
Building modules, stage 2.
MODPOST 0 modules
On 04/03/2014 11:38 AM, Dan Carpenter wrote:
On Thu, Apr 03, 2014 at 10:21:21AM +0200, Sherif wrote:
Yes I see t
On Tue, Mar 25, 2014 at 09:30:18PM +0100, sil...@port1024.net wrote:
> From: Silvio F
Don't use this header for your own patches.
>
> This patch fixes the following type of sparse warnings:
>
> drivers/staging/vt6655/wpactl.c:596:47: warning: cast from restricted gfp_t
> drivers/staging/vt6655
On Thu, Apr 03, 2014 at 11:42:47AM +0200, Sherif wrote:
> Yes I enabled it:
> $ grep PRISM2_USB .config
> CONFIG_PRISM2_USB=m
>
> But still getting the same output:
> $ make M=drivers/staging/wlan-ng/
> Building modules, stage 2.
> MODPOST 0 modules
>
That's very odd. It works for me. I do
On 03/04/14 11:32, Dan Carpenter wrote:
> Sorry for the delay, I'm just catching up with some old emails.
No problem.
> On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote:
>> Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by
>> the TODO list.
>>
>> Signed-off-b
Signed-off-by: Mike Sampson
This fixes a sparse warning:
warning: symbol 'cfs_wi_data' was not declared. Should it be static?
---
drivers/staging/lustre/lustre/libcfs/workitem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/workitem.c
On Thu, Apr 03, 2014 at 01:00:53PM +0300, Kristina Martšenko wrote:
> On 03/04/14 11:32, Dan Carpenter wrote:
> > Sorry for the delay, I'm just catching up with some old emails.
>
> No problem.
>
> > On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote:
> >> Use a mutex instead of a
On Thu, Apr 03, 2014 at 08:43:28PM +1100, Mike Sampson wrote:
> Signed-off-by: Mike Sampson
>
> This fixes a sparse warning:
> warning: symbol 'cfs_wi_data' was not declared. Should it be static?
>
Patch is ok. Signed off should go at the end instead of at the start of
the commit message. The
On Thu, 2014-04-03 at 01:17 +0200, Sherif Shehab Aldin wrote:
> Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c
Please use "scripts/checkpatch.pl --strict" on patches
to files in drivers/staging.
CHECK: Alignment should match open parenthesis
#75: FILE: drivers/staging
On 04/03/2014 04:56 AM, Dan Carpenter wrote:
On Tue, Mar 25, 2014 at 04:38:18PM -0400, Mark Hounschell wrote:
This patch fixes a checkpatch warning about adding typedefs
in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 2 +-
1 file changed,
On 04/03/2014 04:51 AM, Dan Carpenter wrote:
On Tue, Mar 25, 2014 at 04:38:15PM -0400, Mark Hounschell wrote:
This patch fixes a checkpatch warning
"Macros with complex values should be enclosed in parenthesis"
Really this is a bug in checkpatch.pl. We have the source for that, so
we should
On Thu, Apr 03, 2014 at 07:53:30AM -0400, Mark Hounschell wrote:
> On 04/03/2014 04:51 AM, Dan Carpenter wrote:
> >On Tue, Mar 25, 2014 at 04:38:15PM -0400, Mark Hounschell wrote:
> >>This patch fixes a checkpatch warning
> >>"Macros with complex values should be enclosed in parenthesis"
> >>
> >
>
This feature allows multiple channels to be used by each virtual NIC.
It is available on Hyper-V host 2012 R2.
Signed-off-by: Haiyang Zhang
Reviewed-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h | 110 +-
drivers/net/hyperv/netvsc.c | 136 +++
From: Haiyang Zhang
Date: Thu, 3 Apr 2014 09:05:34 -0700
> This feature allows multiple channels to be used by each virtual NIC.
> It is available on Hyper-V host 2012 R2.
>
> Signed-off-by: Haiyang Zhang
> Reviewed-by: K. Y. Srinivasan
I announced on netdev the other day that the merge wind
Am 03.04.2014 00:24, schrieb Bojan Prtvar:
> The checkpatch.pl complains about missing blank line after declaration.
> This patch silence the warning.
>
> Signed-off-by: Bojan Prtvar
> ---
> This patch is for Eudyptula Challenge task 10
>
> drivers/staging/vme/devices/vme_user.c | 1 +
> 1 f
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, April 3, 2014 11:15 AM
> To: Haiyang Zhang
> Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de;
> jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org
>
On Thu, Apr 3, 2014 at 5:14 PM, walter harms wrote:
> beside style:
> that sprint looks like as it could be replaced with a
> name="bus/vme/m%%d"
>
> any takers ?
>
> re,
> wh
>
Hi Walter,
I guess you mean something like this? Please review carefully if I got
right "%%d" intent.
Now a basic q
On Thu, Apr 03, 2014 at 05:40:25PM +0200, bojan prtvar wrote:
> On Thu, Apr 3, 2014 at 5:14 PM, walter harms wrote:
>
> > beside style:
> > that sprint looks like as it could be replaced with a
> > name="bus/vme/m%%d"
> >
> > any takers ?
> >
> > re,
> > wh
> >
>
> Hi Walter,
>
> I guess you
>From f548b09a0fc387b94fee3372c0f7c4de1f281f80 Mon Sep 17 00:00:00 2001
From: Paul McQuade
Date: Thu, 3 Apr 2014 17:12:20 +0100
Subject: [PATCH] Staging:ft1000_debug.c:Renaming __FUNCTION__
__Function__ gets renamed with __func__
Signed-off-by: Paul McQuade
---
drivers/staging/ft1000/ft1000-us
Signed-off-by: Jimmy Li
---
v2: additional cleanups as well.
drivers/staging/vt6655/iwctl.c |9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c
index ac3fc16..394031b 100644
--- a/drivers/staging/vt6655/iw
We can avoid usage of sprintf() and magic-sized array with simple pointer
assignment.
Signed-off-by: Bojan Prtvar
---
This parch should be applied on top of
"staging: vme: Fix a small coding style issue in vme_user.c"
Compile tested only.
drivers/staging/vme/devices/vme_user.c | 8
This patch fixes "Missing a blank line after declarations" checkpatch warning
in panel.c.
Signed-off-by: "Bastien Armand "
---
drivers/staging/panel/panel.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index
Added signed-off-by below:
On Thursday, April 03, 2014 1:32 AM, Paul Bolle wrote:
>
> This Makefile tries to set the DEBUG macro but it uses an unknown Kconfig
> macro to do so. Since no code appears to even care about the DEBUG macro
> this line can safely be removed.
>
> Signed-off-by: Paul Bo
On Thu, Apr 03, 2014 at 06:59:09PM +0200, armand.bast...@laposte.net wrote:
> This patch fixes "Missing a blank line after declarations" checkpatch warning
> in panel.c.
Acked-By: Willy Tarreau
Thanks Bastien for this.
Willy
___
devel mailing list
de
From: Joe Schultz
This patch corrects a failure to dereference a pointer in tsi148_slave_get().
It also removes the following compile warning on some platforms:
warning: cast from pointer to integer of different size
Signed-off-by: Joe Schultz
---
drivers/vme/bridges/vme_tsi148.c |2 +-
1
From: Joe Schultz
Previously, tsi148_master_set() assumed the address contained in its
PCI bus resource represented the actual PCI bus address. This is a fine
assumption on some platforms. However, on platforms that don't use a
1:1 (CPU:PCI) mapping this results in the tsi148 driver configuring a
Save some characters by using to_pci_dev() instead of container_of().
Signed-off-by: Aaron Sierra
---
drivers/vme/bridges/vme_tsi148.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c
index e6
On Fri, Apr 04, 2014 at 12:32:29AM +0800, Jimmy Li wrote:
> Signed-off-by: Jimmy Li
You dropped the commit message which said which sparse warnings were
fixed. It should say something about the other cleanups as well. Also
the subject prefix isn't right. Use:
[PATCH v3] Staging: vt6655: iwctl.
On Thu, Apr 03, 2014 at 06:59:09PM +0200, armand.bast...@laposte.net wrote:
> This patch fixes "Missing a blank line after declarations" checkpatch warning
> in panel.c.
>
>
> Signed-off-by: "Bastien Armand "
Fix your email client to use the proper From header. The signed-off-by
format is wron
On Thu, Apr 03, 2014 at 05:14:44PM +, Insop Song wrote:
> Added signed-off-by below:
>
Signed-off-by is like signing a legal document, to show you haven't
violated copyright law or anything while the patch was in your hands.
You should use Acked-by or Reviewed-by depending on what you mean.
r
On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote:
> From: Joe Schultz
>
> This patch corrects a failure to dereference a pointer in tsi148_slave_get().
If you had a dmesg output of the crash it would be great to include it
here. The commit message would be clearer if it said, "There
On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote:
> drivers/vme/bridges/vme_tsi148.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vme/bridges/vme_tsi148.c
> b/drivers/vme/bridges/vme_tsi148.c
> index 9c1aa4d..604e858 100644
> --- a/drivers/vme/
- Original Message -
> From: "Dan Carpenter"
> Sent: Thursday, April 3, 2014 1:05:03 PM
>
> On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote:
> > From: Joe Schultz
> >
> > This patch corrects a failure to dereference a pointer in
> > tsi148_slave_get().
>
> If you had a dme
On Mon, Mar 31, 2014 at 01:56:28PM -0700, Andrew Morton wrote:
> On Mon, 31 Mar 2014 08:31:38 -0700 Joe Perches wrote:
>
> > > > @@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg {
> > > > * * 1'b1: Unmask the interrupt assertion to the
> > > > application.
> > > > */
> > > >
On Thu, Apr 03, 2014 at 01:24:04PM -0500, Aaron Sierra wrote:
> - Original Message -
> > From: "Dan Carpenter"
> > Sent: Thursday, April 3, 2014 1:05:03 PM
> >
> > On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote:
> > > From: Joe Schultz
> > >
> > > This patch corrects a fai
From: Joe Schultz
Previously, tsi148_master_set() assumed the address contained in its
PCI bus resource represented the actual PCI bus address. This is a fine
assumption on some platforms. However, on platforms that don't use a
1:1 (CPU:PCI) mapping this results in the tsi148 driver configuring a
From: Joe Schultz
This patch corrects a typo where "vme_base" was used instead of
"*vme_base". The typo resulted in an incorrect value being returned
to userspace (via vme_user).
It also removes the following compile warning on some platforms:
warning: cast from pointer to integer of different
Save some characters by using to_pci_dev() instead of container_of().
Signed-off-by: Aaron Sierra
---
drivers/vme/bridges/vme_tsi148.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c
index e6
>On Thursday, April 3, 2014 3:38 AM, Dan Carpenter
>wrote:
>>On Tue, Mar 25, 2014 at 10:43:58PM -0500, Chase Southwood wrote:
>>There were just a handful of more while loops in this file that needed
>>timeouts, and this patch takes care of them. One new callback is
>>introduced, and all of the
It's because I didn't build this source tree before. Had to build it
first and now I can build the module.
I will regenerate the patches and send them by tomorrow hopefully. Hope
to do it right this time. :)
On 04/03/2014 11:48 AM, Dan Carpenter wrote:
On Thu, Apr 03, 2014 at 11:42:47AM +020
There were just a handful of more while loops in this file that needed
timeouts, and this patch takes care of them. One new callback is
introduced, and all of the proper comedi_timeout() calls are then used.
The return type of s626_i2c_handshake() has been changed from uint32_t to
int so that a ne
Only ws2012r2 hosts support the ability to reconnect to the host on VMBUS. This
functionality
is needed by kexec in Linux. To use this functionality we need to negotiate
version 3.0 of the
VMBUS protocol.
Signed-off-by: K. Y. Srinivasan
Cc: [3.9+]
---
drivers/hv/connection.c |5 +++
On Thursday, April 03, 2014 10:56 AM, Dan Carpenter wrote:
>
> Signed-off-by is like signing a legal document, to show you haven't violated
> copyright law or anything while the patch was in your hands.
> You should use Acked-by or Reviewed-by depending on what you mean.
>
Dan,
Thank you for p
On 04/03/2014 01:08 AM, Greg KH wrote:
> On Wed, Apr 02, 2014 at 08:52:18PM +, Insop Song wrote:
>> On Wed, April 02, 2014 1:04 PM, Greg KH wrote:
>>> On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote:
On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote:
> Staging driver pull req
63 matches
Mail list logo
