----- Original Message -----
> From: "Dan Carpenter" <dan.carpen...@oracle.com>
> Sent: Thursday, April 3, 2014 1:05:03 PM
> 
> On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote:
> > From: Joe Schultz <jschu...@xes-inc.com>
> > 
> > This patch corrects a failure to dereference a pointer in
> > tsi148_slave_get().
> 
> If you had a dmesg output of the crash it would be great to include it
> here.  The commit message would be clearer if it said, "There is a
> typo where we use "vme_base" instead of "*vme_base".

Dan,
There is no crash that I can demonstrate based on our use of the
function (via vme_user). As we experience it, the failure to deference
simply results in an incorrect value being returned to userspace and
the compile warning.

> > It also removes the following compile warning on some platforms:
> > 
> > warning: cast from pointer to integer of different size
> > 
> > Signed-off-by: Joe Schultz <jschu...@xes-inc.com>
> 
> Aaron, we need your Signed-off-by as well as Joe's since the patch went
> through your hands.  Please resend.

Ok, no problem.

-Aaron

> regards,
> dan carpenter
> 
> 
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to