On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote:

>  drivers/vme/bridges/vme_tsi148.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vme/bridges/vme_tsi148.c 
> b/drivers/vme/bridges/vme_tsi148.c
> index 9c1aa4d..604e858 100644
> --- a/drivers/vme/bridges/vme_tsi148.c
> +++ b/drivers/vme/bridges/vme_tsi148.c
> @@ -735,7 +735,7 @@ static int tsi148_slave_get(struct vme_slave_resource 
> *image, int *enabled,
>       reg_join(vme_bound_high, vme_bound_low, &vme_bound);
>       reg_join(pci_offset_high, pci_offset_low, &pci_offset);
>  
> -     *pci_base = (dma_addr_t)vme_base + pci_offset;
> +     *pci_base = (dma_addr_t)(*vme_base + pci_offset);

Btw, it would be cleaner if "vme_base" we declared as a dma_addr_t
instead of a long long.  "pci_base" is declared correctly.  Then we
could remove the cast.

That change is a bit of work, which is why no one has done it...
Something to think about if you want to do some more cleanup later.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to