Re: [PATCH 1/3] vme_tsi148: Fix PCI base calculation for slave window

2014-04-03 Thread Dan Carpenter
On Thu, Apr 03, 2014 at 01:24:04PM -0500, Aaron Sierra wrote: > - Original Message - > > From: "Dan Carpenter" > > Sent: Thursday, April 3, 2014 1:05:03 PM > > > > On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote: > > > From: Joe Schultz > > > > > > This patch corrects a fai

Re: [PATCH 1/3] vme_tsi148: Fix PCI base calculation for slave window

2014-04-03 Thread Aaron Sierra
- Original Message - > From: "Dan Carpenter" > Sent: Thursday, April 3, 2014 1:05:03 PM > > On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote: > > From: Joe Schultz > > > > This patch corrects a failure to dereference a pointer in > > tsi148_slave_get(). > > If you had a dme

Re: [PATCH 1/3] vme_tsi148: Fix PCI base calculation for slave window

2014-04-03 Thread Dan Carpenter
On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote: > drivers/vme/bridges/vme_tsi148.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vme/bridges/vme_tsi148.c > b/drivers/vme/bridges/vme_tsi148.c > index 9c1aa4d..604e858 100644 > --- a/drivers/vme/

Re: [PATCH 1/3] vme_tsi148: Fix PCI base calculation for slave window

2014-04-03 Thread Dan Carpenter
On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote: > From: Joe Schultz > > This patch corrects a failure to dereference a pointer in tsi148_slave_get(). If you had a dmesg output of the crash it would be great to include it here. The commit message would be clearer if it said, "There

[PATCH 1/3] vme_tsi148: Fix PCI base calculation for slave window

2014-04-03 Thread Aaron Sierra
From: Joe Schultz This patch corrects a failure to dereference a pointer in tsi148_slave_get(). It also removes the following compile warning on some platforms: warning: cast from pointer to integer of different size Signed-off-by: Joe Schultz --- drivers/vme/bridges/vme_tsi148.c |2 +- 1