From: Marc Zyngier Sent: Friday, December 7, 2018 6:43
AM
> > Add ARM64-specific code to enable Hyper-V. This code includes:
> > * Detecting Hyper-V and initializing the guest/Hyper-V interface
> > * Setting up Hyper-V's synthetic clocks
> > * Making hypercalls using the HVC instruction
> > * S
Change two register addresses and one bit definition to match the
datasheet.
Signed-off-by: Jeremy Fertic
---
drivers/staging/iio/addac/adt7316.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
i
ADT7316_DA_EN_VIA_DAC_LDCA is set when the dac and ldac registers are being
used to update the dacs instead of the ldac pin. ADT7516_SEL_AIN3 is an adc
input that shares the ldac pin. Only set these bits if an ldac pin is not
being used.
Signed-off-by: Jeremy Fertic
---
drivers/staging/iio/addac
From: Will Deacon Sent: Friday, December 7, 2018 5:43 AM
> > hyperv-tlfs.h defines Hyper-V interfaces from the Hyper-V Top Level
> > Functional Spec (TLFS). The TLFS is distinctly oriented to x86/x64,
> > and Hyper-V has not separated out the architecture-dependent parts into
> > x86/x64 vs. ARM6
The option to allow the external vref to bypass the reference buffer is
only available for adt7316/7/8. Remove the attributes for adt751x as
well as the chip->id checks from the show and store functions.
Signed-off-by: Jeremy Fertic
---
drivers/staging/iio/addac/adt7316.c | 14 --
1
Change LDCA to LDAC.
Signed-off-by: Jeremy Fertic
---
drivers/staging/iio/addac/adt7316.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
index 58b462ad0c83..020d695ded97 100644
--- a/driv
Here are some dac related fixes for adt7316. I'm testing with an adt7516
over i2c to an orange pi pc. I've attempted to test any functionality that
these patches are touching.
Jeremy Fertic (11):
staging: iio: adt7316: fix register and bit definitions
staging: iio: adt7316: invert the logic of
With adt7516/7/9, internal vref is available for dacs a and b, dacs c and
d, or all dacs. The driver doesn't currently support internal vref for all
dacs. Change the else if to an if so both bits are checked rather than
just one or the other.
Signed-off-by: Jeremy Fertic
---
drivers/staging/iio/
The dac internal vref settings are part of the ldac config register rather
than the dac config register. Change the variable being used so the read
returns the correct result.
Signed-off-by: Jeremy Fertic
---
drivers/staging/iio/addac/adt7316.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
The dac high resolution option enables or disables 10 bit dac resolution
for the adt7316/7 and adt7516/7 when they're set to output voltage
proportional to temperature. Remove the "1 (12 bits)" output from the show
function since that is not an option for this mode. Return "1 (10 bits)"
if the devi
Based on the output of adt7316_show_all_DAC_update_modes() and
adt7316_show_DAC_update_mode(), adt7316_store_DAC_update_mode() should
expect the user to enter an integer input from 0 to 3. The user input is
currently expected to account for the actual bit positions in the register.
For example, cho
The lsb calculation is not masking the correct bits from the user input.
Subtract 1 from (1 << offset) to correctly set up the mask to be applied
to user input.
The lsb register stores its value starting at the bit 7 position.
adt7316_store_DAC() currently assumes the value is at the other end of
The calculation of the current dac value is using the wrong bits of the
dac lsb register. Create two macros to shift the lsb register value into
lsb position, depending on whether the dac is 10 or 12 bit. Initialize
data to 0 so, with an 8 bit dac, the msb register value can be bitwise
ORed with da
The only assignment to dac_bits is in adt7316_store_da_high_resolution().
This function enables or disables 10 bit dac resolution for the adt7316/7
and adt7516/7 when they're set to output voltage proportional to
temperature. Remove these assignments since they're unnecessary for the
dac high resol
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_shim.c | 2 +-
.../interfa
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_core.c | 19 ++-
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +-
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_core.c | 26 +--
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 ++
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.h| 2
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +++-
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_arm.c | 52 ---
.../i
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c| 11 ++-
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +++-
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 23 ++--
.../inte
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_arm.c | 21 +++---
.../int
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 ++
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
.../int
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 4 +-
.../interfa
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 13 +++--
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 12 ++--
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../vc04_services/bcm2835-camera/mmal-vchiq.c | 28 +--
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c| 5 +++--
..
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 8
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
.../vc
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_arm.c | 23 +++
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_arm.c | 48 +++
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 12 ++--
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchi/vchi_common.h| 8
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Dominic Braun (33):
staging: vc04_services: Remove DUMP_CONTEXT_T typedef
staging: vc04_services: Remove PAGELIST_T typedef
st
Typedefing structs is not encouraged in the kernel.
The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c| 9 +
On Tue, Dec 11, 2018 at 07:09:59PM +0100, Greg KH wrote:
On Tue, Dec 11, 2018 at 12:09:49PM -0500, Sasha Levin wrote:
Now the Hyper-V code has it's own monkey on a tree!
Make it easier to manage patch flow to upper level maintainers.
Acked-by: Haiyang Zhang
Acked-by: K. Y. Srinivasan
Signed-
On Tue, Dec 11, 2018 at 12:09:49PM -0500, Sasha Levin wrote:
> Now the Hyper-V code has it's own monkey on a tree!
>
> Make it easier to manage patch flow to upper level maintainers.
>
> Acked-by: Haiyang Zhang
> Acked-by: K. Y. Srinivasan
> Signed-off-by: Sasha Levin
> ---
> MAINTAINERS | 4
It's better to use pre-calculated values to make
on-disk definition more straight-forward and human-readable.
Since there is the only one user, let's remove
__EROFS_BIT entirely.
Suggested-by: Joe Perches
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/erofs_fs.h | 8 +++-
1 file change
On Mon, 10 Dec 2018 13:03:33 +0200
Stefan Popa wrote:
> Move ad7606 ADC driver out of staging and into the mainline.
>
> Signed-off-by: Stefan Popa
Hi Stefan, I've been a bit silly here and only been looking
at the 'new code' and assuming this was a straight copy.
Please could you split the p
Hi Joe,
On 2018/12/11 23:48, Joe Perches wrote:
> This macro is used only once and is merely obfuscation
> for that one use. Please remove the macro and expand
> it in the one place it is used.
I am also considering to replace it in a plain way,
it will be more straight-forward to describe its o
Now the Hyper-V code has it's own monkey on a tree!
Make it easier to manage patch flow to upper level maintainers.
Acked-by: Haiyang Zhang
Acked-by: K. Y. Srinivasan
Signed-off-by: Sasha Levin
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS
On Tue, 2018-12-11 at 19:06 +0800, Gao Xiang wrote:
> Hi Aaron,
>
> On 2018/12/11 18:54, Aaron Strahlberger wrote:
> > Fix of ERROR: Macros with complex values should be enclosed in parentheses
> > from checkpatch.pl
[]
> > diff --git a/drivers/staging/erofs/erofs_fs.h
> > b/drivers/staging/erofs
On Tue, Dec 11, 2018 at 3:50 AM Alexander Schroth
wrote:
>
> According to the Linux coding guidelines, defines should be written
> in uppercase. This patch converts all define-statements in the
> ni_pcidio.c file to uppercase, thus matching the coding style of the
> kernel.
>
> Signed-off-by: Alex
On Tue, Dec 11, 2018 at 3:50 AM Alexander Schroth
wrote:
>
> Define-statements, which are not used within the file, are being removed
> as they add clutter to the code.
> Because the file is not being included from anywhere else, this has no
> negative side-effects.
This is somewhat coincidental,
On Tue, Dec 11, 2018 at 1:36 PM Nicolas Saenz Julienne
wrote:
> On Mon, 2018-12-10 at 22:11 +0100, Arnd Bergmann wrote:
> > @@ -447,26 +444,26 @@ remote_event_wait(VCHIQ_STATE_T *state,
> > REMOTE_EVENT_T *event)
> > }
> >
> > static inline void
> > -remote_event_signal_local(VCHIQ_STATE_T *sta
On Tue, Dec 11, 2018 at 1:31 PM Nicolas Saenz Julienne
wrote:
>
> On Tue, 2018-12-11 at 13:07 +0300, Dan Carpenter wrote:
> > On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote:
> > > Note that I'm changing it back to 'killable' after the previous
> > > patch
> > > changed 'killable' to
On Tue, Dec 11, 2018 at 11:54:39AM +0100, Aaron Strahlberger wrote:
> Fix of 17 `CHECK: Alignment should match open parenthesis` checkpatch.pl
> issues.
>
> Signed-off-by: Aaron Strahlberger
> Signed-off-by: Julius Wiedmann
> Signed-off-by: Dominik Huber
>
> LocalWords: Alighnment
^
Remove the "drivers: " from the patch prefix.
You're not working from the latest code. Write your patches on top of
staging-next or linux-next.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
Hi Arnd,
Thank you for the patches.
On 10-12-18 22:40, Arnd Bergmann wrote:
This driver uses many semaphores, most of them are equivalent to
completions. The other copies of this driver got moved over to
completions a while ago, so do the same here.
In this usage scenario, the two are equivale
Hi Arnd, thanks for the patch!
On Mon, 2018-12-10 at 22:11 +0100, Arnd Bergmann wrote:
> I had started the removal of semaphores in this driver without
> knowing
> that Nicolas Saenz Julienne also worked on this. In case of the
> "remote
> event" infrastructure, my solution seemed significantly be
On Tue, 2018-12-11 at 13:07 +0300, Dan Carpenter wrote:
> On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote:
> > Note that I'm changing it back to 'killable' after the previous
> > patch
> > changed 'killable' to 'interruptible', apparently based on a
> > misunderstanding
> > of the sub
On 2018/12/11 18:54, Aaron Strahlberger wrote:
> Changed "stoped" to "stopped".
>
> Signed-off-by: Aaron Strahlberger
> Signed-off-by: Julius Wiedmann
> Signed-off-by: Dominik Huber
A typo fix... I'm not a native English speaker, help me if it has more typo
errors...
Reviewed-by: Gao Xiang
Hi Aaron,
On 2018/12/11 18:54, Aaron Strahlberger wrote:
> Fix of 7 `CHECK: Comparison to NULL could be written ...` issues.
>
> Signed-off-by: Aaron Strahlberger
> Signed-off-by: Julius Wiedmann
> Signed-off-by: Dominik Huber
> ---
> drivers/staging/erofs/data.c | 23 ---
Hi Aaron,
On 2018/12/11 18:54, Aaron Strahlberger wrote:
> Fix of 17 `CHECK: Alignment should match open parenthesis` checkpatch.pl
> issues.
>
> Signed-off-by: Aaron Strahlberger
> Signed-off-by: Julius Wiedmann
> Signed-off-by: Dominik Huber
>
> LocalWords: Alighnment
What's this?
> ---
Hi Aaron,
On 2018/12/11 18:54, Aaron Strahlberger wrote:
> Fix of ERROR: Macros with complex values should be enclosed in parentheses
> from checkpatch.pl
>
> Signed-off-by: Aaron Strahlberger
> Signed-off-by: Julius Wiedmann
> Signed-off-by: Dominik Huber
> ---
> drivers/staging/erofs/erofs_
On Mon, 2018-12-10 at 21:27 +, Jonathan Cameron wrote:
> On Sat, 8 Dec 2018 22:10:43 +0100
> Greg KH wrote:
>
> > On Sat, Dec 08, 2018 at 04:56:45PM -0200, Marcelo Schmitt wrote:
> > > Parts of this work came from contributions of Alexandru Ardelean and
> > > Dragos Bogdan, I and Gabriel woul
Define-statements, which are not used within the file, are being removed
as they add clutter to the code.
Because the file is not being included from anywhere else, this has no
negative side-effects.
Signed-off-by: Alexander Schroth
Signed-off-by: Marco Ammon
---
drivers/staging/comedi/drivers/
According to the Linux coding guidelines, defines should be written
in uppercase. This patch converts all define-statements in the
ni_pcidio.c file to uppercase, thus matching the coding style of the
kernel.
Signed-off-by: Alexander Schroth
Signed-off-by: Marco Ammon
---
drivers/staging/comedi/
This patch series improves the conformance of comedi/drivers/ni_pcidio.c
to the Linux coding guidelines. It focuses on the usage of #define and
is based on the next-20181207 tag.
Signed-off-by: Alexander Schroth
Signed-off-by: Marco Ammon
___
devel m
Changed "stoped" to "stopped".
Signed-off-by: Aaron Strahlberger
Signed-off-by: Julius Wiedmann
Signed-off-by: Dominik Huber
---
drivers/staging/erofs/dir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/erofs/dir.c b/drivers/staging/erofs/dir.c
index 4
Fix of checkpatch.pl issue:
CHECK: Please use a blank line after ... declarations
Signed-off-by: Aaron Strahlberger
Signed-off-by: Julius Wiedmann
Signed-off-by: Dominik Huber
---
drivers/staging/erofs/erofs_fs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/erofs/erofs_
Fix of ERROR: Macros with complex values should be enclosed in parentheses
from checkpatch.pl
Signed-off-by: Aaron Strahlberger
Signed-off-by: Julius Wiedmann
Signed-off-by: Dominik Huber
---
drivers/staging/erofs/erofs_fs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Fix of 17 `CHECK: Alignment should match open parenthesis` checkpatch.pl
issues.
Signed-off-by: Aaron Strahlberger
Signed-off-by: Julius Wiedmann
Signed-off-by: Dominik Huber
LocalWords: Alighnment
---
drivers/staging/erofs/data.c | 42 ++--
drivers/staging/er
Fix of 7 `CHECK: Comparison to NULL could be written ...` issues.
Signed-off-by: Aaron Strahlberger
Signed-off-by: Julius Wiedmann
Signed-off-by: Dominik Huber
---
drivers/staging/erofs/data.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers
Fixed several styling issues and one error, reported by checkpatch.pl.
Signed-off-by: Aaron Strahlberger
Signed-off-by: Julius Wiedmann
Signed-off-by: Dominik Huber
Aaron Strahlberger (5):
drivers: staging: erofs: Fix alignment.
drivers: staging: erofs: Fix comparison to NULL issues.
dri
On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote:
> Note that I'm changing it back to 'killable' after the previous patch
> changed 'killable' to 'interruptible', apparently based on a misunderstanding
> of the subtle down_interruptible() macro override in vchiq_killable.h.
Oh wow...
On Sat, Dec 08, 2018 at 08:46:37PM +0530, Shreeya Patel wrote:
> - return irq_type;
> + ret = devm_request_threaded_irq(&indio_dev->dev, chip->bus.irq,
> + NULL, adt7316_event_handler,
> + irq_type | IRQF_ONESHOT,
> +
Hi Aaron,
On 2018/12/11 17:06, Aaron Strahlberger wrote:
> Fixed following checkpatch.pl styling issues:
>
> - 17x CHECK: Alignment should match open parenthesis
> - 7x CHECK: Comparison to NULL could be written ...
> - 1x CHECK: Lines should not end with a '('
> - 1x CHECK: Please use a blank
Fixed following checkpatch.pl styling issues:
- 17x CHECK: Alignment should match open parenthesis
- 7x CHECK: Comparison to NULL could be written ...
- 1x CHECK: Lines should not end with a '('
- 1x CHECK: Please use a blank line after ...
Signed-off-by: Aaron Strahlberger
Signed-off-by: Jul
82 matches
Mail list logo
