[PATCH 02/33] staging: vc04_services: Remove PAGELIST_T typedef

[Dominic Braun]

Typedefing structs is not encouraged in the kernel.

The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.

Signed-off-by: Dominic Braun <inf.br...@fau.de>
Signed-off-by: Tobias Büttner <tobias.buett...@fau.de>
---
 .../interface/vchiq_arm/vchiq_2835_arm.c             | 12 ++++++------
 .../interface/vchiq_arm/vchiq_pagelist.h             |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
index ecee54a31f8d..5601d167ac60 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
@@ -65,7 +65,7 @@ struct vchiq_2835_state {
 };
 
 struct vchiq_pagelist_info {
-       PAGELIST_T *pagelist;
+       struct pagelist_struct *pagelist;
        size_t pagelist_buffer_size;
        dma_addr_t dma_addr;
        enum dma_data_direction dma_dir;
@@ -384,7 +384,7 @@ cleanup_pagelistinfo(struct vchiq_pagelist_info 
*pagelistinfo)
 static struct vchiq_pagelist_info *
 create_pagelist(char __user *buf, size_t count, unsigned short type)
 {
-       PAGELIST_T *pagelist;
+       struct pagelist_struct *pagelist;
        struct vchiq_pagelist_info *pagelistinfo;
        struct page **pages;
        u32 *addrs;
@@ -398,7 +398,7 @@ create_pagelist(char __user *buf, size_t count, unsigned 
short type)
        offset = ((unsigned int)(unsigned long)buf & (PAGE_SIZE - 1));
        num_pages = DIV_ROUND_UP(count + offset, PAGE_SIZE);
 
-       pagelist_size = sizeof(PAGELIST_T) +
+       pagelist_size = sizeof(struct pagelist_struct) +
                        (num_pages * sizeof(u32)) +
                        (num_pages * sizeof(pages[0]) +
                        (num_pages * sizeof(struct scatterlist))) +
@@ -566,9 +566,9 @@ static void
 free_pagelist(struct vchiq_pagelist_info *pagelistinfo,
              int actual)
 {
-       PAGELIST_T *pagelist   = pagelistinfo->pagelist;
-       struct page **pages    = pagelistinfo->pages;
-       unsigned int num_pages = pagelistinfo->num_pages;
+       struct pagelist_struct *pagelist = pagelistinfo->pagelist;
+       struct page **pages              = pagelistinfo->pages;
+       unsigned int num_pages           = pagelistinfo->num_pages;
 
        vchiq_log_trace(vchiq_arm_log_level, "%s - %pK, %d",
                        __func__, pagelistinfo->pagelist, actual);
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h
index bec411061554..debeaf5fd40e 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h
@@ -38,7 +38,7 @@
 #define PAGELIST_READ 1
 #define PAGELIST_READ_WITH_FRAGMENTS 2
 
-typedef struct pagelist_struct {
+struct pagelist_struct {
        u32 length;
        u16 type;
        u16 offset;
@@ -46,6 +46,6 @@ typedef struct pagelist_struct {
                         * of following pages at consecutive
                         * addresses.
                         */
-} PAGELIST_T;
+};
 
 #endif /* VCHIQ_PAGELIST_H */
-- 
2.17.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel