Typedefing structs is not encouraged in the kernel.

The removal of typedefs was requested in interface/vchi/TODO in commit
7626e002225a4c1b9455689b1f22909dfeff43ca.

Signed-off-by: Dominic Braun <inf.br...@fau.de>
Signed-off-by: Tobias Büttner <tobias.buett...@fau.de>
---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c   | 4 ++--
 .../staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index b156019f4d96..1f34dd85f09b 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1320,7 +1320,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned 
long arg)
        } break;
 
        case VCHIQ_IOC_DEQUEUE_MESSAGE: {
-               VCHIQ_DEQUEUE_MESSAGE_T args;
+               struct vchiq_dequeue_message_struct args;
                struct user_service_struct *user_service;
                VCHIQ_HEADER_T *header;
 
@@ -1880,7 +1880,7 @@ vchiq_compat_ioctl_dequeue_message(struct file *file,
                                   unsigned int cmd,
                                   unsigned long arg)
 {
-       VCHIQ_DEQUEUE_MESSAGE_T __user *args;
+       struct vchiq_dequeue_message_struct __user *args;
        struct vchiq_dequeue_message32 args32;
 
        args = compat_alloc_user_space(sizeof(*args));
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
index eab17f03a0ba..855f1ea713a6 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
@@ -76,12 +76,12 @@ struct vchiq_await_completion {
        void **msgbufs;
 };
 
-typedef struct {
+struct vchiq_dequeue_message_struct {
        unsigned int handle;
        int blocking;
        unsigned int bufsize;
        void *buf;
-} VCHIQ_DEQUEUE_MESSAGE_T;
+};
 
 typedef struct {
        unsigned int config_size;
@@ -113,7 +113,7 @@ typedef struct {
 #define VCHIQ_IOC_AWAIT_COMPLETION \
        _IOWR(VCHIQ_IOC_MAGIC, 7, struct vchiq_await_completion)
 #define VCHIQ_IOC_DEQUEUE_MESSAGE \
-       _IOWR(VCHIQ_IOC_MAGIC, 8, VCHIQ_DEQUEUE_MESSAGE_T)
+       _IOWR(VCHIQ_IOC_MAGIC, 8, struct vchiq_dequeue_message_struct)
 #define VCHIQ_IOC_GET_CLIENT_ID        _IO(VCHIQ_IOC_MAGIC,   9)
 #define VCHIQ_IOC_GET_CONFIG \
        _IOWR(VCHIQ_IOC_MAGIC, 10, VCHIQ_GET_CONFIG_T)
-- 
2.17.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to