This patch breaks lines that are longer than 80 characters and joins
together those, that are too short and can be placed at one.
Function calls and declarations are updated to fit kernel code style.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_chip.c | 7 +++--
drivers/sta
Folowing patch set cleans some warnings and checkups from checkpatch.pl
and also fix code to better fot linux code style.
Changes since v1 [1]:
* staging: sm750fb: fix length of lines, function calls and declaration
* created better description
* squashed:
staging: sm750fb: unif
This patch adds tabs into macro definitions so all rhs are on same column.
Removing MHz macro from ddk_chip.c file and reuse MHZ from sm750.h.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_chip.c| 18
drivers/staging/sm750fb/ddk750_display.h | 78 ---
This patch removes typedefs from enum and renames it from "typedef enum
_disp_output_t" to "enum disp_output" as per kernel coding standards.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_display.c | 2 +-
drivers/staging/sm750fb/ddk750_display.h | 8
drivers/staging/sm
This patch removes typedefs from enum and renames it from "typedef enum
_sii164_hot_plug_mode_t" to "enum sii164_hot_plug_mode" as per kernel
coding standards.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_sii164.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.h | 4 ++--
2 file
This patch removes typedefs from enum and renames it from
"typedef enum _DPMS_t" to "enum DPMS" as per kernel coding standards.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_power.c | 2 +-
drivers/staging/sm750fb/ddk750_power.h | 7 +++
2 files changed, 4 insertions(+), 5 d
This patch removes typedefs from enum and renames it from "typedef enum
_logical_chip_type_t" to "enum logical_chip_type" as per kernel coding
standards.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
drivers/staging/sm750fb/ddk750_chip.h | 8
2 files chan
This patch removes typedefs from enum and renames it from "typedef enum
_clock_type_t" to "enum clock_type" as per kernel coding standards.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_chip.h | 8
drivers/staging/sm750fb/ddk750_mode.c | 2 +-
drivers/staging/sm750fb/dd
On 15/05/17 17:10, Johan Hovold wrote:
On Mon, May 15, 2017 at 04:17:55PM +0100, Bryan O'Donoghue wrote:
On 15/05/17 15:26, Johan Hovold wrote:
Remove the remaining timesync bits that were left in the arche platform
driver and which prevented the driver from being compiled.
Fixes: bdfb95c4baab
Fixes a 'code indent should use tabs where possible' checkpatch code
style error by changing whitespace into tabs.
Signed-off-by: Remco Verhoef
---
Changes in v2:
- More expressive commit message and subject
Changes in v3:
- Align with struct, to line things up better
drivers/staging/rtl818
Fix all checkpatch reported issues for "CHECK: Prefer using '"%s...",
__func__' to using '', ..."
Use recommended style. Additionally, __func__ was already used in
similar cases throughout the code, so make it all consistent.
Signed-off-by: Ricardo Silva
---
drivers/staging/media/lirc/lirc_zilo
Fix all checkpatch reported issues for:
* CHECK: "braces {} should be used on all arms of this statement".
* CHECK: "Unbalanced braces around else statement".
Make sure all if/else statements are balanced in terms of braces. Most
cases in code are, but a few were left unbalanced, so put them al
Fix style issues reported by checkpatch, affecting whitespace only:
* CHECK: "Please don't use multiple blank lines".
Two of these still triggering and left untouched because used for
separating logical blocks (vars from functions, etc.).
* CHECK: "spaces preferred around that ''".
All
Fix all checkpatch reported issues for "CHECK: Comparison to NULL could
be written...".
Do these comparisons using the recommended coding style and consistent
with other similar cases in the file, which already used the recommended
way.
Signed-off-by: Ricardo Silva
---
drivers/staging/media/lir
Fix all checkpatch reported issues for "CHECK: Prefer
kzalloc(sizeof(*)...) over kzalloc(sizeof(struct )...)".
Other similar case in the code already using recommended style, so make
it all consistent with the recommended practice.
Signed-off-by: Ricardo Silva
---
drivers/staging/media/lirc/lir
This patch series is intended to fix several checkpatch issues (from
CHECK level) found on lirc_zilog.c:
The 1st patch focus on whitespace related fixes.
The 2nd patch fixes NULL comparisons style.
The 3rd patch is for using __func__ in logging functions that are to
trace the function's name, inst
This patchset fix CamelCases in ks7010 driver except michael_mic
which will be replaced by kernel implementation in the future.
---
v2:
- Rebased all patches to next-20170512. 2 and 8 should apply cleanly now
v3:
- Rebased all not yet applied patched to staging-testing branch
of gregkh/staging
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki
---
drivers/staging/ks7010/ks_hostif.c | 26 +-
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
Replace CamelCase local variables' name with underscores to comply
with the standard kernel coding style.
Changed:
- LinkSpeed
- TransmittedFrameCount
- ReceivedFragmentCount
- FailedCount
- FCSErrorCount
Signed-off-by: Janusz Lisiecki
---
drivers/staging/ks7010/ks_hostif.c | 33
This patch adds further TTY-based functionality, specifically implementation
of send_xchar and tiocmset methods, and input. send_xchar and tiocmset
methods simply delegate to corresponding TTY operations.
For input, it implements the receive_buf2 callback in tty_ldisc_ops of
speakup's ldisc. If a
This changes the above five synths to TTY-based comms. They were chosen as a
first pass because their serial comms are straightforward, i.e. they don't use
serial input and don't do internal port knocking.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/st
This patch fixes the issue where TTY-migrated synths would take a while to shut
up after hitting numpad enter key. When calling synth_flush, even though XOFF
character is sent as high priority, data buffered in TTY layer is still sent to
the synth. This patch flushes that buffered data when synt
This patch simply uses the changes introduced in previous patches and migrates
apollo, ltlk, audptr, decext, spkout and dectlk. Migrations are straightforward
function pointer updates.
Signed-off by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup/speakup
This adds spk_ttyio.c file. It contains a set of functions which implement
those methods in spk_synth struct which relate to sending bytes out using
serial comms. Implementations in this file perform the same function but
using TTY subsystem instead. Currently synths access serial ports, directly
p
This patchset migrates all external synths from using raw serial i/o to
using tty-based comms. The synths not migrated are internal ones -
plugged directly into motherboard, communicating over ISA etc. It's
important to note that these patches access TTY from inside kernel.
Here is the summary of
This exports tty_open_by_driver so that it can be called from other places
inside the kernel. The checks for null file pointer are based on Alan Cox's
patch here:
http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1215095.html.
Description below is quoted from it:
"[RFC] tty_port: all
On 05/15/17 07:26, Johan Hovold wrote:
> Add Arche platform-driver config option and allow the driver to be
> compile tested also without the usb3613 driver.
>
> Signed-off-by: Johan Hovold
> ---
> drivers/staging/greybus/Kconfig | 10 ++
> drivers/staging/greybus/Makefile
On Mon, May 15, 2017 at 04:17:55PM +0100, Bryan O'Donoghue wrote:
> On 15/05/17 15:26, Johan Hovold wrote:
> > Remove the remaining timesync bits that were left in the arche platform
> > driver and which prevented the driver from being compiled.
> >
> > Fixes: bdfb95c4baab ("staging: greybus: remov
On 15/05/17 15:26, Johan Hovold wrote:
Remove the remaining timesync bits that were left in the arche platform
driver and which prevented the driver from being compiled.
Fixes: bdfb95c4baab ("staging: greybus: remove timesync protocol support")
Signed-off-by: Johan Hovold
I thought the plan w
On 15/05/2017 15:54, Stefan Wahren wrote:
> Am 15.05.2017 um 16:29 schrieb Phil Elwell:
>> On 13/05/2017 10:30, Russell King - ARM Linux wrote:
>>> On Sat, May 13, 2017 at 11:07:28AM +0200, Stefan Wahren wrote:
In the meantime this issue has been fixed by Phil [1].
>>> Right - definitely a dri
Am 15.05.2017 um 16:29 schrieb Phil Elwell:
> On 13/05/2017 10:30, Russell King - ARM Linux wrote:
>> On Sat, May 13, 2017 at 11:07:28AM +0200, Stefan Wahren wrote:
>>> In the meantime this issue has been fixed by Phil [1].
>> Right - definitely a driver bug. Mapping more memory for DMA than is
>>
On 13/05/2017 10:30, Russell King - ARM Linux wrote:
> On Sat, May 13, 2017 at 11:07:28AM +0200, Stefan Wahren wrote:
>> In the meantime this issue has been fixed by Phil [1].
>
> Right - definitely a driver bug. Mapping more memory for DMA than is
> actually going to be DMA'd to and expecting da
Add Arche platform-driver config option and allow the driver to be
compile tested also without the usb3613 driver.
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/Kconfig | 10 ++
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/arche-platform.c
Remove the remaining timesync bits that were left in the arche platform
driver and which prevented the driver from being compiled.
Fixes: bdfb95c4baab ("staging: greybus: remove timesync protocol support")
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/arche-apb-ctrl.c | 11 +--
driver
The arche driver currently depends on the out-of-tree usb3613 driver and
this prevented a recent compile breakage after removing the timesync
code from being detected.
These patches remove the remaining timesync bits, and enable compile
testing of the arche driver to avoid further unintended break
Fix coding style, including breaking too long lines, multiple
assignments in same line and empty lines.
Signed-off-by: Juan Manuel Torres Palma
---
drivers/staging/vt6656/rxtx.c | 33 +++--
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/drivers/stagin
-remove duplicate tty allocation code for serial and printer drivers.
-add missing tty c_ispeed and c_ospeed initialization to 9600.
-fix sparse warning: too long initializer-string for array of char.
This patch was only unit tested due to lack of the actual hardware.
Signed-off-by: Haim Daniel
me@haim-toshiba1 ~ $ dpkg -l sparse
Desired=Unknown/Install/Remove/Purge/Hold
|
Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==
On 05/12/2017 01:16 PM, Rui Miguel Silva wrote:
The i2c functions need to test the pm_suspend state and do, if needed, some
retry before i2c operations. This code was repeated 4x.
To isolate this, create a new function to check suspend state and call it in
every need place.
As at it, move the e
On 05/12/2017 01:16 PM, Rui Miguel Silva wrote:
Fix reset of i2c_busy flag if an error occurs during the i2c block read.
Signed-off-by: Rui Miguel Silva
Reviewed-by: Guenter Roeck
---
drivers/staging/typec/fusb302/fusb302.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
On Mon, May 15, 2017 at 03:30:50PM +0300, Haim Daniel wrote:
> -remove duplicate tty allocation code for serial and printer drivers.
> -fix sparse warning: too long initializer-string for array of char.
I think my version of Sparse is too old. I don't get a warning. Please
cut and paste the exac
-remove duplicate tty allocation code for serial and printer drivers.
-fix sparse warning: too long initializer-string for array of char.
Signed-off-by: Haim Daniel
---
drivers/staging/dgnc/dgnc_driver.h | 13
drivers/staging/dgnc/dgnc_tty.c| 150 +++--
Change p80211_caphdr structure args types to __be.. to be
compatible with byte ordering of the network.
and in hfa384x_usb.c make calculations with respect to machine.
Signed-off-by: Karim Eshapa
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
drivers/staging/wlan-ng/p80211conv.h | 28 ++
On Mon, May 15, 2017 at 02:48:52PM +0300, Haim Daniel wrote:
> +static struct tty_driver *_dgnc_tty_register(char *serial_name, uint
> maxports,
Ahh... I see why you are adding underscores. Please, just get a better
name instead of taking an existing name and adding underscores.
regards,
dan
-remove duplicate tty allocation code for serial and printer drivers.
-fix sparse warning: too long initializer-string for array of char.
Signed-off-by: Haim Daniel
---
drivers/staging/dgnc/dgnc_driver.h | 13
drivers/staging/dgnc/dgnc_tty.c| 150 +++--
it's only one patch sorry, there is
something going wrong with my 'git' creating patch.
Thanks,
Kaim
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, May 15, 2017 at 01:22:02PM +0200, Karim Eshapa wrote:
> Change p80211_caphdr structure args types to __be.. to be
> compatible with byte ordering of the network.
> and in hfa384x_usb.c make calculations with respect to machine.
>
> Signed-off-by: Karim Eshapa
> ---
> drivers/staging/wlan
On Mon, May 15, 2017 at 12:10:06PM +0100, Okash Khawaja wrote:
> Hi,
>
> On Mon, May 15, 2017 at 11:31 AM, Greg Kroah-Hartman
> wrote:
> > On Sat, Apr 29, 2017 at 08:52:59PM +0100, Okash Khawaja wrote:
> >> This applies on top of the changes already in staging-next branch which
> >> allow
> >> k
Change p80211_caphdr structure args types to __be.. to be
compatible with byte ordering of the network.
and in hfa384x_usb.c make calculations with respect to machine.
Signed-off-by: Karim Eshapa
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
drivers/staging/wlan-ng/p80211conv.h | 28 ++
Change p80211_caphdr structure args types to __be.. to be
compatible with byte ordering of the network.
and in hfa384x_usb.c make calculations with respect to machine.
Signed-off-by: Karim Eshapa
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
drivers/staging/wlan-ng/p80211conv.h | 28 ++
Hi,
On Mon, May 15, 2017 at 11:31 AM, Greg Kroah-Hartman
wrote:
> On Sat, Apr 29, 2017 at 08:52:59PM +0100, Okash Khawaja wrote:
>> This applies on top of the changes already in staging-next branch which allow
>> kernel access to TTY dev.
>>
>> Signe-doff-by: Okash Khawaja
>> Reviewed-by: Samuel
On Fri, May 12, 2017 at 06:39:44PM -0700, Remco Verhoef wrote:
> Fixes a 'code indent should use tabs where possible' checkpatch code
> style error by changing whitespace into tabs.
>
> Signed-off-by: Remco Verhoef
> ---
> Changes in v2:
> - More expressive commit message and subject
>
> driv
On Sat, May 13, 2017 at 07:45:28AM +0900, Juan Manuel Torres Palma wrote:
> Fix style in rxtx.c splitting lines into 80 characters or less.
>
> Signed-off-by: Juan Manuel Torres Palma
> ---
> drivers/staging/vt6656/rxtx.c | 20
> 1 file changed, 12 insertions(+), 8 deletions
On Fri, May 12, 2017 at 08:43:58PM +0100, Okash Khawaja wrote:
> This patch fixes the issue where TTY-migrated synths would take a while
> to shut up after hitting numpad enter key. When calling synth_flush,
> even though XOFF character is sent as high priority, data buffered in
> TTY layer is stil
On Sat, Apr 29, 2017 at 08:52:59PM +0100, Okash Khawaja wrote:
> This applies on top of the changes already in staging-next branch which allow
> kernel access to TTY dev.
>
> Signe-doff-by: Okash Khawaja
> Reviewed-by: Samuel Thibault
>
> Index: linux-staging/drivers/tty/tty_io.c
>
On Mon, May 15, 2017 at 12:21:45PM +0200, walter harms wrote:
> can this strcpy_s() replaced with strlcpy ?
>
These functions obviously should be removed, yes. Please send a patch
for that and we can drop my patches. Give David reported-by credit.
regards,
dan carpenter
__
On Sun, May 14, 2017 at 12:42:33AM +0200, Matej Dujava wrote:
> Folowing patches are cleaning some warnings and checkups from checkpatch.pl
I've only reviewed a few of these, please fix them up based on the
comments you have received so far and resend.
thanks,
greg k-h
__
On Sun, May 14, 2017 at 12:42:37AM +0200, Matej Dujava wrote:
> This patch remove unnecessary operation (eg. ``X | (0x0 << Y)`` to ``X``).
>
> Signed-off-by: Matej Dujava
> ---
> drivers/staging/sm750fb/ddk750_display.h | 32
>
> 1 file changed, 16 insertions(+)
Am 15.05.2017 12:01, schrieb Dan Carpenter:
> We're putting the NUL terminators one space beyond where they belong.
> This doesn't show up in testing because all but the callers put a NUL in
> the correct place themselves. LOL. It causes a static checker warning
> about buffer overflows.
>
> F
On Sun, May 14, 2017 at 12:42:36AM +0200, Matej Dujava wrote:
> This patch reorder definition of macros so all macros are in same order.
>
> Signed-off-by: Matej Dujava
> ---
> drivers/staging/sm750fb/ddk750_display.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/driv
On Mon, May 15, 2017 at 11:03:40AM +0530, Pushkar Jambhlekar wrote:
> Fixing 'checkpatch.pl' warnings: Trailing whitespaces
>
> Signed-off-by: Pushkar Jambhlekar
> ---
> drivers/staging/ccree/ssi_cipher.c | 110
> ++---
> 1 file changed, 55 insertions(+), 55 dele
On Fri, May 12, 2017 at 03:42:36PM +0200, Janusz Lisiecki wrote:
> Replace CamelCase fields of struct with underscores to comply
> with the standard kernel coding style
>
> Signed-off-by: Janusz Lisiecki
This patch, and your others in this series, do not apply at all to my
staging-testing branch
We're putting the NUL terminators one space beyond where they belong.
This doesn't show up in testing because all but the callers put a NUL in
the correct place themselves. LOL. It causes a static checker warning
about buffer overflows.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the
We should verify that "ix < max_len" before we test whether we have
reached the NUL terminator.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Reported-by: David Binderman
Signed-off-by: Dan Carpenter
diff --git
a/drivers/staging/media/atomisp/pci/atomisp2/css2400/hi
Oops. Please ignore this one. I meant to send it to David Binderman's
thread.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, May 12, 2017 at 12:59:59PM +0200, Christian Gromm wrote:
> From: Andrey Shvetsov
>
> This introduces the kref for the net_dev_context to prevent the
> destruction of the network devices that are in use.
>
> Each get_net_dev_context is completed with the put_net_dev_context,
> except the
We should verify that "ix < max_len" before we test whether we have
reached the NUL terminator.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Reported-by: David Binderman
Signed-off-by: Dan Carpenter
diff --git
a/drivers/staging/media/atomisp/pci/atomisp2/css2400/hi
On Fri, May 12, 2017 at 12:59:57PM +0200, Christian Gromm wrote:
> From: Andrey Shvetsov
>
> This replaces the function names in the print messages with the __func__
> macro.
>
> Signed-off-by: Andrey Shvetsov
> Signed-off-by: Christian Gromm
> ---
> drivers/staging/most/aim-network/networkin
On Sat, May 13, 2017 at 12:30:07AM +0900, Juan Manuel Torres Palma wrote:
> Fix style in rxtx.c splitting lines into 80 characters or less.
>
> Signed-off-by: Juan Manuel Torres Palma
_ALWAYS_ test build your patches, so you don't get a grumpy maintainer
telling you to test build your patches...
Fixed spelling warnings produced by scripts/checkpatch.pl
Signed-off-by: Ammly Fredrick
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c
b/drivers/staging/rt
Use the BIT(n) macro instead of '(1 << n)' in definitions where the bit
semantics clearly applies.
Fixes true positive "Prefer using the BIT macro" checks reported by
checkpatch.
Some of these checks are still triggering on definitions using
'(1 << n)', namely for PIO2_CNTR_SC_DEV1, PIO2_CNTR_RW_
On Sun, May 14, 2017 at 07:19:50PM +, David Binderman wrote:
> Hello there,
>
> linux-4.12-rc1/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2966]: (style)
> Array index 'i' is used before limits check.
>
> Source code is
>
> while (szLine[i] != '{' && i < strlen(szLine))
>
On Sun, May 14, 2017 at 06:50:24PM +0300, Haim Daniel wrote:
> @@ -129,6 +113,41 @@ static void dgnc_tty_set_termios(struct tty_struct *tty,
>
> /* TTY Initialization/Cleanup Functions */
>
> +static struct tty_driver *__dgnc_tty_register(char *serial_name, uint
> maxports,
No need for doubl
On Sun, May 14, 2017 at 12:42:34AM +0200, Matej Dujava wrote:
> This patch breaks lines that are longer than 80 characters and joins
> together those, that are too short and can be placed at one.
>
The patch basically doesn't match the changelog.
regards,
dan carpenter
__
74 matches
Mail list logo
