[PATCH] staging: rtl8192u: Fix warnings about endianness

2017-02-14 Thread maomao xu
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:177:16: warning: cast to restricted __le16 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:177:16: warning: cast to restricted __le16 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:177:16: warning: cast to restricted

[PATCH] staging: rtl8192u: Fix sparse warnings about endianness

2017-02-14 Thread maomao xu
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:175:36: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:175:36:expected unsigned short [unsigned] [short] [usertype] drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:175:36:g

[PATCH 7/8] hyperv: remove unnecessary return variable

2017-02-14 Thread Stephen Hemminger
hv_ringbuffer_read cleanup. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c index 52d0556a5a25..8a249740b4b4 100644 --- a/drivers/hv/ring_buffer.c +++ b/dri

[PATCH 8/8] vmbus: make channel_message table constant

2017-02-14 Thread Stephen Hemminger
This table is immutable and should be const. Cleanup indentation and whitespace for this as well. Signed-off-by: Stephen Hemminger --- drivers/hv/channel_mgmt.c | 48 +++ drivers/hv/hyperv_vmbus.h | 2 +- 2 files changed, 25 insertions(+), 25 deletion

[PATCH 2/8] vmbus: use rcu for per-cpu channel list

2017-02-14 Thread Stephen Hemminger
The per-cpu channel list is now referred to in the interrupt routine. This is mostly safe since the host will not normally generate an interrupt when channel is being deleted but if it did then there would be a use after free problem. To solve, this use RCU protection on ther per-cpu list. Signed

[PATCH 3/8] vmbus: remove useless return's

2017-02-14 Thread Stephen Hemminger
No need for empty return at end of void function Signed-off-by: Stephen Hemminger --- drivers/hv/hv_balloon.c | 2 -- drivers/hv/hv_fcopy.c| 2 -- drivers/hv/hv_kvp.c | 2 -- drivers/hv/hv_snapshot.c | 2 -- drivers/hv/ring_buffer.c | 2 -- drivers/hv/vmbus_drv.c | 2 -- include/linu

[PATCH 5/8] vmbus: fix spelling errors

2017-02-14 Thread Stephen Hemminger
Several spelling errors in comments Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c | 10 +- drivers/hv/hv_kvp.c | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index 81a80c82f1bd..deb852238b2d 10064

[PATCH 0/8] vmbus: cleanup patches

2017-02-14 Thread Stephen Hemminger
These are non-critical cleanup patches to vmbus code. The only possible bug fix is the second one which relates to using RCU to avoid problems if there was guest/host confusion on shutdown. Stephen Hemminger (8): hyperv: fix warning about missing prototype vmbus: use rcu for per-cpu channel li

[PATCH 6/8] vmbus: remove unused low_latency option

2017-02-14 Thread Stephen Hemminger
This was intended for future use, but since the code is currently unused (and therefore dead and unused), remove it. It can be restored when there is a use case. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c | 2 +- include/linux/hyperv.h | 36

[PATCH 1/8] hyperv: fix warning about missing prototype

2017-02-14 Thread Stephen Hemminger
Compiling with warnings enabled finds missing prototype for hv_do_hypercall. Signed-off-by: Stephen Hemminger --- arch/x86/hyperv/hv_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c index db64baf0e500..d4a5f820af5d 1

[PATCH 4/8] vmbus: remove unnecessary initialization

2017-02-14 Thread Stephen Hemminger
Don't initialize variables that are then set a few lines later. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c index d0ff5b41161a..52d0556a5a25 100

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-14 Thread Joe Perches
On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote: > Yes, I totally agree with joe. > > But as there is no coding style issue in this patch. Style is more than just checkpatch conformity. > So, do I have to resend the complete patch series again? I'm not applying any of these so that's en

[PATCH] Staging: wlan-ng: Fixed the code style issue:

2017-02-14 Thread Bo YU
WARNING: Block comments should align the * on each line Signed-off-by: Bo YU --- drivers/staging/wlan-ng/p80211metastruct.h | 88 ++-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metastruct.h b/drivers/staging/wlan-ng/

Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name

2017-02-14 Thread Joe Perches
On Wed, 2017-02-15 at 09:01 +0530, Arushi Singhal wrote: > Hi Joe > Sorry but I am unable to find the identifier of "unsigned long" .Shall you > please help me in how to find the identifier. > Thanks > Arushi Singhal $ git grep -w XGIRegInit drivers/staging/xgifb/XGI_main_26.c:void XGIRegInit(stru

Re: [PATCH v2 2/3] staging: fbtft: Replace magic number with constant

2017-02-14 Thread Joe Perches
On Wed, 2017-02-15 at 14:27 +1100, Tobin C. Harding wrote: > Current call to strncmp() uses a magic number. There is a compile > time constant defined for this buffer, included and used already at > other sites in the file. > > Remove magic number. Replace with pre-existing compile time constant.

[PATCH v2 3/3] staging: fbtft: Add check on strlcpy() return value

2017-02-14 Thread Tobin C. Harding
Return value of strlcpy() is not checked. Name string is silently truncated if longer that SPI_NAME_SIZE, whilst not detrimental to the program logic it would be nice to notify the user. Module is currently quite verbose, adding extra pr_warn() calls will not overly impact this verbosity. Check re

[PATCH v2 2/3] staging: fbtft: Replace magic number with constant

2017-02-14 Thread Tobin C. Harding
Current call to strncmp() uses a magic number. There is a compile time constant defined for this buffer, included and used already at other sites in the file. Remove magic number. Replace with pre-existing compile time constant. Signed-off-by: Tobin C. Harding --- drivers/staging/fbtft/fbtft_de

[PATCH v2 1/3] staging: fbtft: Fix buffer overflow vulnerability

2017-02-14 Thread Tobin C. Harding
Module copies a user supplied string (module parameter) into a buffer using strncpy() and does not check that the buffer is null terminated. Replace call to strncpy() with call to strlcpy() ensuring that the buffer is null terminated. Signed-off-by: Tobin C. Harding --- drivers/staging/fbtft/fb

[PATCH v2 0/3] staging: fbtft: Fix buffer overflow vulnerability

2017-02-14 Thread Tobin C. Harding
Module copies a user supplied string (module parameter) into a buffer using strncpy() and does not check that the buffer is null terminated. Replace call to strncpy() with call to strlcpy() ensuring that the buffer is null terminated. Replace magic number with pre-existing compile time constant.

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-14 Thread SIMRAN SINGHAL
Yes, I totally agree with joe. But as there is no coding style issue in this patch. So, do I have to resend the complete patch series again? On Wed, Feb 15, 2017 at 1:53 AM, Joe Perches wrote: > On Wed, 2017-02-15 at 01:44 +0530, simran singhal wrote: > [] >> diff --git a/drivers/staging/rtl819

[PATCH] staging: rtl8712: Fix sparse warnings about endianness

2017-02-14 Thread maomao xu
drivers/staging/rtl8712/rtl871x_xmit.c:350:44: warning: restricted __le32 degrades to integer Signed-off-by: maomao xu diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index 4ab82ba..1c2ac28 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c +++ b/d

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-14 Thread Steve Longerbeam
Hi Philipp, I've created a test branch off my imx-media-staging-md-wip called tc358743, which cherry-picks a couple of your commits from your imx-media-staging-md-wip branch: [media] tc358743: set entity function to video interface bridge [media] tc358743: put lanes in STOP state before starti

Re: [PATCH] staging: fbtft: Fix buffer overflow vulnerability

2017-02-14 Thread Greg Kroah-Hartman
On Wed, Feb 15, 2017 at 11:42:54AM +1100, Tobin C. Harding wrote: > Module copies a user supplied string (module parameter) into a buffer > using strncpy() and does not check that the buffer is null terminated. > > Replace call to strncpy() with call to strlcpy() ensuring that the > buffer is null

[PATCH] staging: fbtft: Fix buffer overflow vulnerability

2017-02-14 Thread Tobin C. Harding
Module copies a user supplied string (module parameter) into a buffer using strncpy() and does not check that the buffer is null terminated. Replace call to strncpy() with call to strlcpy() ensuring that the buffer is null terminated. Signed-off-by: Tobin C. Harding --- drivers/staging/fbtft/fb

[PATCH] greybus: fw-management: Replace strncpy with strlcpy

2017-02-14 Thread Tobin C. Harding
Greybus currently uses strncpy() coupled with a check for '\0' on the last byte of various buffers. strncpy() is passed size parameter equal to the size of the buffer in all instances. If the source string is larger than the destination buffer the check catches this and, after logging the error, re

[patch] staging: bcm2835-audio: allocate enough data for work queues

2017-02-14 Thread Dan Carpenter
We accidentally allocate sizeof(void *) bytes instead of 112 bytes. It results in memory corruption. Fixes: 23b028c871e1 ("staging: bcm2835-audio: initial staging submission") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audi

[patch] Staging: bcm2835-audio: && vs & typo

2017-02-14 Thread Dan Carpenter
We intended to mask away the upper bits but there is a "&&" vs "&" typo so it's broken. Fixes: 23b028c871e1 ("staging: bcm2835-audio: initial staging submission") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c

[PATCH 2/9] staging:r8188eu: refactor add_RATid() - remove rtw_hal_get_hwreg() call

2017-02-14 Thread Ivan Safonov
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor add_RATid(). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ap.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git

[PATCH 6/9] staging:r8188eu: refactor rtw_update_ht_cap() - remove rtw_hal_get_hwreg() call

2017-02-14 Thread Ivan Safonov
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor rtw_update_ht_cap(). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff

[PATCH 5/9] staging:r8188eu: refactor issue_assocreq() - remove rtw_hal_get_hwreg() call

2017-02-14 Thread Ivan Safonov
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor issue_assocreq(). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 24 1 file changed, 4 insertions(+), 20 del

[PATCH 3/9] staging:r8188eu: refactor rtw_check_beacon_data() - remove rtw_hal_get_hwreg() call

2017-02-14 Thread Ivan Safonov
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor rtw_check_beacon_data(). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ap.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff

[PATCH 4/9] staging:r8188eu: refactor rtw_get_cur_max_rate() - remove rtw_hal_get_hwreg() call

2017-02-14 Thread Ivan Safonov
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor rtw_get_cur_max_rate(). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH 8/9] staging:r8188eu: remove unused HW_VAR_RF_TYPE parameter of HT_caps_handler

2017-02-14 Thread Ivan Safonov
rtw_hal_get_hwreg() does not used with HW_VAR_RF_TYPE parameter. Remove HW_VAR_RF_TYPE switch case in rtw_hal_get_hwreg and definition. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 3 --- drivers/staging/rtl8188eu/include/hal_intf.h | 1 - 2 files changed, 4 del

[PATCH 9/9] staging:r8188eu: remove unused MCS_rate_2R array

2017-02-14 Thread Ivan Safonov
MCS_rate_2R[] does not used. Remove it. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 1 - drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 1 - drivers/staging/rtl8188eu/include/rtw_mlme.h | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 1/9] staging:r8188eu: use DIV_ROUND_UP() in rtw_signal_stat_timer_hdl()

2017-02-14 Thread Ivan Safonov
DIV_ROUND_UP macro is shorter and look better than if-else construction. DIV_ROUND_UP used in rtw_signal_stat_timer_hdl(). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8

[PATCH 7/9] staging:r8188eu: refactor HT_caps_handler() - remove rtw_hal_get_hwreg() call

2017-02-14 Thread Ivan Safonov
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor HT_caps_handler(). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) d

[PATCH v3 2/2] Staging: vc04_services: Fix the "space prohibited" code style errors

2017-02-14 Thread Mandel Benjamin
Fixes the following code style errors: ERROR: space prohibited after/before that open/closed parenthesis Signed-off-by: Mandel Benjamin --- drivers/staging/vc04_services/interface/vchi/vchi_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_s

[PATCH v3 1/2] Staging: vc04_services: Fix the "wrong indent" code style errors

2017-02-14 Thread Mandel Benjamin
Fixes the following code style errors: ERROR: code indent should use tabs where possible Signed-off-by: Mandel Benjamin --- drivers/staging/vc04_services/interface/vchi/vchi_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface

[PATCH] hv: hide unused label

2017-02-14 Thread Arnd Bergmann
This new 32-bit warning just showed up: arch/x86/hyperv/hv_init.c: In function 'hyperv_init': arch/x86/hyperv/hv_init.c:167:1: error: label 'register_msr_cs' defined but not used [-Werror=unused-label] The easiest solution is to move the label up into the existing #ifdef that has the goto. Fixe

Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues

2017-02-14 Thread kbuild test robot
Hi Arushi, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.10-rc8 next-20170214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arushi-Singhal/staging-fwserial

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-14 Thread Joe Perches
On Wed, 2017-02-15 at 01:44 +0530, simran singhal wrote: [] > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c > b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c [] > @@ -150,14 +150,15 @@ static inline char *rtl819x_translate_scan(struct > ieee80211_device *ieee, >

Re: [PATCH v2 5/9] staging: rtl8192u: Use min_t instead of min

2017-02-14 Thread Joe Perches
On Wed, 2017-02-15 at 01:43 +0530, simran singhal wrote: > Use min_t instead of min function in ieee80211/ieee80211_wx.c > fixed warning: > WARNING: min() should probably be min_t(u8, network->ssid_len, 32) [] > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c > b/drivers/staging/rtl

Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name

2017-02-14 Thread Joe Perches
On Wed, 2017-02-15 at 02:03 +0530, Arushi Singhal wrote: > function definition argument 'struct vb_device_info *' should also have > an identifier name. [] > diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h [] > @@ -1,6 +1,6 @@ > #ifndef _VBINIT_ > #define _VBINIT_ >

[PATCH] staging: xgifb: function definition argument should also have an identifier name

2017-02-14 Thread Arushi Singhal
function definition argument 'struct vb_device_info *' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h inde

Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues

2017-02-14 Thread kbuild test robot
Hi Arushi, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.10-rc8 next-20170214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arushi-Singhal/staging-fwserial

[PATCH v2 8/9] staging: rtl8192u: Fixing style issues in r8180_93cx6.h

2017-02-14 Thread simran singhal
Fixing the following checkpatch.pl errors and warning: WARNING: Block comments use * on subsequent lines CHECK: Please don't use multiple blank lines Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8180_93cx6.h | 27 +-- 1 file changed, 13 insertions(+), 14 d

[PATCH v2 9/9] staging: rtl8192u: fixing block comments use * on subsequent lines

2017-02-14 Thread simran singhal
Fixed checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8190_rtl8256.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.h b/drivers/s

[PATCH v2 7/9] staging: rtl8192u: Fixing style issues in r8180_93cx6.c

2017-02-14 Thread simran singhal
Fixing the following checkpatch.pl errors and warning: WARNING: Block comments use * on subsequent lines CHECK: Please don't use multiple blank lines CHECK: Alignment should match open parenthesis CHECK: spaces preferred around that '<<' CHECK: spaces preferred around that '-' CHECK: Alignment

[PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-14 Thread simran singhal
fixed errors and warnings: ERROR: spaces required around that '=' ERROR: spaces required around that '<' ERROR: space required before the open parenthesis '(' CHECK: spaces preferred around that '&' CHECK: spaces preferred around that '<<' ERROR: space required after that ',' ERROR: spaces required

[PATCH v2 5/9] staging: rtl8192u: Use min_t instead of min

2017-02-14 Thread simran singhal
Use min_t instead of min function in ieee80211/ieee80211_wx.c fixed warning: WARNING: min() should probably be min_t(u8, network->ssid_len, 32) Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH v2 4/9] staging: rtl8192u: blank lines aren't necessary before a close brace '}'

2017-02-14 Thread simran singhal
Fix checkpatch issues: "CHECK: Blank lines aren't necessary before a close brace '}'". Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rt

[PATCH v2 3/9] staging: rtl8192u: Adding space after enum and struct definition

2017-02-14 Thread simran singhal
Fixes checkpatch.pl warning: WARNING: missing space after struct definition WARNING: missing space after enum definition Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git

[PATCH v2 2/9] staging: rtl8192u: Adding space after struct definition

2017-02-14 Thread simran singhal
Fixes checkpatch.pl warning: WARNING: missing space after struct definition Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers/staging

[PATCH v2 1/9] staging: rtl8192u: fixing white space issue

2017-02-14 Thread simran singhal
Fix the following checkpatch.pl error and warnings: WARNING: please, no space before tabs Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/d

Re: [PATCH 2/3 staging-next] oom: Add notification for oom_score_adj (fwd)

2017-02-14 Thread Julia Lawall
build test WARNING on staging/staging-testing] [also build test WARNING on v4.10-rc8 next-20170214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/peter-enderborg-sonymobile-com/android-Collect

[PATCH 2/2] staging: vt6656: Alignment match open parenthesis

2017-02-14 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal --- drivers/staging/vt6656/rxtx.c | 54 +-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/stagin

Re: [PATCH]staging: fbtft: Fix sparse warnings about endianness

2017-02-14 Thread Al Viro
On Tue, Feb 14, 2017 at 09:18:25AM -0800, Greg KH wrote: > On Tue, Feb 14, 2017 at 04:53:10PM +0800, maomao xu wrote: > > Fixed sparse warnings about endianness. E.g.: > > > > warning: incorrect type in assignment (different base types) > > Why are these lines indented? > > > Signed-off-

Re: [PATCH] staging: wlan-ng/p80211conv.c: Fix warnings regarding types.

2017-02-14 Thread Greg KH
On Mon, Feb 13, 2017 at 03:15:26PM +0100, Anthony Brandon wrote: > Fix several warnings in p80211conv.c emitted when using make C=1 by turning > the type member in wlan_ethhdr and wlan_snap into __be16 and changing > le16_to_cpu into ntohs. > > Signed-off-by: Anthony Brandon > --- > drivers/stag

[PATCH 1/2] staging: vt6656: Alignment should match open parenthesis

2017-02-14 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal --- drivers/staging/vt6656/firmware.c | 34 +- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656/rf.c | 12 ++-- drivers/staging/vt6

Re: [PATCH 01/15] staging: rtl8192u: fixing white space issue

2017-02-14 Thread Greg KH
On Tue, Feb 14, 2017 at 11:16:59PM +0530, SIMRAN SINGHAL wrote: > While resending them ...do I have to mention v2. Of course, why wouldn't you? :) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject

Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues

2017-02-14 Thread Greg KH
On Tue, Feb 14, 2017 at 11:26:20PM +0530, Arushi Singhal wrote: > Macro argument 'a' may be better as '(a)' to avoid precedence issues as > reported by checkpatch.pl > > Signed-off-by: Arushi Singhal > --- > drivers/staging/fwserial/fwserial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

[PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues

2017-02-14 Thread Arushi Singhal
Macro argument 'a' may be better as '(a)' to avoid precedence issues as reported by checkpatch.pl Signed-off-by: Arushi Singhal --- drivers/staging/fwserial/fwserial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwser

Re: [PATCH 01/15] staging: rtl8192u: fixing white space issue

2017-02-14 Thread SIMRAN SINGHAL
While resending them ...do I have to mention v2. On Tue, Feb 14, 2017 at 10:54 PM, Greg KH wrote: > On Tue, Feb 14, 2017 at 02:33:34AM +0530, simran singhal wrote: >> Fix the following checkpatch.pl error and warnings: >> WARNING: please, no space before tabs >> >> Signed-off-by: simran singhal

Re: [PATCH v2 0/3] x86/vdso: Add Hyper-V TSC page clocksource support

2017-02-14 Thread Andy Lutomirski
On Tue, Feb 14, 2017 at 7:50 AM, Vitaly Kuznetsov wrote: > Thomas Gleixner writes: > >> On Tue, 14 Feb 2017, Vitaly Kuznetsov wrote: >> >>> Hi, >>> >>> while we're still waiting for a definitive ACK from Microsoft that the >>> algorithm is good for SMP case (as we can't prevent the code in vdso f

Re: [PATCH 01/15] staging: rtl8192u: fixing white space issue

2017-02-14 Thread Greg KH
On Tue, Feb 14, 2017 at 02:33:34AM +0530, simran singhal wrote: > Fix the following checkpatch.pl error and warnings: > WARNING: please, no space before tabs > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 d

Re: [PATCH v2 01/25] Staging: rtl8192u: r819xU_phy.c - style fix

2017-02-14 Thread Greg KH
On Mon, Feb 13, 2017 at 06:39:06PM +1300, Derek Robson wrote: > Fixed style of block comments > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/rtl8192u/r819xU_phy.c | 41 > +++ > 1 file changed, 27 insertions(+), 14 deletions(-) T

Re: [PATCH]staging: fbtft: Fix sparse warnings about endianness

2017-02-14 Thread Greg KH
On Tue, Feb 14, 2017 at 04:53:10PM +0800, maomao xu wrote: > Fixed sparse warnings about endianness. E.g.: > > warning: incorrect type in assignment (different base types) Why are these lines indented? > Signed-off-by: maomao xu > > diff --git a/drivers/staging/fbtft/fbtft-io.c > b/dr

Re: [PATCH] Staging: wlan-ng: Fixed code style issue:

2017-02-14 Thread Kroah-Hartman
On Mon, Feb 13, 2017 at 09:20:05AM -0500, Bo YU wrote: > Statements should start on a tabstop > > Signed-off-by: YU Bo > --- > drivers/staging/wlan-ng/prism2mgmt.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch does not apply to my tree :( ___

[PATCH] staging: gdm724x: modify icmp6_checksum for returning a correct data type.

2017-02-14 Thread Javier Rodriguez
The icmp6_checksum was returning an invalid data type as the expected type is __sum16. For returning such data type, icmp6_checksum, now, is using the kernel functions for computing the checksum. Here, the sparse message: drivers/staging/gdm724x/gdm_lte.c:311:39: warning: incorrect type in assign

Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line

2017-02-14 Thread Greg Kroah-Hartman
On Mon, Feb 13, 2017 at 09:25:49AM -0500, Maksymilian Piechota wrote: > move logical continuations at the end of line > > Signed-off-by: Maksymilian Piechota > --- > drivers/staging/wlan-ng/prism2mgmt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/stagin

Re: [PATCH] staging: vt6656: Alignment match open parenthesis

2017-02-14 Thread Greg KH
On Mon, Feb 13, 2017 at 04:01:13AM +0530, Arushi Singhal wrote: > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" > > Signed-off-by: Arushi Singhal > --- > drivers/staging/vt6656/firmware.c | 34 +- > drivers/staging/vt6656/key.h | 2

Re: [PATCH v2 0/1] Staging: vc04_services: Fix the "wrong indent" code style errors

2017-02-14 Thread Greg Kroah-Hartman
On Mon, Feb 13, 2017 at 06:12:31PM +0900, Mandel Benjamin wrote: > > This patch fixes the following code style errors: > > ERROR: code indent should use tabs where possible > > Signed-off-by: Mandel Benjamin > --- > drivers/staging/vc04_services/interface/vchi/vchi_common.h | 4 ++-- > 1 file

[PATCH] staging:nvec:nvec_ps2.c: Prefering kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...)

2017-02-14 Thread Arushi Singhal
Prefer kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...) as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/nvec/nvec_ps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nve

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-14 Thread Philipp Zabel
Hi Steve, On Mon, 2017-02-13 at 15:20 -0800, Steve Longerbeam wrote: [...] > > It seems the OV5640 driver never puts its the CSI-2 lanes into stop > > state while not streaming. > > Yes I found that as well. > > But good news, I finally managed to coax the OV5640's clock lane > into LP-11 state!

Re: [PATCH] staging: gdm724x: Fix sparse warnings

2017-02-14 Thread javier
El 14/02/17 a las 10:24, maomao xu escribió: drivers/staging/gdm724x/gdm_lte.c:311:39: warning: incorrect type in assignment (different base types) drivers/staging/gdm724x/gdm_lte.c:311:39:expected restricted __sum16 [addressable] [assigned] [usertype] icmp6_cksum drivers/staging/gdm724x/gd

Re: [PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller

2017-02-14 Thread Greg KH
On Tue, Feb 14, 2017 at 05:09:30PM +0100, peter.enderb...@sonymobile.com wrote: > From: Peter Enderborg > > This collects stats for shrinker calls and how much > waste work we do within the lowmemorykiller. > > Signed-off-by: Peter Enderborg Wait, what changed from the previous versions of thi

Re: [PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller

2017-02-14 Thread Greg KH
On Tue, Feb 14, 2017 at 05:09:30PM +0100, peter.enderb...@sonymobile.com wrote: > From: Peter Enderborg > > This collects stats for shrinker calls and how much > waste work we do within the lowmemorykiller. > > Signed-off-by: Peter Enderborg > --- > drivers/staging/android/Kconfig

[PATCH 2/3 staging-next] oom: Add notification for oom_score_adj

2017-02-14 Thread peter.enderborg
From: Peter Enderborg This adds subscribtion for changes in oom_score_adj, this value is important to android systems. For task that uses oom_score_adj they read the task list. This can be long and need rcu locks and has a impact on the system. Let the user track the changes based on oom_score_ad

[PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller

2017-02-14 Thread peter.enderborg
From: Peter Enderborg This collects stats for shrinker calls and how much waste work we do within the lowmemorykiller. Signed-off-by: Peter Enderborg --- drivers/staging/android/Kconfig | 11 drivers/staging/android/Makefile| 1 + drivers/staging/android/l

[PATCH 3/3 staging-next] mm: Remove RCU and tasklocks from lmk

2017-02-14 Thread peter.enderborg
From: Peter Enderborg Fundamental changes: 1 Does NOT take any RCU lock in shrinker functions. 2 It returns same result for scan and counts, so we dont need to do shinker will know when it is pointless to call scan. 3 It does not lock any other process than the one that is going to be killed

Re: [PATCH v2 0/3] x86/vdso: Add Hyper-V TSC page clocksource support

2017-02-14 Thread Vitaly Kuznetsov
Thomas Gleixner writes: > On Tue, 14 Feb 2017, Vitaly Kuznetsov wrote: > >> Hi, >> >> while we're still waiting for a definitive ACK from Microsoft that the >> algorithm is good for SMP case (as we can't prevent the code in vdso from >> migrating between CPUs) I'd like to send v2 with some modif

Re: [PATCH v2 0/3] x86/vdso: Add Hyper-V TSC page clocksource support

2017-02-14 Thread Thomas Gleixner
On Tue, 14 Feb 2017, Vitaly Kuznetsov wrote: > Hi, > > while we're still waiting for a definitive ACK from Microsoft that the > algorithm is good for SMP case (as we can't prevent the code in vdso from > migrating between CPUs) I'd like to send v2 with some modifications to keep > the discussion

RE: [PATCH v2 0/3] x86/vdso: Add Hyper-V TSC page clocksource support

2017-02-14 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, February 14, 2017 4:44 AM > To: x...@kernel.org; Andy Lutomirski > Cc: Thomas Gleixner ; Ingo Molnar ; > H. Peter Anvin ; KY Srinivasan ; > Haiyang Zhang ; Stephen Hemminger > ; Dexuan Cui ; linux

[PATCH v2 1/3] x86/hyperv: implement hv_get_tsc_page()

2017-02-14 Thread Vitaly Kuznetsov
To use Hyper-V TSC page clocksource from vDSO we need to make tsc_pg available. Implement hv_get_tsc_page() and add CONFIG_HYPERV_TSCPAGE to make #ifdef-s simple. Signed-off-by: Vitaly Kuznetsov --- arch/x86/hyperv/hv_init.c | 9 +++-- arch/x86/include/asm/mshyperv.h | 8 driv

[PATCH v2 2/3] x86/hyperv: move TSC reading method to asm/mshyperv.h

2017-02-14 Thread Vitaly Kuznetsov
As a preparation to making Hyper-V TSC page suitable for vDSO move the TSC page reading logic to asm/mshyperv.h. While on it, do the following - Document the reading algorithm. - Simplify the code a bit. - Add explicit barriers to prevent re-ordering (we need to read sequence stricktly before and

[PATCH v2 3/3] x86/vdso: Add VCLOCK_HVCLOCK vDSO clock read method

2017-02-14 Thread Vitaly Kuznetsov
Hyper-V TSC page clocksource is suitable for vDSO, however, the protocol defined by the hypervisor is different from VCLOCK_PVCLOCK. Implement the required support by adding hvclock_page VVAR. Signed-off-by: Vitaly Kuznetsov --- arch/x86/entry/vdso/vclock_gettime.c | 24

[PATCH v2 0/3] x86/vdso: Add Hyper-V TSC page clocksource support

2017-02-14 Thread Vitaly Kuznetsov
Hi, while we're still waiting for a definitive ACK from Microsoft that the algorithm is good for SMP case (as we can't prevent the code in vdso from migrating between CPUs) I'd like to send v2 with some modifications to keep the discussion going. Changes since v1: - Document the TSC page reading

[PATCH 09/15] staging: rtl8192u: fixing block comments use * on subsequent lines

2017-02-14 Thread simran singhal
Fixed checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8190_rtl8256.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.h b/drivers/s

[PATCH 08/15] staging: rtl8192u: Fixing style issues in r8180_93cx6.h

2017-02-14 Thread simran singhal
Fixing the following checkpatch.pl errors and warning: WARNING: Block comments use * on subsequent lines CHECK: Please don't use multiple blank lines Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r8180_93cx6.h | 27 +-- 1 file changed, 13 insertions(+), 14 d

[PATCH 07/15] staging: rtl8192u: Fixing style issues in r8180_93cx6.c

2017-02-14 Thread simran singhal
Fixing the following checkpatch.pl errors and warning: WARNING: Block comments use * on subsequent lines CHECK: Please don't use multiple blank lines CHECK: Alignment should match open parenthesis CHECK: spaces preferred around that '<<' CHECK: spaces preferred around that '-' CHECK: Alignment

[PATCH 06/15] staging: rtl8192u: Fixing coding style issues

2017-02-14 Thread simran singhal
fixed errors and warnings: ERROR: spaces required around that '=' ERROR: spaces required around that '<' ERROR: space required before the open parenthesis '(' CHECK: spaces preferred around that '&' CHECK: spaces preferred around that '<<' ERROR: space required after that ',' ERROR: spaces required

Re: [PATCH] staging: nvec: Fix incorrect type of i2c address

2017-02-14 Thread Marc Dietrich
Am Montag, 13. Februar 2017, 09:35:19 CET schrieb Franck Demathieu: > From: Franck Demathieu > > The i2c address is unsigned according to the dt-bindings. > Fix sparse issue (-Wtypesign): > > drivers/staging/nvec/nvec.c:781:35: warning: incorrect type in argument 3 > (different signedness) dri

[PATCH v2] staging: bcm2835-audio: remove unused macro

2017-02-14 Thread Hendrik v. Raven
The VC_AUDIO_MAX_MSG_LEN macro is not used by anything in the bcm2835-audio driver. Signed-off-by: Hendrik v. Raven --- v2: - rebased against next-20170214 --- drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/bcm2835

[PATCH 05/15] staging: rtl8192u: Use min_t instead of min

2017-02-14 Thread simran singhal
Use min_t instead of min function in ieee80211/ieee80211_wx.c fixed warning: WARNING: min() should probably be min_t(u8, network->ssid_len, 32) Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH] staging: gdm724x: Fix sparse warnings

2017-02-14 Thread maomao xu
drivers/staging/gdm724x/gdm_lte.c:311:39: warning: incorrect type in assignment (different base types) drivers/staging/gdm724x/gdm_lte.c:311:39:expected restricted __sum16 [addressable] [assigned] [usertype] icmp6_cksum drivers/staging/gdm724x/gdm_lte.c:311:39:got int Signed-off-by: maom

[PATCH]staging: fbtft: Fix sparse warnings about endianness

2017-02-14 Thread maomao xu
Fixed sparse warnings about endianness. E.g.: warning: incorrect type in assignment (different base types) Signed-off-by: maomao xu diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c index d868405..ffb9a3b 100644 --- a/drivers/staging/fbtft/fbtft-io.c +++ b

[bug report] binder: Support multiple /dev instances

2017-02-14 Thread Dan Carpenter
Hello Martijn Coenen, The patch ac4812c5ffbb: "binder: Support multiple /dev instances" from Feb 3, 2017, leads to the following static checker warning: drivers/android/binder.c:4266 binder_init() warn: did you mean to pass the address of 'device_names' drivers/android/binder.c