On Sat, Feb 11, 2017 at 10:46:27AM +0530, simran singhal wrote:
> Fix brace placement errors caught by checkpatch.pl ERROR: that open
> brace { should be on the previous line
>
> Signed-off-by: simran singhal
> ---
> .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 90
>
On Sat, Feb 11, 2017 at 09:34:12AM +0530, SIMRAN SINGHAL wrote:
> Multiple patches ...?
You sent me lots of patches, how am I supposed to know which one to
apply in what order?
> Can you please clarify what all patches you are including in "Multiple
> Patches".
Everything you have sent me.
> A
On Sat, Feb 11, 2017 at 07:48:35AM +0530, Arushi Singhal wrote:
> Hi
> Sorry Greg but how this not applying to your mailing list.
Your patch did not apply to my staging-next git tree. Probably because
soemone else already did this same work before you did. Try rebasing
your patch on my staging-n
Fix 'void function return statements are not generally useful'
checkpatch.pl warnings.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
b/drivers/stagin
Fix brace placement errors caught by checkpatch.pl ERROR: that open
brace { should be on the previous line
Signed-off-by: simran singhal
---
.../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 90 --
1 file changed, 30 insertions(+), 60 deletions(-)
diff --git a/drivers/sta
Fix checkpatch.pl issue of the form:
"CHECK: Alignment should match open parenthesis".
Signed-off-by: Nathan Howard
---
drivers/staging/dgnc/dgnc_tty.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
Fix checkpatch.pl issue of the form:
"CHECK: Please don't use multiple blank lines".
Signed-off-by: Nathan Howard
---
drivers/staging/greybus/arpc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/arpc.h b/drivers/staging/greybus/arpc.h
index 7fbddfc..c0b63c0 100644
--
Multiple patches ...?
Can you please clarify what all patches you are including in "Multiple Patches".
And the Order you should go for is the order in which I submitted them.
On Sat, Feb 11, 2017 at 7:48 AM, SIMRAN SINGHAL
wrote:
> Multiple patches ...?
> Can you please clarify what all patches
Sparse reports the following:
CHECK drivers/staging/rtl8712/rtl871x_ioctl_linux.c
drivers/staging/rtl8712/rtl871x_ioctl_linux.c:1422:46: warning: restricted
__le16 degrades to integer
drivers/staging/rtl8712/rtl871x_ioctl_linux.c:1424:46: warning: restricted
__le16 degrades to integer
Signed
Sparse reports the following:
CHECK drivers/staging/rtl8712/rtl871x_mlme.c
drivers/staging/rtl8712/rtl871x_mlme.c:1653:46: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8712/rtl871x_mlme.c:1653:46:expected unsigned int
[unsigned] [usertype] DSConfig
drive
Sparse reports the following:
CHECK drivers/staging/rtl8712/rtl871x_recv.c
drivers/staging/rtl8712/rtl871x_recv.c:657:21: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8712/rtl871x_recv.c:657:21:expected unsigned short
[unsigned] [assigned] [usertype] len
Now that endian checking is an automatic part of Sparse, it is advisable
to fix these warnings under controlled conditions, which include testing
on big-endian hardware. This set of patches fix all the issues.
Signed-off-by: Larry Finger
Larry Finger (7):
staging: r8712u: Fix some Sparse endi
The headers describing a number of network packets do not have the
correct endian settings for several types of data.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/ieee80211.h | 84 ++---
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/dr
Sparse reports the following:
CHECK drivers/staging/rtl8712/rtl871x_xmit.c
drivers/staging/rtl8712/rtl871x_xmit.c:350:44: warning: restricted __le32
degrades to integer
drivers/staging/rtl8712/rtl871x_xmit.c:491:23: warning: incorrect type in
initializer (different base types)
drivers/staging
Sparse reports the following:
CHECK drivers/staging/rtl8712/rtl8712_xmit.c
drivers/staging/rtl8712/rtl8712_xmit.c:564:42: warning: cast from restricted
__le32
drivers/staging/rtl8712/rtl8712_xmit.c:569:42: warning: cast from restricted
__le32
drivers/staging/rtl8712/rtl8712_xmit.c:571:42: wa
Although the driver works on big-endian hardware, Sparse generates a lot
of warnings. Many of these are the result of incorrect coding of these
macros.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/wifi.h | 109 -
1 file changed, 52 insertions(+)
Marked msi_domain_ops structs as __ro_after_init when called only during init.
This protects the data structure from accidental corruption.
Suggested-by: Kees Cook
Signed-off-by: Jess Frazelle
---
drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 2 +-
1 file changed, 1 insertion(+), 1 d
Marked msi_domain_ops structs as __ro_after_init when called only during init.
This protects the data structure from accidental corruption.
Suggested-by: Kees Cook
Signed-off-by: Jess Frazelle
---
drivers/pci/host/pci-hyperv.c | 2 +-
drivers/pci/host/vmd.c| 2 +-
drivers/pci/msi.c
Hi Bjorn,
This patch and the other one in the series ([Resend PATCH 2/2 v3] pci-hyperv:
lock pci bus on device eject) have been Acked.
Is there anything else should be done before it can be merged? Please let me
know.
Thanks
Long
> -Original Message-
> From: KY Srinivasan
> Sent: Fri
Changed permissions to octal style
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/platform/bcm2835/bcm2835-camera.c
b/drivers/staging/m
Changed permissions to octal across whole driver
Found by checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
drivers/staging/media/lirc/lirc_sir.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/lirc/lir
Fixed an error where the system was given a code in the form of decimal
instead of octal.
Signed-off-by: Ran Algawi
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/stagi
Fixed alignment of block commenents across whole driver.
Found using checkpatch.
Signed-off-by: Derek Robson
---
.../staging/media/davinci_vpfe/davinci_vpfe_user.h | 24 +++---
.../staging/media/davinci_vpfe/dm365_ipipe_hw.c| 4 ++--
.../staging/media/davinci_vpfe/dm365_isif
On Wed, Feb 08, 2017 at 04:49:22PM -0600, Bjorn Helgaas wrote:
> [Some of you will get this twice because Gmail and I aren't getting along
> today; sorry]
>
> The PCI core doesn't configure the PCIe MPS settings by itself. Each
> host bridge driver has to call pcie_bus_configure_settings() to mak
On Wed, Feb 08, 2017 at 11:19:56PM -0800, Christoph Hellwig wrote:
> On Wed, Feb 08, 2017 at 04:49:30PM -0600, Bjorn Helgaas wrote:
> > + list_for_each_entry(child, &bus->children, node)
> > + pcie_bus_configure_settings(child);
>
> This loop is duplicated in just about every driver, s
On Tue, Feb 07, 2017 at 09:00:10AM +, Dexuan Cui wrote:
> The devfn of 00:02.0 is 0x10.
> devfn_to_wslot(0x10) == 0x2, and wslot_to_devfn(0x2) should be 0x10,
> while it's 0x2 in the current code.
>
> Due to this, hv_eject_device_work() -> pci_get_domain_bus_and_slot()
> returns NULL and pci_s
On 02/10/2017 12:23 PM, Perry Hooker wrote:
This patch fixes the following sparse warning:
drivers/staging/rtl8712/usb_ops_linux.c:212:33: warning: cast to restricted
__le32
Signed-off-by: Perry Hooker
---
drivers/staging/rtl8712/usb_ops_linux.c | 5 +++--
1 file changed, 3 insertions(+), 2 d
On 10-2-2017 16:06, Franck Demathieu wrote:
> It fixes the following warning reported by sparse:
>
> drivers/staging/wilc1000/linux_wlan.c:67:33: warning: too long
> initializer-string for array of char(no space for nul char)
As this was already submitted this should probably say [PATCH V2] in
On 09/02/17 15:04, Saber Rezvani wrote:
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dt2815.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/dt2815.c
Fix the checkpatch.pl issue:
CHECK: Please use a blank line after function/struct/union/enum
declarations
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/ni_pcidio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/comedi/drivers/ni_pcidio.c
b/drivers/stagin
Fix the checkpatch.pl issue:
CHECK: spaces preferred around that '|' (ctx:VxV)
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/ni_pcidio.c | 40 +++---
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_pcidio
Trailing statements should be on next line.
Signed-off-by: AbdAllah-MEZITI
v2:braces {} should be used on all arms of this statement
---
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vch
Trailing statements should be on next line.
Signed-off-by: AbdAllah-MEZITI
v2:braces {} should be used on all arms of this statement
---
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vch
Ouch. My apologies. I'll take more care next time. I've supplied an
updated patch that uses the __le32 type for *(pbuf + 1).
On Fri, Feb 10, 2017 at 8:07 AM, Larry Finger wrote:
> On 02/10/2017 08:58 AM, Greg KH wrote:
>>
>> On Fri, Feb 10, 2017 at 08:52:12AM -0600, Larry Finger wrote:
>>>
>>> On
This patch fixes the following sparse warning:
drivers/staging/rtl8712/usb_ops_linux.c:212:33: warning: cast to restricted
__le32
Signed-off-by: Perry Hooker
---
drivers/staging/rtl8712/usb_ops_linux.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/s626.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/s626.c
b/drivers/staging/comedi/drivers/s626.c
inde
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c
b/drivers/staging/co
On Fri, 10 Feb 2017, Stephen Hemminger wrote:
> Since sequence count algorithm is done by hypervisor, better to not reuse
> seqcount.
> Still concerned that the code is racy.
That's a different question and can only be answered by the hypervisor
folks. Dunno, whether they have barrier requiremen
On Fri, 2017-02-10 at 17:14 +0100, AbdAllah-MEZITI wrote:
> Trailing statements should be on next line.
[]
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
> b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
[]
> @@ -563,7 +563,8 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
>
On Thu, Feb 09, 2017 at 10:18:42AM +, Carlos Palminha wrote:
> Fixed missing conversion to le32, detected by sparse
> (invalid assignment from int to __le32)
>
> Signed-off-by: Carlos Palminha
> ---
> v1->v2:
> missed sob line (too late in the night...)
>
> drivers/staging/rtl8712/rtl8712_x
On 09/02/17 21:38, Saber Rezvani wrote:
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/s626.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/s626.c
b/
On Fri, Feb 10, 2017 at 04:39:02PM +, Stephen Hemminger wrote:
> In the set I submitted was the patch to remove usage of per channel state in
> netvsc.
Ah.
> KY dropped it, because it already is in net-next. So this patch can wait
> until net-next is merged.
> The current split tree process
Removing unnecessary blank lines around braces to solve CHECKS.
Signed-off-by: Shiva Kerdel
---
drivers/staging/ks7010/ks_hostif.c | 11 ---
drivers/staging/ks7010/ks_wlan.h | 1 -
drivers/staging/ks7010/ks_wlan_net.c | 5 -
3 files changed, 17 deletions(-)
diff --git a/driv
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Friday, February 10, 2017 6:47 AM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com; vkuzn...@redhat.com; jasow...@redhat.com;
leann.ogasaw...@ca
Since sequence count algorithm is done by hypervisor, better to not reuse
seqcount.
Still concerned that the code is racy.
-Original Message-
From: Thomas Gleixner [mailto:t...@linutronix.de]
Sent: Friday, February 10, 2017 4:28 AM
To: Vitaly Kuznetsov
Cc: Stephen Hemminger ; x...@kerne
On 09/02/17 15:36, Saber Rezvani wrote:
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/dr
Trailing statements should be on next line.
Signed-off-by: AbdAllah-MEZITI
---
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
index
On 09/02/17 14:44, Saber Rezvani wrote:
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dt2814.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/dt2814.c
On 09/02/17 14:26, Saber Rezvani wrote:
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dt2801.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt28
On 09/02/17 21:33, Saber Rezvani wrote:
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_
Replaced sizeof(struct foo) into sizeof(*ptr), found by checkpatch.pl.
Signed-off-by: Youngdo, Lee
---
drivers/staging/android/ion/ion_cma_heap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/ion/ion_cma_heap.c
b/drivers/staging/android/ion/io
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Friday, February 10, 2017 6:48 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com; leann
On 02/10/2017 08:58 AM, Greg KH wrote:
On Fri, Feb 10, 2017 at 08:52:12AM -0600, Larry Finger wrote:
On 02/10/2017 08:08 AM, Greg KH wrote:
On Thu, Feb 09, 2017 at 08:51:55PM -0700, Perry Hooker wrote:
This patch fixes the following sparse warning:
drivers/staging/rtl8712/usb_ops_linux.c:212:3
It fixes the following warning reported by sparse:
drivers/staging/wilc1000/linux_wlan.c:67:33: warning: too long
initializer-string for array of char(no space for nul char)
Signed-off-by: Franck Demathieu
---
drivers/staging/wilc1000/linux_wlan.c | 3 +--
1 file changed, 1 insertion(+), 2 d
On Thu, Feb 09, 2017 at 09:57:49PM +, William Stevenson wrote:
> This patch fixes a checkpatch.pl error in bcm2835.c
>
> ERROR: do not initialise statics to NULL
>
> Signed-off-by: William Stevenson
Does not apply to my tree :(
___
devel mailing l
On Fri, Feb 10, 2017 at 05:47:11PM +0900, Chetan Sethi wrote:
> This is a patch to the dim2_hdm.c file that fixes coding style error found
> by checkpatch.pl
>
> Signed-off-by: Chetan Sethi
> ---
> drivers/staging/most/hdm-dim2/dim2_hdm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Friday, February 10, 2017 6:40 AM
> To: KY Srinivasan
> Cc: o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org;
> a...@canonical.com; de...@linuxdriverproject.org;
> leann.ogasaw...@canonical.
On Fri, Feb 10, 2017 at 08:52:12AM -0600, Larry Finger wrote:
> On 02/10/2017 08:08 AM, Greg KH wrote:
> > On Thu, Feb 09, 2017 at 08:51:55PM -0700, Perry Hooker wrote:
> > > This patch fixes the following sparse warning:
> > > drivers/staging/rtl8712/usb_ops_linux.c:212:33: warning: cast to
> > >
On Tue, Feb 07, 2017 at 12:32:12AM +, Stephen Hemminger wrote:
> The netvsc part is already in net-next. This patch is not needed.
> The part that removes the per-channel state can be in another patch.
I have no idea what that means to me here, nor what I need to do, so I'm
just deleting this
On 02/10/2017 08:08 AM, Greg KH wrote:
On Thu, Feb 09, 2017 at 08:51:55PM -0700, Perry Hooker wrote:
This patch fixes the following sparse warning:
drivers/staging/rtl8712/usb_ops_linux.c:212:33: warning: cast to restricted
__le32
Signed-off-by: Perry Hooker
---
drivers/staging/rtl8712/usb_o
On Wed, Feb 08, 2017 at 06:30:56PM -0700, k...@exchange.microsoft.com wrote:
> From: K. Y. Srinivasan
>
> The hypercall page only needs to be executable but currently it is setup to
> be writable as well. Fix the issue.
>
> Signed-off-by: K. Y. Srinivasan
I had to hand-edit the subject: line,
On Sun, Feb 05, 2017 at 05:20:35PM -0700, k...@exchange.microsoft.com wrote:
> From: Stephen Hemminger
>
> The netvsc no longer needs per channel state hook to track receive buffer.
>
> Signed-off-by: Stephen Hemminger
> Signed-off-by: K. Y. Srinivasan
> ---
> include/linux/hyperv.h | 14 --
On Sat, Feb 04, 2017 at 04:24:40PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Saturday, February 4, 2017 7:58 AM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> > o...@
On Fri, Feb 10, 2017 at 12:16:12AM +0900, Youngdo, Lee wrote:
> Removed unnecessary white spaces found via checkpatch.pl:
> WARNING: Statements should start on a tabstop
>
> Signed-off-by: Youngdo, Lee
> ---
> drivers/staging/nvec/nvec_power.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 delet
On Thu, Feb 09, 2017 at 08:51:55PM -0700, Perry Hooker wrote:
> This patch fixes the following sparse warning:
> drivers/staging/rtl8712/usb_ops_linux.c:212:33: warning: cast to restricted
> __le32
>
> Signed-off-by: Perry Hooker
> ---
> drivers/staging/rtl8712/usb_ops_linux.c | 2 +-
> 1 file
On Thu, Feb 09, 2017 at 08:17:56PM +0530, Arushi Singhal wrote:
> Function definitions arguments should also have an identifier name as
> reported by checkpatch.pl.
>
> Signed-off-by: Arushi Singhal
> ---
> drivers/staging/vt6656/channel.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On Thu, Feb 09, 2017 at 06:02:12PM +0530, simran singhal wrote:
> This patch fixes the checkpatch warning by removing multiple blank
> lines.
> CHECK: Please don't use multiple blank lines
>
> Signed-off-by: simran singhal
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 12 --
On Thu, Feb 09, 2017 at 05:53:11PM +0530, Arushi wrote:
> This patch fixes the issue by aligning the * on each line in block comments.
>
> Signed-off-by: Arushi Singhal
Your "From:" line in your email does not match this name here, please
fix up and try again.
Also, please properly wrap your ch
On Thu, Feb 09, 2017 at 02:48:39PM +0100, Franck Demathieu wrote:
> It fixes the following warning reported by sparse:
>
> drivers/staging/wilc1000/linux_wlan.c:67:33: warning: too long
> initializer-string for array of char(no space for nul char)
>
> Signed-off-by: Franck Demathieu
> ---
>
On Fri, Feb 10, 2017 at 11:37:04AM +0200, Ran Algawi wrote:
> Fixed a coding style issues, and two major erros about complex macros
> and an error where the driver used a decimal number insted of an octal
> number when using a warning.
Only do one thing-per-patch please.
thanks,
gre gk-h
___
On Fri, Feb 10, 2017 at 11:41:41AM +0200, Ran Algawi wrote:
>
Never attach patches, and always test-build them yourself to ensure they
do not break the build :(
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriver
Remove comparison to true and false in if statement.
Problem found usingcheckpatch.pl.
CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 4 ++--
1 file changed, 2
On Wed, Feb 08, 2017 at 11:42:21AM +0100, Arnd Bergmann wrote:
> On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote:
> > There is a bunch of vc04_services that we're still looking to merge in
> > the near future. Please hold off deleting these until we are further
> > along on that.
>
Fixes sparse warnings:
warning: symbol 'xxx' was not declared. Should it be static?
Signed-off-by: Simon Sandström
---
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
b/dri
On Fri, 10 Feb 2017, Vitaly Kuznetsov wrote:
> Stephen Hemminger writes:
>
> > Why not use existing seqlock's?
> >
>
> To be honest I don't quite understand how we could use it -- the
> sequence locking here is done against the page updated by the
> hypersior, we're not creating new structures
Stephen Hemminger writes:
> Why not use existing seqlock's?
>
To be honest I don't quite understand how we could use it -- the
sequence locking here is done against the page updated by the
hypersior, we're not creating new structures (so I don't understand how
we could use struct seqcount which
Andy Lutomirski writes:
> On Thu, Feb 9, 2017 at 12:45 PM, KY Srinivasan wrote:
>>
>>
>>> -Original Message-
>>> From: Thomas Gleixner [mailto:t...@linutronix.de]
>>> Sent: Thursday, February 9, 2017 9:08 AM
>>> To: Vitaly Kuznetsov
>>> Cc: x...@kernel.org; Andy Lutomirski ; Ingo Molnar
Hi Ran,
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.10-rc7 next-20170210]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ran-Algawi/Staging-media-bcm2048-fixed
On Fri, 10 Feb 2017, Vitaly Kuznetsov wrote:
> Thomas Gleixner writes:
>
> > On Thu, 9 Feb 2017, Vitaly Kuznetsov wrote:
> >> +#ifdef CONFIG_HYPERV_TSCPAGE
> >> +static notrace u64 vread_hvclock(int *mode)
> >> +{
> >> + const struct ms_hyperv_tsc_page *tsc_pg =
> >> + (const struct ms_
Thomas Gleixner writes:
> On Thu, 9 Feb 2017, Vitaly Kuznetsov wrote:
>> +#ifdef CONFIG_HYPERV_TSCPAGE
>> +static notrace u64 vread_hvclock(int *mode)
>> +{
>> +const struct ms_hyperv_tsc_page *tsc_pg =
>> +(const struct ms_hyperv_tsc_page *)&hvclock_page;
>> +u64 sequence, sc
On Fri, Feb 10, 2017 at 10:05:12AM +0100, peter enderborg wrote:
> On 02/10/2017 08:51 AM, Greg Kroah-Hartman wrote:
> > On Fri, Feb 10, 2017 at 08:21:32AM +0100, peter enderborg wrote:
> >> Im not speaking for google, but I think there is a work ongoing to
> >> replace this with user-space code.
>
[I have only now see this cover - it answers some of the questions I've
had to specific patches. It would be really great if you could use git
send-email to post patch series - it just does the right thing(tm)]
On Thu 09-02-17 14:21:40, peter enderborg wrote:
> Lowmemorykiller efficiency problem
On 02/06/2017 05:00 PM, Hans Verkuil wrote:
> On 02/06/2017 04:21 PM, Dave Stevenson wrote:
>> Hi Hans.
>>
>> On 06/02/17 12:58, Hans Verkuil wrote:
>>> On 02/06/2017 12:37 PM, Dave Stevenson wrote:
Hi Hans.
On 06/02/17 09:08, Hans Verkuil wrote:
> Hi Eric,
>
> Great to s
>From 678cf1e0eb1d30537b228e25e38cd4f35c1501ee Mon Sep 17 00:00:00 2001
From: Ran Algawi
Date: Fri, 10 Feb 2017 11:11:27 +0200
Subject: [PATCH 1/2] Staging: media: bcm2048: fixed 20+ warings/errors
Fixed a coding style issues, and two major erros about complex macros
and an error where the drive
Fixed a coding style issues, and two major erros about complex macros
and an error where the driver used a decimal number insted of an octal
number when using a warning.
Signed-off-by: Ran Algawi
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 64 +--
1 file changed,
On Fri 10-02-17 10:05:34, peter enderborg wrote:
> On 02/10/2017 08:59 AM, Michal Hocko wrote:
[...]
> > The approach was wrong from the day 1. Abusing slab shrinkers
> > is just a bad place to stick this logic. This all belongs to the
> > userspace.
>
> But now it is there and we have to stick wit
On 02/10/2017 08:59 AM, Michal Hocko wrote:
> On Fri 10-02-17 08:51:49, Greg KH wrote:
>> On Fri, Feb 10, 2017 at 08:21:32AM +0100, peter enderborg wrote:
> [...]
>>> Until then we have to polish this version as good as we can. It is
>>> essential for android as it is now.
>> But if no one is willi
On 02/10/2017 08:51 AM, Greg Kroah-Hartman wrote:
> On Fri, Feb 10, 2017 at 08:21:32AM +0100, peter enderborg wrote:
>> Im not speaking for google, but I think there is a work ongoing to
>> replace this with user-space code.
> Really? I have not heard this at all, any pointers to whom in Google is
This is a patch to the dim2_hdm.c file that fixes coding style error found
by checkpatch.pl
Signed-off-by: Chetan Sethi
---
drivers/staging/most/hdm-dim2/dim2_hdm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c
b/drivers/staging
On Fri 10-02-17 08:51:49, Greg KH wrote:
> On Fri, Feb 10, 2017 at 08:21:32AM +0100, peter enderborg wrote:
[...]
> > Until then we have to polish this version as good as we can. It is
> > essential for android as it is now.
>
> But if no one is willing to do the work to fix the reported issues, w
90 matches
Mail list logo
