Re: [PATCH 1/1] staging: comedi: s626: usleep_range is preferred over udelay

[Ian Abbott]

On 09/02/17 21:38, Saber Rezvani wrote:
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani <irsa...@gmail.com>
---
 drivers/staging/comedi/drivers/s626.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/s626.c 
b/drivers/staging/comedi/drivers/s626.c
index 0dd5fe2..e5db405 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -1513,7 +1513,7 @@ static int s626_ai_insn_read(struct comedi_device *dev,

        for (n = 0; n < insn->n; n++) {
                /* Delay 10 microseconds for analog input settling. */
-               udelay(10);
+               usleep_range(10, 100);

                /* Start ADC by pulsing GPIO1 low */
                gpio_image = readl(dev->mmio + S626_P_GPIO);


This one is a borderline case since it is in a data reading loop.  I 
suggest using a tighter range such as 'usleep_range(10, 20);'.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbo...@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel