Re: [PATCH 1/1] staging: comedi: dt2814: usleep_range is preferred over udelay

[Ian Abbott]

On 09/02/17 14:44, Saber Rezvani wrote:

Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay

Signed-off-by: Saber Rezvani <irsa...@gmail.com>
---
 drivers/staging/comedi/drivers/dt2814.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/dt2814.c 
b/drivers/staging/comedi/drivers/dt2814.c
index 2f903be..09984a6 100644
--- a/drivers/staging/comedi/drivers/dt2814.c
+++ b/drivers/staging/comedi/drivers/dt2814.c
@@ -245,7 +245,7 @@ static int dt2814_attach(struct comedi_device *dev, struct 
comedi_devconfig *it)
                return ret;

        outb(0, dev->iobase + DT2814_CSR);
-       udelay(100);
+       usleep_range(100, 200);
        if (inb(dev->iobase + DT2814_CSR) & DT2814_ERR) {
                dev_err(dev->class_dev, "reset error (fatal)\n");
                return -EIO;

It looks fine, thanks!

Reviewed-by: Ian Abbott <abbo...@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbo...@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel