Re: rtlwifi: rtl8821ae: Fix system lockups on boot

> In commit 1277fa2ab2f9 ("rtlwifi: Remove the clear interrupt routine from all > drivers"), the code that cleared all interrupt enable bits before setting them > was removed for all PCI drivers. This fixed an issue that caused TX to be > blocked for 3-5 seconds. On some RTL8821AE units, this chan

Re: Bosto 14WA graphics tablet driver

On Sat, Oct 03, 2015 at 06:10:18PM +1300, Leslie Viljoen wrote: > I've read some of the guides and attempted to change the style of the > driver's code to "kernel" style. Style is almost ok. Some of the parts still needs to be modified but that will not take more than 10 - 11 patch. I have not bui

[PATCH] staging: i20: Added a blank line after declaration

Added a blank line after declaration to fix the coding style warning detected by checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Anjali Menon --- drivers/staging/i2o/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/i2o/pci.c b/drivers/stagi

Re: Bosto 14WA graphics tablet driver

I've read some of the guides and attempted to change the style of the driver's code to "kernel" style. Now it seems I have to create a patch - but this is a new file, so how do I send that? Just paste it in here? It would need to go in drivers/input/tablet. Also: 1. I don't think I have to compi

[PATCH] RDMA/amso1100: use offset_in_page macro

Use offset_in_page macro instead of (addr & ~PAGE_MASK). Signed-off-by: Geliang Tang --- drivers/staging/rdma/amso1100/c2_alloc.c| 2 +- drivers/staging/rdma/amso1100/c2_provider.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rdma/amso1100/c2_alloc.c

[PATCH] IB/ipath: use offset_in_page macro

Use offset_in_page macro instead of (addr & ~PAGE_MASK). Signed-off-by: Geliang Tang --- drivers/staging/rdma/ipath/ipath_user_sdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rdma/ipath/ipath_user_sdma.c b/drivers/staging/rdma/ipath/ipath_user_sdma

[PATCH] IB/hfi1: use offset_in_page macro

Use offset_in_page macro instead of (addr & ~PAGE_MASK). Signed-off-by: Geliang Tang --- drivers/staging/rdma/hfi1/file_ops.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rdma/hfi1/file_ops.c b/drivers/staging/rdma/hfi1/file_ops.c index 9a77221..7d

Re: [PATCH 1/3] drivers: staging: wilc1000: Check for errors before kfree

On Fri, Oct 02, 2015 at 04:39:11PM +0300, Dan Carpenter wrote: > On Fri, Oct 02, 2015 at 06:47:35PM +0530, Chandra S Gorentla wrote: > > During the clean-up of the function, it is need to check if > > errors occurred, not the memory pointer. > > > > The bug here is that we have a use after free on

[PATCH] staging: rtl8723au: Fix Sparse errors in rtl8723a_cmd.c

From: Jacob Kiefer This patch fixes the following sparse errors: CHECK drivers/staging/rtl8723au/hal/rtl8723a_cmd.c ... drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:118:25: warning: incorrect type in assignment (different base types) drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:118:25:

[PATCH 14/14] staging: comedi: multiq3: update the MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something more useful than the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sta

[PATCH 13/14] staging: comedi: multiq3: add 8254 counter/timer subdevice support

The board has an 8254 timer/counter. Add support for this subdevice. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 147 ++- 1 file changed, 146 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 11/14] staging: comedi: multiq3: tidy up multiq3_encoder_insn_read()

Encoders are not a "normal" subdevice in comedi. For aesthetics, tidy up this function and add a couple comments to clarify the function. Remove the strange munging of the data. The encoder data is decoded in quadrature and used to increment or decrement a 24-bit counter. Adding 0x80 to the co

[PATCH 12/14] staging: comedi: multiq3: remove unnecessary include

This driver does not use interrupts. Remove the include. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/multiq3.c b/drivers/s

[PATCH 06/14] staging: comedi: multiq3: introduce multiq3_set_ctrl()

According to the programming manual. the 'SH' and 'CLK' bits in the control register need to be kept high at all times. Clarify this by introducing a helper function to set the control register. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/d

[PATCH 09/14] staging: comedi: multiq3: allow user to reset encoder channels

Currently this driver resets all the encoder channels when the driver is first attached. Add a (*insn_config) to the subdevice to allow the use to reset the channels manually. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c |

[PATCH 10/14] staging: comedi: multiq3: remove unnecessary define

This define is not needed. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/multiq3.c b/drivers/staging/comedi/drivers/multiq3.c in

[PATCH 07/14] staging: comedi: multiq3: tidy up control register bit defines

For aesthetics, move these defines closer to the register define and use the BIT macro to define the bits. Add macros to set the bits needed to select the channel for the analog output, analog input, and encoder (counter) subdevices as well as the realtime clock registers. Signed-off-by: H Hartle

[PATCH 08/14] staging: comedi: multiq3: document the encoder chip commands

Add some comments to document the commands that are sent to the encoder chips. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/

[PATCH 05/14] staging: comedi: multiq3: tidy up status register bit defines

For aesthetics, move these defines closer to the register define and use the BIT macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --g

[PATCH 04/14] staging: comedi: multiq3: tidy up register map defines

For auesthetics, rename the register map defines. Convert the offset values to hex and add some whitespace. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 70 1 file changed, 35 insertions(+

[PATCH 03/14] staging: comedi: multiq3: tidy up subdevice init

For aesthetics, add some whitespace to the subdevice init and rearrange the initialization a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 77 1 file changed, 38 insertions(+), 39 dele

[PATCH 01/14] staging: comedi: multiq3: tidy up multi-line comments

Reformat the multi-line comments in the kernel CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 54 +++- 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/drivers/staging

[PATCH 02/14] staging: comedi: multiq3: tidy up multiq3_ai_insn_read()

For aesthetics, use the proper symbol when reading the A/D data register to get the 16-bit sample data. Use the comedi_offset_munge() to do the 2's complement to offset binary munging of the sample data. Tidy up the function a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah

[PATCH 00/14] staging: comedi: multiq3: cleaup driver

Cleanup this driver a bit and add support for the 8254 counter/timer. H Hartley Sweeten (14): staging: comedi: multiq3: tidy up multi-line comments staging: comedi: multiq3: tidy up multiq3_ai_insn_read() staging: comedi: multiq3: tidy up subdevice init staging: comedi: multiq3: tidy up re

Bosto 14WA graphics tablet driver

Hi! I'm one of the authors of a driver for a Bosto 14WA graphics tablet that I'd like to submit to the kernel: https://github.com/lesliev/bosto_14wa I've no idea of the quality of it so I suppose it had to go into "staging"? It was hacked together from an older driver for a similar chip. I'm bus

Re: [PATCH] staging/lustre: Make nrs_policy_get_info_locked() static

On Saturday 03 October 2015 06:10:12 kbuild test robot wrote: > >> drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:456:13: error: static > >> declaration of 'nrs_policy_get_info_locked' follows non-static declaration > static void nrs_policy_get_info_locked(struct ptlrpc_nrs_policy *policy

Re: [PATCH] staging/lustre: Make nrs_policy_get_info_locked() static

Hi Rocco, [auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore] config: sparc64-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bi

Re: [PATCH] staging/lustre: Make nrs_policy_get_info_locked() static

On Friday 02 October 2015 23:54:26 Rocco Folino wrote: > This patch fixes the warning generated by sparse: "symbol > 'nrs_policy_get_info_locked' was not > declared. Should it be static?" by declaring the function static. > > Signed-off-by: Rocco Folino > Reviewed-by: Arnd Bergmann This prob

[PATCH] staging/lustre: Make nrs_policy_get_info_locked() static

This patch fixes the warning generated by sparse: "symbol 'nrs_policy_get_info_locked' was not declared. Should it be static?" by declaring the function static. Signed-off-by: Rocco Folino --- drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

RE: [PATCH] x86: guest: rely on leaf 0x40000001 to detect Hyper-V

> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Friday, October 2, 2015 1:07 PM > To: KY Srinivasan > Cc: Paolo Bonzini ; linux-ker...@vger.kernel.org; > Haiyang Zhang ; x...@kernel.org; > de...@linuxdriverproject.org; alex.william...@redhat.com > Subject

RE: [PATCH] x86: guest: rely on leaf 0x40000001 to detect Hyper-V

On Fri, 2 Oct 2015, KY Srinivasan wrote: > > Change ms_hyperv_platform to actually do what the specification suggests. > > This roughy matches what Windows looks for, though Windows actually > > ignores HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS completely. > > > > Signed-off-by: Paolo Bonzini > > Th

[PATCH 11/11] staging: unisys: visorinput: remove extraneous do_key function

From: Tim Sell do_key() is no longer needed. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/unisys/visorinput/visorinput.c b/drive

[PATCH 05/11] staging: unisys: visorinput: make structs & arrays const where possible

From: Tim Sell This also gave me a warning with the assignment: visorinput_dev->keycode = visorkbd_keycode; because input_dev->keycode is NOT static but visorkbd_keycode now is, so I went ahead and also added logic to stash away non-static copies of visorkbd_keycode[] and visorkbd_ext_keyco

[PATCH 09/11] staging: unisys: visorinput: register & use input_dev open() and close()

From: Tim Sell Registration of visorinput_open() and visorinput_close() for each device allow us to eliminate unnecessary activity when nobody in user-land cares. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 55

[PATCH 10/11] staging: unisys: visorinput: remove extraneous mouse logic

From: Tim Sell Removes a cursor positioning hack that no longer seems to be required. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/unisys/visorinput/vis

[PATCH 04/11] staging: unisys: visorinput: add INPUT to dependent driver list

From: Tim Sell Add the renamed driver to the Kconfig. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorinput/Kconfig b/drivers/staging/unisys/vis

[PATCH 08/11] staging: unisys: visorinput: change input bus type to BUS_VIRTUAL (6)

From: Tim Sell BUS_HOST wasn't really appropriate, so I changed to BUS_VIRTUAL, which is what virtio uses. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH 06/11] staging: unisys: visorinput: correct code comments per kernel conventions

From: Tim Sell Multi-line comments were modified to conform to kernel conventions: /* * multi-line * comments */ doc-test /** */ for some comments was removed. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 47 ++

[PATCH 00/11] staging: unisys: rename visorhid, additional fixes

This patch series moves the visorhid driver to visorinput, and then fixes several other issues discovered by Benjamin Tissoires of Red Hat. Tim Sell (11): staging: unisys: visorhid: rename to visorinput staging: unisys: visorinput: subsume .h files directly into visorinput.c staging: uni

[PATCH 03/11] staging: unisys: visorinput: re-order declarations for consistency

From: Tim Sell In order to be more consistent with kernel conventions used elsewhere, I have re-ordered declarations in visorinput.c to follow this general order (where possible): * #defines * struct/enum/union declarations * static declarations (const if possible for all of them) * forward funct

[PATCH 07/11] staging: unisys: visorinput: comment tweaks - s/gizmo/input node/g

From: Tim Sell Just a simple search and replace in the comments. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visorinput/visorinput.c b

[PATCH 02/11] staging: unisys: visorinput: subsume .h files directly into visorinput.c

From: Tim Sell keyboardchannel.h and mousechannel.h are now included within visorinput.c directly. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- .../staging/unisys/visorinput/keyboardchannel.h| 32 - drivers/staging/unisys/visorinput/mousechannel.h | 33 -

[PATCH 01/11] staging: unisys: visorhid: rename to visorinput

From: Tim Sell This visorhid driver provides a Human Interface Device, but is not at all using HID, the protocol. It's a plain input driver, so for clarity, it is being renamed to visorinput. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/Documentation/overv

[PATCH] rtlwifi: rtl8821ae: Fix system lockups on boot

In commit 1277fa2ab2f9, the code that cleared all interrupt enable bits before setting them was removed for all PCI drivers. This fixed an issue that caused TX to be blocked for 3-5 seconds. On some RTL8821AE units, this change causes soft lockups to occur on boot. For that reason, the portion of t

RE: [PATCH] x86: guest: rely on leaf 0x40000001 to detect Hyper-V

> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, October 2, 2015 2:27 AM > To: linux-ker...@vger.kernel.org > Cc: KY Srinivasan ; Haiyang Zhang > ; x...@kernel.org; de...@linuxdriverproject.org; > alex.william...@redh

Re: [PATCH 03/13] staging: unisys: visorhid: rename to visorinput

On Fri, Oct 02, 2015 at 10:05:34AM -0400, Ben Romer wrote: > On 10/02/2015 05:40 AM, Greg KH wrote: > >Please generate patches with the -M flag, so that it is easy to see that > >you are moving files around, not just removing and adding them somewhere > >else. > > > >Can you fix this up and resend

Re: [PATCH 03/13] staging: unisys: visorhid: rename to visorinput

On 10/02/2015 05:40 AM, Greg KH wrote: Please generate patches with the -M flag, so that it is easy to see that you are moving files around, not just removing and adding them somewhere else. Can you fix this up and resend the series starting with this patch? Will do, do I need to v2 them? Or j

Re: [PATCH 1/3] drivers: staging: wilc1000: Check for errors before kfree

On Fri, Oct 02, 2015 at 06:47:35PM +0530, Chandra S Gorentla wrote: > During the clean-up of the function, it is need to check if > errors occurred, not the memory pointer. > The bug here is that we have a use after free on the success path. It should have been mentioned in the changelog. Anyway

[PATCH 1/3] drivers: staging: wilc1000: Check for errors before kfree

During the clean-up of the function, it is need to check if errors occurred, not the memory pointer. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/driv

[PATCH 3/3] drivers: staging: wilc1000: Do not return from function with lock is on

There are a couple of return statements before unlock. Lock is moved to a location just before queue manipulation. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc

[PATCH 2/3] drivers: staging: wilc1000: Remove ineffective code

The value of 'result' is not modified from 0 after initialization. Hence no need to check it. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc100

[PATCH 02/10] staging: wilc1000: fix NULL comparison style

This patch changes NULL comparison style to use ! operator found by checkpatch.pl CHECK: Comparison to NULL could be written "!pstrWFIDrv" drivers/staging/wilc1000/host_interface.c:5324: Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertio

[PATCH 09/10] staging: wilc1000: use pr_err in host_int_wait_msg_queue_idle

This patch changes PRINT_ER by pr_err. It would be better to use netdev_err, but it cannot use it in this function, so just use pr_err. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wi

[PATCH 07/10] staging: wilc1000: fix return type of host_int_wait_msg_queue_idle

This patch changes return type of host_int_wait_msg_queue_idle from s32 to int. s32Error gets return value from wilc_mq_send that has return type of int. It should be changed return type of host_int_wait_msg_queue_idle by int as well as data type of s32Error. Signed-off-by: Chaehyun Lim --- driv

[PATCH 10/10] staging: wilc1000: remove blank lines before close brace

This patch removes blank lines before close brace '}' CHECK: Blank lines aren't necessary before a close brace '}' drivers/staging/wilc1000/host_interface.c:5366: Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers

[PATCH 03/10] staging: wilc1000: rename s32Error in host_int_set_mac_chnl_num

This patch replaces s32Error with result to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interfa

[PATCH 01/10] staging: wilc1000: fix return type of host_int_set_mac_chnl_num

This patch changes return type of host_int_set_mac_chnl_num from s32 to int. s32Error gets return value from wilc_mq_send function that has return type of int. It should be changed return type of host_int_set_mac_chnl_num function by int as well as data type of s32Error. Signed-off-by: Chaehyun Li

[PATCH 06/10] staging: wilc1000: rename hWFIDrv of host_int_set_mac_chnl_num

This patch replaces hWFIDrv with wfi_drv that is first argument of host_int_set_mac_chnl_num to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-

[PATCH 05/10] staging: wilc1000: rename u8ChNum of host_int_set_mac_chnl_num

This patch replaces u8ChNum with channel that is second argument of host_int_set_mac_chnl_num to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 08/10] staging: wilc1000: rename s32Error in host_int_wait_msg_queue_idle

This patch replaces s32Error with result to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interfa

[PATCH 04/10] staging: wilc1000: replace PRINT_ER with pr_err

This patch replaces PRINT_ER with pr_err. It would be better to use netdev_err, but it cannot use it in this function, so just use pr_err. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/sta

[PATCH] staging: octeon: Removed trailing whitespaces

Removed trailing whitespace in the blank line to fix the coding style error detected by checkpatch.pl ERROR: trailing whitespace Signed-off-by: Anjali Menon --- drivers/staging/octeon/ethernet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet.

Re: [PATCH 08/12] staging: wilc1000: use s8 instead of int8_t

On Fri, Oct 02, 2015 at 09:45:44AM +0200, Arend van Spriel wrote: > On 10/01/2015 03:43 PM, Chaehyun Lim wrote: > >This patch replaces int8_t with s8 that is a preferred type. > > > >Signed-off-by: Chaehyun Lim > >--- > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- > > 1 file ch

Re: [PATCH] x86: guest: rely on leaf 0x40000001 to detect Hyper-V

Paolo Bonzini writes: > The specification says that "Microsoft Hv" is actually a vendor ID field > that is only used for reporting and diagnostic purposes. The actual > field that you need to check is the interface ID that you get in eax > when querying the HYPERV_CPUID_INTERFACE. > > Change ms_

Re: [PATCH 03/13] staging: unisys: visorhid: rename to visorinput

On Thu, Oct 01, 2015 at 12:42:00PM -0400, Benjamin Romer wrote: > From: Tim Sell > > This visorhid driver provides a Human Interface Device, but is not at all > using HID, the protocol. It's a plain input driver, so for clarity, it is > being renamed to visorinput. > > Signed-off-by: Tim Sell

[PATCH] x86: guest: rely on leaf 0x40000001 to detect Hyper-V

The specification says that "Microsoft Hv" is actually a vendor ID field that is only used for reporting and diagnostic purposes. The actual field that you need to check is the interface ID that you get in eax when querying the HYPERV_CPUID_INTERFACE. Change ms_hyperv_platform to actually do what

Re: [PATCH V2 08/12] staging: wilc1000: use int instead of int8_t

On Fri, Oct 2, 2015 at 5:02 PM, Arend van Spriel wrote: > On 10/02/2015 09:41 AM, Chaehyun Lim wrote: >> >> This patch replaces int8_t with int. >> The int8_t should be int. It's used as an index into an array >> or -1 for not found. > > > Please consider using bool instead. See my previous emails

[PATCH V2 11/12] staging: wilc1000: set_channel: rename s32Error

This patch replaces s32Error with result to avoid camelcase. Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi

[PATCH V2 07/12] staging: wilc1000: use ARRAY_SIZE macro

This patch uses ARRAY_SIZE macro found by checkpatch.pl WARNING: Prefer ARRAY_SIZE(wb) drivers/staging/wilc1000/wilc_spi.c:400 drivers/staging/wilc1000/wilc_spi.c:402 Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/wilc_spi.c | 4 ++-- 1 file

[PATCH V2 05/12] staging: wilc1000: remove #if 1 and #endif

This patch removes #if 1 and #endif, which is encapsulated some codes. Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperation

[PATCH V2 12/12] staging: wilc1000: rename u8CurrChannel

This patch replaces u8CurrChannel with curr_channel to avoid camelcase. Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging

[PATCH V2 08/12] staging: wilc1000: use int instead of int8_t

This patch replaces int8_t with int. The int8_t should be int. It's used as an index into an array or -1 for not found. Suggested-by: Dan Carpenter Signed-off-by: Chaehyun Lim --- V2: replaces s8 with int suggested by dan. drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- 1 file ch

[PATCH V2 10/12] staging: wilc1000: set_channel: fix data type of s32Error

This patch changes data type of s32Error variable from s32 to int because return type of this function is int. Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH V2 09/12] staging: wilc1000: set_channel: remove blank line after open brace

This patch removes blank line after open brace '{' found by checkpatch.pl CHECK: Blank lines aren't necessary after an open brace '{' drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:664: Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/wilc_

[PATCH V2 06/12] staging: wilc1000: remove unnecessary comment

This patch removes unnecessary comment. Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/host_interface.c | 6 -- drivers/staging/wilc1000/host_interface.h | 16 drivers/staging/wilc1000/wilc_wfi_netdevice.h | 23 +

[PATCH V2 02/12] staging: wilc1000: remove commented codes

This patch removes commented codes that is not used in this driver. Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/linux_wlan.c | 3 --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - drivers/staging/wilc1000/wilc_wlan.c

[PATCH V2 04/12] staging: wilc1000: fix indentation level

This patch removes unnecessary block braces and fix indentation. Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/linux_wlan.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/stagin

[PATCH V2 03/12] staging: wilc1000: remove if defined codes of USE_OLD_SPI_SW

This patch removes if defined codes of USE_OLD_SPI_SW. This macro is deleted because it is commented out. Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/wilc_spi.c | 125 1 file changed, 125 deletions(-)

[PATCH V2 01/12] staging: wilc1000: remove wilc_platform.h

This patch removes wilc_platform.h file that is not used anywhere. Signed-off-by: Chaehyun Lim --- V2: resend because 08/12 patch is changed. drivers/staging/wilc1000/wilc_platform.h | 28 1 file changed, 28 deletions(-) delete mode 100644 drivers/staging/wilc1000/

Re: [PATCH 08/12] staging: wilc1000: use s8 instead of int8_t

On Fri, Oct 2, 2015 at 3:06 PM, Dan Carpenter wrote: > On Fri, Oct 02, 2015 at 07:56:28AM +0900, Chaehyun Lim wrote: >> On Fri, Oct 2, 2015 at 12:40 AM, Dan Carpenter >> wrote: >> > On Thu, Oct 01, 2015 at 10:43:55PM +0900, Chaehyun Lim wrote: >> >> This patch replaces int8_t with s8 that is a p