On Wed, Jul 01, 2015 at 03:05:45AM +0530, Sohny Thomas wrote:
>
> FIX 2 unnecessary braces found by checkpatch.pl
>
> Signed-off-by: Sohny Thomas
> ---
> drivers/staging/unisys/virtpci/virtpci.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/stagin
else is not generally useful after a break or return, hence removed.
Signed-off-by: Ravi Teja Darbha
---
drivers/staging/rts5208/xd.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 10fea7b..42d8d82
fix sparse warning in lustre/ptlrpc/ptlrpc_module.c:54:12:
warning: symbol 'ptlrpc_init' was not declared. Should it be static?
The __init macro is moved before the function name to match standard usage.
Signed-off-by: matt mooney
---
drivers/staging/lustre/lustre/ptlrpc/ptlrpc_module.c |
The return value of FillH2CCmd in rtl8723a_set_rssi_cmd and
rtl8723a_set_raid_cmd is never checked. Both functions always return
_SUCCESS.
Both functions now return the return value of FillH2CCmd.
Signed-off-by: Michel von Czettritz
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 8 ++--
Writing the output of cpu_to_le32 to an u32 or *(u32*) is an implicit
cast and results in an sparse warning.
Since param and mask won't be changed, the implicit cast can be avoided
by creating local variables.
Signed-off-by: Michel von Czettritz
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
If u8 *param, in the function rtl8723a_set_rssi_cmd, is only 3 Byte long
the 4th Byte of cpu_to_le32 will be written in unallocated memory.
Change the function variable to u32*, so the problem can not
occur.
rtl8723a_set_rssi_cmd currently is only called in hal/odm.c and is
called with u32* as pa
Initialy fixing a sparse warning, resulted in 3 small patches cleaning
rtl8723a_set_rssi_cmd an rtl8723a_set_raid_cmd up a bit.
Both functions now avoid implicit casts, return actual values, and
rtl8723a_set_rssi_cmd cannot write in unallocated memory any more.
Michel von Czettritz (3):
staging
FIX 2 unnecessary braces found by checkpatch.pl
Signed-off-by: Sohny Thomas
---
drivers/staging/unisys/virtpci/virtpci.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/virtpci/virtpci.c
index d5a
Laura Abbott писал 30.06.2015 20:54:
(adding devicetree mailing list since I didn't see it cc-ed)
Please also remember to cc the staging list since Ion is
still a staging framework.
On 06/30/2015 08:34 AM, Andrew Andrianov wrote:
Signed-off-by: Andrew Andrianov
---
Documentation/devicetree/
On 2015/06/28, 12:52 AM, "Julia Lawall" wrote:
>It is not clear that all of the uses of LIBCFS_ALLOC really risk needing
>vmalloc. For example:
>
>lnet/klnds/socklnd/socklnd.c, function ksocknal_accept:
>
>ksock_connreq_t *cr;
>...
>LIBCFS_ALLOC(cr, sizeof(*cr));
>
>The definition of ksock_connr
Thanks for the detailed review
Laura Abbott писал 30.06.2015 20:56:
On 06/30/2015 08:34 AM, Andrew Andrianov wrote:
if (!idev)
+ return -ENOMEM;
+ }
Yeah this is a bit messy as your comments note. Since there can only be
one Ion
device in the system, it s
From: ja...@microsoft.com
This patch changes the logic in hv_vmbus to record all of the ranges in the
VM's firmware (BIOS or UEFI) that offer regions of memory-mapped I/O space for
use by paravirtual front-end drivers. The old logic just found one range
above 4GB and called it good. This logic
This patch series changes the way that hv_vmbus searches for ranges of
memory-mapped I/O space (MMIO) which can be used by its children. The old
way just found the one and only range above 4GB. This one makes all ranges
exposed in the VM's firmware potential candidates. It also moves the code
w
From: ja...@microsoft.com
This patch deletes the logic from hyperv_fb which picked a range of MMIO space
for the frame buffer and adds new logic to hv_vmbus which picks ranges for
child drivers. The new logic isn't quite the same as the old, as it considers
more possible ranges.
Signed-off-by:
On Tue, 2015-06-30 at 20:45 +0300, Dan Carpenter wrote:
> On Tue, Jun 30, 2015 at 07:55:42AM -0700, Joe Perches wrote:
> > On Tue, 2015-06-30 at 10:42 +0300, Dan Carpenter wrote:
> > > On Tue, Jun 30, 2015 at 08:43:14AM +0200, Fabio Falzoi wrote:
> > > > No newline is needed since checkpatch doesn'
On 06/30/2015 08:34 AM, Andrew Andrianov wrote:
This patch adds a generic ion driver that allows
ion heaps to be added via devicetree. It provides
a simple and generic way to feed physical memory regions
to ion without writing a custom driver, e.g.
ion_sram: ion@0x0010 {
(adding devicetree mailing list since I didn't see it cc-ed)
Please also remember to cc the staging list since Ion is
still a staging framework.
On 06/30/2015 08:34 AM, Andrew Andrianov wrote:
Signed-off-by: Andrew Andrianov
---
Documentation/devicetree/bindings/ion,physmem.txt | 98
On Tue, Jun 30, 2015 at 07:55:42AM -0700, Joe Perches wrote:
> On Tue, 2015-06-30 at 10:42 +0300, Dan Carpenter wrote:
> > On Tue, Jun 30, 2015 at 08:43:14AM +0200, Fabio Falzoi wrote:
> > > No newline is needed since checkpatch doesn't complain about line longer
> > > than 80 characters for string
All that you are saying is true and stuff that Julia and I have
discussed before. For this call site though we are not allocating 32k,
we're allocating 4 pointers so libcfs_kvzalloc() doesn't make sense.
regards,
dan carpenter
___
devel mailing list
de
On Tue, Jun 30, 2015 at 05:34:36PM +0900, Dean Lee wrote:
> change type to pointer.
that describes _what_ you did, which is obvious from the patch, but not
_why_ you did it. You need to describe this much better before I can
take it.
One comment on the code:
> Signed-off-by: Dean Lee
> ---
>
On Tue, Jun 30, 2015 at 05:34:33PM +0900, Dean Lee wrote:
> this function needs more arguments.
The subject doesn't make sense.
And this sentance doesn't make sense, please describe _why_ you are
doing this, not what you are doing.
greg k-h
___
devel m
On Fri, 2015-06-26 at 17:47 -0700, Greg KH wrote:
> On Tue, Jun 16, 2015 at 04:22:12PM -0400, Joseph Salisbury wrote:
> > From: Nick Meier
> >
> > BugLink: http://bugs.launchpad.net/bugs/1463584
> >
> > Hyper-V allows a guest to notify the Hyper-V host that a panic
> > condition occured. This n
On Tue, 2015-06-30 at 10:42 +0300, Dan Carpenter wrote:
> On Tue, Jun 30, 2015 at 08:43:14AM +0200, Fabio Falzoi wrote:
> > No newline is needed since checkpatch doesn't complain about line longer
> > than 80 characters for string literals.
[]
> The original was correct.
The original was fine.
>
On Tue, 30 Jun 2015, Simmons, James A. wrote:
> >Yeah. You're right. Doing a vmalloc() when kmalloc() doesn't have even
> >a tiny sliver of RAM isn't going to work. It's easier to use
> >libcfs_kvzalloc() everywhere, but it's probably the wrong thing.
>
> The original reason we have the vmal
>Yeah. You're right. Doing a vmalloc() when kmalloc() doesn't have even
>a tiny sliver of RAM isn't going to work. It's easier to use
>libcfs_kvzalloc() everywhere, but it's probably the wrong thing.
The original reason we have the vmalloc water mark wasn't so much the
issue of memory exhausti
On Tue, Jun 30, 2015 at 05:34:38PM +0900, Dean Lee wrote:
> diff --git a/drivers/staging/wilc1000/linux_wlan.c
> b/drivers/staging/wilc1000/linux_wlan.c
> index 1b8991a..0772292 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -1946,7 +1946,7
On Tue, Jun 30, 2015 at 05:34:37PM +0900, Dean Lee wrote:
> modify it
>
> Signed-off-by: Dean Lee
This patch description is useless. What is the warning?
> ---
> drivers/staging/wilc1000/host_interface.c | 3 ++-
> drivers/staging/wilc1000/linux_wlan.c | 2 +-
> 2 files changed, 3 inserti
> - if ((pstrHostIfSetDrvHandler->u32Address) == (u32)NULL) {
> + if (pstrHostIfSetDrvHandler->pAddress == NULL) {
In the linux kernel we do not like using 'p' to stand for pointer. This
new name uses CamelCase. Use scripts/checkpatch.pl to find obvious
mistakes like this.
The name "add
On Tue, Jun 30, 2015 at 05:34:35PM +0900, Dean Lee wrote:
> argument type change for support 64 bit system.
>
> Signed-off-by: Dean Lee
> -u32 gu8FlushedJoinReqDrvHandler;
> +void *gpFlushedJoinReqDrvHandler;
There are a lot of variables renamed. It makes reviewing this patch
hard. Also the
On Tue, Jun 30, 2015 at 05:58:13PM +0900, Dean.lee wrote:
>
>
> On 2015년 06월 30일 17:50, Dan Carpenter wrote:
> >On Tue, Jun 30, 2015 at 05:34:33PM +0900, Dean Lee wrote:
> >>this function needs more arguments.
> >>
> >Sudip sent a patch for this but he passed false instead of true.
> >
> >We are
On 2015년 06월 30일 17:50, Dan Carpenter wrote:
On Tue, Jun 30, 2015 at 05:34:33PM +0900, Dean Lee wrote:
this function needs more arguments.
Sudip sent a patch for this but he passed false instead of true.
We are disconnecting because we got CONN_DISCONN_EVENT_DISCONN_NOTIF as
a response whic
On Tue, Jun 30, 2015 at 05:34:33PM +0900, Dean Lee wrote:
> this function needs more arguments.
>
Sudip sent a patch for this but he passed false instead of true.
We are disconnecting because we got CONN_DISCONN_EVENT_DISCONN_NOTIF as
a response which seems like not locally generated. I think f
modify it
Signed-off-by: Dean Lee
---
drivers/staging/wilc1000/host_interface.c | 3 ++-
drivers/staging/wilc1000/linux_wlan.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index 1
argument type change for support 64 bit system.
Signed-off-by: Dean Lee
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wilc1000/host_interface.c | 218 +++---
drivers/staging/wilc
delete odd structure and rework it.
Signed-off-by: Dean Lee
---
drivers/staging/wilc1000/host_interface.c | 149 +++---
drivers/staging/wilc1000/host_interface.h | 123 +-
drivers/staging/wilc1000/linux_wlan.c | 14 +-
drivers/staging/
change type to pointer.
Signed-off-by: Dean Lee
---
drivers/staging/wilc1000/host_interface.c | 22 +-
drivers/staging/wilc1000/host_interface.h | 4 ++--
2 files changed, 11 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/st
Signed-off-by: Dean Lee
---
drivers/staging/wilc1000/host_interface.c | 52 ---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
2 files changed, 1 insertion(+), 53 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_
this function needs more arguments.
Signed-off-by: Dean Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 92064
commit 80279fb7ba5b ("cfg80211: properly send
NL80211_ATTR_DISCONNECTED_BY_AP in disconnect") has changed the api of
cfg80211_disconnected() and caused a build failure.
Add the extra argument as false since it appears from the code that the
disconnection is not locally generated.
And incase of doub
On Tue, Jun 30, 2015 at 08:43:14AM +0200, Fabio Falzoi wrote:
> No newline is needed since checkpatch doesn't complain about line longer
> than 80 characters for string literals.
>
> Signed-off-by: Fabio Falzoi
The original was correct. There was no need to go over 80 characters
just because of
On Thu, Jun 25, 2015 at 10:53:33PM -0700, Juston Li wrote:
> On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee
> wrote:
> > Usually I use the checkpatch which is in linux-next. That will be the
> > latest version. If you compare, last commit on checkpatch of staging
> > tree was on April 16th, wher
41 matches
Mail list logo
