The return value of FillH2CCmd in rtl8723a_set_rssi_cmd and
rtl8723a_set_raid_cmd is never checked. Both functions always return
_SUCCESS.

Both functions now return the return value of FillH2CCmd.

Signed-off-by: Michel von Czettritz <michel.von.czettr...@gmail.com>
---
 drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c 
b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
index a5e6726..72924a78 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
@@ -118,9 +118,7 @@ int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u32 
*param)
        __le32 param_le;
        param_le = cpu_to_le32(*(param));
 
-       FillH2CCmd(padapter, RSSI_SETTING_EID, 3, (u8 *)&param_le);
-
-       return _SUCCESS;
+       return FillH2CCmd(padapter, RSSI_SETTING_EID, 3, (u8 *)&param_le);
 }
 
 int rtl8723a_set_raid_cmd(struct rtw_adapter *padapter, u32 mask, u8 arg)
@@ -133,9 +131,7 @@ int rtl8723a_set_raid_cmd(struct rtw_adapter *padapter, u32 
mask, u8 arg)
        memcpy(buf, &mask_le, 4);
        buf[4]  = arg;
 
-       FillH2CCmd(padapter, MACID_CONFIG_EID, 5, buf);
-
-       return _SUCCESS;
+       return FillH2CCmd(padapter, MACID_CONFIG_EID, 5, buf);
 }
 
 /* bitmap[0:27] = tx_rate_bitmap */
-- 
2.4.5

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to