> -     if ((pstrHostIfSetDrvHandler->u32Address) == (u32)NULL) {
> +     if (pstrHostIfSetDrvHandler->pAddress == NULL) {

In the linux kernel we do not like using 'p' to stand for pointer.  This
new name uses CamelCase.  Use scripts/checkpatch.pl to find obvious
mistakes like this.

The name "address" is too generic.  Use a meaningful name.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to